[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599242#comment-16599242
 ] 

ASF subversion and git services commented on ASTERIXDB-2449:
------------------------------------------------------------

Commit bcc93471dfcf6cb2947376fec7336684efd91a8b in asterixdb's branch 
refs/heads/master from [~dlychagin-cb]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=bcc9347 ]

[ASTERIXDB-2449][FUN] Incorrect NULL/MISSING handling by concat functions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Infer function return type as unknownable if
  its input list item can be NULL/MISSING
- Always return MISSING if there is a MISSING argument

Change-Id: Idc364b061f3e74bdc9d7715bbadedc957e9e8223
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2946
Sonar-Qube: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Reviewed-by: Till Westmann <ti...@apache.org>


> Incorrect null/missing handling in string/binary concat functions and concat 
> operator
> -------------------------------------------------------------------------------------
>
>                 Key: ASTERIXDB-2449
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2449
>             Project: Apache AsterixDB
>          Issue Type: Bug
>          Components: FUN - Functions
>            Reporter: Dmitry Lychagin
>            Assignee: Dmitry Lychagin
>            Priority: Major
>
> There a couple of issue with null/missing handling in string_concat() and 
> binary_concat().
> 1) The return type should always beĀ inferred as unknownable string. Currently 
> the return type is inferred as string if input cannot be null/missing. This 
> is incorrect because these functions return null/missing not only if the 
> input argument is null/missing, but also if an item in the input list is 
> null/missing
> 2) These functions should return 'missing' in input list is [ null, missingĀ 
> ]. Currently they both return 'null' in this case
> String concatenation operator (||) is also affected by these issues because 
> it's rewritten into string_concat()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to