Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Murtadha Hubail has submitted this change and it was merged.
Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to
FileMapManager
..
[ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Currently it is possible for a thread to access
FileMapManager without holding the proper lock
and therefore seeing a stale state of the map.
This change ensures that all access to the map
is synchronized on the same lock.
Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2863
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: abdullah alamoudi
---
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/BufferedFileHandle.java
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
3 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Anon. E. Moose #1000171:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
index f8b9a57..b35cefe 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
@@ -849,9 +849,8 @@
if (LOGGER.isEnabled(fileOpsLevel)) {
LOGGER.log(fileOpsLevel, "Opening file: " + fileId + " in cache: "
+ this);
}
-BufferedFileHandle fInfo = null;
try {
-fInfo = getOrCreateFileHandle(fileId);
+final BufferedFileHandle fInfo = getOrCreateFileHandle(fileId);
if (fInfo.getFileHandle() == null) {
// a new file
synchronized (fInfo) {
@@ -861,7 +860,10 @@
closeOpeningFiles(fInfo);
}
// create, open, and map new file reference
-FileReference fileRef =
fileMapManager.lookupFileName(fileId);
+FileReference fileRef;
+synchronized (fileInfoMap) {
+fileRef = fileMapManager.lookupFileName(fileId);
+}
IFileHandle fh = ioManager.open(fileRef,
IIOManager.FileReadWriteMode.READ_WRITE,
IIOManager.FileSyncMode.METADATA_ASYNC_DATA_ASYNC);
fInfo.setFileHandle(fh);
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/BufferedFileHandle.java
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/BufferedFileHandle.java
index 1312d97..4f15588 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/BufferedFileHandle.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/BufferedFileHandle.java
@@ -24,7 +24,7 @@
public class BufferedFileHandle {
private final int fileId;
-private IFileHandle handle;
+private volatile IFileHandle handle;
private final AtomicInteger refCount;
public BufferedFileHandle(int fileId, IFileHandle handle) {
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
index 32922d2..0f2703b 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
@@ -25,7 +25,9 @@
import org.apache.hyracks.api.exceptions.ErrorCode;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.io.FileReference;
+import org.apache.hyracks.util.annotations.NotThreadSafe;
+@NotThreadSafe
public class FileMapManager implements IFileMapManager {
private static final long serialVersionUID = 1L;
--
To view, visit https://asterix-gerrit.ics.uci.edu/2863
To unsub
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7100/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/2R5wrS : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3550/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3550/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4639/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Murtadha Hubail has posted comments on this change.
Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to
FileMapManager
..
Patch Set 2:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/2863/1/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
File
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java:
PS1, Line 854: if (fInfo.getFileHandle() == null) {
: // a new file
: synchronized (fInfo) {
: // prevent concurrent opening of the same
file
: if (fInfo.getFileHandle() == null) {
> double-checked locking, this is not safe
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/pxfYsE : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7100/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4259/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8196/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/545/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4171/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4481/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4813/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/490/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2863 to look at the new patch set (#2). Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager - user model changes: no - storage format changes: no - interface changes: no Details: - Currently it is possible for a thread to access FileMapManager without holding the proper lock and therefore seeing a stale state of the map. This change ensures that all access to the map is synchronized on the same lock. Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d --- M hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java M hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/BufferedFileHandle.java M hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java 3 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/63/2863/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9735/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4264/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2271/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4224/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4670/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Michael Blow has posted comments on this change.
Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to
FileMapManager
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/2863/1/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
File
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java:
PS1, Line 854: if (fInfo.getFileHandle() == null) {
: // a new file
: synchronized (fInfo) {
: // prevent concurrent opening of the same
file
: if (fInfo.getFileHandle() == null) {
double-checked locking, this is not safe
--
To view, visit https://asterix-gerrit.ics.uci.edu/2863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7098/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3548/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/ynbYu2 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3548/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4637/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/cpZt4g : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7098/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4222/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4257/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/488/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2863
Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to
FileMapManager
..
[ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Currently it is possible for a thread to access
FileMapManager without holding the proper lock
and therefore seeing a stale state of the map.
This change ensures that all access to the map
is synchronized on the same lock.
Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d
---
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/63/2863/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
index f8b9a57..b35cefe 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
@@ -849,9 +849,8 @@
if (LOGGER.isEnabled(fileOpsLevel)) {
LOGGER.log(fileOpsLevel, "Opening file: " + fileId + " in cache: "
+ this);
}
-BufferedFileHandle fInfo = null;
try {
-fInfo = getOrCreateFileHandle(fileId);
+final BufferedFileHandle fInfo = getOrCreateFileHandle(fileId);
if (fInfo.getFileHandle() == null) {
// a new file
synchronized (fInfo) {
@@ -861,7 +860,10 @@
closeOpeningFiles(fInfo);
}
// create, open, and map new file reference
-FileReference fileRef =
fileMapManager.lookupFileName(fileId);
+FileReference fileRef;
+synchronized (fileInfoMap) {
+fileRef = fileMapManager.lookupFileName(fileId);
+}
IFileHandle fh = ioManager.open(fileRef,
IIOManager.FileReadWriteMode.READ_WRITE,
IIOManager.FileSyncMode.METADATA_ASYNC_DATA_ASYNC);
fInfo.setFileHandle(fh);
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
index 32922d2..0f2703b 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/FileMapManager.java
@@ -25,7 +25,9 @@
import org.apache.hyracks.api.exceptions.ErrorCode;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.io.FileReference;
+import org.apache.hyracks.util.annotations.NotThreadSafe;
+@NotThreadSafe
public class FileMapManager implements IFileMapManager {
private static final long serialVersionUID = 1L;
--
To view, visit https://asterix-gerrit.ics.uci.edu/2863
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9733/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4479/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/543/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4811/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4169/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2269/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4262/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4668/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMap...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2398][STO] Ensure No Concurrent Access to FileMapManager .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8194/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2863 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea7fdb0b891b4ba2aaa528b42eab47b6f841672d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
