Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Murtadha Hubail has submitted this change and it was merged.
Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
..
[NO ISSUE][TX] Fix Concurrent Access in TransactionContext
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Ensure all access to TransactionContext is thread safe.
Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2875
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Murtadha Hubail
Reviewed-by: abdullah alamoudi
---
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java
3 files changed, 16 insertions(+), 18 deletions(-)
Approvals:
Anon. E. Moose #1000171:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
Murtadha Hubail: Looks good to me, but someone else must approve
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
index 95cabf9..a0944ea 100644
---
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
+++
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
@@ -36,7 +36,7 @@
public abstract class AbstractTransactionContext implements
ITransactionContext {
protected final TxnId txnId;
-protected final Map txnOpTrackers;
+private final Map txnOpTrackers;
private final AtomicLong firstLSN;
private final AtomicLong lastLSN;
private final AtomicInteger txnState;
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
index 079e99a..083c26b 100644
---
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
+++
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
@@ -18,8 +18,8 @@
*/
package org.apache.asterix.transaction.management.service.transaction;
-import java.util.HashMap;
import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicInteger;
import org.apache.asterix.common.exceptions.ACIDException;
@@ -35,9 +35,9 @@
@ThreadSafe
public class AtomicTransactionContext extends AbstractTransactionContext {
-private final Map opTrackers = new HashMap<>();
-private final Map indexPendingOps = new HashMap<>();
-private final Map callbacks = new
HashMap<>();
+private final Map opTrackers = new
ConcurrentHashMap<>();
+private final Map indexPendingOps = new
ConcurrentHashMap<>();
+private final Map callbacks = new
ConcurrentHashMap<>();
public AtomicTransactionContext(TxnId txnId) {
super(txnId);
@@ -47,7 +47,7 @@
public void register(long resourceId, int partition, ILSMIndex index,
IModificationOperationCallback callback,
boolean primaryIndex) {
super.register(resourceId, partition, index, callback, primaryIndex);
-synchronized (txnOpTrackers) {
+synchronized (opTrackers) {
if (primaryIndex && !opTrackers.containsKey(resourceId)) {
opTrackers.put(resourceId, index.getOperationTracker());
callbacks.put(resourceId, callback);
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java
index 9fcb08b..188bb1b 100644
---
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java
+++
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java
@@ -18,8 +18,8 @@
*/
package
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7130/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3577/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3577/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4669/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4700/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/520/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7130/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/mstJou : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/dkZwsQ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4514/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4849/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4260/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8231/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4298/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9771/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4205/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2306/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4293/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/581/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3573/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7125/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3573/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/zNhTjR : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4664/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4695/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/515/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7125/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/ZC7uwL : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4292/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4508/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4199/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4287/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/575/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2300/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4843/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8225/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9765/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4254/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4286/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2299/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/574/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Murtadha Hubail has uploaded a new patch set (#2). Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. [NO ISSUE][TX] Fix Concurrent Access in TransactionContext - user model changes: no - storage format changes: no - interface changes: no Details: - Ensure all access to TransactionContext is thread safe. Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c --- M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java 3 files changed, 16 insertions(+), 18 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/75/2875/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9764/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4842/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4253/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/jGa4UD : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2875 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2875
Change subject: [NO ISSUE][TX] Fix Concurrent Access in TransactionContext
..
[NO ISSUE][TX] Fix Concurrent Access in TransactionContext
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Ensure all access to TransactionContext is thread safe.
Change-Id: Id7cc9e67cd51e06cf78b0ea231d3970e5199573c
---
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java
3 files changed, 25 insertions(+), 31 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/75/2875/1
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
index 95cabf9..cc27cd8 100644
---
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
+++
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AbstractTransactionContext.java
@@ -18,8 +18,8 @@
*/
package org.apache.asterix.transaction.management.service.transaction;
-import java.util.HashMap;
import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;
@@ -50,7 +50,7 @@
txnState = new AtomicInteger(ITransactionManager.ACTIVE);
isTimeout = false;
isWriteTxn = new AtomicBoolean();
-txnOpTrackers = new HashMap<>();
+txnOpTrackers = new ConcurrentHashMap<>();
}
@Override
@@ -120,13 +120,11 @@
@Override
public void register(long resourceId, int partition, ILSMIndex index,
IModificationOperationCallback callback,
boolean primaryIndex) {
-synchronized (txnOpTrackers) {
-if (!txnOpTrackers.containsKey(resourceId)) {
-final ITransactionOperationTracker txnOpTracker =
-(ITransactionOperationTracker)
index.getOperationTracker();
-txnOpTrackers.put(resourceId, txnOpTracker);
-txnOpTracker.beforeTransaction(resourceId);
-}
+if (!txnOpTrackers.containsKey(resourceId)) {
+final ITransactionOperationTracker txnOpTracker =
+(ITransactionOperationTracker) index.getOperationTracker();
+txnOpTrackers.put(resourceId, txnOpTracker);
+txnOpTracker.beforeTransaction(resourceId);
}
}
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
index 079e99a..49cd82b 100644
---
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
+++
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
@@ -18,8 +18,8 @@
*/
package org.apache.asterix.transaction.management.service.transaction;
-import java.util.HashMap;
import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicInteger;
import org.apache.asterix.common.exceptions.ACIDException;
@@ -35,9 +35,9 @@
@ThreadSafe
public class AtomicTransactionContext extends AbstractTransactionContext {
-private final Map opTrackers = new HashMap<>();
-private final Map indexPendingOps = new HashMap<>();
-private final Map callbacks = new
HashMap<>();
+private final Map opTrackers = new
ConcurrentHashMap<>();
+private final Map indexPendingOps = new
ConcurrentHashMap<>();
+private final Map callbacks = new
ConcurrentHashMap<>();
public AtomicTransactionContext(TxnId txnId) {
super(txnId);
@@ -47,12 +47,10 @@
public void register(long resourceId, int partition, ILSMIndex index,
IModificationOperationCallback callback,
boolean primaryIndex) {
super.register(resourceId, partition, index, callback, primaryIndex);
-synchronized (txnOpTrackers) {
-if
