Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Ian Maxon has submitted this change and it was merged.

Change subject: Make Xmx small on 32bit JVM
..


Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1521
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Michael Blow 
Integration-Tests: Jenkins 
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 14 insertions(+), 11 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
index 5a03d3c..9b00cc2 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
@@ -111,7 +111,7 @@
 return cList;
 }
 
-private static void configEnvironment(Map env) {
+private static void configEnvironment(Map env) {
 String jvmargs = IniUtils.getString(ini, nodeSection, "jvm.args", 
null);
 if (jvmargs != null) {
 LOGGER.info("Using JAVA_OPTS from conf file (jvm.args)");
@@ -122,7 +122,11 @@
 } else {
 LOGGER.info("Using default JAVA_OPTS");
 long ramSize = ((com.sun.management.OperatingSystemMXBean) 
osMXBean).getTotalPhysicalMemorySize();
-jvmargs = "-Xmx" + (int) Math.ceil(0.6 * ramSize / (1024 * 
1024)) + "m";
+int proportionalRamSize = (int) Math.ceil(0.6 * ramSize / 
(1024 * 1024));
+//if under 32bit JVM, use less than 1GB heap by default. 
otherwise use proportional ramsize.
+int heapSize = 
"32".equals(System.getProperty("sun.arch.data.model"))
+? (proportionalRamSize <= 1024 ? proportionalRamSize : 
1024) : proportionalRamSize;
+jvmargs = "-Xmx" + heapSize + "m";
 }
 }
 env.put("JAVA_OPTS", jvmargs);
@@ -132,10 +136,11 @@
 /**
  * Attempts to launch the "real" NCDriver, based on the configuration
  * information gathered so far.
+ *
  * @return true if the process was successfully launched and has now
- * exited with a 0 (normal) exit code. false if some configuration error
- * prevented the process from being launched or the process returned
- * a non-0 (abnormal) exit code.
+ * exited with a 0 (normal) exit code. false if some configuration 
error
+ * prevented the process from being launched or the process 
returned
+ * a non-0 (abnormal) exit code.
  */
 private static boolean launchNCProcess() {
 try {
@@ -149,13 +154,11 @@
 }
 
 // Logfile
-if (! "-".equals(config.logdir)) {
+if (!"-".equals(config.logdir)) {
 pb.redirectErrorStream(true);
 File log = new File(config.logdir);
-if (! log.mkdirs()) {
-if (! log.isDirectory()) {
-throw new IOException(config.logdir + ": cannot 
create");
-}
+if (!log.mkdirs() && !log.isDirectory()) {
+throw new IOException(config.logdir + ": cannot create");
 // If the directory IS there, all is well
 }
 File logfile = new File(config.logdir, "nc-" + ncId + ".log");
@@ -202,7 +205,7 @@
 try {
 ObjectInputStream ois = new ObjectInputStream(is);
 String magic = ois.readUTF();
-if (! ServiceConstants.NC_SERVICE_MAGIC_COOKIE.equals(magic)) {
+if (!ServiceConstants.NC_SERVICE_MAGIC_COOKIE.equals(magic)) {
 LOGGER.severe("Connection used incorrect magic cookie");
 return false;
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2029/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2029/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2027/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2025/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/8/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS8, Line 128: (proportionalRamSize <= 1024 ? proportionalRamSize : 1024)
> There's no method call for Math.min().
I'm a little sad we didn't put back Math.min() since we spun another patch...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/652/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/652/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2025/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2021/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4470/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Hello Michael Blow, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1521

to look at the new patch set (#9).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 14 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/8/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS8, Line 128: (proportionalRamSize <= 1024 ? proportionalRamSize : 1024)
> I had that originally but I changed it due to Yingyi's comment. It does sav
There's no method call for Math.min().


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2021/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2019/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2019/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2001/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/8/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS8, Line 128: (proportionalRamSize <= 1024 ? proportionalRamSize : 1024)
> Math.min(1024, proportionalRamSize)?
I had that originally but I changed it due to Yingyi's comment. It does save a 
method call, for whatever that's worth.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

(1 comment)

Already did a plus two, but...

https://asterix-gerrit.ics.uci.edu/#/c/1521/8/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS8, Line 128: (proportionalRamSize <= 1024 ? proportionalRamSize : 1024)
Math.min(1024, proportionalRamSize)?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/631/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4433/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1521

to look at the new patch set (#8).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 14 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 7:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

Line 121: return "64".equals("prop");
> I guess you meant prop not "prop".
Ah, true.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 7:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

Line 121: return "64".equals("prop");
> MAJOR SonarQube violation:
I guess you meant prop not "prop".

Wouldn't this be way cleaner to just change the condition to be 32-bit (since 
it's the exception), and then replace this whole method with 
"32".equals(System.getProperty("sun.arch.data.model"))?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4415/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1521

to look at the new patch set (#7).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 24 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1979/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 6: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/614/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/614/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1979/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4403/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS6, Line 137: 1024
line width?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1521

to look at the new patch set (#6).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 23 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Ian Maxon has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS4, Line 137: (int) Math.ceil(0.6 * ramSize / (1024 * 1024))
> move the calculation to one line above the if block and use a variable for 
Done (I think, not sure which conditional you mean)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1521

to look at the new patch set (#5).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 23 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1975/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1521/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java:

PS4, Line 137: (int) Math.ceil(0.6 * ramSize / (1024 * 1024))
move the calculation to one line above the if block and use a variable for that 
in both if and else branches?

use an one line conditional expression for the if-else ?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1975/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1967/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/605/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1967/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/605/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4388/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1521

to look at the new patch set (#4).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 25 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 3: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/603/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/603/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1965/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Xikui Wang 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1521

to look at the new patch set (#3).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 25 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4387/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4386/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Ian Maxon has uploaded a new patch set (#2).

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
1 file changed, 26 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Make Xmx small on 32bit JVM
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4385/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1521
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Make Xmx small on 32bit JVM

[Ian Maxon (Code Review)]

Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1521

Change subject: Make Xmx small on 32bit JVM
..

Make Xmx small on 32bit JVM

There can be issues with the default memory parameter settings
if run on a 32Bit JVM, as the maximum RAM can be large due to
PAE or using 32bit JVM on a 64bit OS, therefore leading to an
-Xmx setting that is too large to address.

This makes the maximum 1GB by default on 32bit JVMs, as there
is a related issue on Windows where 32 bit processes are
limited to about 1.5G per process.

Change-Id: I025174fc2ca53e8d15ed53fac31b43bea3ddf281
---
M asterixdb/asterix-client-helper/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
M asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java
6 files changed, 33 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/1521/1

diff --git a/asterixdb/asterix-client-helper/pom.xml 
b/asterixdb/asterix-client-helper/pom.xml
index 9a7bb64..726e8fa 100644
--- a/asterixdb/asterix-client-helper/pom.xml
+++ b/asterixdb/asterix-client-helper/pom.xml
@@ -41,26 +41,17 @@
 
   
 unix
+windows
   
   asterixhelper
   
org.apache.asterix.clienthelper.AsterixHelper
 
   
-  
-
-  asterixhelper
-  
org.apache.asterix.clienthelper.AsterixHelper
-  
-booter-windows
-  
-
-  
 
 
   
 
   assemble
-  generate-daemons
 
   
 
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
index dd7c8e4..83ff3a2 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
@@ -31,7 +31,7 @@
 // 3000  3999: feed errors
 // 4000  4999: lifecycle management errors
 public class ErrorCode {
-private static final String RESOURCE_PATH = "asx_errormsg" + 
File.separator + "en.properties";
+private static final String RESOURCE_PATH = "asx_errormsg/en.properties";
 public static final String ASTERIX = "ASX";
 
 // Extension errors
diff --git 
a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat 
b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
index 580e1e0..74ca87e 100644
--- a/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.bat
@@ -52,20 +52,6 @@
 goto opts
 :postopts
 
-if NOT DEFINED JAVA_HOME (
-  echo ERROR: JAVA_HOME not defined
-  goto :ERROR
-)
-REM ensure JAVA_HOME has no spaces nor quotes, since appassembler can't handle 
them
-set JAVA_HOME=%JAVA_HOME:"=%
-for %%I in ("%JAVA_HOME%") do (
-  set JAVA_HOME=%%~sI
-)
-
-set JAVACMD=%JAVA_HOME%\bin\java
-
-REM TODO(mblow): check java version, spaces in CWD
-
 set DIRNAME=%~dp0
 
 pushd %DIRNAME%\..
@@ -92,7 +78,7 @@
 
 wmic process where ^
   "name='java.exe' and CommandLine like 
'%%org.codehaus.mojo.appassembler.booter.AppassemblerBooter%%' and (CommandLine 
like '%%app.name=\"%%[cn]c\"%%' or CommandLine like 
'%%app.name=\"%%ncservice\"%%')" ^
-  GET processid > %tempfile% 2>/dev/null
+  GET processid > %tempfile% 2> nul
 
 set severity=ERROR
 if "%force%" == "1" set severity=WARNING
diff --git 
a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat 
b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat
index 7ac9483..6b02174 100644
--- a/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat
+++ b/asterixdb/asterix-server/src/main/opt/local/bin/stop-sample-cluster.bat
@@ -58,17 +58,6 @@
 goto opts
 :postopts
 
-if NOT DEFINED JAVA_HOME (
-  echo ERROR: JAVA_HOME not defined
-  goto :ERROR
-)
-
-REM ensure JAVA_HOME has no spaces nor quotes, since appassembler can't handle 
them
-set JAVA_HOME=%JAVA_HOME:"=%
-for %%I in ("%JAVA_HOME%") do (
-  set JAVA_HOME=%%~sI
-)
-
 set DIRNAME=%~dp0
 
 pushd %DIRNAME%\..
@@ -92,12 +81,12 @@
 if "%tries%" == "60" goto :timed_out
 wmic process where ^
   "name='java.exe' and CommandLine like 
'%%org.codehaus.mojo.appassembler.booter.AppassemblerBooter%%'