Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-numbers/pull/8
You're right, that's the most simple way.
Pushed changes now to master.
They appear here in this pull request.
Furthermore I will close pull request #9.
---
If your project is
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-numbers/pull/8
Yes, since you have opened it, you have right to close #9 , but simply push
those changes to your master so those will be available in #8. Thanks.
---
If your project is set up for it, you
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-numbers/pull/8
Yes ...
Forgot that I created a branch explicitly yesterday.
After pughing ...
Think that doesn't bother a lot, simply delete the pull request you do not
need.
---
If your pro
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-numbers/pull/8
Thanks @TheRealHaui. will take another round or review.
If you wish that new code to be come under same PR you have to push to same
branch :wink:
for #8 you pushed to ```TheRea
Github user TheRealHaui commented on the issue:
https://github.com/apache/commons-numbers/pull/8
@ameyjadiye
Removed evil empty lines in pull request #9.
Don't know why Github didn't add the change to the original pull request.
Anyway, I think that doesn't bother a lot.
Github user coveralls commented on the issue:
https://github.com/apache/commons-numbers/pull/8
[](https://coveralls.io/builds/12328326)
Coverage increased (+3.2%) to 86.303% when pulling
**eb962ef6f5348a706cec
