[GitHub] couchdb-fauxton pull request: Improve the strings

2015-11-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/575#discussion_r45573716 --- Diff: app/addons/auth/components.react.jsx --- @@ -239,9 +238,6 @@ define([ - Non-admin users

[GitHub] couchdb-couch-log pull request: Implement couch_log_devnull for su...

2015-11-22 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log/pull/9#issuecomment-158853795 @jaydoane yea, I should add travis.yml everywhere. Thanks for reminder (: --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-fauxton pull request: Improve the strings

2015-11-22 Thread ykye
Github user ykye commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/575#discussion_r45573598 --- Diff: app/addons/auth/components.react.jsx --- @@ -239,9 +238,6 @@ define([ - Non-admin users

[GitHub] couchdb-couch-log pull request: Implement couch_log_devnull for su...

2015-11-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-log/pull/9#discussion_r45570641 --- Diff: src/couch_log_devnull.erl --- @@ -0,0 +1,60 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +%

[jira] [Commented] (COUCHDB-2899) It should be easy to suppress all logging during testing, regardless of backend

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021437#comment-15021437 ] ASF GitHub Bot commented on COUCHDB-2899: - GitHub user jaydoane opened a pull request:

[GitHub] couchdb-couch-log pull request: Implement couch_log_devnull for su...

2015-11-22 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch-log/pull/9 Implement couch_log_devnull for suppressing logging during testing COUCHDB-2899 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] couchdb-couch-log pull request: Implement couch_log_devnull for su...

2015-11-22 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-log/pull/9#issuecomment-158853319 @kxepal, excellent. Thank you! Looks like you'll need to add .travis.yml in your commit, though. --- If your project is set up for it, you can reply to this

[jira] [Created] (COUCHDB-2899) It should be easy to suppress all logging during testing, regardless of backend

2015-11-22 Thread Jay Doane (JIRA)
Jay Doane created COUCHDB-2899: -- Summary: It should be easy to suppress all logging during testing, regardless of backend Key: COUCHDB-2899 URL: https://issues.apache.org/jira/browse/COUCHDB-2899

[GitHub] couchdb-couch-log pull request: Implement couch_log_devnull for su...

2015-11-22 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-log/pull/9#issuecomment-158846637 I can certainly look into configuring couch_log via config, but right now my priority is re-enabling the test suite for downstream CI builds. This is just a

[GitHub] couchdb-couch-log pull request: Make couch_log configurable

2015-11-22 Thread kxepal
GitHub user kxepal opened a pull request: https://github.com/apache/couchdb-couch-log/pull/10 Make couch_log configurable This allows to set logging backend and level via config API making logging configuration a bit closer as it was in CouchDB 1.x. You can merge this pull

[GitHub] couchdb-couch-log pull request: Implement couch_log_devnull for su...

2015-11-22 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log/pull/9#issuecomment-158852721 @jaydoane ok, so I just submitted https://github.com/apache/couchdb-couch-log/pull/10 To solve your problem there is nothing need to do since

[GitHub] couchdb-couch pull request: 2898 improve global changes tests

2015-11-22 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/129#issuecomment-158793662 Don't you actually hide an issue with e7b3ba4 commit? Slash character is used by global_changes for specific logic owner. --- If your project is set up for it,

[jira] [Created] (COUCHDB-2898) Improve robustness of global_changes_tests

2015-11-22 Thread Jay Doane (JIRA)
Jay Doane created COUCHDB-2898: -- Summary: Improve robustness of global_changes_tests Key: COUCHDB-2898 URL: https://issues.apache.org/jira/browse/COUCHDB-2898 Project: CouchDB Issue Type:

[GitHub] couchdb-couch pull request: 2898 improve global changes tests

2015-11-22 Thread jaydoane
GitHub user jaydoane opened a pull request: https://github.com/apache/couchdb-couch/pull/129 2898 improve global changes tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloudant/couchdb-couch

[GitHub] couchdb-couch pull request: 2898 improve global changes tests

2015-11-22 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch/pull/129#issuecomment-158799592 Yes, it's possible that there's a bug downstream that's triggered by the "/" in the db name. It works correctly for one of the downstream builds, but fails in

[GitHub] couchdb-couch pull request: 2898 improve global changes tests

2015-11-22 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/129#issuecomment-158801429 I think you should omit that commit in order to not forget about the bug and fix it in downstream (: There is no better reminder as build failure. --- If your