[GitHub] couchdb-fabric issue #88: Use RealReplyCount to distinguish worker replies a...

2017-02-10 Thread nickva
Github user nickva commented on the issue: https://github.com/apache/couchdb-fabric/pull/88 _bulk_get and open_revs=all work +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-fauxton pull request #848: Fix build & config addons

2017-02-10 Thread skorobkov
GitHub user skorobkov opened a pull request: https://github.com/apache/couchdb-fauxton/pull/848 Fix build & config addons Bump `grunt-contrib-copy` to version 1.0.0 required because `npm install` generate this error: ``` $ npm install npm WARN peerDependencies The peer

[GitHub] couchdb-fauxton issue #833: remove backbone from auth

2017-02-10 Thread justin-mcdavid-ibm
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/833 Hi Tim, thanks for your work on this section. Here are some ideas of what we might do with that section.

[jira] [Commented] (COUCHDB-3113) fabric:open_revs can return {ok, []}

2017-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861726#comment-15861726 ] ASF GitHub Bot commented on COUCHDB-3113: - GitHub user tonysun83 opened a pull request:

[GitHub] couchdb-fabric pull request #88: Use RealReplyCount to distinguish worker re...

2017-02-10 Thread tonysun83
GitHub user tonysun83 opened a pull request: https://github.com/apache/couchdb-fabric/pull/88 Use RealReplyCount to distinguish worker replies and invalid docs We use {ok, []} in couch_db:open_doc_revs_int/3 as a return value when the document does not exist and open_revs=all.

[GitHub] couchdb-fauxton issue #833: remove backbone from auth

2017-02-10 Thread timmak
Github user timmak commented on the issue: https://github.com/apache/couchdb-fauxton/pull/833 Thanks @garrensmith will remove `babel-eslint` and the transform and work through the other stuff mentioned as for design changes will have a better idea once I know whether or not to do in

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100534561 --- Diff: app/addons/auth/base.js --- @@ -61,50 +71,16 @@ Auth.initialize = function () { className: 'logout' }); }

[jira] [Commented] (COUCHDB-2829) Fauxton username and password do not autofill

2017-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861246#comment-15861246 ] ASF GitHub Bot commented on COUCHDB-2829: - Github user garrensmith commented on a diff in the

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100530991 --- Diff: app/addons/auth/components/LoginForm.jsx --- @@ -0,0 +1,101 @@ +import React from "react"; +import ReactDOM from "react-dom";

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100529877 --- Diff: app/addons/auth/base.js --- @@ -61,50 +71,16 @@ Auth.initialize = function () { className: 'logout' });

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100531254 --- Diff: app/addons/auth/stores/ChangePassword.js --- @@ -0,0 +1,57 @@ +import FauxtonAPI from "../../../core/api"; +import { +

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100530478 --- Diff: app/addons/auth/components/LoginForm.jsx --- @@ -0,0 +1,101 @@ +import React from "react"; +import ReactDOM from "react-dom";

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100529683 --- Diff: app/addons/auth/actiontypes.js --- @@ -2,24 +2,24 @@ // use this file except in compliance with the License. You may obtain a

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100529913 --- Diff: app/addons/auth/base.js --- @@ -61,50 +71,16 @@ Auth.initialize = function () { className: 'logout' });

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100531532 --- Diff: app/addons/verifyinstall/resources.js --- @@ -11,152 +11,159 @@ // the License. import app from "../../app";

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100528884 --- Diff: .babelrc --- @@ -3,5 +3,5 @@ "react", "es2015" ], - "plugins": ["transform-object-assign"] +

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100529377 --- Diff: app/addons/auth/actions.js --- @@ -10,148 +10,162 @@ // License for the specific language governing permissions and limitations

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100529625 --- Diff: app/addons/auth/actions.js --- @@ -10,148 +10,162 @@ // License for the specific language governing permissions and limitations

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100529500 --- Diff: app/addons/auth/actions.js --- @@ -10,148 +10,162 @@ // License for the specific language governing permissions and limitations

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100529832 --- Diff: app/addons/auth/base.js --- @@ -44,7 +54,7 @@ Auth.initialize = function () { } else if (session.isLoggedIn()) {

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100528767 --- Diff: .eslintrc --- @@ -31,9 +31,10 @@ "react/jsx-uses-vars": 2, "react/jsx-uses-react": 2 }, - +

[GitHub] couchdb-fauxton issue #847: lodash updates switching from _.contains to _.in...

2017-02-10 Thread garrensmith
Github user garrensmith commented on the issue: https://github.com/apache/couchdb-fauxton/pull/847 +1. I've merged. Can you close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this