Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107330320
--- Diff: src/couch_mrview.erl ---
@@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) ->
end.
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107329994
--- Diff: src/couch_mrview.erl ---
@@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) ->
end.
Github user jaydoane commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/72
This LGTM, and tests pass for me locally:
```
module 'couch_mrview_local_docs_tests'
_local_docs view tests
couch_mrview_local_docs_tests:68: should_query...ok
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107325855
--- Diff: test/couch_mrview_local_docs_tests.erl ---
@@ -0,0 +1,134 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
Github user jaydoane commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107325722
--- Diff: test/couch_mrview_local_docs_tests.erl ---
@@ -0,0 +1,134 @@
+% Licensed under the Apache License, Version 2.0 (the "License");
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107318756
--- Diff: src/couch_mrview.erl ---
@@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) ->
end.
Github user sagelywizard commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107306442
--- Diff: src/couch_mrview.erl ---
@@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) ->
end.
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/72
@davisp @iilyak Can you take a look, please, whenever you'll have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/COUCHDB-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935485#comment-15935485
]
ASF GitHub Bot commented on COUCHDB-3337:
-
GitHub user eiri opened a pull request:
Eric Avdey created COUCHDB-3337:
---
Summary: End-point _local_docs doesn't conform to query params of
_all_docs
Key: COUCHDB-3337
URL: https://issues.apache.org/jira/browse/COUCHDB-3337
Project: CouchDB
10 matches
Mail list logo