[GitHub] couchdb-nmo pull request: Isonline cluster

2015-09-07 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-nmo/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-nmo pull request: Isonline cluster

2015-09-04 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-nmo/pull/2 Isonline cluster Adds functionality to `nmo isonline clusterName` to do a check if all nodes in a cluster are online. You can merge this pull request into a Git repository by running

[GitHub] couchdb-nmo pull request: [WIP] Import csv

2015-09-04 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-nmo/pull/1#issuecomment-137716155 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-nmo pull request: [WIP] Import csv

2015-09-04 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-nmo/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb pull request: Adapt csrf test to hit form data endpoint

2015-09-04 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/341#issuecomment-137702151 For what its worth I +1. Not sure why travis is failing though. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-nmo pull request: [WIP] Import csv

2015-09-02 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-nmo/pull/1#discussion_r38513788 --- Diff: src/import-csv.js --- @@ -0,0 +1,65 @@ +import fs from 'fs'; +import Promise from 'bluebird'; +import _ from 'lodash

[GitHub] couchdb-nmo pull request: [WIP] Import csv

2015-09-02 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-nmo/pull/1#discussion_r38518425 --- Diff: src/import-csv.js --- @@ -0,0 +1,65 @@ +import fs from 'fs'; +import Promise from 'bluebird'; +import _ from 'lodash

[GitHub] couchdb-fauxton pull request: remove broken notifications

2015-09-01 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/511#issuecomment-136768264 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-nmo pull request: [WIP] Import csv

2015-08-27 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-nmo/pull/1 [WIP] Import csv This needs some clean up around error handling and capturing the arguments. But other than that it can now import a csv to CouchDB. You can merge this pull request

[GitHub] couchdb-fauxton pull request: Add CSRF indicator

2015-08-13 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/497#issuecomment-130683765 +1 once the tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request: React query options

2015-08-11 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-129785406 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: React query options

2015-08-11 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: Fauxton csrf fixes

2015-08-10 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/494#issuecomment-129365346 +1 nice fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Fix doc attachment uploader

2015-08-10 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/491#issuecomment-129365623 @michellephung could you rebase once #494 lands and test this again. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-fauxton pull request: React query options

2015-08-10 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36630749 --- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx --- @@ -0,0 +1,405 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request: React query options

2015-08-10 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-129457967 @michellephung and @robertkowalski thanks for reviewing. All tests passing and all fixes done. I need a +1 from both of you and then I can merge this :+1

[GitHub] couchdb-fauxton pull request: Use CSRF protection if available

2015-08-03 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/488#discussion_r36083449 --- Diff: app/app.js --- @@ -63,6 +63,29 @@ function (app, $, _, Backbone, Bootstrap, Helpers, Utils, FauxtonAPI, Couchdb) { // Localize

[GitHub] couchdb-fauxton pull request: Use CSRF protection if available

2015-08-03 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/488#discussion_r36083505 --- Diff: app/app.js --- @@ -63,6 +63,29 @@ function (app, $, _, Backbone, Bootstrap, Helpers, Utils, FauxtonAPI, Couchdb) { // Localize

[GitHub] couchdb-fauxton pull request: Trigger error on failed session

2015-07-21 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/482#issuecomment-123405693 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Trigger error on failed session

2015-07-21 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: Url fix

2015-06-23 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: Fix failing PreviousButton test

2015-06-23 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/470#issuecomment-114389530 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Fix for relative link handling issue...

2015-06-22 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/465#issuecomment-114155759 +1 nice find --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Url fix

2015-06-22 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/464#issuecomment-114038653 @benkeen can you take another look. I've changed the behaviour. It now uses the history when a user is viewing a doc. But uses `_all_docs` when returning

[GitHub] couchdb-fauxton pull request: React sidebar

2015-06-17 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: Refactoring CodeEditor /

2015-06-15 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/459#discussion_r32405708 --- Diff: app/addons/components/react-components.react.jsx --- @@ -220,56 +332,49 @@ function (app, FauxtonAPI, React, Components, ace

<    1   2   3   4   5