[GitHub] couchdb-fauxton pull request #849: Currently reducers seem to be handled qui...

2017-02-20 Thread timmak
Github user timmak closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/849 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request #849: Currently reducers seem to be handled qui...

2017-02-15 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/849#discussion_r101279779 --- Diff: app/core/base.js --- @@ -157,6 +157,10 @@ FauxtonAPI.setSession = function (newSession) { return FauxtonAPI.session.fetchUser

[GitHub] couchdb-fauxton pull request #849: Currently reducers seem to be handled qui...

2017-02-15 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/849#discussion_r101274745 --- Diff: app/core/base.js --- @@ -157,6 +157,10 @@ FauxtonAPI.setSession = function (newSession) { return FauxtonAPI.session.fetchUser

[GitHub] couchdb-fauxton pull request #849: Currently reducers seem to be handled qui...

2017-02-14 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/849#discussion_r101054470 --- Diff: app/main.js --- @@ -57,24 +57,10 @@ $(document).on("click", "a:not([data-bypass])", function (evt) { } });

[GitHub] couchdb-fauxton pull request #849: Currently reducers seem to be handled qui...

2017-02-14 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/849#discussion_r101055093 --- Diff: app/addons/permissions/base.js --- @@ -12,11 +12,13 @@ import FauxtonAPI from "../../core/api"; import Permis

[GitHub] couchdb-fauxton issue #833: remove backbone from auth

2017-02-10 Thread timmak
Github user timmak commented on the issue: https://github.com/apache/couchdb-fauxton/pull/833 Thanks @garrensmith will remove `babel-eslint` and the transform and work through the other stuff mentioned as for design changes will have a better idea once I know whether or not to do

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-02-10 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r100534561 --- Diff: app/addons/auth/base.js --- @@ -61,50 +71,16 @@ Auth.initialize = function () { className: 'logout

[GitHub] couchdb-fauxton issue #833: remove backbone from auth

2017-02-07 Thread timmak
Github user timmak commented on the issue: https://github.com/apache/couchdb-fauxton/pull/833 @garrensmith could you give this a code review ended up making a lot of changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-fauxton issue #833: remove backbone from auth

2017-01-18 Thread timmak
Github user timmak commented on the issue: https://github.com/apache/couchdb-fauxton/pull/833 Still working on it fixing the test is turning out to be a lot harder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-01-17 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r96428914 --- Diff: app/core/base.js --- @@ -9,9 +9,11 @@ // WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the // License

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-01-17 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r96428694 --- Diff: app/core/base.js --- @@ -159,4 +161,15 @@ FauxtonAPI.setSession = function (newSession) { FauxtonAPI.reducers

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-01-17 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/833#discussion_r96428612 --- Diff: app/addons/config/routes.js --- @@ -16,10 +16,10 @@ import CORSActions from "../cors/actions"; import ClusterActions from &

[GitHub] couchdb-fauxton issue #833: remove backbone from auth

2017-01-16 Thread timmak
Github user timmak commented on the issue: https://github.com/apache/couchdb-fauxton/pull/833 Yep will do just ran out of time will try get done later today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request #833: remove backbone from auth

2017-01-16 Thread timmak
GitHub user timmak opened a pull request: https://github.com/apache/couchdb-fauxton/pull/833 remove backbone from auth In process of removing jQuery this also will require remove backbone rather make a few small PRs then on big one. You can merge this pull request into a Git

[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing

2016-11-30 Thread timmak
Github user timmak commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/815#discussion_r90232178 --- Diff: app/addons/replication/__tests__/helpers-tests.js --- @@ -0,0 +1,34 @@ +// Licensed under the Apache License, Version 2.0 (the "Li

[GitHub] couchdb-fauxton pull request #813: encodeding url path for database name wit...

2016-11-29 Thread timmak
Github user timmak closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/813 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #813: encodeding url path for database name with speci...

2016-11-28 Thread timmak
Github user timmak commented on the issue: https://github.com/apache/couchdb-fauxton/pull/813 @michellephung everything fixed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-fauxton pull request #813: encodeding url path for database name wit...

2016-11-23 Thread timmak
GitHub user timmak opened a pull request: https://github.com/apache/couchdb-fauxton/pull/813 encodeding url path for database name with special characters Should resolve https://issues.apache.org/jira/browse/COUCHDB-3146 You can merge this pull request into a Git repository