[GitHub] [couchdb] nickva commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-18 Thread via GitHub
nickva commented on code in PR #4718: URL: https://github.com/apache/couchdb/pull/4718#discussion_r1298530399 ## src/fabric/src/fabric.erl: ## @@ -590,25 +590,38 @@ cleanup_index_files(DbName) -> cleanup_local_indices_and_purge_checkpoints([]) -> ok;

[GitHub] [couchdb] nickva commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-17 Thread via GitHub
nickva commented on code in PR #4718: URL: https://github.com/apache/couchdb/pull/4718#discussion_r1297859281 ## src/fabric/src/fabric.erl: ## @@ -590,25 +590,38 @@ cleanup_index_files(DbName) -> cleanup_local_indices_and_purge_checkpoints([]) -> ok;

[GitHub] [couchdb] nickva commented on a diff in pull request #4718: enhance smoosh to cleanup search indexes when ddocs change

2023-08-07 Thread via GitHub
nickva commented on code in PR #4718: URL: https://github.com/apache/couchdb/pull/4718#discussion_r1286023989 ## src/smoosh/src/smoosh_server.erl: ## @@ -342,6 +345,8 @@ find_channel(#state{} = State, [Channel | Rest], Object) -> find_channel(State, Rest, Object)