[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385529390 Hrm, that is interesting. I have checked the corresponding `rebar` scripts and only these paths were included on the C compiler flags. -- This is an automated message from the Apache Git

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385509568 @big-r81 do you have any ideas why this current version fails on the CI? Initially I thought that is due to `--skip-deps` but by browsing the code, it seems to be unrelated. -- This is

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385507303 Sure, I am happy to consider the Windows bits as well. Maybe I can find a Windows system somewhere to poke around with this. -- This is an automated message from the Apache Git Service.

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385488222 Hi @big-r81 : I tried to mention that this is for Unix-based systems -- I do not have a Windows instance around to experiment with the changes. But I can take a chance with that. -- This

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385486336 Oh, and it seems I also did not consider the `--skip-deps` flag either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and