[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2023-04-22 Thread via GitHub
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1518664205 leaving branch alive as I squashed the history when I merged. some of the commits might be useful for understanding nascent project history. -- This is an automated message from the

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2023-04-21 Thread via GitHub
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1517689907 @nickva thank you for the detailed review, I've pushed a commit with fixes for pretty much all of it. It helped find a silly error in _nouveau_analyze (the core of it worked, I somehow

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2023-04-21 Thread via GitHub
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1517681072 the 'expectation_failed' I think is because some tests run so quickly that the new dbname for the next test is the same. I suspect its a timestamp? -- This is an automated message from

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2023-03-30 Thread via GitHub
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1489996648 on sort order, yes, you can sort on one or more fields (string or number) in ascending or descending order, the same as dreyfus. Unlike dreyfus, nouveau uses couch_ejson_compare when

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2023-03-27 Thread via GitHub
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1485747436 * Nouveau endpoints return 404 if disabled and no attempt is made by the nouveau erlang app to contact the JVM side for background indexing. * update=true|false is supported but

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2022-12-07 Thread GitBox
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1341152139 API choices. Currently you can define a nouveau index almost identically to clouseau, the `index()` function behaves the same way, you just need to use "nouveau" as a top-level

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2022-12-07 Thread GitBox
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1341144819 @big-r81 they worked in the original repo when they are at the root. good call, though. we either need to adjust them so they work here or remove them. haven't thought much about it.