[GitHub] [couchdb] rnewson commented on pull request #4755: Add tests for X-Forwarded-For

2023-09-11 Thread via GitHub
rnewson commented on PR #4755: URL: https://github.com/apache/couchdb/pull/4755#issuecomment-1714287565 I should say, even if it does test couchdb (that is touch real chttpd and real mochiweb, not mocked versions), the problem we're addressing was not what couchdb logged anyway. it was

[GitHub] [couchdb] rnewson commented on pull request #4755: Add tests for X-Forwarded-For

2023-09-11 Thread via GitHub
rnewson commented on PR #4755: URL: https://github.com/apache/couchdb/pull/4755#issuecomment-1714283996 I like the coverage but I don't think it tests _couchdb_. It asserts the behaviour of a mochiweb function, but not whether we call it and use the result to populate `peer` There