[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-141205964 @rnewson I fixed all your comments + made a bit cleanup. All changes are done in own commits for simpler review. --- If your project is set up for it, you can

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-141245687 nice! +1 after squash. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user asfgit closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/33#discussion_r39591539 --- Diff: src/chttpd_db.erl --- @@ -1536,6 +1576,135 @@ set_namespace(<<"_design_docs">>, Args) -> set_namespace(NS, #mrargs{extra = Extra} = Args)

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/33#discussion_r39591526 --- Diff: src/chttpd_db.erl --- @@ -449,6 +449,45 @@ db_req(#httpd{method='POST',path_parts=[_,<<"_bulk_docs">>], user_ctx=Ctx}=Req,

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140336820 I'd like this to land for 2.0 but haven't been focusing attention here. Is PouchDB satisified with the api and functionality? --- If your project is set up for

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/33#discussion_r39495399 --- Diff: src/chttpd_db.erl --- @@ -1536,6 +1576,135 @@ set_namespace(<<"_design_docs">>, Args) -> set_namespace(NS, #mrargs{extra = Extra} =

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/33#discussion_r39495390 --- Diff: src/chttpd_db.erl --- @@ -1536,6 +1576,135 @@ set_namespace(<<"_design_docs">>, Args) -> set_namespace(NS, #mrargs{extra = Extra} =

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user rnewson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140348091 +1 after addressing comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/33#discussion_r39495330 --- Diff: src/chttpd_db.erl --- @@ -1536,6 +1576,135 @@ set_namespace(<<"_design_docs">>, Args) -> set_namespace(NS, #mrargs{extra = Extra} =

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/33#discussion_r39497381 --- Diff: src/chttpd_db.erl --- @@ -1536,6 +1576,135 @@ set_namespace(<<"_design_docs">>, Args) -> set_namespace(NS, #mrargs{extra = Extra} = Args)

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/33#discussion_r39495209 --- Diff: src/chttpd_db.erl --- @@ -449,6 +449,45 @@ db_req(#httpd{method='POST',path_parts=[_,<<"_bulk_docs">>], user_ctx=Ctx}=Req,

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140141043 to elaborate, PouchDB is adding query parameters (revs=true, attachments=true) to the request body instead of the query string. --- If your project is set up

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140140779 ah - ignore the above. PouchDB is wrong here (if we're basing this on rcouch). The CouchDB implementation works as expected through the clustered interface.

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140161373 @willholley Actually, we all here should use http://developer.couchbase.com/mobile/develop/references/sync-gateway/rest-api/database/post-bulk-get/index.html as

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140180282 I have a PouchDB PR with all tests now passing against this implementation. I imagine there are some optimisations that could be done in terms of minimising

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-139565250 in my tests, bulk_get doesn't return the list of revisions correctly: $ curl http://localhost:15984/willtest -XPUT {"ok":true}

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

Github user nolanlawson commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-131152149 @kxepal @robertkowalski What is the status of this? Been meaning to implement this in PouchDB/PouchDB Server, but I was hoping this could get merged first.