[GitHub] couchdb-couch-mrview pull request #65: Refactor mrview_index get

2017-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-mrview/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch-mrview pull request #65: Refactor mrview_index get

2017-02-09 Thread davisp
Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/65#discussion_r100305494 --- Diff: src/couch_mrview_index.erl --- @@ -23,84 +23,77 @@ -include_lib("couch_mrview/include/couch_mrview.hrl").

[GitHub] couchdb-couch-mrview pull request #65: Refactor mrview_index get

2017-02-08 Thread eiri
Github user eiri commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/65#discussion_r100131808 --- Diff: src/couch_mrview_index.erl --- @@ -23,84 +23,77 @@ -include_lib("couch_mrview/include/couch_mrview.hrl").

[GitHub] couchdb-couch-mrview pull request #65: Refactor mrview_index get

2017-02-07 Thread eiri
Github user eiri commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/65#discussion_r99881145 --- Diff: src/couch_mrview_index.erl --- @@ -23,84 +23,80 @@ -include_lib("couch_mrview/include/couch_mrview.hrl").

[GitHub] couchdb-couch-mrview pull request #65: Refactor mrview_index get

2017-02-07 Thread davisp
Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/65#discussion_r99875440 --- Diff: src/couch_mrview_index.erl --- @@ -23,84 +23,80 @@ -include_lib("couch_mrview/include/couch_mrview.hrl").

[GitHub] couchdb-couch-mrview pull request #65: Refactor mrview_index get

2017-02-07 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/65#discussion_r99859905 --- Diff: src/couch_mrview_index.erl --- @@ -23,84 +23,80 @@ -include_lib("couch_mrview/include/couch_mrview.hrl").

[GitHub] couchdb-couch-mrview pull request #65: Refactor mrview_index get

2017-02-07 Thread eiri
GitHub user eiri opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/65 Refactor mrview_index get This is a simple refactoring of mrview's `get/2` function that uses function's pattern matching instead of staircase case. Arguably this makes code