[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140422655 @micah no, you have https://github.com/micah/couchdb-documentation/tree/patch-2 P: --- If your project is set up for it, you can reply to this email and

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread micah
Github user micah commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140422258 @kxepal The thing is, I didn't have a fork at all... I went and forked it to make this last pull request, and there was no patch-2 branch there either.

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140420382 Github webeditor is just shortcut for: fork, create patch-N branch, commit and create PR - and all in your browser. --- If your project is set up for it,

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140420153 @micah Actually, you can control this PR via patch-2 branch which is located in your fork. Any modifications there will be reflected here. --- If your

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread micah
GitHub user micah opened a pull request: https://github.com/apache/couchdb-documentation/pull/34 Fix bashism in Makefile The [[ operator is a bashism, and fails with POSIX shells (such as dash), replace it with a simplier version that does the same thing, without the

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread micah
Github user micah closed the pull request at: https://github.com/apache/couchdb-documentation/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/34#issuecomment-140419751 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-documentation/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-15 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/34#issuecomment-140419835 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-14 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140208285 @benkeen that's lack of python sphinx: you don't have it installed, so build fails on docs. However, they shouldn't and cannot block Fauxton as they

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-14 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140207450 Could this be causing a couchdb installation failure? - Fresh clone of couchdb - run `./configure` - run `make`. Result: ```

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-14 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140207796 @micah ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-14 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-140209475 I see, thanks @kxepal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-02 Thread micah
Github user micah commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-137098465 >not sure why you didn't edit the original PR but note for future that we prefer it if comments are addressed in the same place I'm not sure why I

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-02 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-137105055 @micah thanks! please squash your commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-01 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-documentation/pull/30#discussion_r38478436 --- Diff: Makefile --- @@ -21,11 +21,7 @@ PAPERSIZE:= -D latex_paper_size=a4 SPHINXFLAGS := -a -W -n -A local=1 $(PAPERSIZE) -d

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-01 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-136877922 This version doesn't works for me: ``` $ make html which: no sphinx-build in

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-01 Thread micah
GitHub user micah opened a pull request: https://github.com/apache/couchdb-documentation/pull/29 Fix bashism in Makefile The [[ operator is a bashism, and fails with POSIX shells (such as dash), replace it with a simplier version that does the same thing, without the unnecessary

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-01 Thread micah
Github user micah commented on the pull request: https://github.com/apache/couchdb-documentation/pull/29#issuecomment-136863497 See new pull request which suppresses additional stdout/stderr output caused by which call --- If your project is set up for it, you can reply to this

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-01 Thread micah
Github user micah closed the pull request at: https://github.com/apache/couchdb-documentation/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-01 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-136875583 not sure why you didn't edit the original PR but note for future that we prefer it if comments are addressed in the same place. --- If your project is

[GitHub] couchdb-documentation pull request: Fix bashism in Makefile

2015-09-01 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-documentation/pull/30#issuecomment-136875643 +1 from me (@kxepal, thoughts?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your