[GitHub] couchdb-fauxton pull request: Notifications update

2016-05-18 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-220005442 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-31 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203980010 I'm on chrome. It always looked jagged. On Thu, Mar 31, 2016 at 4:33 PM, Benjamin Keen wrote: > @garrensmith

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-31 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203966945 @garrensmith - worrying about the animation looking jagged. Did it always look jagged for you, or just now and then? You're on Chrome/FF, I guess. --- If

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-31 Thread benkeen
Github user benkeen commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58063745 --- Diff: app/templates.js --- @@ -0,0 +1,623 @@ +this["JST"] = this["JST"] || {}; --- End diff -- Ah ok, thanks. --- If your

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-31 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203903107 This looks really cool, so awesome to see another piece of backbone disappear. Two things * The animation looks a little jagged when a notification

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-31 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58041150 --- Diff: app/templates.js --- @@ -0,0 +1,623 @@ +this["JST"] = this["JST"] || {}; --- End diff -- This file shouldn't be here.

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-30 Thread benkeen
GitHub user benkeen reopened a pull request: https://github.com/apache/couchdb-fauxton/pull/668 Notifications update This updates the global notifications to use the same store as the notification panel, drop Backbone. I chose to build it on Garren's Webpack branch:

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-30 Thread benkeen
Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request: Notifications update

2016-03-15 Thread benkeen
GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/668 Notifications update This updates the global notifications to use the same store as the notification panel, drop Backbone. I chose to build it on Garren's Webpack branch: