[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-04-04 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-205344422 Thanks @garrensmith. Merged as f6a1f82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-04-04 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-205184081 +1 working for me now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-03-31 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-204107230 Curious. Couldn't reproduce, but I made the code a bit more defensive. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-03-31 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-203904853 I'm getting this error `bundle.js:135902 Uncaught TypeError: Cannot read property 'toLocaleString' of undefined` --- If your project is set up

[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-03-09 Thread justin-mcdavid-ibm
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194410189 I feel strongly about consistent alignment (and wish it was used throughout our application, too). :) I'd like to see spacing used to

[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-03-09 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194401530 Cool! - I don't mind dropping the headings at all. Not sure they added much. But the gaps between the sections seem odd now - could we remove them? It's all

[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-03-08 Thread justin-mcdavid-ibm
Github user justin-mcdavid-ibm commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-194095712 How about something like this (and hear me out)? - Detailed field labels will help in understanding the metadata. - The sub-headings

[GitHub] couchdb-fauxton pull request: Style update for metadata page

2016-03-08 Thread benkeen
GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/663 Style update for metadata page The metadata page was kinda ugly, and Tim White recently made a few aesthetic changes to the page. This implements them and generally smartens up the