[GitHub] davisp commented on issue #1376: Add fields to sort based on selector

2018-06-19 Thread GitBox
davisp commented on issue #1376: Add fields to sort based on selector URL: https://github.com/apache/couchdb/pull/1376#issuecomment-398463058 Don't forget to squerge before merging! This is an automated message from the

[GitHub] davisp commented on issue #1376: Add fields to sort based on selector

2018-06-07 Thread GitBox
davisp commented on issue #1376: Add fields to sort based on selector URL: https://github.com/apache/couchdb/pull/1376#issuecomment-395485774 @garrensmith I see the PR updated but nothing else. Did you forget to push your local changes?

[GitHub] davisp commented on issue #1376: Add fields to sort based on selector

2018-06-06 Thread GitBox
davisp commented on issue #1376: Add fields to sort based on selector URL: https://github.com/apache/couchdb/pull/1376#issuecomment-395196897 Also, it seems like normalize_sort_fields and all of the mayb_filter_sort_fields logic should actually be inside each index's implementation