[GitHub] davisp commented on issue #674: Flaky compaction daemon test

2017-07-14 Thread git
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315401626 I'm gonna add a log message when the assertion fails to try and figure out what it is exactly that's causing this to fail. Hopefully that'll shed some

[GitHub] davisp commented on issue #674: Flaky compaction daemon test

2017-07-13 Thread git
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315198304 Oops, I think we both read that wrong with GitHub chopping off and forcing the horizontal scroll. The second database compaction is the view compaction.

[GitHub] davisp commented on issue #674: Flaky compaction daemon test

2017-07-13 Thread git
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315186525 Looks like the right diagnosis to me. My read on the is_idle test is that we're trying to assert that the compaction daemon doesn't hold a monitor on the

[GitHub] davisp commented on issue #674: Flaky compaction daemon test

2017-07-13 Thread git
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315147326 This is probably related to #638 This is an automated message from the Apache Git Service.