glynnbird opened a new pull request #53: bring follow library under Nano's wing URL: https://github.com/apache/couchdb-nano/pull/53 ## Overview Currently Nano uses a the [follow](https://www.npmjs.com/package/follow) library as a dependency to handle changes feed subscription. Unfortunately, `follow` is not maintained. The nice people at Cloudant have taken the code and fixed it up and published it [here](https://github.com/cloudant-labs/cloudant-follow). This [PR](https://github.com/apache/couchdb-nano/pull/51) proposes to depend on the cloudant-follow fork, but I am proposing something different: 1) Bring the follow codebase into the Nano project (it is published under an Apache-2.0 license) 2) Remove follow as a dependency 3) In the future refactor the follow code to be more in keeping with the ## Testing recommendations This should be a drop-in replacement of the previous version. The only difference is that the `follow` code lives in this repo and not as a dependency. I've brought in the `follow` tests too. Unfortunately they rely on CouchDB1.6 so I've altered the testing sequence to run our core tests with CouchDB2 then switch over to CouchDB1.6 for the follow tests. See `npm run coretests` & `npm run followtests` in package.json. ## GitHub issue number <!-- If this is a significant change, please file a separate issue at: https://github.com/apache/couchdb-nano/issues and include the number here and in commit message(s) using syntax like "Fixes #472" or "Fixes apache/couchdb#472". --> ## Related Pull Requests See issue #28 & pull #51 ## Checklist - [x ] Code is written and works correctly; - [x] Changes are covered by tests; - [x ] Documentation reflects the changes; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
