pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1381524075
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
willholley merged PR #4828:
URL: https://github.com/apache/couchdb/pull/4828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380811414
##
src/mango/src/mango_selector.erl:
##
@@ -1070,12 +1073,18 @@ check_beginswith(Field, Prefix) ->
match_beginswith_test() ->
% matching
?assertEqual(true,
nickva commented on PR #4830:
URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791584258
the build passed! closing the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nickva closed pull request #4830: mango: fix $beginsWith range
URL: https://github.com/apache/couchdb/pull/4830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
nickva commented on PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1791577531
Full CI tests passed
https://ci-couchdb.apache.org/blue/organizations/jenkins/jenkins-cm1%2FFullPlatformMatrix/detail/jenkins-mango-begingswith-fixes-2/1/pipeline
but see the minor test
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380811414
##
src/mango/src/mango_selector.erl:
##
@@ -1070,12 +1073,18 @@ check_beginswith(Field, Prefix) ->
match_beginswith_test() ->
% matching
?assertEqual(true,
pgj commented on PR #4830:
URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791569055
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
nickva commented on PR #4830:
URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791537538
> Why is not #4829 enough?
noticed some failures there and was wondering if it just need to be rebased
--
This is an automated message from the Apache Git Service.
To respond
pgj commented on PR #4830:
URL: https://github.com/apache/couchdb/pull/4830#issuecomment-1791536007
Why is not #4829 enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380717931
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380652572
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
big-r81 commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380700798
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380688095
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380675948
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
big-r81 commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380667886
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380662149
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380599542
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380652572
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
willholley commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380629457
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380608148
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380608148
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380600671
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380599542
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380599046
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
willholley commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380597426
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
willholley commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380595300
##
src/mango/src/mango_selector.erl:
##
@@ -1070,12 +1073,17 @@ check_beginswith(Field, Prefix) ->
match_beginswith_test() ->
% matching
willholley commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380595004
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
nickva commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380586593
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1380459255
##
src/mango/src/mango_selector.erl:
##
@@ -1070,12 +1073,17 @@ check_beginswith(Field, Prefix) ->
match_beginswith_test() ->
% matching
?assertEqual(true,
willholley commented on PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1790827914
@pgj updated as per #4829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
willholley commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1379933225
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1790482735
If you implement the pre-check that I suggested then it can be established
for `mango_idx_view:range/5` that the input will always be a valid UTF-8 input
hence no tests are needed. The
willholley commented on PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#issuecomment-1790448696
@pgj I'm trying to think where it would make sense to add unit tests for
non-UTF8 data. There are no existing eunit tests for `field_ranges` or `range`
(perhaps we add some?) and I
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1379843635
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
pgj commented on code in PR #4828:
URL: https://github.com/apache/couchdb/pull/4828#discussion_r1379838747
##
src/mango/src/mango_idx_view.erl:
##
@@ -417,7 +417,7 @@ range(_, _, LCmp, Low, HCmp, High) ->
% beginsWith requires both a high and low bound
36 matches
Mail list logo
