[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77600024 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDecoded =

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77600225 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDecoded =

[GitHub] couchdb-couch-index issue #19: Do not use config subscription in couch_index

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch-index/pull/19 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb-couch-index issue #19: Do not use config subscription in couch_index

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch-index/pull/19 (can be merged for 2.0) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (COUCHDB-3135) Do not use config subscription in couch_index

2016-09-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468457#comment-15468457 ] ASF subversion and git services commented on COUCHDB-3135: -- Commit

[jira] [Commented] (COUCHDB-3135) Do not use config subscription in couch_index

2016-09-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468459#comment-15468459 ] ASF GitHub Bot commented on COUCHDB-3135: - Github user asfgit closed the pull request at:

[GitHub] couchdb-couch-index pull request #19: Do not use config subscription in couc...

2016-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-index/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77589926 --- Diff: test/couch_mrview_all_docs_tests.erl --- @@ -107,6 +107,21 @@ should_query_with_limit_and_skip(Db) -> ]},

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77589892 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDecoded =

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77590126 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDecoded =

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77590186 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDecoded =

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77590404 --- Diff: test/couch_mrview_all_docs_tests.erl --- @@ -107,6 +107,21 @@ should_query_with_limit_and_skip(Db) -> ]},

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77590448 --- Diff: test/couch_mrview_all_docs_tests.erl --- @@ -107,6 +107,21 @@ should_query_with_limit_and_skip(Db) -> ]},

[jira] [Commented] (COUCHDB-2980) Replicator DB on 15984 replicates to backdoor ports

2016-09-06 Thread Robert Newson (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466795#comment-15466795 ] Robert Newson commented on COUCHDB-2980: I had a good stab at implementing what was needed;

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77595154 --- Diff: src/couch_mrview_http.erl --- @@ -469,10 +469,16 @@ parse_params(Props, Keys, #mrargs{}=Args0, Options) -> IsDecoded =

[GitHub] couchdb-couch-mrview issue #56: Make Query Limit Results Configurable

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch-mrview/pull/56 still some more issues but we're getting closer. Note that this cannot merge until 2.0 is cut, we're in feature freeze. --- If your project is set up for it, you can reply to this

[jira] [Created] (COUCHDB-3133) Continuous change response header is sent late

2016-09-06 Thread Samuel Tardieu (JIRA)
Samuel Tardieu created COUCHDB-3133: --- Summary: Continuous change response header is sent late Key: COUCHDB-3133 URL: https://issues.apache.org/jira/browse/COUCHDB-3133 Project: CouchDB

[jira] [Commented] (COUCHDB-2980) Replicator DB on 15984 replicates to backdoor ports

2016-09-06 Thread Robert Newson (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467133#comment-15467133 ] Robert Newson commented on COUCHDB-2980: this needs to be added to the release notes. >

[jira] [Created] (COUCHDB-3131) Valid JSON rejected in _changed query with filter

2016-09-06 Thread Samuel Tardieu (JIRA)
Samuel Tardieu created COUCHDB-3131: --- Summary: Valid JSON rejected in _changed query with filter Key: COUCHDB-3131 URL: https://issues.apache.org/jira/browse/COUCHDB-3131 Project: CouchDB

[jira] [Created] (COUCHDB-3132) Invalid chunk when database is deleted while a continuous change request is running

2016-09-06 Thread Samuel Tardieu (JIRA)
Samuel Tardieu created COUCHDB-3132: --- Summary: Invalid chunk when database is deleted while a continuous change request is running Key: COUCHDB-3132 URL: https://issues.apache.org/jira/browse/COUCHDB-3132

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread tonysun83
Github user tonysun83 commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77654169 --- Diff: test/couch_mrview_all_docs_tests.erl --- @@ -107,6 +107,21 @@ should_query_with_limit_and_skip(Db) -> ]},

[GitHub] couchdb-fauxton pull request #767: Check dependencies added to Fauxton build

2016-09-06 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/767#discussion_r77660861 --- Diff: bin/depCheck.js --- @@ -0,0 +1,8 @@ +var webpack = require("webpack"); +const config = require('../webpack.config.release');

[GitHub] couchdb pull request #440: update fauxton licenses

2016-09-06 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb/pull/440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (COUCHDB-2980) Replicator DB on 15984 replicates to backdoor ports

2016-09-06 Thread Nick Vatamaniuc (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467500#comment-15467500 ] Nick Vatamaniuc commented on COUCHDB-2980: -- Wonder if it is worth at least preventing creating

[jira] [Created] (COUCHDB-3134) Incorrect format for list ETag

2016-09-06 Thread Samuel Tardieu (JIRA)
Samuel Tardieu created COUCHDB-3134: --- Summary: Incorrect format for list ETag Key: COUCHDB-3134 URL: https://issues.apache.org/jira/browse/COUCHDB-3134 Project: CouchDB Issue Type: Bug

[GitHub] couchdb-fauxton pull request #767: Check dependencies added to Fauxton build

2016-09-06 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/767#discussion_r77660802 --- Diff: bin/depCheck.js --- @@ -0,0 +1,8 @@ +var webpack = require("webpack"); --- End diff -- const and singel quotes

[jira] [Commented] (COUCHDB-3121) Updates _changes examples to use the new sequence values

2016-09-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467683#comment-15467683 ] ASF GitHub Bot commented on COUCHDB-3121: - GitHub user willholley opened a pull request:

[GitHub] couchdb-couch-replicator issue #47: Validate boolean parameters in /_replica...

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/47 Committers to couchdb should be focused on making 2.0 happen. If they want to do other, unrelated work, they can keep it elsewhere for now. --- If your project is set up for it,

[GitHub] couchdb issue #440: update fauxton licenses

2016-09-06 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb/pull/440 merged as 18534cb5aea93ba10c6598a7ea26f23a172ecd67 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (COUCHDB-3133) Continuous change response header is sent late

2016-09-06 Thread Samuel Tardieu (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467558#comment-15467558 ] Samuel Tardieu commented on COUCHDB-3133: - Also, note that the response will also be sent when

[GitHub] couchdb-fauxton pull request #768: License headers & remove of unused dep

2016-09-06 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb-documentation pull request #56: update _changes API documentation fo...

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-documentation/pull/56#discussion_r77664900 --- Diff: src/json-structure.rst --- @@ -72,11 +72,13 @@ Changes information for a database

[GitHub] couchdb-documentation pull request #56: update _changes API documentation fo...

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-documentation/pull/56#discussion_r77664919 --- Diff: src/json-structure.rst --- @@ -72,11 +72,13 @@ Changes information for a database

[GitHub] couchdb-documentation pull request #56: update _changes API documentation fo...

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-documentation/pull/56#discussion_r77664547 --- Diff: src/api/database/changes.rst --- @@ -95,7 +95,8 @@ - :mimetype:`text/plain; charset=utf-8`

[GitHub] couchdb-fauxton issue #768: License headers & remove of unused dep

2016-09-06 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/768 merged! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] couchdb-couch-mrview pull request #56: Make Query Limit Results Configurable

2016-09-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/56#discussion_r77662244 --- Diff: test/couch_mrview_all_docs_tests.erl --- @@ -107,6 +107,21 @@ should_query_with_limit_and_skip(Db) -> ]},

[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 `sequence identifiers` is a very late-minute terminology invention. We usually call these `update sequences` or `update sequence values`. --- If your project is set up for it, you can

[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0

2016-09-06 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 @rnewson sure - I couldn't see an example other than `sequence number` in the CouchDB docs. Cloudant uses `sequence identifiers` in the documentation so I went with that as a first

[GitHub] couchdb-couch-index pull request #19: Do not use config subscription in couc...

2016-09-06 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-index/pull/19 Do not use config subscription in couch_index The simple fact that we call config:subscribe_for_changes causes the hike in memory consumed by couch_index process. Monitoring the changes

[jira] [Commented] (COUCHDB-3135) Do not use config subscription in couch_index

2016-09-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468424#comment-15468424 ] ASF GitHub Bot commented on COUCHDB-3135: - GitHub user iilyak opened a pull request:

[GitHub] couchdb-couch-index pull request #19: Do not use config subscription in couc...

2016-09-06 Thread davisp
Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb-couch-index/pull/19#discussion_r77710187 --- Diff: src/couch_index.erl --- @@ -30,16 +29,14 @@ -define(CHECK_INTERVAL, 60). % 10 minutes --define(RELISTEN_DELAY,

[GitHub] couchdb-documentation pull request #56: update _changes API documentation fo...

2016-09-06 Thread rnewson
Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-documentation/pull/56#discussion_r77711316 --- Diff: src/api/database/changes.rst --- @@ -104,7 +105,7 @@ :json array changes: List of document`s leafs with single field

[GitHub] couchdb-couch-index issue #19: Do not use config subscription in couch_index

2016-09-06 Thread davisp
Github user davisp commented on the issue: https://github.com/apache/couchdb-couch-index/pull/19 +1 after removing the unused record field. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 +1 after that last comment is addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0

2016-09-06 Thread willholley
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 thanks all for the feedback. I've pushed a new update which addresses the comments and adds a new section on the `_selector` filter. --- If your project is set up for it, you can

[jira] [Created] (COUCHDB-3135) Do not use config subscription in couch_index

2016-09-06 Thread ILYA (JIRA)
ILYA created COUCHDB-3135: - Summary: Do not use config subscription in couch_index Key: COUCHDB-3135 URL: https://issues.apache.org/jira/browse/COUCHDB-3135 Project: CouchDB Issue Type: Bug

[jira] [Commented] (COUCHDB-3135) Do not use config subscription in couch_index

2016-09-06 Thread ILYA (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468744#comment-15468744 ] ILYA commented on COUCHDB-3135: --- The result of investigation. De-duplication of event handlers is

[GitHub] couchdb pull request #440: update fauxton licenses

2016-09-06 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb/pull/440 update fauxton licenses You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb release2-prep Alternatively you can

[GitHub] couchdb-couch-replicator issue #47: Validate boolean parameters in /_replica...

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/47 please remember that couchdb is frozen for the 2.0 release, please stop merging new features or fixing that aren't 2.0 blockers. @nickva @eiri @iilyak --- If your project

[GitHub] couchdb-couch-replicator issue #47: Validate boolean parameters in /_replica...

2016-09-06 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb-couch-replicator/pull/47 @rnewson Why not to create a branch for 2.0 and prepare release from there while people still can work on new features and master? Sounds like gitflow-ish. --- If your project is

[jira] [Commented] (COUCHDB-3118) Replicator's validation ignored

2016-09-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467007#comment-15467007 ] ASF subversion and git services commented on COUCHDB-3118: -- Commit

[jira] [Commented] (COUCHDB-3114) Couch allows to create doc with id "_design/"

2016-09-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467006#comment-15467006 ] ASF subversion and git services commented on COUCHDB-3114: -- Commit

[GitHub] couchdb-fauxton issue #768: License headers & remove of unused dep

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb-fauxton/pull/768 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb issue #440: update fauxton licenses

2016-09-06 Thread rnewson
Github user rnewson commented on the issue: https://github.com/apache/couchdb/pull/440 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (COUCHDB-2980) Replicator DB on 15984 replicates to backdoor ports

2016-09-06 Thread Chris Foster (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468251#comment-15468251 ] Chris Foster commented on COUCHDB-2980: --- Hi everyone, Just chiming in on this again. Sorry for