[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653925 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import FauxtonAPI from

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653979 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import FauxtonAPI from

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93654957 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import FauxtonAPI from

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653242 --- Diff: app/addons/fauxton/assets/less/components.less --- @@ -44,6 +40,7 @@ } -a.clipboard-copy-element:hover { -

[GitHub] couchdb-fauxton issue #825: 3192 - Rip and replace zeroclipboard with clipbo...

2016-12-22 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/825 Heh, yeah a bit of a git issue for app/addons/fauxton/components.react.jsx. The only change I made was mass deletion of ZeroClipboard components but git is picking up old code as new

[GitHub] couchdb-fauxton pull request #826: NavBar: Rework NavBar

2016-12-22 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/826#discussion_r93670918 --- Diff: app/addons/fauxton/navigation/__tests__/login-logout-test.js --- @@ -0,0 +1,80 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request #826: NavBar: Rework NavBar

2016-12-22 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/826#discussion_r93672506 --- Diff: app/addons/fauxton/navigation/components/Brand.js --- @@ -0,0 +1,36 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread millayr
GitHub user millayr reopened a pull request: https://github.com/apache/couchdb-fauxton/pull/825 3192 - Rip and replace zeroclipboard with clipboardjs Removing flash-based zeroclipboard. Created generic React Copy component using clipboard.js. Relevant JIRA ticket:

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread millayr
Github user millayr closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/825 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (COUCHDB-3192) Remove ZeroClipboard and replace it with pure JS

2016-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770950#comment-15770950 ] ASF GitHub Bot commented on COUCHDB-3192: - GitHub user millayr reopened a pull request:

[jira] [Commented] (COUCHDB-3192) Remove ZeroClipboard and replace it with pure JS

2016-12-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770949#comment-15770949 ] ASF GitHub Bot commented on COUCHDB-3192: - Github user millayr closed the pull request at:

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653495 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import FauxtonAPI from

[jira] [Created] (COUCHDB-3260) For POST to _changes accept all parameters in the request body

2016-12-22 Thread Brian Wilkins (JIRA)
Brian Wilkins created COUCHDB-3260: -- Summary: For POST to _changes accept all parameters in the request body Key: COUCHDB-3260 URL: https://issues.apache.org/jira/browse/COUCHDB-3260 Project: