[GitHub] garrensmith commented on issue #1020: Support for closing couchdb server
garrensmith commented on issue #1020: Support for closing couchdb server URL: https://github.com/apache/couchdb-fauxton/pull/1020#issuecomment-343132017 Awesome thanks @sanketbajoria This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith closed pull request #1020: Support for closing couchdb server
garrensmith closed pull request #1020: Support for closing couchdb server URL: https://github.com/apache/couchdb-fauxton/pull/1020 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/index.js b/index.js index 98961004c..a17d629f6 100644 --- a/index.js +++ b/index.js @@ -35,13 +35,13 @@ module.exports = function (options) { } // create proxy to couch for all couch requests - var proxy = httpProxy.createServer({ + this.proxy = httpProxy.createServer({ secure: false, changeOrigin: true, target: proxyUrl }); - http.createServer(function (req, res) { + this.server = http.createServer((req, res) => { var isDocLink = /_utils\/docs/.test(req.url); var url = req.url.split(/\?v=|\?noCache/)[0].replace('_utils', ''); var accept = []; @@ -66,16 +66,16 @@ module.exports = function (options) { var urlObj = urlLib.parse(req.url); req.headers.host = urlObj.host; -proxy.web(req, res); +this.proxy.web(req, res); }).listen(port, '0.0.0.0'); - proxy.on('error', () => { + this.proxy.on('error', () => { // don't explode on cancelled requests }); //Remove Secure on the cookie if the proxy is communicating to a CouchDB instance // via https. - proxy.on('proxyRes', function (proxyRes) { + this.proxy.on('proxyRes', (proxyRes) => { if (proxyRes.headers['set-cookie']) { proxyRes.headers['set-cookie'][0] = proxyRes.headers["set-cookie"][0].replace('Secure', ''); } @@ -97,4 +97,11 @@ module.exports = function (options) { }); console.log('Listening on ' + port); + + this.close = () => { +this.server.close(); +this.proxy.close(); + }; + + return this; }; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith closed pull request #1021: Add missing title to Replication page
garrensmith closed pull request #1021: Add missing title to Replication page URL: https://github.com/apache/couchdb-fauxton/pull/1021 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/app/addons/replication/controller.js b/app/addons/replication/controller.js index 819b17a44..40e98131e 100644 --- a/app/addons/replication/controller.js +++ b/app/addons/replication/controller.js @@ -249,6 +249,8 @@ export default class ReplicationController extends React.Component { getCrumbs () { if (this.state.tabSection === 'new replication') { return [{'name': 'Job Configuration'}]; +} else { + return [{'name': 'Replication'}]; } return []; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace
drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace URL: https://github.com/apache/couchdb/issues/732#issuecomment-343177069 I don't believe this problem is related to spaces with paths -- I don't see any spaces. Unfortunately I don't see anything that stands out as an error in Process Monitor when the error occurs. This is typical output: 9:23:12.0321134 AM erl.exe 29256 CreateFile \Device\HarddiskVolume38\CouchDB\data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view REPARSE Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: `9:23:12.0321134 AM erl.exe 29256 CreateFile \Device\HarddiskVolume38\CouchDB\data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view REPARSE Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: 9:23:12.0322531 AM erl.exe 29256 CreateFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: Opened 9:23:12.0323475 AM erl.exe 29256 QueryInformationVolume C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS VolumeCreationTime: 4/10/2017 2:13:07 PM, VolumeSerialNumber: E27C-C00D, SupportsObjects: True, VolumeLabel: 9:23:12.0323577 AM erl.exe 29256 QueryAllInformationFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view BUFFER OVERFLOW CreationTime: 11/9/2017 9:20:40 AM, LastAccessTime: 11/9/2017 9:20:40 AM, LastWriteTime: 11/9/2017 9:20:46 AM, ChangeTime: 11/9/2017 9:20:46 AM, FileAttributes: A, AllocationSize: 8,192, EndOfFile: 4,272, NumberOfLinks: 1, DeletePending: False, Directory: False, IndexNumber: 0x130006ad68, EaSize: 0, Access: Generic Read, Position: 0, Mode: Synchronous IO Non-Alert, AlignmentRequirement: Word 9:23:12.0324106 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS 9:23:12.0324381 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview SUCCESS ` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace
drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace URL: https://github.com/apache/couchdb/issues/732#issuecomment-343177069 I don't believe this problem is related to spaces with paths -- I don't see any spaces. Unfortunately I don't see anything that stands out as an error in Process Monitor when the error occurs. This is typical output: 9:23:12.0321134 AM erl.exe 29256 CreateFile \Device\HarddiskVolume38\CouchDB\data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view REPARSE Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: 9:23:12.0322531 AM erl.exe 29256 CreateFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: Opened 9:23:12.0323475 AM erl.exe 29256 QueryInformationVolume C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS VolumeCreationTime: 4/10/2017 2:13:07 PM, VolumeSerialNumber: E27C-C00D, SupportsObjects: True, VolumeLabel: 9:23:12.0323577 AM erl.exe 29256 QueryAllInformationFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view BUFFER OVERFLOW CreationTime: 11/9/2017 9:20:40 AM, LastAccessTime: 11/9/2017 9:20:40 AM, LastWriteTime: 11/9/2017 9:20:46 AM, ChangeTime: 11/9/2017 9:20:46 AM, FileAttributes: A, AllocationSize: 8,192, EndOfFile: 4,272, NumberOfLinks: 1, DeletePending: False, Directory: False, IndexNumber: 0x130006ad68, EaSize: 0, Access: Generic Read, Position: 0, Mode: Synchronous IO Non-Alert, AlignmentRequirement: Word 9:23:12.0324106 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS 9:23:12.0324381 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview SUCCESS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace
drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace URL: https://github.com/apache/couchdb/issues/732#issuecomment-343177069 I don't believe this problem is related to spaces with paths -- I don't see any spaces. Unfortunately I don't see anything that stands out as an error in Process Monitor when the error occurs. This is typical output: 9:23:12.0321134 AM erl.exe 29256 CreateFile \Device\HarddiskVolume38\CouchDB\data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view REPARSE Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: 9:23:12.0322531 AM erl.exe 29256 CreateFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: Opened 9:23:12.0323475 AM erl.exe 29256 QueryInformationVolume C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS VolumeCreationTime: 4/10/2017 2:13:07 PM, VolumeSerialNumber: E27C-C00D, SupportsObjects: True, VolumeLabel: 9:23:12.0323577 AM erl.exe 29256 QueryAllInformationFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view BUFFER OVERFLOW CreationTime: 11/9/2017 9:20:40 AM, LastAccessTime: 11/9/2017 9:20:40 AM, LastWriteTime: 11/9/2017 9:20:46 AM, ChangeTime: 11/9/2017 9:20:46 AM, FileAttributes: A, AllocationSize: 8,192, EndOfFile: 4,272, NumberOfLinks: 1, DeletePending: False, Directory: False, IndexNumber: 0x130006ad68, EaSize: 0, Access: Generic Read, Position: 0, Mode: Synchronous IO Non-Alert, AlignmentRequirement: Word 9:23:12.0324106 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS 9:23:12.0324381 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview SUCCESS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace
drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace URL: https://github.com/apache/couchdb/issues/732#issuecomment-343177069 I don't believe this problem is related to spaces with paths -- I don't see any spaces. Unfortunately I don't see anything that stands out as an error in Process Monitor when the error occurs. I attached a sample of typical output captured by Process Monitor. [erl.txt](https://github.com/apache/couchdb/files/1457977/erl.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith closed pull request #1013: Support fauxton on IE10,IE11 and Edge
garrensmith closed pull request #1013: Support fauxton on IE10,IE11 and Edge URL: https://github.com/apache/couchdb-fauxton/pull/1013 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/app/addons/activetasks/assets/less/activetasks.less b/app/addons/activetasks/assets/less/activetasks.less index 1041fe6c5..5b4cb7a90 100644 --- a/app/addons/activetasks/assets/less/activetasks.less +++ b/app/addons/activetasks/assets/less/activetasks.less @@ -148,4 +148,8 @@ align-items: center; flex-direction: row; height: 100%; + + &--ie1X { + align-items: stretch; + } } diff --git a/app/addons/activetasks/components.js b/app/addons/activetasks/components.js index 91b477e69..c63927a05 100644 --- a/app/addons/activetasks/components.js +++ b/app/addons/activetasks/components.js @@ -17,6 +17,7 @@ import Stores from "./stores"; import Resources from "./resources"; import Actions from "./actions"; import Components from "../components/react-components"; +import Helpers from '../../helpers'; const {TabElement, TabElementWrapper, Polling} = Components; @@ -388,8 +389,12 @@ export class ActiveTasksPollingWidgetController extends React.Component { state = this.getStoreState(); render() { +let activePollingClass = "active-tasks__polling-wrapper"; +if (Helpers.isIE1X()) { + activePollingClass += " " + activePollingClass + "--ie1X"; +} return ( - + { onPoll={() => {}} />); - const props = wrapper.find('input').props(); + const props = wrapper.find('Range').props(); assert.deepEqual(props.value, 10); assert.deepEqual(props.step, 1); @@ -80,7 +80,7 @@ describe("Polling", () => { onPoll={() => {}} />); - wrapper.find('input').simulate('change', {target: {value: 21}}); + wrapper.find('input').simulate('mouseMove', {buttons:1, which:1, target: {value: 21}}); const isOff = wrapper.find('.faux__polling-info-value--off').text(); assert.deepEqual(isOff.toLowerCase(), "off"); }); diff --git a/app/addons/components/assets/less/jsonlink.less b/app/addons/components/assets/less/jsonlink.less index 071b53826..a93f19e63 100644 --- a/app/addons/components/assets/less/jsonlink.less +++ b/app/addons/components/assets/less/jsonlink.less @@ -11,7 +11,7 @@ // the License. .faux__jsonlink { - width: 76px; + /*width: 76px; Static width cause rendering problems on Edge */ border-left: 1px solid #ccc; padding: 16px 12px 12px 12px !important; height: 64px; diff --git a/app/addons/components/assets/less/layouts.less b/app/addons/components/assets/less/layouts.less index 4f020cf17..8d72807b0 100644 --- a/app/addons/components/assets/less/layouts.less +++ b/app/addons/components/assets/less/layouts.less @@ -18,6 +18,10 @@ align-items: center; flex-direction: row; height: 100%; + + &--ie1X{ + align-items:stretch; + } } //yes !important!!! We have to overridde some styles I can't override any other way for now diff --git a/app/addons/components/components/polling.js b/app/addons/components/components/polling.js index 245806ed7..513ebf575 100644 --- a/app/addons/components/components/polling.js +++ b/app/addons/components/components/polling.js @@ -14,6 +14,7 @@ import PropTypes from 'prop-types'; import React from 'react'; import ReactDOM from 'react-dom'; +import Range from 'react-range'; let pollIntervalId; @@ -51,6 +52,7 @@ export class Polling extends React.Component { this.state = { value: this.props.startValue }; +this.updatePollingFreq = this.updatePollingFreq.bind(this); } componentDidMount () { @@ -101,8 +103,8 @@ export class Polling extends React.Component { Polling Interval {pollValue} - { return ( @@ -40,6 +41,10 @@ export const OnePane = ({children}) => { }; export const OnePaneHeader = ({showApiUrl, docURL, endpoint, crumbs, children}) => { + let rightHeaderClass = "right-header-flex"; + if (Helpers.isIE1X()) { + rightHeaderClass += " " + rightHeaderClass + "--ie1X"; + } return ( @@ -47,7 +52,7 @@ export const OnePaneHeader = ({showApiUrl, docURL, endpoint, crumbs, children}) - + {children} diff --git a/app/addons/replication/assets/less/replication.less b/app/addons/replication/assets/less/replication.less index 87ba4ef80..c1a56de04 100644 --- a/app/addons/replication/assets/less/replication.less +++ b/app/addons/replication/assets/less/replication.less @@ -149,6 +149,7 @@ div.replication__page { .replication__activity { padding: 0 10px 0 10px !important; +
[GitHub] popojargo commented on issue #949: No list of databases shown in IE 11
popojargo commented on issue #949: No list of databases shown in IE 11 URL: https://github.com/apache/couchdb-fauxton/issues/949#issuecomment-343175920 @garrensmith You can close this one This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith closed issue #949: No list of databases shown in IE 11
garrensmith closed issue #949: No list of databases shown in IE 11 URL: https://github.com/apache/couchdb-fauxton/issues/949 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith commented on issue #949: No list of databases shown in IE 11
garrensmith commented on issue #949: No list of databases shown in IE 11 URL: https://github.com/apache/couchdb-fauxton/issues/949#issuecomment-343179081 Closed thanks to @popojargo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #10: Fix the config file
wohali commented on issue #10: Fix the config file URL: https://github.com/apache/couchdb-pkg/issues/10#issuecomment-343214754 Thanks for the report! This has been in the config file since day 1 - and didn't get caught in testing. We'll get new packages posted in a few hours This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flimzy opened a new pull request #204: Document the 'info' field of the scheduler doc
flimzy opened a new pull request #204: Document the 'info' field of the scheduler doc URL: https://github.com/apache/couchdb-documentation/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flimzy commented on issue #204: Document the 'info' field of the scheduler doc
flimzy commented on issue #204: Document the 'info' field of the scheduler doc URL: https://github.com/apache/couchdb-documentation/pull/204#issuecomment-343205055 I'm also wondering if there's a better way to handle this, than triplicating these fields (and the other documentation about scheduler docs). Would it be reasonable to include this info only once, and have the two other instances link to it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flimzy commented on a change in pull request #204: Document the 'info' field of the scheduler doc
flimzy commented on a change in pull request #204: Document the 'info' field of the scheduler doc URL: https://github.com/apache/couchdb-documentation/pull/204#discussion_r150008396 ## File path: src/api/server/common.rst ## @@ -938,6 +939,22 @@ error. :code 200: Request completed successfully :code 401: CouchDB Server Administrator privileges required +The ``info`` field of a scheduler doc: Review comment: Is there any way to define an anchor here that can be linked from above (i.e. line 931)? My RST mojo is weak. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace
wohali commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace URL: https://github.com/apache/couchdb/issues/732#issuecomment-343213741 @drnybble Please open a new issue instead of hijacking this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali closed issue #10: Fix the config file
wohali closed issue #10: Fix the config file URL: https://github.com/apache/couchdb-pkg/issues/10 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #10: Fix the config file
wohali commented on issue #10: Fix the config file URL: https://github.com/apache/couchdb-pkg/issues/10#issuecomment-343236345 New packages being built and should be visible on bintray within 1 hour. Sorry for the inconvenience. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali opened a new pull request #11: debian: fix typo
wohali opened a new pull request #11: debian: fix typo URL: https://github.com/apache/couchdb-pkg/pull/11 Fixes #10 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali closed pull request #11: debian: fix typo
wohali closed pull request #11: debian: fix typo URL: https://github.com/apache/couchdb-pkg/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hrishiballal commented on issue #10: Fix the config file
hrishiballal commented on issue #10: Fix the config file URL: https://github.com/apache/couchdb-pkg/issues/10#issuecomment-343218291 Thanks for this, strange that apt caught it just now. Basically I installed Couchdb 2.1 earlier and it worked fine when I used apt-get upgrade to upgrade to 2.1.1, apt bombed giving this error. I look forward to the fixes and testing it. . Thank you again for all the work with couch! Really appreciate it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #10: Fix the config file
wohali commented on issue #10: Fix the config file URL: https://github.com/apache/couchdb-pkg/issues/10#issuecomment-343245239 2.1.1-1 packages uploaded and published. Thank you again for bringing this to our attention! :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chewbranca commented on issue #974: Access to db/_all_docs results in 500 in 1.7.0 if user is only a DB member
chewbranca commented on issue #974: Access to db/_all_docs results in 500 in 1.7.0 if user is only a DB member URL: https://github.com/apache/couchdb/issues/974#issuecomment-343270162 @tmende thank you for the detailed bug report! It really does simplify things when we have detailed reproducer steps, so the extra effort is greatly appreciated! Good call @kocolosk, the underlying issue from that PR is the introduction of second auth failure type `forbidden`, in addition to just `unauthorized` [1], without the corresponding case clause to handle it [2]. There's a simple fix in PR#975. [1] https://github.com/apache/couchdb/blob/5f88da2a5ee8ba78917fafd572c7b9fa37e76460/src/couchdb/couch_db.erl#L388-L391 [2] https://github.com/apache/couchdb/blob/5f88da2a5ee8ba78917fafd572c7b9fa37e76460/src/couch_mrview/src/couch_mrview_http.erl#L158-L163 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chewbranca commented on issue #974: Access to db/_all_docs results in 500 in 1.7.0 if user is only a DB member
chewbranca commented on issue #974: Access to db/_all_docs results in 500 in 1.7.0 if user is only a DB member URL: https://github.com/apache/couchdb/issues/974#issuecomment-343270162 @tmende thank you for the detailed bug report! It really does simplify things when we have detailed reproducer steps, so the extra effort is greatly appreciated! Good call @kocolosk, the underlying issue from that PR is the introduction of second auth failure type `forbidden`, in addition to just `unauthorized` [1], without the corresponding case clause to handle it [2]. There's a simple fix in #975. [1] https://github.com/apache/couchdb/blob/5f88da2a5ee8ba78917fafd572c7b9fa37e76460/src/couchdb/couch_db.erl#L388-L391 [2] https://github.com/apache/couchdb/blob/5f88da2a5ee8ba78917fafd572c7b9fa37e76460/src/couch_mrview/src/couch_mrview_http.erl#L158-L163 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chewbranca opened a new pull request #975: Look for forbidden and unauthorized in is_admin
chewbranca opened a new pull request #975: Look for forbidden and unauthorized in is_admin URL: https://github.com/apache/couchdb/pull/975 ## Overview In https://github.com/apache/couchdb-couch/pull/29/files the possible security errors went from only "unauthorized" to "unauthorized" and "forbidden", but the corresponding check for both was not done in couch_mrview_http. This addresses that problem and fixes #974. ## Testing recommendations ## Related Issues or Pull Requests ## Checklist - [X] Code is written and works correctly; - [ ] Changes are covered by tests; - [ ] Documentation reflects the changes; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tejaycar opened a new issue #976: Replication never reaches 100%
tejaycar opened a new issue #976: Replication never reaches 100% URL: https://github.com/apache/couchdb/issues/976 ## Expected Behavior When I use cUrl to put a document into the _replicator database then all documents should be replicated from the source to the target and, when viewing status in futon I should see the database reach 100% replication ## Current Behavior In some cases, futon reports replication at either 0% or 99% (or sometimes other high %'s). However, all documents have been replicated correctly. Both source and target have the same number of documents, same database size, and save values. However, the UI still shows results like: ``` Checkpointed source sequence 13724, current source sequence 13726, progress 99% ``` OR ``` Checkpointed source sequence 0, current source sequence 1, progress 0% ``` Compaction of the source does not seem to change this result either. ## Steps to Reproduce (for bugs) I can't seem to re-produce this on demand ## Context The main problem we have is that we cannot trust the status to tell us if replication is complete. When doing cut-over from an old server to a new one, or even simple hot-standby, we can't be 100% sure we're fully replicated. ## Your Environment Couchdb 1.6 and 1.7 seem to be impacted Using chrome to view futon Ubuntu 12 and 14 both show the same This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rgaidjr commented on issue #737: CouchDB 2.0 version indexing getting timeout for records more than 100k records
rgaidjr commented on issue #737: CouchDB 2.0 version indexing getting timeout for records more than 100k records URL: https://github.com/apache/couchdb/issues/737#issuecomment-343329372 Hi guys, how was this issue resolved? I have similar experience with CouchDB 2.1.1, I freshly replicated about 18 million documents, and when I trigger the indexing, it seems to process only 1.5 million "changes" at a time, and I have to keep on retriggering. I thought it will complete in one trigger, although it takes time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kocolosk commented on issue #976: Replication never reaches 100%
kocolosk commented on issue #976: Replication never reaches 100% URL: https://github.com/apache/couchdb/issues/976#issuecomment-343341032 Hi @tejaycar thanks for the report. I've encountered a few situations like that myself in the past. We put a significant amount of work into the replicator internals in 2.x including the job reporting functionality; for some details see [this blog post](https://developer.ibm.com/dwblog/2017/replicator-apache-couchdb-cloudant/). It's highly likely that the cause of this misreported status was addressed in that work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith closed pull request #1019: Fix replication activity order reversing on action click
garrensmith closed pull request #1019: Fix replication activity order reversing on action click URL: https://github.com/apache/couchdb-fauxton/pull/1019 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/Gruntfile.js b/Gruntfile.js index bca5e268d..62cc59d51 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -159,7 +159,7 @@ module.exports = function (grunt) { exec: { start_nightWatch: { -command: __dirname + '/node_modules/nightwatch/bin/nightwatch' + +command: 'node ' + __dirname + '/node_modules/nightwatch/bin/nightwatch' + ' -c ' + __dirname + '/test/nightwatch_tests/nightwatch.json', options: { maxBuffer: 1000 * 1024 diff --git a/app/addons/replication/components/common-table.js b/app/addons/replication/components/common-table.js index 8e3fd0508..39122611a 100644 --- a/app/addons/replication/components/common-table.js +++ b/app/addons/replication/components/common-table.js @@ -280,12 +280,15 @@ export class ReplicationTable extends React.Component { } sort(column, descending, docs) { +let orderChanged = false; const sorted = docs.sort((a, b) => { if (a[column] < b[column]) { +orderChanged = true; return -1; } if (a[column] > b[column]) { +orderChanged = true; return 1; } @@ -293,7 +296,7 @@ export class ReplicationTable extends React.Component { }); -if (!descending) { +if (!descending && orderChanged) { sorted.reverse(); } diff --git a/app/addons/replication/tests/nightwatch/replicationactivity.js b/app/addons/replication/tests/nightwatch/replicationactivity.js index c3f2e07c1..3f1f49b59 100644 --- a/app/addons/replication/tests/nightwatch/replicationactivity.js +++ b/app/addons/replication/tests/nightwatch/replicationactivity.js @@ -94,5 +94,44 @@ module.exports = { .setValue('.replication__filter-input', 'filter') .waitForElementPresent('a[href="#/database/_replicator/existing-doc-filter2"]', waitTime, true) .end(); + }, + "Action click doesn't change doc's order": client =>{ + const waitTime = client.globals.maxWaitTime; + const baseUrl = client.globals.test_settings.launch_url; + const firstRowSelector = '.replication__table-row:nth-of-type(1)'; + let firstDoc; + + const replicatorDoc1 = { + _id: 'existing-doc-id-filter1', + source: "http://source-db.com;, + target: "http://target-db.com; + }; + + const replicatorDoc2 = { + _id: 'existing-doc-filter2', + source: "http://source-db2.com;, + target: "http://target-db.com; + }; + client + .deleteDatabase('_replicator') + .createDatabase('_replicator') + .createDocument(replicatorDoc1._id, '_replicator', replicatorDoc1) + .createDocument(replicatorDoc2._id, '_replicator', replicatorDoc2) + .loginToGUI() + .waitForElementNotPresent('.global-notification .fonticon-cancel', waitTime, false) + .url(baseUrl + '/#replication') + .waitForElementNotPresent('.load-lines', waitTime, true) + .waitForElementVisible(firstRowSelector, waitTime, true) + .getText(firstRowSelector + ' td:nth-of-type(2)', function(result) { +firstDoc = result.value; + }) + .clickWhenVisible(firstRowSelector + ' .replication__row-btn.icon-trash', waitTime, true) + .clickWhenVisible('.replication_delete-doc-modal.modal-dialog .modal-footer .cancel-link', waitTime, true) + .waitForElementVisible(firstRowSelector, waitTime, true) + .getText(firstRowSelector + ' td:nth-of-type(2)', function(result) { + this.verify.ok(result.value === firstDoc, + 'Checking if the order was reserved if no documents were sorted'); + }) + .end(); } }; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flimzy opened a new pull request #203: Update _all_docs documentation
flimzy opened a new pull request #203: Update _all_docs documentation URL: https://github.com/apache/couchdb-documentation/pull/203 I started by updating the `_all_docs` documentation, to reflect some of the changes made to the views documentation, then decided it might be easier to simply have the former refer to the latter, since they're 99% identical. The 'views' documentation had several changes not found in `_all_docs`--this appears to be just the natural effect of having two duplicate pieces of code (documentation). If this approach is undesirable, perhaps we can extract the common documentation to a new file, and somehow include it twice (does RST let us do that?). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hrishiballal opened a new issue #10: Fix the config file
hrishiballal opened a new issue #10: Fix the config file URL: https://github.com/apache/couchdb-pkg/issues/10 When I updated to Couchdb 2.1.1 the installation failed and bricked my existing box. The culprit is typos in teh config file (atleast according to apt-get): https://github.com/apache/couchdb-pkg/blob/master/debian/couchdb.config#L78 https://github.com/apache/couchdb-pkg/blob/master/debian/couchdb.config#L86 "whitespace" is misspelt, I am not sure how to resurrect my production install but I hope that this is caught in testing the next time. ## Expected Behavior ## Current Behavior ## Possible Solution ## Steps to Reproduce (for bugs) 1. 2. 3. 4. ## Context ## Your Environment * Version used: * Browser Name and version: * Operating System and version (desktop or mobile): * Link to your project: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace
drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace URL: https://github.com/apache/couchdb/issues/732#issuecomment-343177069 I don't believe this problem is related to spaces with paths -- I don't see any spaces. Unfortunately I don't see anything that stands out as an error in Process Monitor when the error occurs. This is typical output: 9:23:12.0321134 AM erl.exe 29256 CreateFile \Device\HarddiskVolume38\CouchDB\data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view REPARSE Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: 9:23:12.0322531 AM erl.exe 29256 CreateFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: Opened 9:23:12.0323475 AM erl.exe 29256 QueryInformationVolume C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS VolumeCreationTime: 4/10/2017 2:13:07 PM, VolumeSerialNumber: E27C-C00D, SupportsObjects: True, VolumeLabel: 9:23:12.0323577 AM erl.exe 29256 QueryAllInformationFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view BUFFER OVERFLOW CreationTime: 11/9/2017 9:20:40 AM, LastAccessTime: 11/9/2017 9:20:40 AM, LastWriteTime: 11/9/2017 9:20:46 AM, ChangeTime: 11/9/2017 9:20:46 AM, FileAttributes: A, AllocationSize: 8,192, EndOfFile: 4,272, NumberOfLinks: 1, DeletePending: False, Directory: False, IndexNumber: 0x130006ad68, EaSize: 0, Access: Generic Read, Position: 0, Mode: Synchronous IO Non-Alert, AlignmentRequirement: Word 9:23:12.0324106 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS 9:23:12.0324381 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview SUCCESS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace
drnybble commented on issue #732: CouchDB 2.1 crashes when a mount point contains whitespace URL: https://github.com/apache/couchdb/issues/732#issuecomment-343177069 I don't believe this problem is related to spaces with paths -- I don't see any spaces. Unfortunately I don't see anything that stands out as an error in Process Monitor when the error occurs. This is typical output: `9:23:12.0321134 AM erl.exe 29256 CreateFile \Device\HarddiskVolume38\CouchDB\data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view REPARSE Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: 9:23:12.0322531 AM erl.exe 29256 CreateFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS Desired Access: Generic Read, Disposition: Open, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: n/a, ShareMode: Read, Write, Delete, AllocationSize: n/a, OpenResult: Opened 9:23:12.0323475 AM erl.exe 29256 QueryInformationVolume C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS VolumeCreationTime: 4/10/2017 2:13:07 PM, VolumeSerialNumber: E27C-C00D, SupportsObjects: True, VolumeLabel: 9:23:12.0323577 AM erl.exe 29256 QueryAllInformationFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view BUFFER OVERFLOW CreationTime: 11/9/2017 9:20:40 AM, LastAccessTime: 11/9/2017 9:20:40 AM, LastWriteTime: 11/9/2017 9:20:46 AM, ChangeTime: 11/9/2017 9:20:46 AM, FileAttributes: A, AllocationSize: 8,192, EndOfFile: 4,272, NumberOfLinks: 1, DeletePending: False, Directory: False, IndexNumber: 0x130006ad68, EaSize: 0, Access: Generic Read, Position: 0, Mode: Synchronous IO Non-Alert, AlignmentRequirement: Word 9:23:12.0324106 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview\6752926508c3e23cc927ad0d3f715a76.view SUCCESS 9:23:12.0324381 AM erl.exe 29256 CloseFile C:\ProgramData\docker\volumes\paw_couchdb\_data\.shards\e000-\socialdb.1510236493_design\mrview SUCCESS ` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Antonio-Maranhao commented on issue #1019: Fix replication activity order reversing on action click
Antonio-Maranhao commented on issue #1019: Fix replication activity order reversing on action click URL: https://github.com/apache/couchdb-fauxton/pull/1019#issuecomment-343181293 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith opened a new issue #977: COPY doc doesn't decode the destination header
garrensmith opened a new issue #977: COPY doc doesn't decode the destination header URL: https://github.com/apache/couchdb/issues/977 We have an issue when a user tries to clone/copy a doc in Fauxton and the new doc id has Unicode characters. The Fauxton URL request to CouchDB encodes the user input and sets the Destination header with the encoded value of the new ID when sending the COPY request. CouchDB does not decode this, and just creates the ID including escaped values literally. #Context Cloning/copying a document with a new ID that includes Unicode chars (e.g. xxx?xxx) fails because CouchDB takes the encoded value literally, creating a doc with ID xxx%E5%95%8Axxx instead of xxx?xxx. E.g.: curl 'https://antonio-cloudant.cloudant.com/appts1/original1' -X COPY -H 'Content-Type: application/json' -H 'Destination: xxx%E5%95%8Axxx' Note that using xxx?xxx directly in curl works. The new doc will have ID xxx?xxx: curl 'https://antonio-cloudant.cloudant.com/appts1/original1' -X COPY -H 'Content-Type: application/json' -H 'Destination: xxx?xxx'. Which means the API works although it doesn't follow 100% the Destination header's spec which states the header should contain an URI, hence its value should be encoded if it includes characters outside the valid range. CouchDB COPY doc: http://docs.couchdb.org/en/2.0.0/api/document/common.html#copy--db-docid ## Possible Solution From the Fauxton side we might bypass the COPY api and just create a new doc via the PUT request. But this doesn't solve the CouchDB issue. Ideally CouchDB needs to decode the destination header. ## Steps to Reproduce (for bugs) 1. Go to a database in Fauxton 2. Click on a document. 3. Click on Clone Document 4. Add a doc id like `this/is/an/example` or `xxx?xxx` 5. Click on Clone document 6. The newly created document will be incorrect as it will be the url encoded doc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith commented on issue #977: COPY doc doesn't decode the destination header
garrensmith commented on issue #977: COPY doc doesn't decode the destination header URL: https://github.com/apache/couchdb/issues/977#issuecomment-343388484 Just to note that most of the bug report research was done by @Antonio-Maranhao. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #737: CouchDB 2.0 version indexing getting timeout for records more than 100k records
wohali commented on issue #737: CouchDB 2.0 version indexing getting timeout for records more than 100k records URL: https://github.com/apache/couchdb/issues/737#issuecomment-343370875 If your indexer job is crashing, there will be something in your couch.log file to help diagnose the problem. The original reporter never got back to us with their specifics as to what might be the problem, so we closed the ticket. Please don't hijack other tickets - if you have logfile info to go on, please open a new ticket. Locking. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services