[Jenkins] FAILURE: CouchDB » master #234
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/234/
[GitHub] davisp closed pull request #1252: Fix killing of OS processes
davisp closed pull request #1252: Fix killing of OS processes URL: https://github.com/apache/couchdb/pull/1252 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] SUCCESS: CouchDB » master #233
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/233/
[GitHub] davisp closed pull request #1251: Fix shard substitution in changes feeds
davisp closed pull request #1251: Fix shard substitution in changes feeds URL: https://github.com/apache/couchdb/pull/1251 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chewbranca commented on issue #1251: Fix shard substitution in changes feeds
chewbranca commented on issue #1251: Fix shard substitution in changes feeds URL: https://github.com/apache/couchdb/pull/1251#issuecomment-377065018 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] FAILURE: CouchDB » master #232
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/232/
[GitHub] davisp commented on issue #1251: Fix shard substitution in changes feeds
davisp commented on issue #1251: Fix shard substitution in changes feeds URL: https://github.com/apache/couchdb/pull/1251#issuecomment-377043222 @wohali Narp. That's unrelated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #1221: `_changes` filtered on `_doc_ids` returns unexpected `last_seq`
wohali commented on issue #1221: `_changes` filtered on `_doc_ids` returns unexpected `last_seq` URL: https://github.com/apache/couchdb/issues/1221#issuecomment-377043045 I wonder if this is related to #984 and @rnewson 's investigation there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #1251: Fix shard substitution in changes feeds
wohali commented on issue #1251: Fix shard substitution in changes feeds URL: https://github.com/apache/couchdb/pull/1251#issuecomment-377042785 @davisp is this at all related to #1221 ? i'm not sure it does since it looks like the reported bug applies even when shards have not yet been substituted. if so ignore this comment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl closed pull request #1245: feat: add debug log output for shard open errors
janl closed pull request #1245: feat: add debug log output for shard open errors
URL: https://github.com/apache/couchdb/pull/1245
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/fabric/src/fabric_util.erl b/src/fabric/src/fabric_util.erl
index 49f4c8913f..dd4b80da60 100644
--- a/src/fabric/src/fabric_util.erl
+++ b/src/fabric/src/fabric_util.erl
@@ -194,9 +194,11 @@ get_shard([#shard{node = Node, name = Name} | Rest], Opts,
Timeout, Factor) ->
throw(Error);
{Ref, {'rexi_EXIT', {{forbidden, _} = Error, _}}} ->
throw(Error);
-{Ref, _Else} ->
+{Ref, Reason} ->
+couch_log:debug("Failed to open shard ~p because: ~p", [Name,
Reason]),
get_shard(Rest, Opts, Timeout, Factor)
after Timeout ->
+couch_log:debug("Failed to open shard ~p after: ~p", [Name,
Timeout]),
get_shard(Rest, Opts, Factor * Timeout, Factor)
end
after
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chewbranca commented on issue #1252: Fix killing of OS processes
chewbranca commented on issue #1252: Fix killing of OS processes URL: https://github.com/apache/couchdb/pull/1252#issuecomment-377038084 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp opened a new pull request #1252: Fix killing of OS processes
davisp opened a new pull request #1252: Fix killing of OS processes URL: https://github.com/apache/couchdb/pull/1252 This was a latent bad merge that failed to remove the duplicate receive statement. This ended up discarding the monitor's 'DOWN' message which leads to an infinite loop in couch_os_proces:killer/1. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp opened a new pull request #1251: Fix shard substitution in changes feeds
davisp opened a new pull request #1251: Fix shard substitution in changes feeds URL: https://github.com/apache/couchdb/pull/1251 PSE changed the local_tree's join function so we need to update this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali closed issue #1174: shared secrete for proxy authentication
wohali closed issue #1174: shared secrete for proxy authentication URL: https://github.com/apache/couchdb/issues/1174 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rnewson commented on issue #1235: Idea: Bring back all_or_nothing
rnewson commented on issue #1235: Idea: Bring back all_or_nothing URL: https://github.com/apache/couchdb/issues/1235#issuecomment-377021566 We have considered a (fundamental) change within CouchDB that would allow a revision to have multiple parents. This would change conflict resolution from what you describe (posting a new merged revision and then deleting the unwanted siblings) to a single doc update, which (should it pass all the VDU's) would apply the 'merged' update and resolve all the conflicts. Are we describing the same problem now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali opened a new issue #1238: Fix users_db_security.js delete/recreate _users DB
wohali opened a new issue #1238: Fix users_db_security.js delete/recreate
_users DB
URL: https://github.com/apache/couchdb/issues/1238
We got a random failure in Jenkins related to encryption:
https://builds.apache.org/blue/organizations/jenkins/CouchDB/detail/master/223/pipeline
Logs at
https://couchdb-vm2.apache.org/ci_errorlogs/jenkins-couchdb-223-2018-03-23T23:15:34.663810/couchlog.tar.gz
```
test/javascript/tests/users_db_security.js
Error: undefined
Trace back (most recent call first):
52: test/javascript/test_setup.js
T((void 0))
35: test/javascript/tests/users_db_security.js
("jchris1")
39: test/javascript/tests/users_db_security.js
([object Object],"org.couchdb.user:fdmanana","jchris1")
168: test/javascript/tests/users_db_security.js
("pbkdf2",(function (derived_key) {TEquals(40, derived_key.length, "de
413: test/javascript/tests/users_db_security.js
()
395: test/javascript/couch_test_runner.js
run_on_modified_server([object Array],(function () {try {testFun(schem
411: test/javascript/tests/users_db_security.js
("pbkdf2",0,[object Array])
399: test/javascript/tests/users_db_security.js
()
37: test/javascript/cli_runner.js
runTest()
48: test/javascript/cli_runner.js
```
@eiri says:
> I looked into it and as far as I can see with bcrypt PR API test
users_db_security.js was changed to be prune to racing condition - user
database [got deleted and
re-created](https://github.com/apache/couchdb/blob/master/test/javascript/tests/users_db_security.js#L414),
which is known anti-pattern.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wohali commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
wohali commented on issue #1238: Fix users_db_security.js delete/recreate
_users DB
URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376999626
@janl Your fix failed on Jenkins, reopening :(
https://builds.apache.org/blue/organizations/jenkins/CouchDB/detail/master/231/pipeline
```
test/javascript/tests/users_db_security.js
Error: undefined
Trace back (most recent call first):
52: test/javascript/test_setup.js
T((void 0))
35: test/javascript/tests/users_db_security.js
("jchris")
39: test/javascript/tests/users_db_security.js
([object Object],"org.couchdb.user:jchris","jchris")
111: test/javascript/tests/users_db_security.js
("bcrypt",(function (derived_key) {TEquals(60, derived_key.length, "de
413: test/javascript/tests/users_db_security.js
()
395: test/javascript/couch_test_runner.js
run_on_modified_server([object Array],(function () {try {testFun(schem
411: test/javascript/tests/users_db_security.js
("bcrypt",1,[object Array])
399: test/javascript/tests/users_db_security.js
()
37: test/javascript/cli_runner.js
runTest()
48: test/javascript/cli_runner.js
fail
```
https://couchdb-vm2.apache.org/ci_errorlogs/jenkins-couchdb-231-2018-03-28T17:21:43.727450/couchlog.tar.gz
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rnewson closed pull request #265: debug level does not log HTTP requests anymore
rnewson closed pull request #265: debug level does not log HTTP requests anymore URL: https://github.com/apache/couchdb-documentation/pull/265 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rnewson opened a new pull request #265: debug level does not log HTTP requests anymore
rnewson opened a new pull request #265: debug level does not log HTTP requests anymore URL: https://github.com/apache/couchdb-documentation/pull/265 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] FAILURE: CouchDB » master #231
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/231/
[GitHub] janl commented on issue #1227: Admin-level audit logging
janl commented on issue #1227: Admin-level audit logging URL: https://github.com/apache/couchdb/issues/1227#issuecomment-376957518 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1232: Extend tests utility belt
janl commented on issue #1232: Extend tests utility belt URL: https://github.com/apache/couchdb/issues/1232#issuecomment-376956729 @eiri problem is eunit standard timeouts. So even if we do a spinloop of “do until success”, we’d run into the eunit timeout. We can raise that of course, but we’ll be doing that a lot. Maybe there is a way to set a timeout globally and set it to really long for travis and jenkins runs, so we never run into them™ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1244: Investigate if it is feasible to support a creation of a database with security object.
janl commented on issue #1244: Investigate if it is feasible to support a creation of a database with security object. URL: https://github.com/apache/couchdb/issues/1244#issuecomment-376954823 I’ve wanted this forever <3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] SUCCESS: CouchDB » master #230
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/230/
[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376901075 All good :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1250: fix: more reliable password scheme tests
janl commented on issue #1250: fix: more reliable password scheme tests URL: https://github.com/apache/couchdb/pull/1250#issuecomment-376900949 thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl closed pull request #1250: fix: more reliable password scheme tests
janl closed pull request #1250: fix: more reliable password scheme tests
URL: https://github.com/apache/couchdb/pull/1250
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/test/javascript/couch_test_runner.js
b/test/javascript/couch_test_runner.js
index 47f1ad95cd..7fe8ed39f2 100644
--- a/test/javascript/couch_test_runner.js
+++ b/test/javascript/couch_test_runner.js
@@ -427,7 +427,9 @@ function waitForSuccess(fun, tag) {
try {
fun();
break;
- } catch (e) {}
+ } catch (e) {
+log(e)
+ }
// sync http req allow async req to happen
try {
CouchDB.request("GET", "/test_suite_db/?tag="+encodeURIComponent(tag));
diff --git a/test/javascript/tests/users_db_security.js
b/test/javascript/tests/users_db_security.js
index 536585acf2..4cc154edd8 100644
--- a/test/javascript/tests/users_db_security.js
+++ b/test/javascript/tests/users_db_security.js
@@ -411,11 +411,27 @@ couchTests.users_db_security = function(debug) {
function() {
try {
testFun(scheme, derivedKeyTests[scheme], saltTests[scheme]);
+} catch (e) {
+ throw(e)
} finally {
CouchDB.login("jan", "apple");
usersDb.deleteDb(); // cleanup
- sleep(5000);
+ waitForSuccess(function() {
+var req = CouchDB.request("GET", db_name);
+if (req.status == 404) {
+ return true
+}
+throw({});
+ }, 'usersDb.deleteDb')
+
usersDb.createDb();
+ waitForSuccess(function() {
+var req = CouchDB.request("GET", db_name);
+if (req.status == 200) {
+ return true
+}
+throw({});
+ }, 'usersDb.creteDb')
}
}
);
@@ -501,8 +517,21 @@ couchTests.users_db_security = function(debug) {
} finally {
CouchDB.login("jan", "apple");
usersDb.deleteDb(); // cleanup
-sleep(5000);
+waitForSuccess(function() {
+ var req = CouchDB.request("GET", db_name);
+ if (req.status == 404) {
+return true
+ }
+ throw({});
+}, 'usersDb.deleteDb')
usersDb.createDb();
+waitForSuccess(function() {
+ var req = CouchDB.request("GET", db_name);
+ if (req.status == 200) {
+return true
+ }
+ throw({});
+}, 'usersDb.creteDb')
}
}
);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eiri commented on issue #1249: add test covering loading admins from config
eiri commented on issue #1249: add test covering loading admins from config URL: https://github.com/apache/couchdb/pull/1249#issuecomment-376895496 This should do it, I think. For a reason why this needed - `config:set` is sync, but config change broadcasting and consequently pass hashing isn't, so half of time `get_admin/1` in couch_auth cache will be getting "password" instead of prefixed hash and default to `nil` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eiri commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
eiri commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376893311 @janl No worries, it's actually my bias of assuming me been online miracly obvious to everyone and I do seat in a weird timezone. Sorry this came across that grouchy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Jianru-Lin commented on issue #1248: Maybe we need a new admin UI?
Jianru-Lin commented on issue #1248: Maybe we need a new admin UI? URL: https://github.com/apache/couchdb/issues/1248#issuecomment-376892889 @garrensmith Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1249: add test covering loading admins from config
janl commented on issue #1249: add test covering loading admins from config URL: https://github.com/apache/couchdb/pull/1249#issuecomment-376885503 new patch with proper wait This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376882795 Closing this in favour of #1250. Apologies again for the toe-stepping. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl closed issue #1238: Fix users_db_security.js delete/recreate _users DB
janl closed issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl opened a new pull request #1250: fix: more reliable password scheme tests
janl opened a new pull request #1250: fix: more reliable password scheme tests URL: https://github.com/apache/couchdb/pull/1250 Closes #1238 1. log errors from waitForSuccess 2. log errors in testFun() 3. spinloop replaces arbitrary wait timeout This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376882441 @eiri I felt a bit over-eager because I had approved this PR and I should have caught the issue on review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376882169 @eiri sorry, I thought your clock ran out and the end of your day yesterday :/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eiri commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
eiri commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376878342 @janl ok, I'll stop my work and switch to something different. Was self-assignment on this case not sufficient to indicate I'm already working on it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] SUCCESS: CouchDB » master #229
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/229/
[GitHub] janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB
janl commented on issue #1238: Fix users_db_security.js delete/recreate _users DB URL: https://github.com/apache/couchdb/issues/1238#issuecomment-376875742 I’m having a stab at it at the moment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1249: add test covering loading admins from config
janl commented on issue #1249: add test covering loading admins from config URL: https://github.com/apache/couchdb/pull/1249#issuecomment-376871536 Travis suggests this new test is flakey. Is `config:set()` async? e.g. can there be no admin configured if trying to `config:get()` right after? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl closed pull request #1247: Fix couch peruser test suite
janl closed pull request #1247: Fix couch peruser test suite
URL: https://github.com/apache/couchdb/pull/1247
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/couch_peruser/test/couch_peruser_test.erl
b/src/couch_peruser/test/couch_peruser_test.erl
index ea71f113c0..8501cc36fb 100644
--- a/src/couch_peruser/test/couch_peruser_test.erl
+++ b/src/couch_peruser/test/couch_peruser_test.erl
@@ -18,7 +18,6 @@
-define(ADMIN_USERNAME, "admin").
-define(ADMIN_PASSWORD, "secret").
--define(WAIT_FOR_DB_TIMEOUT, 1000).
-define(WAIT_FOR_USER_DELETE_TIMEOUT, 3000).
setup_all() ->
@@ -53,20 +52,18 @@ teardown(TestAuthDb) ->
set_config("cluster", "n", "3"),
do_request(delete, get_cluster_base_url() ++ "/" ++ ?b2l(TestAuthDb)),
do_request(delete, get_base_url() ++ "/" ++ ?b2l(TestAuthDb)),
-lists:foreach(fun (DbName) ->
-case DbName of
-<<"userdb-",_/binary>> -> delete_db(DbName);
-_ -> ok
+lists:foreach(fun(DbName) ->
+case binary:part(DbName, 0, 7) of
+<<"userdb-">> -> delete_db(DbName);
+_ -> ok
end
end, all_dbs()).
set_config(Section, Key, Value) ->
ok = config:set(Section, Key, Value, _Persist=false).
-delete_config(Section, Key, Value) ->
-Url = lists:concat([
-get_base_url(), "/_config/", Section, "/", Key]),
-do_request(delete, Url, "\"" ++ Value ++ "\"").
+delete_config(Section, Key) ->
+ok = config:delete(Section, Key, _Persist=false).
do_request(Method, Url) ->
Headers = [{basic_auth, {?ADMIN_USERNAME, ?ADMIN_PASSWORD}}],
@@ -114,9 +111,13 @@ delete_user(AuthDb, Name) ->
get_security(DbName) ->
Url = lists:concat([
get_cluster_base_url(), "/", ?b2l(DbName), "/_security"]),
-{ok, 200, _, Body} = do_request(get, Url),
-{SecurityProperties} = jiffy:decode(Body),
-SecurityProperties.
+test_util:wait(fun() ->
+{ok, 200, _, Body} = do_request(get, Url),
+case jiffy:decode(Body) of
+{[]} -> wait;
+{SecurityProperties} -> SecurityProperties
+end
+end).
set_security(DbName, SecurityProperties) ->
Url = lists:concat([
@@ -157,14 +158,14 @@ should_create_user_db_with_custom_prefix(TestAuthDb) ->
set_config("couch_peruser", "database_prefix", "newuserdb-"),
create_user(TestAuthDb, "fooo"),
wait_for_db_create(<<"newuserdb-666f6f6f">>),
-delete_config("couch_peruser", "database_prefix", "newuserdb-"),
+delete_config("couch_peruser", "database_prefix"),
?_assert(lists:member(<<"newuserdb-666f6f6f">>, all_dbs())).
should_create_user_db_with_custom_special_prefix(TestAuthDb) ->
set_config("couch_peruser", "database_prefix", "userdb_$()+--/"),
create_user(TestAuthDb, "fooo"),
wait_for_db_create(<<"userdb_$()+--/666f6f6f">>),
-delete_config("couch_peruser", "database_prefix", "userdb_$()+--/"),
+delete_config("couch_peruser", "database_prefix"),
?_assert(lists:member(<<"userdb_$()+--/666f6f6f">>, all_dbs())).
should_create_anon_user_db_with_default(TestAuthDb) ->
@@ -181,14 +182,14 @@ should_create_anon_user_db_with_custom_prefix(TestAuthDb)
->
set_config("couch_peruser", "database_prefix", "newuserdb-"),
create_anon_user(TestAuthDb, "fooo"),
wait_for_db_create(<<"newuserdb-666f6f6f">>),
-delete_config("couch_peruser", "database_prefix", "newuserdb-"),
+delete_config("couch_peruser", "database_prefix"),
?_assert(lists:member(<<"newuserdb-666f6f6f">>, all_dbs())).
should_create_anon_user_db_with_custom_special_prefix(TestAuthDb) ->
set_config("couch_peruser", "database_prefix", "userdb_$()+--/"),
create_anon_user(TestAuthDb, "fooo"),
wait_for_db_create(<<"userdb_$()+--/666f6f6f">>),
-delete_config("couch_peruser", "database_prefix", "userdb_$()+--/"),
+delete_config("couch_peruser", "database_prefix"),
?_assert(lists:member(<<"userdb_$()+--/666f6f6f">>, all_dbs())).
should_create_user_db_with_q4(TestAuthDb) ->
@@ -197,8 +198,7 @@ should_create_user_db_with_q4(TestAuthDb) ->
wait_for_db_create(<<"userdb-666f6f">>),
{ok, DbInfo} = fabric:get_db_info(<<"userdb-666f6f">>),
{ClusterInfo} = couch_util:get_value(cluster, DbInfo),
-delete_config("couch_peruser", "q", "4"),
-
+delete_config("couch_peruser", "q"),
[
?_assert(lists:member(<<"userdb-666f6f">>, all_dbs())),
?_assertEqual(4, couch_util:get_value(q, ClusterInfo))
@@ -210,7 +210,7 @@ should_create_anon_user_db_with_q4(TestAuthDb) ->
wait_for_db_create(<<"userdb-666f6f6f">>),
{ok, TargetInfo} = fabric:get_db_info(<<"userdb-666f6f6f">>),
{ClusterInfo} = couch_util:get_value(cluster, TargetInfo),
-delete_config("couch_peruser",
[GitHub] janl closed issue #1236: Fix should_add_user_to_db_admins test suite
janl closed issue #1236: Fix should_add_user_to_db_admins test suite URL: https://github.com/apache/couchdb/issues/1236 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith closed issue #1248: Maybe we need a new admin UI?
garrensmith closed issue #1248: Maybe we need a new admin UI? URL: https://github.com/apache/couchdb/issues/1248 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] garrensmith commented on issue #1248: Maybe we need a new admin UI?
garrensmith commented on issue #1248: Maybe we need a new admin UI? URL: https://github.com/apache/couchdb/issues/1248#issuecomment-376851738 Great that you want to contribute. The CouchDB Fauxton dashboard can be found here https://github.com/apache/couchdb-fauxton Take a look at the tickets and see which is something you would like to help with. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl commented on issue #1246: [DISCUSS] Remove duplicate authorisation check
janl commented on issue #1246: [DISCUSS] Remove duplicate authorisation check URL: https://github.com/apache/couchdb/pull/1246#issuecomment-376842957 @chewbranca good feedback, thanks. 0. I agree that this should be reviewed VERY thoroughly, hence the controversially short PR, to solicit said review :) 1. I care less about which duplicate we remove and more about making sure we only do it once. I chose to keep the one higher up the chain so we can avoid doing any more work as soon as we know we don’t have an auth match. 2. I’d love to get cassim in. Did you have a chance to resolve the issues we found in the running up to 2.0? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] janl opened a new pull request #1249: add test covering loading admins from config
janl opened a new pull request #1249: add test covering loading admins from config URL: https://github.com/apache/couchdb/pull/1249 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Jianru-Lin opened a new issue #1248: Maybe we need a new admin UI?
Jianru-Lin opened a new issue #1248: Maybe we need a new admin UI? URL: https://github.com/apache/couchdb/issues/1248 I love CouchDB and I think CouchDB is great! However it's admin UI looks old in 2018 now. It works fine but the UI design is not so attractive any more especially compared with other DB systems. Maybe the core team already have a plan to improve it? If that's ture, I'll be glad to do some contributions on weekend. Thanks. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
