[GitHub] couchdb-rebar pull request #1: Create new branch based on Mainline Rebar (v2...
GitHub user lag-linaro opened a pull request: https://github.com/apache/couchdb-rebar/pull/1 Create new branch based on Mainline Rebar (v2) This PR uses the latest software provided by the upstream Rebar (v2) repo. The most significant change allows this version of Rebar to work with compilers which do not support the -m64 flag, as reported in #892 amongst others. The latest code base also contains @davisp's `Properly skip apps with a .app.src.script file patch` which CouchDB has been carrying for a while now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lag-linaro/couchdb-rebar rebar-mainline Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-rebar/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit 78ed642967c358520fdd7bcbef764a7191335897 Author: Jared Morrow Date: 2015-06-22T04:23:49Z Add license to relnotes tool per reviewer request commit 585e307d231a5150d24bc196991778999d55a6f5 Author: Fred Hebert Date: 2015-06-22T11:35:22Z Merge pull request #514 from rebar/jem-add-license-prtool Add license to relnotes tool per reviewer request commit a47230899e879b1d49ca5ee8b33e1f0f34fd6a61 Author: Luis Rascao Date: 2015-06-25T13:05:46Z Generate reserved file for erlc regression test Reserved files such as ._do_not_compile.erl should be generated automatically when running the regression test and not added to the repo. .tar.gz source releases are not correctly generated when handling such files. commit 6cc18c931cdeec68f50708fdc7638e13611b825d Author: Fred Hebert Date: 2015-06-25T13:53:58Z Merge pull request #518 from lrascao/fix/generate_do_not_compile_file Generate reserved file for erlc regression test commit 24d82c3befff262b62e6fb064b973c90873f642d Author: Tony Rogvall Date: 2015-01-20T20:54:22Z port_compiler: add cross arch support New vars for cross arch support: * REBAR_ARCH_TARGET * REBAR_TARGET_WORDSIZE * REBAR_ARCH_TARGET_VSN commit 29447c760f388d0b5d288e10846129ace6e66f20 Author: Tony Rogvall Date: 2015-01-26T15:10:35Z rebar_utils: add (word)size helper function commit 49fd99c7011191ae9fe499f03c8070faf0bb41ba Author: Tony Rogvall Date: 2015-02-05T14:11:14Z port_compiler: cross-arch rename variables New variable names: * REBAR_TARGET_ARCH * REBAR_TARGET_ARCH_VSN * REBAR_TARGET_ARCH_WORDSIZE commit 9a64826172ade12997e8ee0ff32df52757c43025 Author: Tuncer Ayaz Date: 2015-07-02T11:45:35Z cross-arch: fix up issues * fix commit messages * fix whitespace issues * move internal helper functions to correct location * unexport internal cross arch helper functions * fix 18.0 time API compatibility * fix Windows temp dir detection * use correct helper function name * use sh/2 instead of os:cmd/1 * match file:delete/1 result * use logging macros * fix typo * fix Dialyzer warnings * add Tony Rogvall to THANKS * add missing termination clause * os type must be win32, not windows * match file:write_file/2 result * document cross-arch variables * simplify env_wordsize/1 (Thanks Fred Hebert) commit 75b7dda523861b1b1f0cf06910f8bcaabd226ca3 Author: Fred Hebert Date: 2015-07-02T18:47:54Z Merge pull request #520 from tuncer/tonyrog-cross-arch Fixed version of #451 commit 4780cc4e3b94624dab5fc8015bb683c2b41f0989 Author: Tuncer Ayaz Date: 2015-07-02T19:24:16Z rebar_utils: fix comment commit 0ad3eafc7a3401ce381c0a0d750ba3ac8d2b4321 Author: Fred Hebert Date: 2015-07-02T19:26:38Z Merge pull request #521 from tuncer/fix-comment rebar_utils: fix comment commit a587a9f7eb10691b7da5fcb45f2741c82618142f Author: Andrey Teplyashin Date: 2014-11-09T08:04:05Z Add colored logs Fix verbose level in global rebar config Replace application:set_env on erlang:put commit 8da0e014dcac75bff23ee827b139ea7fcaf08fd7 Author: Tuncer Ayaz Date: 2015-07-03T10:10:48Z Fix up colored log support * do not use pdict * do not enable color support by default. once we have the new getopt version, we can add a new type of command line flag for that. * fix Dialyzer warnings * use atom instead of boolean * use better name for internal function * do not try (and fail) to access rebar's app env in retest test commit e83a214e2984c5d2e0cb96c6dc7eb0d9ef3bc1d7 Author: Fred Hebert Date: 2015-07-03T13:05:01Z Merge pull request #522 from tuncer/platinumthinker-colored-logs Fixed version of #395 commit 6ca71569c8f726ce24ba2396794aaf065384770f Author: Tuncer Ayaz Date:
[GitHub] lag-linaro edited a comment on issue #1678: Use mainline Rebar (v2)
lag-linaro edited a comment on issue #1678: Use mainline Rebar (v2) URL: https://github.com/apache/couchdb/pull/1678#issuecomment-432922014 > Also, we have a strong preference to migrate the build process to rebar 3 - #1428. If you are able to help with this conversion process, we'll be especially grateful. Yes, I am aware of that, and I'm happy to help. **NB: I would still like to see Rebar v2 updated in the mean time please.** I did briefly investigate moving to Rebar3, but I didn't find the code to update. How does one compile native code with @davisp's offering? Where is the NIF code? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro commented on issue #1678: Use mainline Rebar (v2)
lag-linaro commented on issue #1678: Use mainline Rebar (v2) URL: https://github.com/apache/couchdb/pull/1678#issuecomment-432922014 > Also, we have a strong preference to migrate the build process to rebar 3 - #1428. If you are able to help with this conversion process, we'll be especially grateful. Yes, I am aware of that, and I'm happy to help. I would still like to see Rebar v2 updated in the mean time please. I did briefly investigate moving to Rebar3, but I didn't find the code to update. How does one compile native code with @davisp's offering? Where is the NIF code? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro commented on issue #1678: Use mainline Rebar (v2)
lag-linaro commented on issue #1678: Use mainline Rebar (v2) URL: https://github.com/apache/couchdb/pull/1678#issuecomment-432921641 > Unfortunately, we cannot accept this PR, as none of our dependencies can be on repositories outside of the Apache organization directly. > > You can try a PR against the apache/couchdb-rebar repository if you want... > > Sorry about this. That's okay. I will update CouchDB's Rebar repo instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro commented on issue #34: debian: Relax Erlang dependencies when building Debian packages on ARM
lag-linaro commented on issue #34: debian: Relax Erlang dependencies when building Debian packages on ARM URL: https://github.com/apache/couchdb-pkg/pull/34#issuecomment-432921458 New version pushed. Please re-review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro commented on issue #85: Provide and publish arm64 images
lag-linaro commented on issue #85: Provide and publish arm64 images URL: https://github.com/apache/couchdb-docker/issues/85#issuecomment-432920601 I'll get to work on your reviews right away. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Antonio-Maranhao opened a new pull request #1148: [partitioned-dbs] Updates to sidebar
Antonio-Maranhao opened a new pull request #1148: [partitioned-dbs] Updates to
sidebar
URL: https://github.com/apache/couchdb-fauxton/pull/1148
## Overview
Forth in a series of PRs that will be submitted in support of the new
user-defined partitioned databases feature (apache/couchdb#1605).
Summary:
Update links in the sidebar to include the selected partition key
## Testing recommendations
**Note:** disregard the error `'partition' parameter is mandatory for
queries to this view`. It will be addressed in a separate PR
Execute the steps below in a partitioned db:
- Create a new view `p1` in a new ddoc called `ddocPartitioned`
- Create a new view `g1` in a new ddoc called `ddocGlobal`
- edit `ddocGlobal` and add `"options": { "partitioned": false }`
- verify that `ddocPartitioned` and `ddocGlobal` have different icons on
the sidebar
- Go back to 'All Documents' and select a partition key at the top. Press
Enter to confirm.
- Click on each of the items below and verify 1) page opens correctly and 2)
selected partition key is preserved.
- All Documents
- Create Document, then cancel to go back to All Documents
- Run A Query with Mango, then go back to All Documents
- Design Documents, then back to All Documents
- `ddocGlobal` > `Metadata`
- `ddocGlobal` > `g1`
- `ddocPartitioned` > `Metadata`
- `ddocPartitioned` > `p1` (it'll show an error)
- (+) button besides 'Design Documents'
- New Doc, then cancel
- New View
- New Mango Indexes
- (+) button besides `ddocGlobal`, then click New View
- (+) button besides `ddocPartitioned`, then click New View
## Related Pull Requests
apache/couchdb#1605
## Checklist
- [x] Code is written and works correctly;
- [x] Changes are covered by tests;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wohali commented on issue #85: Provide and publish arm64 images
wohali commented on issue #85: Provide and publish arm64 images URL: https://github.com/apache/couchdb-docker/issues/85#issuecomment-432768696 @lag-linaro Thanks for sticking with this, we'll get there. Once apache/couchdb-ci#14 is merged I can get #2, will need your help to get the build working (including that rebar PR needs to be done correctly). Thanks again for all your hard work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on a change in pull request #34: debian: Relax Erlang dependencies when building Debian packages on ARM
wohali commented on a change in pull request #34: debian: Relax Erlang dependencies when building Debian packages on ARM URL: https://github.com/apache/couchdb-pkg/pull/34#discussion_r227900810 ## File path: Makefile ## @@ -69,6 +69,21 @@ centos6: make-rpmbuild centos centos-7: centos7 centos7: make-rpmbuild centos +# Erlang is built from source on ARMv8 +# These packages are not installed, but the files are present +armv8-prep: Review comment: Change the name of this to `drop-deb-deps-for-source-arch` please, as I anticipate we'll need to do this for `ppc64le` as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #1679: Error when verifying instalation
wohali commented on issue #1679: Error when verifying instalation URL: https://github.com/apache/couchdb/issues/1679#issuecomment-432734270 Is your CouchDB bound to 127.0.0.1? We would need more of your couchdb.log file to diagnose this problem. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] greenais opened a new issue #1305: Enabling require_valid_user blocks login to Fauxton
greenais opened a new issue #1305: Enabling require_valid_user blocks login to
Fauxton
URL: https://github.com/apache/couchdb/issues/1305
## Expected Behavior
Admin can log to Fauxton with require_valid_user = true
## Current Behavior
Once require_valid_user is enabled opening
http://localhost:5984/_utils/#login brings on white page:
{"error":"unauthorized","reason":"Authentication required."}. No login form,
no further actions possible.
## Possible Solution
Keep require_valid_user disabled?
## Steps to Reproduce (for bugs)
1. fresh install according to docs, cors enabled, admin user and one test Db
created
2. set require_valid_user = true in local.ini
3. open http://localhost:5984/_utils/#login
4. disable require_valid_user => Fauxton opens login with no issues
## Context
Doesn't depend on browser used - the same in Crome, Opera, FF...
## Your Environment
* Version used: 2.1.1
* Browser Name and version: all latest Chrome, Opera, FF
* Operating System and version (desktop or mobile): Windows 8.1, desktop
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wohali commented on issue #1305: Enabling require_valid_user blocks login to Fauxton
wohali commented on issue #1305: Enabling require_valid_user blocks login to Fauxton URL: https://github.com/apache/couchdb/issues/1305#issuecomment-432733985 I'll reopen for now. Someone will have to try to reproduce this on `master`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on issue #1678: Use mainline Rebar (v2)
wohali commented on issue #1678: Use mainline Rebar (v2) URL: https://github.com/apache/couchdb/pull/1678#issuecomment-432733693 Also, we have a strong preference to migrate the build process to rebar 3 - #1428. If you are able to help with this conversion process, we'll be especially grateful. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali closed pull request #1678: Use mainline Rebar (v2)
wohali closed pull request #1678: Use mainline Rebar (v2)
URL: https://github.com/apache/couchdb/pull/1678
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/configure b/configure
index 370c964ae0..2686a01b0c 100755
--- a/configure
+++ b/configure
@@ -209,7 +209,7 @@ EOF
install_local_rebar() {
if [ ! -x "${rootdir}/bin/rebar" ]; then
if [ ! -d "${rootdir}/src/rebar" ]; then
-git clone --depth 1 --branch 2.6.0-couchdb
https://github.com/apache/couchdb-rebar.git ${rootdir}/src/rebar
+git clone --depth 1 --branch master
https://github.com/rebar/rebar.git ${rootdir}/src/rebar
fi
make -C ${rootdir}/src/rebar
mv ${rootdir}/src/rebar/rebar ${rootdir}/bin/rebar
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wohali commented on issue #1678: Use mainline Rebar (v2)
wohali commented on issue #1678: Use mainline Rebar (v2) URL: https://github.com/apache/couchdb/pull/1678#issuecomment-432733259 Unfortunately, we cannot accept this PR, as none of our dependencies can be on repositories outside of the Apache organization directly. You can try a PR against the apache/couchdb-rebar repository if you want... Sorry about this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Antonio-Maranhao commented on issue #1146: Add grouping to databases with IDs containing '/'
Antonio-Maranhao commented on issue #1146: Add grouping to databases with IDs containing '/' URL: https://github.com/apache/couchdb-fauxton/pull/1146#issuecomment-432725110 @Georift Sorry for not being clear. I was suggesting having two separate modes - similar to how you can switch between table/metadata/json in the documents list. The default mode would be the paginated list with no groupings we have today. The new mode would show the complete list (no pagination) with dbs grouped. Something like a 'Show All / Paginate' link at the top would toggle between the two modes. But again, this is an alternative approach to avoid making the pagination logic too complex. Feel free to completely ignore it :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Georift commented on issue #1146: Add grouping to databases with IDs containing '/'
Georift commented on issue #1146: Add grouping to databases with IDs containing '/' URL: https://github.com/apache/couchdb-fauxton/pull/1146#issuecomment-432714493 Ah ok, I didn't realise we got a list of all dbs in a single request. I think I'm across how you're thinking. One thing I'm not entirely clear on is how we will activate the new view? From your comment on changing the pagination logic I'd imagine it involves click on the folded prefix row which would swap for the grouped listing view. Does this sound right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Antonio-Maranhao closed pull request #1140: Increase the width of string editor modal
Antonio-Maranhao closed pull request #1140: Increase the width of string editor
modal
URL: https://github.com/apache/couchdb-fauxton/pull/1140
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/app/addons/components/assets/less/header-breadcrumbs.less
b/app/addons/components/assets/less/header-breadcrumbs.less
index c4bacc455..7e4b8a0bf 100644
--- a/app/addons/components/assets/less/header-breadcrumbs.less
+++ b/app/addons/components/assets/less/header-breadcrumbs.less
@@ -33,7 +33,7 @@ a.faux-header__breadcrumbs-link {
&:hover {
color: @hoverHighlight;
text-decoration: none;
- cursor: hand;
+ cursor: pointer;
}
}
diff --git a/app/addons/components/assets/less/modals.less
b/app/addons/components/assets/less/modals.less
index 2bc047262..93e1ba3ea 100644
--- a/app/addons/components/assets/less/modals.less
+++ b/app/addons/components/assets/less/modals.less
@@ -20,6 +20,6 @@
&:hover {
color: @hoverHighlight;
text-decoration: none;
-cursor: hand;
+cursor: pointer;
}
}
diff --git a/app/addons/components/components/stringeditmodal.js
b/app/addons/components/components/stringeditmodal.js
index edee0c9a1..0c699be0c 100644
--- a/app/addons/components/components/stringeditmodal.js
+++ b/app/addons/components/components/stringeditmodal.js
@@ -56,7 +56,7 @@ export class StringEditModal extends React.Component {
render() {
return (
-
+
Edit Value
diff --git a/app/addons/documents/assets/less/doc-editor.less
b/app/addons/documents/assets/less/doc-editor.less
index 97895e808..b0f3e9efb 100644
--- a/app/addons/documents/assets/less/doc-editor.less
+++ b/app/addons/documents/assets/less/doc-editor.less
@@ -83,7 +83,7 @@
&:hover {
color: @hoverHighlight;
text-decoration: none;
- cursor: hand;
+ cursor: pointer;
}
}
.panel-button {
@@ -91,7 +91,7 @@
&:hover {
color: @hoverHighlight;
text-decoration: none;
- cursor: hand;
+ cursor: pointer;
}
}
@@ -195,9 +195,16 @@
}
}
-#editor-container div.string-editor-modal {
- height: inherit;
- max-height: 600px;
+div.string-editor-modal {
+ width: 80%;
+
+ .modal-content {
+min-width: initial;
+ }
+
+ .modal-body {
+padding: 0px;
+ }
}
.attachment-delimiter {
diff --git a/app/addons/documents/assets/less/documents.less
b/app/addons/documents/assets/less/documents.less
index c161e9bf3..6e31c632b 100644
--- a/app/addons/documents/assets/less/documents.less
+++ b/app/addons/documents/assets/less/documents.less
@@ -131,14 +131,6 @@ button.string-edit[disabled] {
display: none;
}
-#string-edit-modal {
- div.modal {
-overflow-x: visible;
-width: initial;
-min-width: 560px;
- }
-}
-
#string-editor-wrapper {
height: 500px;
width: 100%;
diff --git a/app/addons/documents/assets/less/view-editor.less
b/app/addons/documents/assets/less/view-editor.less
index ddfb6ce14..163c244d6 100644
--- a/app/addons/documents/assets/less/view-editor.less
+++ b/app/addons/documents/assets/less/view-editor.less
@@ -250,6 +250,6 @@ a.index-cancel-link {
&:hover {
color: @hoverHighlight;
text-decoration: none;
-cursor: hand;
+cursor: pointer;
}
}
diff --git a/assets/less/fauxton.less b/assets/less/fauxton.less
index bffd722e4..5658e2e9d 100644
--- a/assets/less/fauxton.less
+++ b/assets/less/fauxton.less
@@ -142,6 +142,21 @@ a:hover {
}
}
+.modal {
+ transform: translateX(-50%);
+ margin-left: inherit;
+}
+
+.modal-dialog {
+ display: flex;
+ flex-direction: row;
+}
+
+.modal-content {
+ flex: 1;
+ width: 560px;
+}
+
/*TABLE STYLES*/
table.table {
table-layout: fixed;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] davisp commented on issue #1616: Add downgrade function to downgrade database with clustered purge
davisp commented on issue #1616: Add downgrade function to downgrade database with clustered purge URL: https://github.com/apache/couchdb/pull/1616#issuecomment-432683614 @rnewson Definitely agree its probably a good idea to consolidate where up/down-grade logic happens. This is a bit wonky because it requires file modifications so it was pulled out of couch_bt_engine_header where the traditional bits do that work since they were all just about changing a view values in a record. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Antonio-Maranhao commented on issue #1140: Increase the width of string editor modal
Antonio-Maranhao commented on issue #1140: Increase the width of string editor modal URL: https://github.com/apache/couchdb-fauxton/pull/1140#issuecomment-432676440 Hey @Georift not really. Just didn't have time to take it for a final spin. I'll get to it in a bit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Antonio-Maranhao commented on issue #1146: Add grouping to databases with IDs containing '/'
Antonio-Maranhao commented on issue #1146: Add grouping to databases with IDs containing '/' URL: https://github.com/apache/couchdb-fauxton/pull/1146#issuecomment-432675917 @Georift I don't think there's a way around it. You'd need to iterate through all db names and group them until you end up with 20 entries (group or single items). The good thing is `_all_dbs` already returns all names sorted, so the only extra work is to group them. That said, it'd probably make things easier to move the grouping logic to `actions.js` since it already handles the pagination aspect, which btw will need to be updated since jumping to another page is not as simple as `(page_number * items_per_page)`. Given there's a bit of complexity with mixing grouping & pagination... I'd be ok if we split them into separate view modes. I.e. keep the paginated approach as is, and introduce a new one that would show the complete list (i.e. no pagination) with the groupings. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rnewson commented on a change in pull request #1605: Feature/user partitioned databases
rnewson commented on a change in pull request #1605: Feature/user partitioned
databases
URL: https://github.com/apache/couchdb/pull/1605#discussion_r227800805
##
File path: src/mango/src/mango_cursor_view.erl
##
@@ -98,15 +100,31 @@ maybe_replace_max_json([H | T] = EndKey) when
is_list(EndKey) ->
maybe_replace_max_json(EndKey) ->
EndKey.
-base_args(#cursor{index = Idx, selector = Selector} = Cursor) ->
-#mrargs{
+base_args(#cursor{index = Idx, opts = Opts, selector = Selector} = Cursor) ->
+Args1 = #mrargs{
view_type = map,
reduce = false,
start_key = mango_idx:start_key(Idx, Cursor#cursor.ranges),
end_key = mango_idx:end_key(Idx, Cursor#cursor.ranges),
include_docs = true,
extra = [{callback, {?MODULE, view_cb}}, {selector, Selector}]
-}.
+},
+
+DbPartitioned = mem3:is_partitioned(couch_db:name(Cursor#cursor.db)),
+Partitioned = couch_util:get_value(partitioned, Idx#idx.design_opts,
DbPartitioned),
+Args2 = couch_mrview_util:set_extra(Args1, partitioned, Partitioned),
+Args3 = case couch_util:get_value(partition, Opts) of
+<<>> ->
Review comment:
`<<>>` is the default_value in mango_opts:validate_idx_create
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rnewson commented on a change in pull request #1605: Feature/user partitioned databases
rnewson commented on a change in pull request #1605: Feature/user partitioned
databases
URL: https://github.com/apache/couchdb/pull/1605#discussion_r227799644
##
File path: src/couch/src/couch_btree.erl
##
@@ -133,7 +133,9 @@ make_group_fun(Bt, exact) ->
end;
make_group_fun(Bt, GroupLevel) when is_integer(GroupLevel), GroupLevel > 0 ->
fun
-({[_|_] = Key1, _}, {[_|_] = Key2, _}) ->
+GF({{p, _Partition, Key1}, Val1}, {{p, _Partition, Key2}, Val2}) ->
Review comment:
If the partition for Key1 and Key2 were different, that's a bug and we
should crash.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rnewson commented on a change in pull request #1605: Feature/user partitioned databases
rnewson commented on a change in pull request #1605: Feature/user partitioned
databases
URL: https://github.com/apache/couchdb/pull/1605#discussion_r227798339
##
File path: src/couch/src/couch_bt_engine.erl
##
@@ -283,6 +340,31 @@ get_security(#st{header = Header} = St) ->
end.
+get_props(#st{header = Header} = St) ->
+case couch_bt_engine_header:get(Header, props_ptr) of
+undefined ->
+[];
+Pointer ->
+{ok, Props} = couch_file:pread_term(St#st.fd, Pointer),
+Props
+end.
+
+
+get_prop(St, Key) ->
+Props = get_props(St),
+case lists:keyfind(Key, 1, Props) of
+false -> {error, no_value};
+{Key, Value} -> {ok, Value}
+end.
+
+
+get_prop(St, Key, DefaultValue) ->
+case get_prop(St, Key) of
+{error, no_value} -> DefaultValue;
+Value -> Value
Review comment:
This was intentional but I see your point. get_prop/3 will always return a
value whereas get_prop/2 might not, which is why the result shape is different.
We could change get_prop/2 to return `Value` or `undefined` instead, which
matches proplists:get_value behaviour.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rnewson commented on a change in pull request #1605: Feature/user partitioned databases
rnewson commented on a change in pull request #1605: Feature/user partitioned databases URL: https://github.com/apache/couchdb/pull/1605#discussion_r227795960 ## File path: src/chttpd/src/chttpd_httpd_handlers.erl ## @@ -43,3 +44,6 @@ design_handler(<<"_update">>) -> fun chttpd_show:handle_doc_update_req/3; design_handler(<<"_info">>)-> fun chttpd_db:handle_design_info_req/3; design_handler(<<"_rewrite">>) -> fun chttpd_rewrite:handle_rewrite_req/3; design_handler(_) -> no_match. + +partition_design_handler(<<"_view">>) -> fun chttpd_view:handle_partition_view_req/4; +partition_design_handler(_) -> no_match. Review comment: we've run our test suite and manual testing without needing that, what fails without it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rnewson commented on a change in pull request #1605: Feature/user partitioned databases
rnewson commented on a change in pull request #1605: Feature/user partitioned
databases
URL: https://github.com/apache/couchdb/pull/1605#discussion_r227795527
##
File path: src/couch_mrview/src/couch_mrview_util.erl
##
@@ -32,13 +32,20 @@
-export([extract_view/4, extract_view_reduce/1]).
-export([get_view_keys/1, get_view_queries/1]).
-export([set_view_type/3]).
+-export([set_extra/3, get_extra/2, get_extra/3]).
-export([changes_key_opts/2]).
-export([fold_changes/4]).
-export([to_key_seq/1]).
-define(MOD, couch_mrview_index).
-define(GET_VIEW_RETRY_COUNT, 1).
-define(GET_VIEW_RETRY_DELAY, 50).
+-define(LOWEST_KEY, null).
+-define(HIGHEST_KEY, {<<255, 255, 255, 255>>}).
+-define(PARTITION_START(P), <>).
+-define(PARTITION_END(P), <>).
Review comment:
intentional. it is the next character in order after `:` and therefore marks
the end of the partition key range.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Georift commented on issue #1140: Increase the width of string editor modal
Georift commented on issue #1140: Increase the width of string editor modal URL: https://github.com/apache/couchdb-fauxton/pull/1140#issuecomment-432659662 Hey @Antonio-Maranhao, is there anything else you'd like changed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[Jenkins] SUCCESS: CouchDB ยป master #376
Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/376/
[jira] [Commented] (COUCHDB-3326) Implement clustered purge API: _purge
[
https://issues.apache.org/jira/browse/COUCHDB-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662172#comment-16662172
]
ASF subversion and git services commented on COUCHDB-3326:
--
Commit 5a65ec72242e1e1cb37067512d335f9b4e5e in couchdb's branch
refs/heads/master from [~jiangph]
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=5a65ddd ]
Merge pull request #1677 from apache/COUCHDB-3326-mixed-cluster
Allow to return with accepted for mixed nodes in cluster
> Implement clustered purge API: _purge
> -
>
> Key: COUCHDB-3326
> URL: https://issues.apache.org/jira/browse/COUCHDB-3326
> Project: CouchDB
> Issue Type: New Feature
> Components: Database Core, Documentation, HTTP Interface
>Reporter: Mayya Sharipova
>Priority: Major
>
> This implements the clustered purge API:
> {code:}
> curl -H 'Content-Type: application/json' -X POST
> "http://adm:pass@127.0.0.1:5984/test1/_purge; -d
> '{"d1":["3-410e46c04b51b4c3304ed232790a49da",
> "3-420e46c04b51b4c3304ed232790a35db"],"d2":["2-a39d6d63f29a956ae39930f84dd71ec3"],
> "d3":["1-bdca7a3ac9503bf6e46d7d7a782e8f03"]}'
> {code}
> Response: status_code 201 or 202
> {code:javascript}
> {
> "purged": [
> {
> "ok": true, //Quorum was reached, at least W nodes
> successfully purged doc
> "id": "d1",
> "revs": [
> "3-410e46c04b51b4c3304ed232790a49da",
>"3-420e46c04b51b4c3304ed232790a35db"
> ]
> },
> {
> "accepted": true, //Quorum was NOT reached, but request was
> accepted
> "id": "d2",
> "revs": [
> "2-a39d6d63f29a956ae39930f84dd71ec3"
> ]
> },
> {
> "ok": true,
> "id": "d3",
> "revs": []//(DocId or Revs missing) OR (Revs are not leaf
> revisions)
> } ],
> "purge_seq":
> "6-g1BMeJzLYWBgYMpgTmHgz8tPSTV2MDQy1zMAQsMckEQiQ5L8sxKZ4UoMcSrJAgC9PRRl"
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (COUCHDB-3326) Implement clustered purge API: _purge
[
https://issues.apache.org/jira/browse/COUCHDB-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662171#comment-16662171
]
ASF subversion and git services commented on COUCHDB-3326:
--
Commit 3ac1aca98737b7f986b7efb9ed10f474821fa01f in couchdb's branch
refs/heads/master from jiangph
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=3ac1aca ]
Allow to return with accepted for mixed nodes in cluster
- for mixed nodes in cluster, i.e. nodes with different releases,
it is possible that "accepted" result is returned instead of ok when
purge request is sent. This commit is used to address badmatch error
where "accepted" returned result is not considered.
COUCHDB-3326
> Implement clustered purge API: _purge
> -
>
> Key: COUCHDB-3326
> URL: https://issues.apache.org/jira/browse/COUCHDB-3326
> Project: CouchDB
> Issue Type: New Feature
> Components: Database Core, Documentation, HTTP Interface
>Reporter: Mayya Sharipova
>Priority: Major
>
> This implements the clustered purge API:
> {code:}
> curl -H 'Content-Type: application/json' -X POST
> "http://adm:pass@127.0.0.1:5984/test1/_purge; -d
> '{"d1":["3-410e46c04b51b4c3304ed232790a49da",
> "3-420e46c04b51b4c3304ed232790a35db"],"d2":["2-a39d6d63f29a956ae39930f84dd71ec3"],
> "d3":["1-bdca7a3ac9503bf6e46d7d7a782e8f03"]}'
> {code}
> Response: status_code 201 or 202
> {code:javascript}
> {
> "purged": [
> {
> "ok": true, //Quorum was reached, at least W nodes
> successfully purged doc
> "id": "d1",
> "revs": [
> "3-410e46c04b51b4c3304ed232790a49da",
>"3-420e46c04b51b4c3304ed232790a35db"
> ]
> },
> {
> "accepted": true, //Quorum was NOT reached, but request was
> accepted
> "id": "d2",
> "revs": [
> "2-a39d6d63f29a956ae39930f84dd71ec3"
> ]
> },
> {
> "ok": true,
> "id": "d3",
> "revs": []//(DocId or Revs missing) OR (Revs are not leaf
> revisions)
> } ],
> "purge_seq":
> "6-g1BMeJzLYWBgYMpgTmHgz8tPSTV2MDQy1zMAQsMckEQiQ5L8sxKZ4UoMcSrJAgC9PRRl"
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] jiangphcn closed pull request #1677: Allow to return with accepted for mixed nodes in cluster
jiangphcn closed pull request #1677: Allow to return with accepted for mixed nodes in cluster URL: https://github.com/apache/couchdb/pull/1677 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiangphcn commented on issue #1677: Allow to return with accepted for mixed nodes in cluster
jiangphcn commented on issue #1677: Allow to return with accepted for mixed nodes in cluster URL: https://github.com/apache/couchdb/pull/1677#issuecomment-432624037 thanks Bob @rnewson This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] LiamRa opened a new issue #1679: Error when verifying instalation
LiamRa opened a new issue #1679: Error when verifying instalation
URL: https://github.com/apache/couchdb/issues/1679
Error: {http_request_failed,"GET","http://127.0.0.1:5984/verifytestdb/;,
{error,{error,{conn_failed,{error,econnrefused}
That's the error I get, everything is installed properly except the
replication part. Just wondering what exactly it is and how to fix it, thank
you.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rnewson commented on issue #1616: Add downgrade function to downgrade database with clustered purge
rnewson commented on issue #1616: Add downgrade function to downgrade database with clustered purge URL: https://github.com/apache/couchdb/pull/1616#issuecomment-432619310 @davisp I would like to see the triggering of the downgrade logic happening in the same spot as all previous upgrade logic triggering (specifically, couch_bt_engine_header:upgrade/1). The actual downgrade logic appears right (and you would know better than I). Since we have another change after this that also changes db_header and will require up- and downgrade logic, we need a mechanism that extends naturally. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1642: Set io_priority for couch_index pids
AlexanderKaraberov commented on issue #1642: Set io_priority for couch_index pids URL: https://github.com/apache/couchdb/pull/1642#issuecomment-432591456 Hi @iilyak I wonder whether this change may result in better performance of index I/O operations (like view index updates)? If I understood correctly this `io_priority` flag is for [ioq supervisor](https://github.com/apache/couchdb-ioq) which prioritises I/O operations inside of CouchDB. Or this change is pure informative/debugging one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ktaragorn commented on issue #1305: Enabling require_valid_user blocks login to Fauxton
ktaragorn commented on issue #1305: Enabling require_valid_user blocks login to Fauxton URL: https://github.com/apache/couchdb/issues/1305#issuecomment-432588359 Installed using your cookbook https://supermarket.chef.io/cookbooks/couchdb This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro opened a new pull request #1678: Use mainline Rebar (v2)
lag-linaro opened a new pull request #1678: Use mainline Rebar (v2) URL: https://github.com/apache/couchdb/pull/1678 This PR uses the latest software provided by the upstream Rebar (v2) repo. The most significant change allows this version of Rebar to work with compilers which do not support the -m64 flag, as reported in https://github.com/apache/couchdb/issues/892 amongst others. The latest code base also contains @davisp's `Properly skip apps with a .app.src.script file` patch with CouchDB has been carrying for a while now. Signed-off-by: Lee Jones This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ktaragorn commented on issue #1305: Enabling require_valid_user blocks login to Fauxton
ktaragorn commented on issue #1305: Enabling require_valid_user blocks login to Fauxton URL: https://github.com/apache/couchdb/issues/1305#issuecomment-432575651 @wohali This is couchdb 2.1.1 installed on Ubuntu 16.04 LTS. I changed this option via fauxton, and now am locked out of admin panel. Still figuring out where fauxton stores the config so I can go undo it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro commented on issue #85: Provide and publish arm64 images
lag-linaro commented on issue #85: Provide and publish arm64 images URL: https://github.com/apache/couchdb-docker/issues/85#issuecomment-432556830 @wohali https://github.com/apache/couchdb-pkg/pull/34 should solve .3 above. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro opened a new pull request #34: debian: Relax Erlang dependencies when building Debian packages on ARM
lag-linaro opened a new pull request #34: debian: Relax Erlang dependencies when building Debian packages on ARM URL: https://github.com/apache/couchdb-pkg/pull/34 Erlang is built and installed from source on ARM based platforms. Signed-off-by: Lee Jones ## Overview ## Testing recommendations ## GitHub issue number ## Related Pull Requests ## Checklist - [ ] Code is written and works correctly; - [ ] Changes are covered by tests; - [ ] Documentation reflects the changes; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lag-linaro commented on issue #85: Provide and publish arm64 images
lag-linaro commented on issue #85: Provide and publish arm64 images URL: https://github.com/apache/couchdb-docker/issues/85#issuecomment-432555287 @wohali https://github.com/apache/couchdb-ci/pull/14 should solve 1. above. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiangphcn commented on a change in pull request #1676: Downgrade code for Database partitions
jiangphcn commented on a change in pull request #1676: Downgrade code for
Database partitions
URL: https://github.com/apache/couchdb/pull/1676#discussion_r227666512
##
File path: src/couch/src/couch_bt_engine.erl
##
@@ -857,6 +868,59 @@ init_state(FilePath, Fd, Header0, Options) ->
end.
+downgrade_partition_info(Header) ->
+% {db_header,
+% disk_version = ?LATEST_DISK_VERSION,
+% update_seq = 0,
+% unused = 0,
+% id_tree_state = nil,
+% seq_tree_state = nil,
+% local_tree_state = nil,
+% purge_tree_state = nil,
+% purge_seq_tree_state = nil, %purge tree: purge_seq -> uuid
+% security_ptr = nil,
+% revs_limit = 1000,
+% uuid,
+% epochs,
+% compacted_seq,
+% purge_infos_limit = 1000,
+% props_ptr
+% },
+{
+db_header,
+_DiskVer,
+UpSeq,
+_Unused,
+IdTreeState,
+SeqTreeState,
+LocalTreeState,
+PurgeTreeState,
+PurgeSeqTreeState,
+SecurityPtr,
+RevsLimit,
+Uuid,
+Epochs,
+CompactedSeq,
+_PDocsLimit,
+_PropsPtr
+} = Header,
+
+NewHeader = couch_bt_engine_header:new(),
+couch_bt_engine_header:set(NewHeader, [
+{update_seq, UpSeq},
+{id_tree_state, IdTreeState},
+{seq_tree_state, SeqTreeState},
+{local_tree_state, LocalTreeState},
+{purge_tree_state, PurgeTreeState},
+{purge_seq_tree_state, PurgeSeqTreeState},
+{security_ptr, SecurityPtr},
+{revs_limit, RevsLimit},
+{uuid, Uuid},
+{epochs, Epochs},
+{compacted_seq, CompactedSeq}
Review comment:
The value of `purge_infos_limit` can be changed and may not be default. So
there is need to write current value to database header as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] lu-xiansheng commented on issue #112: Error writing to pipe: Broken pipe
lu-xiansheng commented on issue #112: Error writing to pipe: Broken pipe URL: https://github.com/apache/couchdb-docker/issues/112#issuecomment-432538749 > How did you start CouchDB? Give me the full command line, please. I just use "docker run couchdb" couchdb is images name This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lu-xiansheng removed a comment on issue #112: Error writing to pipe: Broken pipe
lu-xiansheng removed a comment on issue #112: Error writing to pipe: Broken pipe URL: https://github.com/apache/couchdb-docker/issues/112#issuecomment-432538345 I just use "docker run couchdb" to run my images,couchdb is my images name . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lu-xiansheng commented on issue #112: Error writing to pipe: Broken pipe
lu-xiansheng commented on issue #112: Error writing to pipe: Broken pipe URL: https://github.com/apache/couchdb-docker/issues/112#issuecomment-432538345 I just use "docker run couchdb" to run my images,couchdb is my images name . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (COUCHDB-3326) Implement clustered purge API: _purge
[
https://issues.apache.org/jira/browse/COUCHDB-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661808#comment-16661808
]
ASF subversion and git services commented on COUCHDB-3326:
--
Commit 3ac1aca98737b7f986b7efb9ed10f474821fa01f in couchdb's branch
refs/heads/COUCHDB-3326-mixed-cluster from jiangph
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=3ac1aca ]
Allow to return with accepted for mixed nodes in cluster
- for mixed nodes in cluster, i.e. nodes with different releases,
it is possible that "accepted" result is returned instead of ok when
purge request is sent. This commit is used to address badmatch error
where "accepted" returned result is not considered.
COUCHDB-3326
> Implement clustered purge API: _purge
> -
>
> Key: COUCHDB-3326
> URL: https://issues.apache.org/jira/browse/COUCHDB-3326
> Project: CouchDB
> Issue Type: New Feature
> Components: Database Core, Documentation, HTTP Interface
>Reporter: Mayya Sharipova
>Priority: Major
>
> This implements the clustered purge API:
> {code:}
> curl -H 'Content-Type: application/json' -X POST
> "http://adm:pass@127.0.0.1:5984/test1/_purge; -d
> '{"d1":["3-410e46c04b51b4c3304ed232790a49da",
> "3-420e46c04b51b4c3304ed232790a35db"],"d2":["2-a39d6d63f29a956ae39930f84dd71ec3"],
> "d3":["1-bdca7a3ac9503bf6e46d7d7a782e8f03"]}'
> {code}
> Response: status_code 201 or 202
> {code:javascript}
> {
> "purged": [
> {
> "ok": true, //Quorum was reached, at least W nodes
> successfully purged doc
> "id": "d1",
> "revs": [
> "3-410e46c04b51b4c3304ed232790a49da",
>"3-420e46c04b51b4c3304ed232790a35db"
> ]
> },
> {
> "accepted": true, //Quorum was NOT reached, but request was
> accepted
> "id": "d2",
> "revs": [
> "2-a39d6d63f29a956ae39930f84dd71ec3"
> ]
> },
> {
> "ok": true,
> "id": "d3",
> "revs": []//(DocId or Revs missing) OR (Revs are not leaf
> revisions)
> } ],
> "purge_seq":
> "6-g1BMeJzLYWBgYMpgTmHgz8tPSTV2MDQy1zMAQsMckEQiQ5L8sxKZ4UoMcSrJAgC9PRRl"
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] jiangphcn opened a new pull request #1677: Allow return with accepted for mixed nodes in cluster
jiangphcn opened a new pull request #1677: Allow return with accepted for mixed
nodes in cluster
URL: https://github.com/apache/couchdb/pull/1677
## Overview
Under situation where mixed nodes exist in one cluster, i.e. some nodes are
with clustered purge feature while some nodes are without clustered purge
feature, the `accepted` result is returned instead of `ok` when purge request
is sent.
This PR is used to address `badmatch` error where "accepted" returned result
is not considered. Otherwise, the following error may occur
```
req_err(3038544381) badmatch :
{accepted,[{accepted,[{1,<<217,66,240,206,1,100,122,160,244,101,24,178,19,181,98,142>>}]}]}[<<"chttpd_db:db_req/2
L527">>,<<"chttpd:handle_req_after_auth/2 L320">>,<<"chttpd:process_request/1
L303">>,<<"chttpd:handle_request_int/1 L243">>,<<"mochiweb_http:headers/6
L124">>,<<"proc_lib:init_p_do_apply/3 L247">>]
```
## Testing recommendations
make check skip_deps+=couch_epi apps=chttpd tests=purge_test_
```
EUnit
chttpd db tests
Application crypto was left running!
chttpd_purge_tests:86: test_empty_purge_request...[0.009 s] ok
chttpd_purge_tests:103: test_ok_purge_request...[0.176 s] ok
chttpd_purge_tests:140: test_accepted_purge_request...[0.123 s] ok
chttpd_purge_tests:172: test_partial_purge_request...[0.094 s] ok
chttpd_purge_tests:208: test_mixed_purge_request...[0.177 s] ok
chttpd_purge_tests:256: test_overmany_ids_or_revs_purge_request...[0.128
s] ok
chttpd_purge_tests:306: test_exceed_limits_on_purge_infos...[0.146 s] ok
chttpd_purge_tests:349: should_error_set_purged_docs_limit_to0...[0.004 s]
ok
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
[done in 2.965 s]
===
All 8 tests passed.
```
## Related Issues or Pull Requests
COUCHDB-3326
## Checklist
- [X] Code is written and works correctly;
- [X] Changes are covered by tests;
- [X] Documentation reflects the changes;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
