[GitHub] [couchdb] garrensmith commented on a change in pull request #2456: FDB Builtin reduce

2020-01-16 Thread GitBox
garrensmith commented on a change in pull request #2456: FDB Builtin reduce URL: https://github.com/apache/couchdb/pull/2456#discussion_r367279447 ## File path: src/couch_views/src/couch_views_reduce.erl ## @@ -0,0 +1,232 @@ +% Licensed under the Apache License, Version

[GitHub] [couchdb] garrensmith commented on issue #2456: FDB Builtin reduce

2020-01-16 Thread GitBox
garrensmith commented on issue #2456: FDB Builtin reduce URL: https://github.com/apache/couchdb/pull/2456#issuecomment-575035893 @chewbranca thanks for the review. I've made the fixes you suggested. Where I would really value your feedback is the actual skip list algorithm.

[GitHub] [couchdb-documentation] willholley merged pull request #473: Document same_site cookie attribute

2020-01-16 Thread GitBox
willholley merged pull request #473: Document same_site cookie attribute URL: https://github.com/apache/couchdb-documentation/pull/473 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix potential ID selector collisions

2020-01-16 Thread GitBox
willholley commented on issue #1246: Nav: Fix potential ID selector collisions URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575091751 nice catch - thanks @mhamann. +1 This is an automated

[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file

2020-01-16 Thread GitBox
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file URL: https://github.com/apache/couchdb/pull/2459#discussion_r367542195 ## File path: rel/overlay/etc/default.ini ## @@ -578,3 +584,44 @@ compaction = false ; CouchDB

[GitHub] [couchdb] rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken

2020-01-16 Thread GitBox
rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken URL: https://github.com/apache/couchdb/pull/2450#discussion_r367421488 ## File path: src/ken/rebar.config.script ## @@ -11,7 +11,9 @@ % the License. HaveDreyfus =

[GitHub] [couchdb] rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken

2020-01-16 Thread GitBox
rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken URL: https://github.com/apache/couchdb/pull/2450#discussion_r367421354 ## File path: .idea/vcs.xml ## @@ -0,0 +1,25 @@ + Review comment: and remove this file

[GitHub] [couchdb] rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken

2020-01-16 Thread GitBox
rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken URL: https://github.com/apache/couchdb/pull/2450#discussion_r367421287 ## File path: .idea/inspectionProfiles/Project_Default.xml ## @@ -0,0 +1,6 @@ + Review comment:

[GitHub] [couchdb] wohali commented on issue #2461: [Jenkins] Revert to SM 1.8.5 for arm64

2020-01-16 Thread GitBox
wohali commented on issue #2461: [Jenkins] Revert to SM 1.8.5 for arm64 URL: https://github.com/apache/couchdb/pull/2461#issuecomment-575248871 And Jenkins passed, so I'm merging this. This is an automated message from the

[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file

2020-01-16 Thread GitBox
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file URL: https://github.com/apache/couchdb/pull/2459#discussion_r367541977 ## File path: rel/overlay/etc/default.ini ## @@ -578,3 +584,44 @@ compaction = false ; CouchDB

[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix potential ID selector collisions

2020-01-16 Thread GitBox
willholley commented on issue #1246: Nav: Fix potential ID selector collisions URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575181746 something's not quite right in the CI here - it's consistently failing when search is enabled. I'm running the Jenkins build

[GitHub] [couchdb] garrensmith opened a new pull request #2460: Change map indexes to be stored in one row

2020-01-16 Thread GitBox
garrensmith opened a new pull request #2460: Change map indexes to be stored in one row URL: https://github.com/apache/couchdb/pull/2460 ## Overview Changes map indexes to store the original key and value in a single FDB row. ## Testing recommendations All tests

[Jenkins] FAILURE: CouchDB » Full Platform Builds » jenkins-185-arm64 #2

2020-01-16 Thread Apache Jenkins Server
Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/jenkins-185-arm64/2/display/redirect

[GitHub] [couchdb-documentation] wohali commented on issue #477: Update scheduler docs/info endpoint docs with newly provided field info

2020-01-16 Thread GitBox
wohali commented on issue #477: Update scheduler docs/info endpoint docs with newly provided field info URL: https://github.com/apache/couchdb-documentation/issues/477#issuecomment-575194290 ok thanks! I would rather over-file these issues and have some duplicates than miss stuff for

[GitHub] [couchdb-documentation] wohali closed issue #477: Update scheduler docs/info endpoint docs with newly provided field info

2020-01-16 Thread GitBox
wohali closed issue #477: Update scheduler docs/info endpoint docs with newly provided field info URL: https://github.com/apache/couchdb-documentation/issues/477 This is an automated message from the Apache Git Service. To

[GitHub] [couchdb] nickva merged pull request #2458: Fix fabric worker failures for partition requests

2020-01-16 Thread GitBox
nickva merged pull request #2458: Fix fabric worker failures for partition requests URL: https://github.com/apache/couchdb/pull/2458 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb] davisp commented on a change in pull request #2462: Debug mem3_sync_event_listener flakiness

2020-01-16 Thread GitBox
davisp commented on a change in pull request #2462: Debug mem3_sync_event_listener flakiness URL: https://github.com/apache/couchdb/pull/2462#discussion_r367539197 ## File path: src/mem3/src/mem3_sync_event_listener.erl ## @@ -305,6 +306,9 @@ should_terminate(Pid) ->

[GitHub] [couchdb] nickva commented on a change in pull request #2462: Debug mem3_sync_event_listener flakiness

2020-01-16 Thread GitBox
nickva commented on a change in pull request #2462: Debug mem3_sync_event_listener flakiness URL: https://github.com/apache/couchdb/pull/2462#discussion_r367539950 ## File path: src/mem3/src/mem3_sync_event_listener.erl ## @@ -305,6 +306,9 @@ should_terminate(Pid) ->

[GitHub] [couchdb] nickva opened a new pull request #2462: Debug mem3_sync_event_listener flakiness

2020-01-16 Thread GitBox
nickva opened a new pull request #2462: Debug mem3_sync_event_listener flakiness URL: https://github.com/apache/couchdb/pull/2462 Noticed mem3_sync_event_listner tests still fails intermetently, add a debug log to it to hopefully find the cause of the failure.

[GitHub] [couchdb] wohali opened a new pull request #2461: [Jenkins] Revert to SM 1.8.5 for arm64

2020-01-16 Thread GitBox
wohali opened a new pull request #2461: [Jenkins] Revert to SM 1.8.5 for arm64 URL: https://github.com/apache/couchdb/pull/2461 Fixes #2449 and our "full" builds. We will need a separate change to explicitly disallow SM 60 on arm - or we just document it. What do you think @davisp

[GitHub] [couchdb] wohali commented on a change in pull request #2459: Add a few missing settings to the default.ini file

2020-01-16 Thread GitBox
wohali commented on a change in pull request #2459: Add a few missing settings to the default.ini file URL: https://github.com/apache/couchdb/pull/2459#discussion_r367487521 ## File path: rel/overlay/etc/default.ini ## @@ -578,3 +584,44 @@ compaction = false ; CouchDB

[GitHub] [couchdb] wohali commented on a change in pull request #2459: Add a few missing settings to the default.ini file

2020-01-16 Thread GitBox
wohali commented on a change in pull request #2459: Add a few missing settings to the default.ini file URL: https://github.com/apache/couchdb/pull/2459#discussion_r367487972 ## File path: rel/overlay/etc/default.ini ## @@ -578,3 +584,44 @@ compaction = false ; CouchDB

[GitHub] [couchdb] jiangphcn merged pull request #2450: Adjust way to detect presence of hastings for Ken

2020-01-16 Thread GitBox
jiangphcn merged pull request #2450: Adjust way to detect presence of hastings for Ken URL: https://github.com/apache/couchdb/pull/2450 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb-fauxton] mhamann commented on issue #1246: Nav: Fix potential ID selector collisions

2020-01-16 Thread GitBox
mhamann commented on issue #1246: Nav: Fix potential ID selector collisions URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575226180 @willholley I had some trouble running the nightwatch tests locally, so I had to update a couple of test cases based on failures I

[GitHub] [couchdb] jiangphcn commented on issue #2461: [Jenkins] Revert to SM 1.8.5 for arm64

2020-01-16 Thread GitBox
jiangphcn commented on issue #2461: [Jenkins] Revert to SM 1.8.5 for arm64 URL: https://github.com/apache/couchdb/pull/2461#issuecomment-575197664 What about doing both? `disallow SM 60 on arm` and `document it` This is an

[Jenkins] FAILURE: CouchDB » Full Platform Builds » jenkins-185-arm64 #5

2020-01-16 Thread Apache Jenkins Server
Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/jenkins-185-arm64/5/display/redirect

[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix potential ID selector collisions

2020-01-16 Thread GitBox
willholley commented on issue #1246: Nav: Fix potential ID selector collisions URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575257355 @mhamann https://travis-ci.org/apache/couchdb-fauxton/jobs/637256303 (test suite running against couchdb + search) fails

[GitHub] [couchdb-documentation] nickva opened a new pull request #478: Update resharding config section

2020-01-16 Thread GitBox
nickva opened a new pull request #478: Update resharding config section URL: https://github.com/apache/couchdb-documentation/pull/478 Some entries were stale and others were missing This is an automated message from

[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file

2020-01-16 Thread GitBox
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file URL: https://github.com/apache/couchdb/pull/2459#discussion_r367572953 ## File path: rel/overlay/etc/default.ini ## @@ -578,3 +584,44 @@ compaction = false ; CouchDB

[GitHub] [couchdb] wohali opened a new pull request #2463: Fix ini file setting for #2296

2020-01-16 Thread GitBox
wohali opened a new pull request #2463: Fix ini file setting for #2296 URL: https://github.com/apache/couchdb/pull/2463 Settings in `default.ini` should be the defaults. Also a little text cleanup for clarity. This is an

[GitHub] [couchdb] wohali commented on a change in pull request #2296: Fix/1977

2020-01-16 Thread GitBox
wohali commented on a change in pull request #2296: Fix/1977 URL: https://github.com/apache/couchdb/pull/2296#discussion_r367585046 ## File path: rel/overlay/etc/default.ini ## @@ -68,6 +68,9 @@ default_engine = couch ; inadvertently abusing partitions resulting in hot

[GitHub] [couchdb-documentation] flimzy commented on a change in pull request #478: Update resharding config section

2020-01-16 Thread GitBox
flimzy commented on a change in pull request #478: Update resharding config section URL: https://github.com/apache/couchdb-documentation/pull/478#discussion_r367634990 ## File path: src/config/resharding.rst ## @@ -32,7 +32,17 @@ Resharding Configuration will

[GitHub] [couchdb-documentation] flimzy commented on a change in pull request #478: Update resharding config section

2020-01-16 Thread GitBox
flimzy commented on a change in pull request #478: Update resharding config section URL: https://github.com/apache/couchdb-documentation/pull/478#discussion_r367636969 ## File path: src/config/resharding.rst ## @@ -77,3 +87,22 @@ Resharding Configuration

[GitHub] [couchdb-documentation] flimzy commented on a change in pull request #478: Update resharding config section

2020-01-16 Thread GitBox
flimzy commented on a change in pull request #478: Update resharding config section URL: https://github.com/apache/couchdb-documentation/pull/478#discussion_r367636092 ## File path: src/config/resharding.rst ## @@ -32,7 +32,17 @@ Resharding Configuration will

[GitHub] [couchdb] nickva merged pull request #2462: Debug mem3_sync_event_listener flakiness

2020-01-16 Thread GitBox
nickva merged pull request #2462: Debug mem3_sync_event_listener flakiness URL: https://github.com/apache/couchdb/pull/2462 This is an automated message from the Apache Git Service. To respond to the message, please log on

[Jenkins] FAILURE: CouchDB » Full Platform Builds » jenkins-185-arm64 #8

2020-01-16 Thread Apache Jenkins Server
Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/jenkins-185-arm64/8/display/redirect

[GitHub] [couchdb] nickva commented on a change in pull request #1919: Ignore new subprojects

2020-01-16 Thread GitBox
nickva commented on a change in pull request #1919: Ignore new subprojects URL: https://github.com/apache/couchdb/pull/1919#discussion_r367579099 ## File path: .gitignore ## @@ -47,17 +47,21 @@ src/docs/ src/ets_lru/ src/fauxton/ src/folsom/ +src/hqueue/ +src/hyper/

[GitHub] [couchdb] wohali closed issue #2449: arm64 auth cache tests failing

2020-01-16 Thread GitBox
wohali closed issue #2449: arm64 auth cache tests failing URL: https://github.com/apache/couchdb/issues/2449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [couchdb] wohali merged pull request #2461: [Jenkins] Revert to SM 1.8.5 for arm64

2020-01-16 Thread GitBox
wohali merged pull request #2461: [Jenkins] Revert to SM 1.8.5 for arm64 URL: https://github.com/apache/couchdb/pull/2461 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [couchdb-documentation] nickva commented on a change in pull request #478: Update resharding config section

2020-01-16 Thread GitBox
nickva commented on a change in pull request #478: Update resharding config section URL: https://github.com/apache/couchdb-documentation/pull/478#discussion_r367649177 ## File path: src/config/resharding.rst ## @@ -32,7 +32,17 @@ Resharding Configuration will

[GitHub] [couchdb] wohali commented on issue #2437: Hung beam.smp sitting at 100% CPU

2020-01-16 Thread GitBox
wohali commented on issue #2437: Hung beam.smp sitting at 100% CPU URL: https://github.com/apache/couchdb/issues/2437#issuecomment-575255673 Another failed build with this situation:

[GitHub] [couchdb] wohali commented on issue #2410: Mango metrics

2020-01-16 Thread GitBox
wohali commented on issue #2410: Mango metrics URL: https://github.com/apache/couchdb/pull/2410#issuecomment-575287193 Looks nice. If you want this in 3.0, now's the time to merge it. This is an automated message from the

[GitHub] [couchdb-documentation] wohali opened a new issue #479: Document partitioned DBs + Mango

2020-01-16 Thread GitBox
wohali opened a new issue #479: Document partitioned DBs + Mango URL: https://github.com/apache/couchdb-documentation/issues/479 Left out of #385 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [couchdb] jaydoane commented on issue #2361: Make smoosh use UTC for scheduling window

2020-01-16 Thread GitBox
jaydoane commented on issue #2361: Make smoosh use UTC for scheduling window URL: https://github.com/apache/couchdb/pull/2361#issuecomment-575334199 CouchDB emits time in ISO8601 format in several places, but I was unable to find anywhere in the code base which reads that format. For

[GitHub] [couchdb-documentation] nickva commented on a change in pull request #478: Update resharding config section

2020-01-16 Thread GitBox
nickva commented on a change in pull request #478: Update resharding config section URL: https://github.com/apache/couchdb-documentation/pull/478#discussion_r367650498 ## File path: src/config/resharding.rst ## @@ -77,3 +87,22 @@ Resharding Configuration

[Jenkins] FAILURE: CouchDB » Full Platform Builds » master #36

2020-01-16 Thread Apache Jenkins Server
Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/master/36/display/redirect

[GitHub] [couchdb] wohali commented on issue #2437: Hung beam.smp sitting at 100% CPU

2020-01-16 Thread GitBox
wohali commented on issue #2437: Hung beam.smp sitting at 100% CPU URL: https://github.com/apache/couchdb/issues/2437#issuecomment-575263817 And: https://ci-couchdb.apache.org/blue/organizations/jenkins/jenkins-cm1%2FFullPlatformMatrix/detail/jenkins-185-arm64/6/pipeline

[GitHub] [couchdb] wohali commented on a change in pull request #1919: Ignore new subprojects

2020-01-16 Thread GitBox
wohali commented on a change in pull request #1919: Ignore new subprojects URL: https://github.com/apache/couchdb/pull/1919#discussion_r367568962 ## File path: .gitignore ## @@ -47,17 +47,21 @@ src/docs/ src/ets_lru/ src/fauxton/ src/folsom/ +src/hqueue/ +src/hyper/

[Jenkins] FAILURE: CouchDB » Full Platform Builds » master #35

2020-01-16 Thread Apache Jenkins Server
Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/master/35/display/redirect

[GitHub] [couchdb] nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file

2020-01-16 Thread GitBox
nickva commented on a change in pull request #2459: Add a few missing settings to the default.ini file URL: https://github.com/apache/couchdb/pull/2459#discussion_r367574179 ## File path: rel/overlay/etc/default.ini ## @@ -578,3 +584,44 @@ compaction = false ; CouchDB

[Jenkins] FAILURE: CouchDB » Full Platform Builds » master #37

2020-01-16 Thread Apache Jenkins Server
Boo, we failed. https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/master/37/display/redirect

[GitHub] [couchdb] wohali commented on issue #2465: Release candidate 123256 - 3

2020-01-16 Thread GitBox
wohali commented on issue #2465: Release candidate 123256 - 3 URL: https://github.com/apache/couchdb/pull/2465#issuecomment-575450537 ??? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb] tonysun83 merged pull request #1783: fix empty queries

2020-01-16 Thread GitBox
tonysun83 merged pull request #1783: fix empty queries URL: https://github.com/apache/couchdb/pull/1783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [couchdb] jiangphcn commented on issue #2465: Release candidate 123256 - 3

2020-01-16 Thread GitBox
jiangphcn commented on issue #2465: Release candidate 123256 - 3 URL: https://github.com/apache/couchdb/pull/2465#issuecomment-575460452 hi @wohali I am in charge of building Cloudant Release Candidate and need to cherry-pick some commits from apache/couchdb. This PR should open against

[GitHub] [couchdb] jiangphcn opened a new pull request #2465: Release candidate 123256 - 3

2020-01-16 Thread GitBox
jiangphcn opened a new pull request #2465: Release candidate 123256 - 3 URL: https://github.com/apache/couchdb/pull/2465 jiangphs-MacBook-Pro:couchdb jiangph$ git cherry-pick efb374a6493c4220333a201b649649736ddcc528 [release-candidate-123256-3 03889948c] Improve replicator error

[GitHub] [couchdb] jiangphcn closed pull request #2465: Release candidate 123256 - 3

2020-01-16 Thread GitBox
jiangphcn closed pull request #2465: Release candidate 123256 - 3 URL: https://github.com/apache/couchdb/pull/2465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [couchdb] jjrodrig opened a new pull request #2464: Port etags tests into elixir test suite

2020-01-16 Thread GitBox
jjrodrig opened a new pull request #2464: Port etags tests into elixir test suite URL: https://github.com/apache/couchdb/pull/2464 ## Overview This PR ports etags_head test into exlixir test suite. I've checked the etags_views.js but it currently disabled in the js test suite

[GitHub] [couchdb] rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken

2020-01-16 Thread GitBox
rnewson commented on a change in pull request #2450: More way to detect presence of hastings for Ken URL: https://github.com/apache/couchdb/pull/2450#discussion_r367387605 ## File path: src/ken/rebar.config.script ## @@ -11,7 +11,12 @@ % the License. HaveDreyfus =

[GitHub] [couchdb] toumbask commented on issue #2441: Memory Usage Keeps Increasing Gradually

2020-01-16 Thread GitBox
toumbask commented on issue #2441: Memory Usage Keeps Increasing Gradually URL: https://github.com/apache/couchdb/issues/2441#issuecomment-575093353 Also facing the same issue, on Single Node installation , though the increase span is much faster (within 2-4 days, RAM usage jumps to over