[GitHub] [couchdb-config] iilyak merged pull request #30: Refactor config:set to be able to pass sensitive flag

2020-07-29 Thread GitBox
iilyak merged pull request #30: URL: https://github.com/apache/couchdb-config/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [couchdb-documentation] flimzy commented on pull request #577: fix(api): Fix typo in ddoc/views.rst

2020-07-29 Thread GitBox
flimzy commented on pull request #577: URL: https://github.com/apache/couchdb-documentation/pull/577#issuecomment-665612059 LGTM! +1 and thanks! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [couchdb-documentation] janl merged pull request #578: Persistent cookies accurate description

2020-07-29 Thread GitBox
janl merged pull request #578: URL: https://github.com/apache/couchdb-documentation/pull/578 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [couchdb-documentation] fmoko opened a new pull request #577: fix(api): Fix typo in ddoc/views.rst

2020-07-29 Thread GitBox
fmoko opened a new pull request #577: URL: https://github.com/apache/couchdb-documentation/pull/577 ## Overview Fixes a small typo in `src/api/ddoc/views.rst`. Not sure if the wording as I've put it is correct, but given that there are probably multiple ICU drivers in existence,

[GitHub] [couchdb] ermouth commented on pull request #3038: feat: per-document-access

2020-07-29 Thread GitBox
ermouth commented on pull request #3038: URL: https://github.com/apache/couchdb/pull/3038#issuecomment-665578748 This is great, gratz! One question: it’s not clear to me how /_security response will look for buckets having access restrictions, is there a special field for those

[GitHub] [couchdb-documentation] flimzy merged pull request #577: fix(api): Fix typo in ddoc/views.rst

2020-07-29 Thread GitBox
flimzy merged pull request #577: URL: https://github.com/apache/couchdb-documentation/pull/577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [couchdb] rnewson merged pull request #3045: Prototype/fdb layer ebtree enhancements

2020-07-29 Thread GitBox
rnewson merged pull request #3045: URL: https://github.com/apache/couchdb/pull/3045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [couchdb] iilyak commented on a change in pull request #3031: Clean up logs

2020-07-29 Thread GitBox
iilyak commented on a change in pull request #3031: URL: https://github.com/apache/couchdb/pull/3031#discussion_r462317114 ## File path: src/couch_mrview/src/couch_mrview_index.erl ## @@ -324,3 +325,14 @@ update_local_purge_doc(Db, State, PSeq) -> BaseDoc

[GitHub] [couchdb-documentation] rnewson opened a new pull request #578: Persistent cookies accurate description

2020-07-29 Thread GitBox
rnewson opened a new pull request #578: URL: https://github.com/apache/couchdb-documentation/pull/578 ## Testing recommendations Accurately describe what persistent_cookies = true does. ## GitHub issue number N/A ## Related Pull Requests N/A ##

[GitHub] [couchdb-pkg] sklassen closed pull request #68: A template for compiling under feature/core20

2020-07-29 Thread GitBox
sklassen closed pull request #68: URL: https://github.com/apache/couchdb-pkg/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [couchdb-ibrowse] tonysun83 commented on a change in pull request #4: Strip sensitive data from state

2020-07-29 Thread GitBox
tonysun83 commented on a change in pull request #4: URL: https://github.com/apache/couchdb-ibrowse/pull/4#discussion_r461852905 ## File path: src/ibrowse_http_client.erl ## @@ -268,10 +269,46 @@ terminate(_Reason, State) -> code_change(_OldVsn, State, _Extra) -> {ok,

[GitHub] [couchdb] tonysun83 removed a comment on pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
tonysun83 removed a comment on pull request #3043: URL: https://github.com/apache/couchdb/pull/3043#issuecomment-665196787 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [couchdb] iilyak commented on a change in pull request #3031: Clean up logs

2020-07-29 Thread GitBox
iilyak commented on a change in pull request #3031: URL: https://github.com/apache/couchdb/pull/3031#discussion_r461756723 ## File path: src/setup/src/setup_httpd.erl ## @@ -173,3 +173,8 @@ get_body(Req) -> couch_log:notice("Body Fail: ~p~n", [Else]),

[GitHub] [couchdb] nickva commented on a change in pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
nickva commented on a change in pull request #3043: URL: https://github.com/apache/couchdb/pull/3043#discussion_r461784853 ## File path: src/couch_views/src/couch_views_indexer.erl ## @@ -407,17 +408,26 @@ fetch_docs(Db, Changes) -> } end, #{},

[GitHub] [couchdb-docker] wohali commented on pull request #187: Combined CouchDB / Clouseau dockerfile

2020-07-29 Thread GitBox
wohali commented on pull request #187: URL: https://github.com/apache/couchdb-docker/pull/187#issuecomment-665366827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [couchdb] DQvsRA commented on issue #1540: Streaming API for attachment data

2020-07-29 Thread GitBox
DQvsRA commented on issue #1540: URL: https://github.com/apache/couchdb/issues/1540#issuecomment-665141823 I'm Interested in the progress of the feature. This is an automated message from the Apache Git Service. To respond

[GitHub] [couchdb] nickva commented on pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
nickva commented on pull request #3043: URL: https://github.com/apache/couchdb/pull/3043#issuecomment-665220158 @garrensmith This is a nice feature! See a minor comment about keymember vs keyfind and value checking. Then perhaps we could add is a eunit test to maintain test

[GitHub] [couchdb] tonysun83 edited a comment on pull request #3031: Clean up logs

2020-07-29 Thread GitBox
tonysun83 edited a comment on pull request #3031: URL: https://github.com/apache/couchdb/pull/3031#issuecomment-665280532 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [couchdb] tonysun83 commented on a change in pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
tonysun83 commented on a change in pull request #3043: URL: https://github.com/apache/couchdb/pull/3043#discussion_r461688953 ## File path: src/couch_views/src/couch_views_indexer.erl ## @@ -407,17 +408,27 @@ fetch_docs(Db, Changes) -> } end, #{},

[GitHub] [couchdb-docker] grapevineai commented on pull request #187: Combined CouchDB / Clouseau dockerfile

2020-07-29 Thread GitBox
grapevineai commented on pull request #187: URL: https://github.com/apache/couchdb-docker/pull/187#issuecomment-665363895 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [couchdb] nickva merged pull request #3044: Use _scheduler/jobs instead of _active_tasks in replication Elixir tests

2020-07-29 Thread GitBox
nickva merged pull request #3044: URL: https://github.com/apache/couchdb/pull/3044 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [couchdb] tonysun83 commented on pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
tonysun83 commented on pull request #3043: URL: https://github.com/apache/couchdb/pull/3043#issuecomment-665192290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [couchdb] garrensmith opened a new pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
garrensmith opened a new pull request #3043: URL: https://github.com/apache/couchdb/pull/3043 ## Overview Add support for the `_local_seq` option to views https://docs.couchdb.org/en/stable/api/ddoc/views.html#view-options ## Testing recommendations `make

[GitHub] [couchdb] tonysun83 commented on pull request #3031: Clean up logs

2020-07-29 Thread GitBox
tonysun83 commented on pull request #3031: URL: https://github.com/apache/couchdb/pull/3031#issuecomment-665280532 I think shortening the complex terms is the right approach. Similar to what I wrote in the other PR about more meaningful output, I was thinking if providing a length(Term)

[GitHub] [couchdb] tonysun83 commented on a change in pull request #3031: Clean up logs

2020-07-29 Thread GitBox
tonysun83 commented on a change in pull request #3031: URL: https://github.com/apache/couchdb/pull/3031#discussion_r461326057 ## File path: src/setup/src/setup_httpd.erl ## @@ -173,3 +173,8 @@ get_body(Req) -> couch_log:notice("Body Fail: ~p~n", [Else]),

[GitHub] [couchdb] tonysun83 commented on pull request #3044: Use _scheduler/jobs instead of _active_tasks in replication Elixir tests

2020-07-29 Thread GitBox
tonysun83 commented on pull request #3044: URL: https://github.com/apache/couchdb/pull/3044#issuecomment-665266462 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [couchdb] nickva opened a new pull request #3044: Use _scheduler/jobs instead of _active_tasks in replication Elixir tests

2020-07-29 Thread GitBox
nickva opened a new pull request #3044: URL: https://github.com/apache/couchdb/pull/3044 After _active_tasks was implemented on FDB, single-node (previous) _active_tasks implementation, had stopped working. It turns out were were relying on it to run Elixir replication tests.

[GitHub] [couchdb] garrensmith commented on pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
garrensmith commented on pull request #3043: URL: https://github.com/apache/couchdb/pull/3043#issuecomment-665195781 thanks @tonysun83 I've made the fix. This is an automated message from the Apache Git Service. To respond

[GitHub] [couchdb-ibrowse] iilyak commented on a change in pull request #4: Strip sensitive data from state

2020-07-29 Thread GitBox
iilyak commented on a change in pull request #4: URL: https://github.com/apache/couchdb-ibrowse/pull/4#discussion_r461779688 ## File path: src/ibrowse_http_client.erl ## @@ -268,10 +269,46 @@ terminate(_Reason, State) -> code_change(_OldVsn, State, _Extra) -> {ok,

[GitHub] [couchdb] ermouth edited a comment on pull request #3038: feat: per-document-access

2020-07-29 Thread GitBox
ermouth edited a comment on pull request #3038: URL: https://github.com/apache/couchdb/pull/3038#issuecomment-665578748 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [couchdb] rnewson opened a new pull request #3045: Prototype/fdb layer ebtree enhancements

2020-07-29 Thread GitBox
rnewson opened a new pull request #3045: URL: https://github.com/apache/couchdb/pull/3045 ## Overview This PR adds inclusive_start / inclusive_end options for reduce and group_reduce. Included in this work is a change to the expected result of any custom collate_fun in order

[GitHub] [couchdb] garrensmith commented on a change in pull request #3043: add local_seq option to views

2020-07-29 Thread GitBox
garrensmith commented on a change in pull request #3043: URL: https://github.com/apache/couchdb/pull/3043#discussion_r462127734 ## File path: src/couch_views/src/couch_views_indexer.erl ## @@ -407,17 +408,26 @@ fetch_docs(Db, Changes) -> } end, #{},