[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204155467 Not a bad idea. I'd not try and add it to the current replicator though as there are way too many sharp corners with the HTTP stuff for us to trip up on

[jira] [Resolved] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

[ https://issues.apache.org/jira/browse/COUCHDB-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Vatamaniuc resolved COUCHDB-2979. -- Resolution: Fixed > Replicator manager attempts to checkpoint too frequently >

[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal

Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/676#issuecomment-204141459 The message is awesome! It seems I can delete google.com now (: --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal

GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/676 Deleting cors domain moved to modal This is part of the death-to-all-window.confirms that Justin's leading. The delete origin is now a modal. Two related things: - The cors

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user nickva commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204138765 @kxepal Yeah it seems like a decent optimization. @rnewson @davisp -- Robert, Paul, what do you think? Is this doable based on how _local

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204136297 @nickva Right. This saves you one HTTP request and makes checkpoints more often for free. However, it doesn't removes need to do PUT to _local as not

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user nickva commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204135460 @kxepal Oh interesting. I took at look and yeah PouchDB supports _bulk_docs on _local docs ( https://pouchdb.com/guides/local-documents.html ). So the

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204108936 @nickva Idea for future: I think it worth to steal the idea from PouchDB about sending checkpoint with _bulk_docs update. This is: 1) cheap 2) reduces

[GitHub] couchdb-fauxton pull request: Style update for metadata page

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-204107230 Curious. Couldn't reproduce, but I made the code a bit more defensive. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb pull request: adding velocity-react license for Fauxton

Github user benkeen closed the pull request at: https://github.com/apache/couchdb/pull/392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] couchdb pull request: adding velocity-react license for Fauxton

Github user benkeen commented on the pull request: https://github.com/apache/couchdb/pull/392#issuecomment-204100958 Merged as 1a91fe5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

[ https://issues.apache.org/jira/browse/COUCHDB-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220488#comment-15220488 ] ASF GitHub Bot commented on COUCHDB-2979: - Github user asfgit closed the pull request at:

[jira] [Commented] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

[ https://issues.apache.org/jira/browse/COUCHDB-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220487#comment-15220487 ] ASF subversion and git services commented on COUCHDB-2979: -- Commit

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user rnewson commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204082838 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-fauxton pull request: Minor fixes

GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/675 Minor fixes Three unrelated small changes: - typo fix on doc page - fix for absolute URLs for APIs setup and config pages - spacing tweak for icons on db page You can merge

[GitHub] couchdb-couch pull request: Refactor rename on delete

Github user rnewson commented on the pull request: https://github.com/apache/couchdb-couch/pull/141#issuecomment-204014583 I think this can and should be much simpler. I'm not sure where the reluctance to call `config:get` in `couch_file:delete` comes from but I don't find it

[GitHub] couchdb-fauxton pull request: Improvements for table view

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/667#issuecomment-204008207 I ran that command but don't see any new addition in the table view content for that DB. How new is that feature? Do I need to update couch? --- If your

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#discussion_r58083278 --- Diff: src/couch_replicator.erl --- @@ -76,7 +78,7 @@ target_monitor = nil, source_seq = nil, use_checkpoints =

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

GitHub user nickva opened a pull request: https://github.com/apache/couchdb-couch-replicator/pull/34 Better handling of multiple concurrent replications * Reduce checkpoint frequency from 5 to 30 seconds * Avoid calling replicator manager for ownership checks. During

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

Github user rnewson commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/34#discussion_r58082760 --- Diff: src/couch_replicator_manager.erl --- @@ -134,9 +134,14 @@ replication_error(#rep{id = {BaseId, _} = RepId}, Error) ->

[jira] [Created] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

Nick Vatamaniuc created COUCHDB-2979: Summary: Replicator manager attempts to checkpoint too frequently Key: COUCHDB-2979 URL: https://issues.apache.org/jira/browse/COUCHDB-2979 Project: CouchDB

[GitHub] couchdb-couch pull request: Refactor rename on delete

Github user rnewson commented on the pull request: https://github.com/apache/couchdb-couch/pull/141#issuecomment-203984230 This is a lot to read for something apparently simple. It's also not a refactor as it changes behaviour, so please correct the title and any comments claiming

[GitHub] couchdb-fauxton pull request: Notifications update

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203980010 I'm on chrome. It always looked jagged. On Thu, Mar 31, 2016 at 4:33 PM, Benjamin Keen wrote: > @garrensmith

[GitHub] couchdb-couch pull request: Refactor rename on delete

Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/141#issuecomment-203979341 I am +1 for this change. However since I also contributed to this work it would be nice if someone else would review it as well. --- If your project is set up

[GitHub] couchdb-couch pull request: Refactor rename on delete

Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/141#discussion_r58068950 --- Diff: src/couch_file.erl --- @@ -247,7 +247,7 @@ delete_file(FilePath) -> deleted_filename(_RootDir, Original, rename) ->

[GitHub] couchdb-fauxton pull request: Notifications update

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203966945 @garrensmith - worrying about the animation looking jagged. Did it always look jagged for you, or just now and then? You're on Chrome/FF, I guess. --- If

[GitHub] couchdb-fauxton pull request: Notifications update

Github user benkeen commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58063745 --- Diff: app/templates.js --- @@ -0,0 +1,623 @@ +this["JST"] = this["JST"] || {}; --- End diff -- Ah ok, thanks. --- If your

[jira] [Commented] (COUCHDB-2978) Stale ETags are re-used for _local docs

[ https://issues.apache.org/jira/browse/COUCHDB-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219936#comment-15219936 ] Garren Smith commented on COUCHDB-2978: --- I can take a look at this next week and get a fix in. >

[jira] [Commented] (COUCHDB-2978) Stale ETags are re-used for _local docs

[ https://issues.apache.org/jira/browse/COUCHDB-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219898#comment-15219898 ] Jan Lehnardt commented on COUCHDB-2978: --- Via IRC discussion: rnewson:I think the best fix

[GitHub] couchdb-fauxton pull request: Webpack fixes

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/674#issuecomment-203954265 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Created] (COUCHDB-2978) ETag should not be sent for _local docs

Nolan Lawson created COUCHDB-2978: - Summary: ETag should not be sent for _local docs Key: COUCHDB-2978 URL: https://issues.apache.org/jira/browse/COUCHDB-2978 Project: CouchDB Issue Type:

[GitHub] couchdb-fauxton pull request: Webpack fixes

Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/674#discussion_r58056436 --- Diff: assets/js/libs/css.escape.js --- @@ -1,84 +0,0 @@ -/*! https://mths.be/cssescape v0.2.1 by @mathias | MIT license */

[jira] [Created] (COUCHDB-2977) JavaScript and CSS files for fauxton can not be found

Patrick Palacin created COUCHDB-2977: Summary: JavaScript and CSS files for fauxton can not be found Key: COUCHDB-2977 URL: https://issues.apache.org/jira/browse/COUCHDB-2977 Project: CouchDB

[GitHub] couchdb-fauxton pull request: Style update for metadata page

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-203904853 I'm getting this error `bundle.js:135902 Uncaught TypeError: Cannot read property 'toLocaleString' of undefined` --- If your project is set up

[GitHub] couchdb-fauxton pull request: Notifications update

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203903107 This looks really cool, so awesome to see another piece of backbone disappear. Two things * The animation looks a little jagged when a notification

[GitHub] couchdb-fauxton pull request: Notifications update

Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58041150 --- Diff: app/templates.js --- @@ -0,0 +1,623 @@ +this["JST"] = this["JST"] || {}; --- End diff -- This file shouldn't be here.

[GitHub] couchdb pull request: adding velocity-react license for Fauxton

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/392#issuecomment-203895791 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature