[GitHub] nickva edited a comment on issue #1619: Implement replicator forced session refresh

2018-10-02 Thread GitBox
nickva edited a comment on issue #1619: Implement replicator forced session refresh URL: https://github.com/apache/couchdb/pull/1619#issuecomment-426317032 Hmm cookies only get an expiration header if allow_persistent is enabled and it's not by default. ``` $curl -c

[GitHub] Antonio-Maranhao closed pull request #1126: Sidebar redux refactoring

2018-10-02 Thread GitBox
Antonio-Maranhao closed pull request #1126: Sidebar redux refactoring URL: https://github.com/apache/couchdb-fauxton/pull/1126 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] nickva commented on issue #323: Update purging.rst

2018-10-02 Thread GitBox
nickva commented on issue #323: Update purging.rst URL: https://github.com/apache/couchdb-documentation/pull/323#issuecomment-426426376 Good catch. Thank you for your contribution, @zacharylawson ! Would you mind rebasing on the latest master and then we'll merge the PR

[GitHub] nickva closed pull request #334: added missing semicolon in code example list

2018-10-02 Thread GitBox
nickva closed pull request #334: added missing semicolon in code example list URL: https://github.com/apache/couchdb-documentation/pull/334 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] nickva commented on issue #334: added missing semicolon in code example list

2018-10-02 Thread GitBox
nickva commented on issue #334: added missing semicolon in code example list URL: https://github.com/apache/couchdb-documentation/pull/334#issuecomment-426423803 Thank you! +1 This is an automated message from the

[Jenkins] FAILURE: CouchDB » master #351

2018-10-02 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/351/

[GitHub] nickva closed pull request #1631: Do not crash replicator on VDU function failure

2018-10-02 Thread GitBox
nickva closed pull request #1631: Do not crash replicator on VDU function failure URL: https://github.com/apache/couchdb/pull/1631 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jaydoane commented on issue #1631: Do not crash replicator on VDU function failure

2018-10-02 Thread GitBox
jaydoane commented on issue #1631: Do not crash replicator on VDU function failure URL: https://github.com/apache/couchdb/pull/1631#issuecomment-426399744 LGTM ``` $ make eunit skip_deps+=couch_epi apps=couch_replicator suites=couch_replicator_docs

[GitHub] sklassen commented on issue #27: vm.args is now editable -- enabling clusters; snap set works for name and cookie

2018-10-02 Thread GitBox
sklassen commented on issue #27: vm.args is now editable -- enabling clusters; snap set works for name and cookie URL: https://github.com/apache/couchdb-pkg/pull/27#issuecomment-426395077 Hi @wohali I found this example of a docker build.sh file that will install snapd and a snap

[Jenkins] FAILURE: CouchDB » master #350

2018-10-02 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/350/

[GitHub] wohali commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-10-02 Thread GitBox
wohali commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-426364080 @ermouth Thanks for the patch!! This is an automated message from the Apache Git

[GitHub] wohali closed issue #1612: JS-rewritten post/put hangs or returns bad_request

2018-10-02 Thread GitBox
wohali closed issue #1612: JS-rewritten post/put hangs or returns bad_request URL: https://github.com/apache/couchdb/issues/1612 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wohali closed pull request #1620: 1612 fix, js-rewritten PUTs now work

2018-10-02 Thread GitBox
wohali closed pull request #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[Jenkins] FAILURE: CouchDB » master #349

2018-10-02 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/349/

[GitHub] machinaeXphilip opened a new pull request #334: added missing semicolon in code example list

2018-10-02 Thread GitBox
machinaeXphilip opened a new pull request #334: added missing semicolon in code example list URL: https://github.com/apache/couchdb-documentation/pull/334 missing semicolon before while loop. ##Overview added missing semicolon before while loop in code example for list functions

[GitHub] wohali commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-10-02 Thread GitBox
wohali commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-426345421 @ermouth thanks, I'll just update the branch to master's latest and re-run them. Test suite can be a bit touchy sometimes, it's an endless battle to

[GitHub] ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-10-02 Thread GitBox
ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-426337601 @wohali I added small test, but see failed CI. What should I do with this? Seems CI fails on smth completely unrelated to rewrites.

[GitHub] nickva closed pull request #1627: Switch rexi server_per_node to true by default

2018-10-02 Thread GitBox
nickva closed pull request #1627: Switch rexi server_per_node to true by default URL: https://github.com/apache/couchdb/pull/1627 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] nickva closed issue #1625: Default rexi_per_server to true

2018-10-02 Thread GitBox
nickva closed issue #1625: Default rexi_per_server to true URL: https://github.com/apache/couchdb/issues/1625 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] bleveque opened a new issue #333: Update uuid config documentation

2018-10-02 Thread GitBox
bleveque opened a new issue #333: Update uuid config documentation URL: https://github.com/apache/couchdb-documentation/issues/333 I've been advised that all nodes in a cluster should be given the same UUID, but the description of the `uuid` setting in the

[GitHub] popojargo closed issue #333: Update uuid config documentation

2018-10-02 Thread GitBox
popojargo closed issue #333: Update uuid config documentation URL: https://github.com/apache/couchdb-documentation/issues/333 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] nickva commented on issue #1619: Implement replicator forced session refresh

2018-10-02 Thread GitBox
nickva commented on issue #1619: Implement replicator forced session refresh URL: https://github.com/apache/couchdb/pull/1619#issuecomment-426317032 Hmm cookies only get an expiration header if allow_persistent is enabled and it's not by default. ``` $curl -c /tmp/cdb.cookies -H

[Jenkins] FAILURE: CouchDB » master #348

2018-10-02 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/348/

[GitHub] nickva commented on issue #1619: Implement replicator forced session refresh

2018-10-02 Thread GitBox
nickva commented on issue #1619: Implement replicator forced session refresh URL: https://github.com/apache/couchdb/pull/1619#issuecomment-426305108 Good points. Yeah a hard cookie expire would be an ideal solution. And I had also forgotten about the expired header which would still be

[GitHub] rnewson edited a comment on issue #1619: Implement replicator forced session refresh

2018-10-02 Thread GitBox
rnewson edited a comment on issue #1619: Implement replicator forced session refresh URL: https://github.com/apache/couchdb/pull/1619#issuecomment-426302320 I'm -0 on this. It doesn't properly fix the problem we introduced when we taught the replicator to acquire session cookies if the

[GitHub] rnewson commented on issue #1619: Implement replicator forced session refresh

2018-10-02 Thread GitBox
rnewson commented on issue #1619: Implement replicator forced session refresh URL: https://github.com/apache/couchdb/pull/1619#issuecomment-426302320 I'm +0 on this. It doesn't properly fix the problem we introduced when we taught the replicator to acquire session cookies if the user has

[GitHub] garrensmith closed pull request #1615: Add /_partition/:partition/_info endpoint

2018-10-02 Thread GitBox
garrensmith closed pull request #1615: Add /_partition/:partition/_info endpoint URL: https://github.com/apache/couchdb/pull/1615 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] garrensmith commented on issue #1615: Add /_partition/:partition/_info endpoint

2018-10-02 Thread GitBox
garrensmith commented on issue #1615: Add /_partition/:partition/_info endpoint URL: https://github.com/apache/couchdb/pull/1615#issuecomment-426294219 This is merged into the partitions branch. This is an automated message

[GitHub] bleveque opened a new issue #333: Update uuid config documentation

2018-10-02 Thread GitBox
bleveque opened a new issue #333: Update uuid config documentation URL: https://github.com/apache/couchdb-documentation/issues/333 I've been advised that all nodes in a cluster should be given the same UUID, but the description of the `uuid` setting in the

[GitHub] nickva closed pull request #1635: Avoid restarting /_replicate jobs if parameters haven't changed

2018-10-02 Thread GitBox
nickva closed pull request #1635: Avoid restarting /_replicate jobs if parameters haven't changed URL: https://github.com/apache/couchdb/pull/1635 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[Jenkins] FAILURE: CouchDB » master #347

2018-10-02 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/347/

[GitHub] garrensmith commented on a change in pull request #1615: Add /_partition/:partition/_info endpoint

2018-10-02 Thread GitBox
garrensmith commented on a change in pull request #1615: Add /_partition/:partition/_info endpoint URL: https://github.com/apache/couchdb/pull/1615#discussion_r221931592 ## File path: src/couch/src/couch_db_engine.erl ## @@ -43,10 +43,10 @@ -type epochs() ::

[GitHub] garrensmith closed pull request #1129: VerifyInstall Redux refactoring

2018-10-02 Thread GitBox
garrensmith closed pull request #1129: VerifyInstall Redux refactoring URL: https://github.com/apache/couchdb-fauxton/pull/1129 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] nickva closed pull request #1636: Improve connection cleanup in replication connection pool

2018-10-02 Thread GitBox
nickva closed pull request #1636: Improve connection cleanup in replication connection pool URL: https://github.com/apache/couchdb/pull/1636 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] garrensmith commented on issue #124: `then` and `catch` both called

2018-10-02 Thread GitBox
garrensmith commented on issue #124: `then` and `catch` both called URL: https://github.com/apache/couchdb-nano/issues/124#issuecomment-426210343 Thanks for reporting @j3k0 we will take a look This is an automated message

[GitHub] rnewson commented on a change in pull request #1615: Add /_partition/:partition/_info endpoint

2018-10-02 Thread GitBox
rnewson commented on a change in pull request #1615: Add /_partition/:partition/_info endpoint URL: https://github.com/apache/couchdb/pull/1615#discussion_r221876635 ## File path: src/couch/src/couch_db_engine.erl ## @@ -43,10 +43,10 @@ -type epochs() :: [{Node::atom(),

[GitHub] j3k0 opened a new issue #124: `then` and `catch` both called

2018-10-02 Thread GitBox
j3k0 opened a new issue #124: `then` and `catch` both called URL: https://github.com/apache/couchdb-nano/issues/124 ## Expected Behavior * When using promises ; * When `db.get` returns 404 (because the document is missing) ; * Then I expect **either of** `.then` or `.catch`