[GitHub] Antonio-Maranhao closed pull request #1142: Update fauxton/navigation to use redux

2018-10-15 Thread GitBox
Antonio-Maranhao closed pull request #1142: Update fauxton/navigation to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1142 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jaydoane commented on a change in pull request #1629: handle db deletion in load validation funs

2018-10-15 Thread GitBox
jaydoane commented on a change in pull request #1629: handle db deletion in load validation funs URL: https://github.com/apache/couchdb/pull/1629#discussion_r225330673 ## File path: src/couch/test/couchdb_db_tests.erl ## @@ -0,0 +1,81 @@ +% Licensed under the Apache

[GitHub] jaydoane commented on a change in pull request #1629: handle db deletion in load validation funs

2018-10-15 Thread GitBox
jaydoane commented on a change in pull request #1629: handle db deletion in load validation funs URL: https://github.com/apache/couchdb/pull/1629#discussion_r225345843 ## File path: src/ddoc_cache/test/ddoc_cache_open_test.erl ## @@ -0,0 +1,98 @@ +% Licensed under the

[GitHub] jaydoane commented on issue #1629: handle db deletion in load validation funs

2018-10-15 Thread GitBox
jaydoane commented on issue #1629: handle db deletion in load validation funs URL: https://github.com/apache/couchdb/pull/1629#issuecomment-430047024 Comparing ``` $ make eunit skip_tests+=couch_epep apps=couch suites=couchdb_db_tests module 'couchdb_db_tests' Checking

[GitHub] iilyak opened a new pull request #1655: Fix ets_lru configuration in chttpd application

2018-10-15 Thread GitBox
iilyak opened a new pull request #1655: Fix ets_lru configuration in chttpd application URL: https://github.com/apache/couchdb/pull/1655 ## Overview The code was incorrect in a sense that it was using is_integer guard, while `config:get` cannot return integer. ## Testing

[GitHub] Antonio-Maranhao opened a new pull request #1142: Update fauxton/navigation to use redux

2018-10-15 Thread GitBox
Antonio-Maranhao opened a new pull request #1142: Update fauxton/navigation to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1142 ## Overview Update fauxton/notifications to use redux. ## Testing recommendations - Expand / collapse the navbar -

[GitHub] popojargo commented on a change in pull request #1137: Validate regex on client side.

2018-10-15 Thread GitBox
popojargo commented on a change in pull request #1137: Validate regex on client side. URL: https://github.com/apache/couchdb-fauxton/pull/1137#discussion_r225313780 ## File path: app/addons/documents/mango/components/MangoQueryEditor.js ## @@ -130,16 +131,54 @@ export

[GitHub] Antonio-Maranhao closed pull request #1139: Update fauxton/notifications to use redux

2018-10-15 Thread GitBox
Antonio-Maranhao closed pull request #1139: Update fauxton/notifications to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1139 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] garrensmith closed pull request #1141: Convert activetasks to redux

2018-10-15 Thread GitBox
garrensmith closed pull request #1141: Convert activetasks to redux URL: https://github.com/apache/couchdb-fauxton/pull/1141 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[Jenkins] FAILURE: CouchDB ยป master #357

2018-10-15 Thread Apache Jenkins Server
Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/357/

[GitHub] Antonio-Maranhao closed pull request #1138: Update config addon to use redux

2018-10-15 Thread GitBox
Antonio-Maranhao closed pull request #1138: Update config addon to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1138 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rnewson closed pull request #1654: Test correct condition for exceed_limit error

2018-10-15 Thread GitBox
rnewson closed pull request #1654: Test correct condition for exceed_limit error URL: https://github.com/apache/couchdb/pull/1654 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] janl commented on issue #1653: Slow reads when view indexes generating

2018-10-15 Thread GitBox
janl commented on issue #1653: Slow reads when view indexes generating URL: https://github.com/apache/couchdb/issues/1653#issuecomment-429956345 How are you measuring request time? And what numbers are you getting with and without indexing/inserting?

[GitHub] wohali commented on a change in pull request #1137: Validate regex on client side.

2018-10-15 Thread GitBox
wohali commented on a change in pull request #1137: Validate regex on client side. URL: https://github.com/apache/couchdb-fauxton/pull/1137#discussion_r225258275 ## File path: app/addons/documents/mango/components/MangoQueryEditor.js ## @@ -130,16 +131,54 @@ export

[GitHub] popojargo commented on issue #1137: Validate regex on client side.

2018-10-15 Thread GitBox
popojargo commented on issue #1137: Validate regex on client side. URL: https://github.com/apache/couchdb-fauxton/pull/1137#issuecomment-429919344 @wohali Will pointed out a good point for the regex validation. Should we fix the error formatting at the server side instead?

[GitHub] Antonio-Maranhao closed pull request #1134: Update documents/changes to use redux

2018-10-15 Thread GitBox
Antonio-Maranhao closed pull request #1134: Update documents/changes to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rnewson opened a new pull request #1654: Test correct condition for exceed_limit error

2018-10-15 Thread GitBox
rnewson opened a new pull request #1654: Test correct condition for exceed_limit error URL: https://github.com/apache/couchdb/pull/1654 Previously we were testing if Pos + TotalBytes exceeded the pread limit. This is the wrong logic entirely. We are trying to prevent an attempted

[GitHub] Antonio-Maranhao commented on a change in pull request #1141: Convert activetasks to redux

2018-10-15 Thread GitBox
Antonio-Maranhao commented on a change in pull request #1141: Convert activetasks to redux URL: https://github.com/apache/couchdb-fauxton/pull/1141#discussion_r225173629 ## File path: app/addons/activetasks/actions.js ## @@ -9,72 +9,79 @@ // WARRANTIES OR CONDITIONS OF

[GitHub] jasons316 opened a new issue #1653: Slow reads when view indexes generating

2018-10-15 Thread GitBox
jasons316 opened a new issue #1653: Slow reads when view indexes generating URL: https://github.com/apache/couchdb/issues/1653 I don't know if this is the right place to ask this, but we are currently getting issues when data is being inserted, or view indexes are being built. During this

[jira] [Commented] (COUCHDB-3326) Implement clustered purge API: _purge

2018-10-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650099#comment-16650099 ] ASF subversion and git services commented on COUCHDB-3326: -- Commit

[GitHub] garrensmith commented on a change in pull request #1138: Update config addon to use redux

2018-10-15 Thread GitBox
garrensmith commented on a change in pull request #1138: Update config addon to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1138#discussion_r225109574 ## File path: app/addons/config/__tests__/components.test.js ## @@ -10,85 +10,117 @@ // License for

[GitHub] garrensmith commented on a change in pull request #1139: Update fauxton/notifications to use redux

2018-10-15 Thread GitBox
garrensmith commented on a change in pull request #1139: Update fauxton/notifications to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1139#discussion_r225108133 ## File path: app/addons/fauxton/notifications/components/GlobalNotifications.js ## @@ -0,0

[GitHub] garrensmith commented on a change in pull request #1139: Update fauxton/notifications to use redux

2018-10-15 Thread GitBox
garrensmith commented on a change in pull request #1139: Update fauxton/notifications to use redux URL: https://github.com/apache/couchdb-fauxton/pull/1139#discussion_r225107785 ## File path: app/addons/fauxton/notifications/__tests__/permanentNotification.test.js ## @@

[GitHub] garrensmith opened a new pull request #1141: Convert activetasks to redux

2018-10-15 Thread GitBox
garrensmith opened a new pull request #1141: Convert activetasks to redux URL: https://github.com/apache/couchdb-fauxton/pull/1141 ## Overview Convert active tasks to use redux ## Testing recommendations Create some active tasks. Checkout the active tasks tab. Make sure