[GitHub] pierrekilly commented on issue #749: couch_peruser is broken in 2.1.0

2017-10-18 Thread GitBox
pierrekilly commented on issue #749: couch_peruser is broken in 2.1.0
URL: https://github.com/apache/couchdb/issues/749#issuecomment-337585148
 
 
   I have found a workaround:
   
   As setting the `couch_peruser` to `true` from Fauxton works well, I simply 
activate it "by hand" after the DB is started.
   
   In the script that starts the DB, I wait 10 seconds (to leave some time to 
the DB to start) and then:
   ```
   curl \
   -X PUT \
   --user "${adminUser}:${adminPass}" \
   --data '"true"' \
   "http://localhost:5984/_node/nonode@nohost/_config/couch_peruser/enable";
   ```
   (The admin username and password are taken from env variables in my case)
   
   Hope this helps!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #749: couch_peruser is broken in 2.1.0

2017-10-18 Thread GitBox
wohali commented on issue #749: couch_peruser is broken in 2.1.0
URL: https://github.com/apache/couchdb/issues/749#issuecomment-337619907
 
 
   There's a lot more wrong with couch_peruser in 2.1.0 - I strongly recommend 
you wait for our imminent 2.1.1 release before using this feature.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dwbentley opened a new issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-18 Thread GitBox
dwbentley opened a new issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901
 
 
   
   
   ## Expected Behavior
   Commenting the following from the default.ini
   `[daemons]`
   `httpd={couch_httpd, start_link, []}`
Disables HTTP access
   
   ## Current Behavior
   Commenting that line has no effect on HTTP access
   
   ## Possible Solution
   
   
   
   ## Steps to Reproduce (for bugs)
   
   
   1. Start CouchDB
   2. Use command line tool (Curl this instance): curl "http://localhost:5984";
   3. Receive the CouchDB welcome return
   4. Stop CouchDB
   5. Comment out above line within defaul.ini
   6. Start CouchDB
   7. Use command line tool (Curl this instance): curl "http://localhost:5984";
   8. Receive CouchDB welcome return
   
   This should have returned host unreachable.
   
   ## Context
   
   
   Running CouchDB in an environment with a requirement to ONLY use HTTPS for 
web based API puts us in a delinquent state in regards to environment network 
security.
   
   ## Your Environment
   
   * Version used: 2.0.1
   * Browser Name and version: Chrome and Edge
   * Operating System and version (desktop or mobile): Windows 10
   * Link to your project:
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new pull request #902: Update 2.1.x with all changes on master to date

2017-10-18 Thread GitBox
wohali opened a new pull request #902: Update 2.1.x with all changes on master 
to date
URL: https://github.com/apache/couchdb/pull/902
 
 
   As nothing appears to have landed on master that could break 2.1.0, I 
propose doing a straightforward rebase of 2.1.x with the contents of master. 
This is 120 commits on this repo.
   
   Please review this PR and give your +1/0/-1. I will not "click the big green 
button" on GH to make this merge, but instead will do either a `git rebase` or 
a `git merge --no-ff` from the CLI and close this out by hand. (If you have a 
strong preference for either approach, let me know.)
   
   If this lands, I will request a release/tag of Fauxton, docs, and any other 
dependencies that have updated in the interim.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] nickva commented on issue #902: Update 2.1.x with all changes on master to date

2017-10-18 Thread GitBox
nickva commented on issue #902: Update 2.1.x with all changes on master to date
URL: https://github.com/apache/couchdb/pull/902#issuecomment-337745379
 
 
   +1
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new issue #903: Aggregate stats for all nodes

2017-10-18 Thread GitBox
wohali opened a new issue #903: Aggregate stats for all nodes
URL: https://github.com/apache/couchdb/issues/903
 
 
   Continuing from #810:
   
   > Replications will uniformly pick one node in the cluster to run on which 
doesn't have to be the node which processed the document update request. To 
detect the crashed stats update would have to know which node to check for 
changes. I made this mistake so mentioning it here just in case. Perhaps there 
is a case there in general for aggregating stats for all nodes.
   
   /cc @nickva 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-18 Thread GitBox
dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-337749971
 
 
   Tomorrow I will install 2.0 and follow up with the results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new pull request #177: Add 2.1.1 release notes

2017-10-18 Thread GitBox
wohali opened a new pull request #177: Add 2.1.1 release notes
URL: https://github.com/apache/couchdb-documentation/pull/177
 
 
   Also moved the upgrade notes to the start to be more consistent with 
previous release note formatting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-18 Thread GitBox
flimzy commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145611698
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
+  returned if volumes are mounted containing whitespace in their name. This
+  problem surfaced primarily on macOS (Time Machine volumes). CouchDB now
+  works around this bug in unpatched versions of Erlang by skipping the free
+  space check performed by the compaction daemon. Erlang itself will
+  correctly perform free space checks in version 21.0.
+
+* The Dockerfile in the source repository has been retired. For a current
+  Dockerfile, see the ``couchdb-docker`` repository.
 
 Review comment:
   Can we include a link here, too?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-18 Thread GitBox
flimzy commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145611145
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
 
 Review comment:
   *incur


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-18 Thread GitBox
flimzy commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145611536
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
 
 Review comment:
   Would it be possible to make `ERL-343` a link to the Erlang bug?  Maybe just 
a nice-to-have for anyone seeking more info.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-18 Thread GitBox
flimzy commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145611089
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
 
 Review comment:
   *the replicator


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-18 Thread GitBox
flimzy commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145611203
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
 
 Review comment:
   s/switching using/using the/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-18 Thread GitBox
flimzy commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145612098
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
+  returned if volumes are mounted containing whitespace in their name. This
+  problem surfaced primarily on macOS (Time Machine volumes). CouchDB now
+  works around this bug in unpatched versions of Erlang by skipping the free
+  space check performed by the compaction daemon. Erlang itself will
+  correctly perform free space checks in version 21.0.
+
+* The Dockerfile in the source repository has been retired. For a current
+  Dockerfile, see the ``couchdb-docker`` repository.
+
+Performance
+---
+
+* :ghissue:`835`: CouchDB now no longer decompresses documents just to
+  determine their uncompressed size. In tests, this has lead to improvements
+  between 10-40% in both CPU and wall-clock time for database compaction.
+
+* The design document cache (``ddoc_cache``) has been rewritten to improve
+  performance.
+
+Mango
+-
+
+* :ghissue:`740`: Mango queries can now be paginated. Each query response
+  includes a bookmark.  The bookmark can be provided on a subsequent query to
+  continue from a specific key.
+
+* :ghissue:`768`: Mango ``_find`` accepts an ``execution_stats``
+  parameter. If present, a new object is included in the response which
+  contains information about the query executed. The object contains the
+  count of total keys examined (0 for json indexes), total documents
+  examined (when ``include_docs=true`` is used), and the total quorum
+  documents examined (when fabric doc lookups are used).
+
+* :ghissue:`816` and :ghissue:`866`: Mango now requires that all of the fields
+  in a candidate index must exist in a query's selector. Previously, this check
+  was incorrect, and indexes that might only contain a subset of valid
+  documents might be selected by the query planner if an explicit index was not
+  specified at query time. Further, if a sort field is specified at query time,
+  that field needs to exist (but could be null) in the results returned.
+
+Other
+-
+
+The 2.1.1 release also includes the following minor improvements:
+
+  * :ghissue:`635`: Stop couch_index processes on ddoc update
+  * :ghissue:`721`: Save migrated replicator checkpoint documents immediately
+  * :ghissue:`688`: Reuse http-based replicatoin checkpoints when upgrading
 
 Review comment:
   s/replicatoin/replication/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
janl commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145603733
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
+  returned if volumes are mounted containing whitespace in their name. This
+  problem surfaced primarily on macOS (Time Machine volumes). CouchDB now
+  works around this bug in unpatched versions of Erlang by skipping the free
+  space check performed by the compaction daemon. Erlang itself will
+  correctly perform free space checks in version 21.0.
+
+* The Dockerfile in the source repository has been retired. For a current
+  Dockerfile, see the ``couchdb-docker`` repository.
+
+Performance
+---
+
+* :ghissue:`835`: CouchDB now no longer decompresses documents just to
+  determine their uncompressed size. In tests, this has lead to improvements
+  between 10-40% in both CPU and wall-clock time for database compaction.
+
+* The design document cache (``ddoc_cache``) has been rewritten to improve
+  performance.
+
+Mango
+-
+
+* :ghissue:`740`: Mango queries can now be paginated. Each query response
+  includes a bookmark.  The bookmark can be provided on a subsequent query to
+  continue from a specific key.
+
+* :ghissue:`768`: Mango ``_find`` accepts an ``execution_stats``
+  parameter. If present, a new object is included in the response which
+  contains information about the query executed. The object contains the
+  count of total keys examined (0 for json indexes), total documents
+  examined (when ``include_docs=true`` is used), and the total quorum
+  documents examined (when fabric doc lookups are used).
+
+* :ghissue:`816` and :ghissue:`866`: Mango now requires that all of the fields
+  in a candidate index must exist in a query's selector. Previously, this check
+  was incorrect, and indexes that might only contain a subset of valid
+  documents might be selected by the query planner if an explicit index was not
+  specified at query time. Further, if a sort field is specified at query time,
+  that field needs to exist (but could be null) in the results returned.
+
+Other
+-
+
+The 2.1.1 release also includes the following minor improvements:
+
+  * :ghissue:`635`: Stop couch_index processes on ddoc update
+  * :ghissue:`721`: Save migrated replicator checkpoint documents immediately
+  * :ghissue:`688`: Reuse http-based replicatoin checkpoints when upgrading
+to https
+  * :ghissue:`729`: Recommend the use only of ``-name`` and not ``-sname`` in
+`vm.args` for compatibility.
+  * :ghissue:`738`: Allow replicator application to always update replicator
+docs.
+  * :ghissue:`605`: Add ``Prefer: return=minimal`` header options from
+RFC7240 to reduce the number of headers in the response.
+  * :ghissue:`744`: Allow a 503 response to be returned to clients (with
+metric support)
+  * :ghissue:`746`: Log additional information on crashes from rexi
+  * :ghissue:`752`: Allow Mango $in queries without requiring the index to
+use an array
+  * (multiple) Additional debugging utilities have been added.
+  * (multiple) Hot code upgrades from 2.0 -> 2.1.1 are now possible.
+  * (multip

[GitHub] janl commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
janl commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145603636
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
+  returned if volumes are mounted containing whitespace in their name. This
+  problem surfaced primarily on macOS (Time Machine volumes). CouchDB now
+  works around this bug in unpatched versions of Erlang by skipping the free
+  space check performed by the compaction daemon. Erlang itself will
+  correctly perform free space checks in version 21.0.
+
+* The Dockerfile in the source repository has been retired. For a current
+  Dockerfile, see the ``couchdb-docker`` repository.
+
+Performance
+---
+
+* :ghissue:`835`: CouchDB now no longer decompresses documents just to
+  determine their uncompressed size. In tests, this has lead to improvements
+  between 10-40% in both CPU and wall-clock time for database compaction.
+
+* The design document cache (``ddoc_cache``) has been rewritten to improve
+  performance.
+
+Mango
+-
+
+* :ghissue:`740`: Mango queries can now be paginated. Each query response
+  includes a bookmark.  The bookmark can be provided on a subsequent query to
+  continue from a specific key.
+
+* :ghissue:`768`: Mango ``_find`` accepts an ``execution_stats``
+  parameter. If present, a new object is included in the response which
+  contains information about the query executed. The object contains the
+  count of total keys examined (0 for json indexes), total documents
+  examined (when ``include_docs=true`` is used), and the total quorum
+  documents examined (when fabric doc lookups are used).
+
+* :ghissue:`816` and :ghissue:`866`: Mango now requires that all of the fields
+  in a candidate index must exist in a query's selector. Previously, this check
+  was incorrect, and indexes that might only contain a subset of valid
+  documents might be selected by the query planner if an explicit index was not
 
 Review comment:
   ? would rephrase for clarity: ?if no explicit?? instead of ?if an 
explicit?was not found?.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
janl commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145603481
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
 
 Review comment:
   Add GH issue number 756 it?s a PR, but issues and PRs are numbered un 
unison, and GH does redirects in either direction.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] willholley commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
willholley commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145641644
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
+  returned if volumes are mounted containing whitespace in their name. This
+  problem surfaced primarily on macOS (Time Machine volumes). CouchDB now
+  works around this bug in unpatched versions of Erlang by skipping the free
+  space check performed by the compaction daemon. Erlang itself will
+  correctly perform free space checks in version 21.0.
+
+* The Dockerfile in the source repository has been retired. For a current
+  Dockerfile, see the ``couchdb-docker`` repository.
+
+Performance
+---
+
+* :ghissue:`835`: CouchDB now no longer decompresses documents just to
+  determine their uncompressed size. In tests, this has lead to improvements
+  between 10-40% in both CPU and wall-clock time for database compaction.
+
+* The design document cache (``ddoc_cache``) has been rewritten to improve
+  performance.
+
+Mango
+-
+
+* :ghissue:`740`: Mango queries can now be paginated. Each query response
+  includes a bookmark.  The bookmark can be provided on a subsequent query to
+  continue from a specific key.
+
+* :ghissue:`768`: Mango ``_find`` accepts an ``execution_stats``
+  parameter. If present, a new object is included in the response which
+  contains information about the query executed. The object contains the
+  count of total keys examined (0 for json indexes), total documents
+  examined (when ``include_docs=true`` is used), and the total quorum
+  documents examined (when fabric doc lookups are used).
+
+* :ghissue:`816` and :ghissue:`866`: Mango now requires that all of the fields
+  in a candidate index must exist in a query's selector. Previously, this check
+  was incorrect, and indexes that might only contain a subset of valid
+  documents might be selected by the query planner if an explicit index was not
+  specified at query time. Further, if a sort field is specified at query time,
+  that field needs to exist (but could be null) in the results returned.
+
+Other
+-
+
+The 2.1.1 release also includes the following minor improvements:
+
+  * :ghissue:`635`: Stop couch_index processes on ddoc update
+  * :ghissue:`721`: Save migrated replicator checkpoint documents immediately
+  * :ghissue:`688`: Reuse http-based replicatoin checkpoints when upgrading
+to https
+  * :ghissue:`729`: Recommend the use only of ``-name`` and not ``-sname`` in
+`vm.args` for compatibility.
+  * :ghissue:`738`: Allow replicator application to always update replicator
+docs.
+  * :ghissue:`605`: Add ``Prefer: return=minimal`` header options from
+RFC7240 to reduce the number of headers in the response.
+  * :ghissue:`744`: Allow a 503 response to be returned to clients (with
+metric support)
+  * :ghissue:`746`: Log additional information on crashes from rexi
+  * :ghissue:`752`: Allow Mango $in queries without requiring the index to
+use an array
+  * (multiple) Additional debugging utilities have been added.
+  * (multiple) Hot code upgrades from 2.0 -> 2.1.1 are now possible.
+  * (

[GitHub] dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-19 Thread GitBox
dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-337879584
 
 
   Alright I tried with version 2.0 and that seems to be broken even worse. 
Once the HTTPS module is uncommented CouchDB HTTP also fails to start. Will 
this issue get any attention? Thank you for your efforts!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] koleto commented on issue #892: Building CouchDB on ARMv8

2017-10-19 Thread GitBox
koleto commented on issue #892: Building CouchDB on ARMv8
URL: https://github.com/apache/couchdb/issues/892#issuecomment-337940778
 
 
   Just manage to comile on Linaro ARMv8.
   
   1. Open the file ~/apache-couchdb-2.1.0$ vim 
src/rebar/src/rebar_port_compiler.erl
   2. Remove the '-m64' flag from Line 608 and 609. The output should be:
   ` %% Linux specific flags for multiarch
{"linux.*-64$", "CFLAGS", "$CFLAGS"},
{"linux.*-64$", "CXXFLAGS", "$CXXFLAGS"},
{"linux.*-64$", "LDFLAGS", "$LDFLAGS"},` 
   
   3. Recompile rebar:   cd src/rebar
   `./bootstrap`
   
   4. Rebuild couchdb: 
   `make release`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Antonio-Maranhao opened a new pull request #999: Fix View Attachments menu and upload modal in doc editor

2017-10-19 Thread GitBox
Antonio-Maranhao opened a new pull request #999: Fix View Attachments menu and 
upload modal in doc editor
URL: https://github.com/apache/couchdb-fauxton/pull/999
 
 
   ## Overview
   
   In the document editor: 
   - Fixes "View Attachments" dropdown menu that stopped working after removal 
of `bootstrap.js` in https://github.com/apache/couchdb-fauxton/pull/994
   - Fixes the file upload modal that was not displaying error messages.
   
   ## Testing recommendations
   
   - Click on a document to bring up the editor
   - Click on 'Upload Attachment'
  - Choose a file that starts with underscore (e.g. '_afile.txt') then 
click 'Upload Attachment'
  - The modal should show the error message: `Attachment name '_afile.txt' 
starts with prohibited character '_'`
  - Pick another file then click 'Upload Attachment'
  - Success message is displayed
  - 'View Attachements' is now visible. Click on it and select the file to 
download it.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pdxfixit opened a new pull request #178: Minor changes

2017-10-19 Thread GitBox
pdxfixit opened a new pull request #178: Minor changes
URL: https://github.com/apache/couchdb-documentation/pull/178
 
 
   Just a few minor corrections.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pdxfixit closed pull request #178: Minor changes

2017-10-19 Thread GitBox
pdxfixit closed pull request #178: Minor changes
URL: https://github.com/apache/couchdb-documentation/pull/178
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/api/database/changes.rst b/src/api/database/changes.rst
index 2a740f1..caca75f 100644
--- a/src/api/database/changes.rst
+++ b/src/api/database/changes.rst
@@ -685,7 +685,7 @@ amount of duplicated code.
 While :ref:`map functions ` doesn't process the design documents,
 using ``_view`` filter forces them to do this. You need to be sure, that
 they are ready to handle documents with *alien* structure without panic
-crush.
+crash.
 
 .. note::
 Using ``_view`` filter doesn't queries the view index files, so you cannot
diff --git a/src/cluster/setup.rst b/src/cluster/setup.rst
index 4cb6570..f8e238b 100644
--- a/src/cluster/setup.rst
+++ b/src/cluster/setup.rst
@@ -24,7 +24,7 @@ Firewall
 
 If you do not have a firewall between your servers, then you can skip this.
 
-CouchDB in cluster mode uses the port ``5984`` just as standalone, but is also
+CouchDB in cluster mode uses the port ``5984`` just as standalone, but it also
 uses ``5986`` for node-local APIs.
 
 Erlang uses TCP port ``4369`` (EPMD) to find other nodes, so all servers must 
be
diff --git a/src/config/http.rst b/src/config/http.rst
index 7016317..f38a31f 100644
--- a/src/config/http.rst
+++ b/src/config/http.rst
@@ -32,7 +32,7 @@ HTTP Server Options
 [httpd]
 allow_jsonp = false
 
-.. _JSONP: http://www.json-p.org/
+.. _JSONP: https://en.wikipedia.org/wiki/JSONP
 
 .. config:option:: bind_address :: Listen IP address
 
diff --git a/src/config/logging.rst b/src/config/logging.rst
index e6c83c8..389f0eb 100644
--- a/src/config/logging.rst
+++ b/src/config/logging.rst
@@ -90,7 +90,7 @@ Logging options
 - ``warning`` or ``warn``: Warning messages are alerts about edge 
situations that
   may lead to errors. For instance, compaction daemon alerts about low
   or insufficient disk space at this level.
-- ``error`` or ``err``: Error level includes only things that going 
wrong, crush
+- ``error`` or ``err``: Error level includes only things that going 
wrong, crash
   reports and HTTP error responses (5xx codes).
 - ``critical`` or ``crit``
 - ``alert``


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #178: Minor changes

2017-10-19 Thread GitBox
flimzy commented on a change in pull request #178: Minor changes
URL: 
https://github.com/apache/couchdb-documentation/pull/178#discussion_r145770194
 
 

 ##
 File path: src/config/logging.rst
 ##
 @@ -90,7 +90,7 @@ Logging options
 - ``warning`` or ``warn``: Warning messages are alerts about edge 
situations that
   may lead to errors. For instance, compaction daemon alerts about low
   or insufficient disk space at this level.
-- ``error`` or ``err``: Error level includes only things that going 
wrong, crush
+- ``error`` or ``err``: Error level includes only things that going 
wrong, crash
 
 Review comment:
   should also replace "going wrong" with "go wrong" while you're there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #178: Minor changes

2017-10-19 Thread GitBox
flimzy commented on a change in pull request #178: Minor changes
URL: 
https://github.com/apache/couchdb-documentation/pull/178#discussion_r145769887
 
 

 ##
 File path: src/api/database/changes.rst
 ##
 @@ -685,7 +685,7 @@ amount of duplicated code.
 While :ref:`map functions ` doesn't process the design documents,
 using ``_view`` filter forces them to do this. You need to be sure, that
 they are ready to handle documents with *alien* structure without panic
-crush.
+crash.
 
 Review comment:
   I'd just remove the word entirely.  "panic crash" is redundant.  I think 
"without panic." is better. What do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pdxfixit opened a new pull request #179: Minor changes

2017-10-19 Thread GitBox
pdxfixit opened a new pull request #179: Minor changes
URL: https://github.com/apache/couchdb-documentation/pull/179
 
 
   Just a few minor corrections.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Antonio-Maranhao commented on issue #999: Fix View Attachments menu and upload modal in doc editor

2017-10-19 Thread GitBox
Antonio-Maranhao commented on issue #999: Fix View Attachments menu and upload 
modal in doc editor
URL: https://github.com/apache/couchdb-fauxton/pull/999#issuecomment-337986240
 
 
   @garrensmith can you please review? thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #179: Minor changes

2017-10-19 Thread GitBox
flimzy commented on a change in pull request #179: Minor changes
URL: 
https://github.com/apache/couchdb-documentation/pull/179#discussion_r145797507
 
 

 ##
 File path: src/api/database/changes.rst
 ##
 @@ -685,7 +685,7 @@ amount of duplicated code.
 While :ref:`map functions ` doesn't process the design documents,
 using ``_view`` filter forces them to do this. You need to be sure, that
 they are ready to handle documents with *alien* structure without panic
-crush.
+crash.
 
 Review comment:
   I suggest just removing the word "crash" entirely. "panic crash" seems 
redundant to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on a change in pull request #179: Minor changes

2017-10-19 Thread GitBox
flimzy commented on a change in pull request #179: Minor changes
URL: 
https://github.com/apache/couchdb-documentation/pull/179#discussion_r145797615
 
 

 ##
 File path: src/config/logging.rst
 ##
 @@ -90,7 +90,7 @@ Logging options
 - ``warning`` or ``warn``: Warning messages are alerts about edge 
situations that
   may lead to errors. For instance, compaction daemon alerts about low
   or insufficient disk space at this level.
-- ``error`` or ``err``: Error level includes only things that going 
wrong, crush
+- ``error`` or ``err``: Error level includes only things that going 
wrong, crash
 
 Review comment:
   s/going wrong/go wrong/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #895: CouchDB 1.6.1 fails to start under macOS High Sierra

2017-10-19 Thread GitBox
janl commented on issue #895: CouchDB 1.6.1 fails to start under macOS High 
Sierra
URL: https://github.com/apache/couchdb/issues/895#issuecomment-338021893
 
 
   Not really, as the build toolchain is now all geared up for 2.x. I don?t 
likely have any time in the foreseeable future to work on this. I recommend 
upgrading to 2.1.0


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #896: Consider error messages or host resolution in Bind IP configuration.

2017-10-19 Thread GitBox
janl commented on issue #896: Consider error messages or host resolution in 
Bind IP configuration.
URL: https://github.com/apache/couchdb/issues/896#issuecomment-338022394
 
 
   +1, this would be a great addition for a first-time contributor. Wanna work 
on a PR? Happy to help get you started.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #897: Some passwords show up in the logs

2017-10-19 Thread GitBox
janl commented on issue #897: Some passwords show up in the logs
URL: https://github.com/apache/couchdb/issues/897#issuecomment-338023356
 
 
   For the record, CouchDB has never guaranteed that no passwords would end up 
in logs. We?re trying, but no guarantees.
   
   That said, the fix is fairly simple. The `notice` level log here 
https://github.com/apache/couchdb-setup/blob/master/src/setup.erl#L214 should 
really be a debug level log. Same for most of the other notices in there.
   
   Wanna attempt a PR? This is the debug function: 
https://github.com/apache/couchdb/blob/master/src/couch_log/src/couch_log.erl#L30-L31


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-19 Thread GitBox
janl commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-338023788
 
 
   I don?t think we are in a rush to fix this, but we?d happily accept PRs and 
guide folks who want to give that a try.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl closed pull request #900: Mango test README formatting

2017-10-19 Thread GitBox
janl closed pull request #900: Mango test README formatting
URL: https://github.com/apache/couchdb/pull/900
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/mango/test/README.md b/src/mango/test/README.md
index a7f6350b0a..3c99cab9dd 100644
--- a/src/mango/test/README.md
+++ b/src/mango/test/README.md
@@ -22,8 +22,8 @@ Test configuration
 
 The following environment variables can be used to configure the test fixtures:
 
-COUCH_HOST - root url (including port) of the CouchDB instance to run the 
tests against. Default is "http://127.0.0.1:15984";.
-COUCH_USER - CouchDB username (with admin premissions). Default is "testuser"
-COUCH_PASSWORD -  CouchDB password. Default is "testpass"
-COUCH_AUTH_HEADER - Optional Authorization header value. If specified, this is 
used instead of basic authentication with the username/password variables above.
-MANGO_TEXT_INDEXES - Set to "1" to run the tests only applicable to text 
indexes
+ * `COUCH_HOST` - root url (including port) of the CouchDB instance to run the 
tests against. Default is `"http://127.0.0.1:15984"`.
+ * `COUCH_USER` - CouchDB username (with admin premissions). Default is 
`"testuser"`.
+ * `COUCH_PASSWORD` -  CouchDB password. Default is `"testpass"`.
+ * `COUCH_AUTH_HEADER` - Optional Authorization header value. If specified, 
this is used instead of basic authentication with the username/password 
variables above.
+ * `MANGO_TEXT_INDEXES` - Set to `"1"` to run the tests only applicable to 
text indexes.


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #892: Building CouchDB on ARMv8

2017-10-19 Thread GitBox
janl commented on issue #892: Building CouchDB on ARMv8
URL: https://github.com/apache/couchdb/issues/892#issuecomment-338024575
 
 
   That means this needs to be fixed in rebar, not CouchDB. cc @davisp any 
opinions?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #889: Ignore javascript test suites

2017-10-19 Thread GitBox
janl commented on issue #889: Ignore javascript test suites
URL: https://github.com/apache/couchdb/pull/889#issuecomment-338024869
 
 
   agree this would be neat, but didn?t get it at first like @wohali. I too 
like the symmetry. Either way, whatever helps make running tests more 
comfortable :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #892: Building CouchDB on ARMv8

2017-10-19 Thread GitBox
wohali commented on issue #892: Building CouchDB on ARMv8
URL: https://github.com/apache/couchdb/issues/892#issuecomment-338027979
 
 
   If it's a rebar problem, we should look at the rebar3 change using paul's 
[enc](https://github.com/davisp/erlang-native-compiler) and make this patch 
over there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
wohali commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145814119
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
+  returned if volumes are mounted containing whitespace in their name. This
+  problem surfaced primarily on macOS (Time Machine volumes). CouchDB now
+  works around this bug in unpatched versions of Erlang by skipping the free
+  space check performed by the compaction daemon. Erlang itself will
+  correctly perform free space checks in version 21.0.
+
+* The Dockerfile in the source repository has been retired. For a current
+  Dockerfile, see the ``couchdb-docker`` repository.
+
+Performance
+---
+
+* :ghissue:`835`: CouchDB now no longer decompresses documents just to
+  determine their uncompressed size. In tests, this has lead to improvements
+  between 10-40% in both CPU and wall-clock time for database compaction.
+
+* The design document cache (``ddoc_cache``) has been rewritten to improve
+  performance.
+
+Mango
+-
+
+* :ghissue:`740`: Mango queries can now be paginated. Each query response
+  includes a bookmark.  The bookmark can be provided on a subsequent query to
+  continue from a specific key.
+
+* :ghissue:`768`: Mango ``_find`` accepts an ``execution_stats``
+  parameter. If present, a new object is included in the response which
+  contains information about the query executed. The object contains the
+  count of total keys examined (0 for json indexes), total documents
+  examined (when ``include_docs=true`` is used), and the total quorum
+  documents examined (when fabric doc lookups are used).
+
+* :ghissue:`816` and :ghissue:`866`: Mango now requires that all of the fields
+  in a candidate index must exist in a query's selector. Previously, this check
+  was incorrect, and indexes that might only contain a subset of valid
+  documents might be selected by the query planner if an explicit index was not
+  specified at query time. Further, if a sort field is specified at query time,
+  that field needs to exist (but could be null) in the results returned.
+
+Other
+-
+
+The 2.1.1 release also includes the following minor improvements:
+
+  * :ghissue:`635`: Stop couch_index processes on ddoc update
+  * :ghissue:`721`: Save migrated replicator checkpoint documents immediately
+  * :ghissue:`688`: Reuse http-based replicatoin checkpoints when upgrading
+to https
+  * :ghissue:`729`: Recommend the use only of ``-name`` and not ``-sname`` in
+`vm.args` for compatibility.
+  * :ghissue:`738`: Allow replicator application to always update replicator
+docs.
+  * :ghissue:`605`: Add ``Prefer: return=minimal`` header options from
+RFC7240 to reduce the number of headers in the response.
+  * :ghissue:`744`: Allow a 503 response to be returned to clients (with
+metric support)
+  * :ghissue:`746`: Log additional information on crashes from rexi
+  * :ghissue:`752`: Allow Mango $in queries without requiring the index to
+use an array
+  * (multiple) Additional debugging utilities have been added.
+  * (multiple) Hot code upgrades from 2.0 -> 2.1.1 are now possible.
+  * (mult

[GitHub] koleto commented on issue #892: Building CouchDB on ARMv8

2017-10-19 Thread GitBox
koleto commented on issue #892: Building CouchDB on ARMv8
URL: https://github.com/apache/couchdb/issues/892#issuecomment-338030413
 
 
   But unfortunately after I was able to build couchdb, there are still some 
issues with the replication and views on ARMv8.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #889: Ignore javascript test suites

2017-10-19 Thread GitBox
janl commented on issue #889: Ignore javascript test suites
URL: https://github.com/apache/couchdb/pull/889#issuecomment-338034846
 
 
   @tonysun83 wanna add a few lines of docs to 
https://github.com/apache/couchdb/blob/master/README-DEV.rst#testing +1 
afterwards


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wyc commented on issue #896: Consider error messages or host resolution in Bind IP configuration.

2017-10-19 Thread GitBox
wyc commented on issue #896: Consider error messages or host resolution in Bind 
IP configuration.
URL: https://github.com/apache/couchdb/issues/896#issuecomment-338048907
 
 
   Thanks for your response. Sure, happy to attempt a resolution with tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wyc commented on issue #897: Some passwords show up in the logs

2017-10-19 Thread GitBox
wyc commented on issue #897: Some passwords show up in the logs
URL: https://github.com/apache/couchdb/issues/897#issuecomment-338048927
 
 
   Thanks for your response. Sure, I think I can do this one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wyc commented on issue #896: Consider error messages or host resolution in Bind IP configuration.

2017-10-19 Thread GitBox
wyc commented on issue #896: Consider error messages or host resolution in Bind 
IP configuration.
URL: https://github.com/apache/couchdb/issues/896#issuecomment-338048907
 
 
   Thanks for your response. Sure, happy to attempt a resolution with tests. Do 
you think we should error or support hostname resolution?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] pdxfixit commented on a change in pull request #178: Minor changes

2017-10-19 Thread GitBox
pdxfixit commented on a change in pull request #178: Minor changes
URL: 
https://github.com/apache/couchdb-documentation/pull/178#discussion_r145835043
 
 

 ##
 File path: src/api/database/changes.rst
 ##
 @@ -685,7 +685,7 @@ amount of duplicated code.
 While :ref:`map functions ` doesn't process the design documents,
 using ``_view`` filter forces them to do this. You need to be sure, that
 they are ready to handle documents with *alien* structure without panic
-crush.
+crash.
 
 Review comment:
   Agreed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
wohali commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145842769
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
 
 Review comment:
   Oops, meant to look this one up and forgot. Good catch


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on a change in pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
wohali commented on a change in pull request #177: Add 2.1.1 release notes
URL: 
https://github.com/apache/couchdb-documentation/pull/177#discussion_r145842937
 
 

 ##
 File path: src/whatsnew/2.1.rst
 ##
 @@ -20,11 +20,162 @@
 :depth: 1
 :local:
 
+.. _release/2.1.x/upgrade:
+
+Upgrade Notes
+=
+
+* The deprecated (and broken) OAuth 1.0 implementation has been removed.
+
+* If user code reads or manipulates replicator document states,
+  consider using the ``[replicator] update_docs = true`` compatibility
+  parameter. In that case replicator will continue updating documents
+  with transient replication states. However, that will incure a
+  performance cost. Consider instead switching using
+  ``_scheduler/docs`` HTTP endpoint.
+
+* The ``stale`` parameter for views and ``_find`` has been deprecated in favour
+  of two new parameters: ``stable`` and ``update``. The old ``stale=ok``
+  behaviour is equivalent to ``stable=true&update=false``, and the old
+  ``stale=update_after`` behaviour is equivalent to 
``stable=true&update=lazy``.
+  The deprecated ``stale`` parameter will be removed in CouchDB 3.0.
+
+* The ``[couchdb] max_document_size`` configuration parameter was renamed
+  to ``[httpd] max_http_request_size`` to reflect its actual implementation.
+  It has been enhanced by a new ``[couchdb] single_max_doc_size`` setting.
+  Both are documented in the shipped ``default.ini`` file.
+
+.. _release/2.1.1:
+
+Version 2.1.1
+=
+
+General
+---
+
+* :ghissue:`617`: CouchDB now supports compilation and running under Erlang/OTP
+  20.x.
+
+* :ghissue:``: The ``couch_peruser`` functionality is now *really* fixed.
+  Really.
+
+* :ghissue:`827`: The cookie domain for AuthSession cookies, used in a
+  proxy authentication configuration, can now be customized via the ini file.
+
+* :ghissue:`858`: It is now possible to modify shard maps for system databases.
+
+* :ghissue:`732`: Due to an Erlang bug (ERL-343), invalid paths can be
+  returned if volumes are mounted containing whitespace in their name. This
+  problem surfaced primarily on macOS (Time Machine volumes). CouchDB now
+  works around this bug in unpatched versions of Erlang by skipping the free
+  space check performed by the compaction daemon. Erlang itself will
+  correctly perform free space checks in version 21.0.
+
+* The Dockerfile in the source repository has been retired. For a current
+  Dockerfile, see the ``couchdb-docker`` repository.
+
+Performance
+---
+
+* :ghissue:`835`: CouchDB now no longer decompresses documents just to
+  determine their uncompressed size. In tests, this has lead to improvements
+  between 10-40% in both CPU and wall-clock time for database compaction.
+
+* The design document cache (``ddoc_cache``) has been rewritten to improve
+  performance.
+
+Mango
+-
+
+* :ghissue:`740`: Mango queries can now be paginated. Each query response
+  includes a bookmark.  The bookmark can be provided on a subsequent query to
+  continue from a specific key.
+
+* :ghissue:`768`: Mango ``_find`` accepts an ``execution_stats``
+  parameter. If present, a new object is included in the response which
+  contains information about the query executed. The object contains the
+  count of total keys examined (0 for json indexes), total documents
+  examined (when ``include_docs=true`` is used), and the total quorum
+  documents examined (when fabric doc lookups are used).
+
+* :ghissue:`816` and :ghissue:`866`: Mango now requires that all of the fields
+  in a candidate index must exist in a query's selector. Previously, this check
+  was incorrect, and indexes that might only contain a subset of valid
+  documents might be selected by the query planner if an explicit index was not
+  specified at query time. Further, if a sort field is specified at query time,
+  that field needs to exist (but could be null) in the results returned.
+
+Other
+-
+
+The 2.1.1 release also includes the following minor improvements:
+
+  * :ghissue:`635`: Stop couch_index processes on ddoc update
+  * :ghissue:`721`: Save migrated replicator checkpoint documents immediately
+  * :ghissue:`688`: Reuse http-based replicatoin checkpoints when upgrading
+to https
+  * :ghissue:`729`: Recommend the use only of ``-name`` and not ``-sname`` in
+`vm.args` for compatibility.
+  * :ghissue:`738`: Allow replicator application to always update replicator
+docs.
+  * :ghissue:`605`: Add ``Prefer: return=minimal`` header options from
+RFC7240 to reduce the number of headers in the response.
+  * :ghissue:`744`: Allow a 503 response to be returned to clients (with
+metric support)
+  * :ghissue:`746`: Log additional information on crashes from rexi
+  * :ghissue:`752`: Allow Mango $in queries without requiring the index to
+use an array
+  * (multiple) Additional debugging utilities have been added.
+  * (multiple) Hot code upgrades from 2.0 -> 2.1.1 are now possible.
+  * (mult

[GitHub] dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-19 Thread GitBox
dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-338059528
 
 
   I'm interested to see what I can do. What do I need to get started? Before I 
dive in though I am curious why this functionality was taken out of 2.1 from 
1.6? It works like a champ in 1.6 or was this an exploited work around? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #177: Add 2.1.1 release notes

2017-10-19 Thread GitBox
wohali closed pull request #177: Add 2.1.1 release notes
URL: https://github.com/apache/couchdb-documentation/pull/177
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #179: Minor changes

2017-10-19 Thread GitBox
wohali commented on issue #179: Minor changes
URL: 
https://github.com/apache/couchdb-documentation/pull/179#issuecomment-338062750
 
 
   @pdxfixit Thanks so much for your first-time contribution to Apache CouchDB! 
I'll get this merged for you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #179: Minor changes

2017-10-19 Thread GitBox
wohali closed pull request #179: Minor changes
URL: https://github.com/apache/couchdb-documentation/pull/179
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/api/database/changes.rst b/src/api/database/changes.rst
index 2a740f1..d48a9a6 100644
--- a/src/api/database/changes.rst
+++ b/src/api/database/changes.rst
@@ -684,8 +684,7 @@ amount of duplicated code.
 .. warning::
 While :ref:`map functions ` doesn't process the design documents,
 using ``_view`` filter forces them to do this. You need to be sure, that
-they are ready to handle documents with *alien* structure without panic
-crush.
+they are ready to handle documents with *alien* structure without panic.
 
 .. note::
 Using ``_view`` filter doesn't queries the view index files, so you cannot
diff --git a/src/cluster/setup.rst b/src/cluster/setup.rst
index 4cb6570..f8e238b 100644
--- a/src/cluster/setup.rst
+++ b/src/cluster/setup.rst
@@ -24,7 +24,7 @@ Firewall
 
 If you do not have a firewall between your servers, then you can skip this.
 
-CouchDB in cluster mode uses the port ``5984`` just as standalone, but is also
+CouchDB in cluster mode uses the port ``5984`` just as standalone, but it also
 uses ``5986`` for node-local APIs.
 
 Erlang uses TCP port ``4369`` (EPMD) to find other nodes, so all servers must 
be
diff --git a/src/config/http.rst b/src/config/http.rst
index 7016317..f38a31f 100644
--- a/src/config/http.rst
+++ b/src/config/http.rst
@@ -32,7 +32,7 @@ HTTP Server Options
 [httpd]
 allow_jsonp = false
 
-.. _JSONP: http://www.json-p.org/
+.. _JSONP: https://en.wikipedia.org/wiki/JSONP
 
 .. config:option:: bind_address :: Listen IP address
 
diff --git a/src/config/logging.rst b/src/config/logging.rst
index e6c83c8..8aa9c35 100644
--- a/src/config/logging.rst
+++ b/src/config/logging.rst
@@ -90,7 +90,7 @@ Logging options
 - ``warning`` or ``warn``: Warning messages are alerts about edge 
situations that
   may lead to errors. For instance, compaction daemon alerts about low
   or insufficient disk space at this level.
-- ``error`` or ``err``: Error level includes only things that going 
wrong, crush
+- ``error`` or ``err``: Error level includes only things that go 
wrong, like crash
   reports and HTTP error responses (5xx codes).
 - ``critical`` or ``crit``
 - ``alert``


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #902: Update 2.1.x with all changes on master to date

2017-10-19 Thread GitBox
wohali closed pull request #902: Update 2.1.x with all changes on master to date
URL: https://github.com/apache/couchdb/pull/902
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kavinho commented on issue #5: [1.6.1] image exits without notice or log on bulk write

2017-10-19 Thread GitBox
kavinho commented on issue #5: [1.6.1] image exits without notice or log on 
bulk write
URL: https://github.com/apache/couchdb-docker/issues/5#issuecomment-338097313
 
 
   Hi, this is a question : How can I use already existing, locally hosted 
couchdb data files, using this docker image. While this works in real world by 
simply copying /shards and _dbs.couch into the new couch instance, it does not 
work on docker- hosted couch db. IT basically fails to load dbs. and the 
web-console verify fails , when trying to create a test db.
   sample command : 
   docker run -d -v $(pwd)/my-couch-files:/opt/couchdb/data -p 5984:5984  
--name mw-couch apache/couchdb:latest   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kavinho commented on issue #5: [1.6.1] image exits without notice or log on bulk write

2017-10-19 Thread GitBox
kavinho commented on issue #5: [1.6.1] image exits without notice or log on 
bulk write
URL: https://github.com/apache/couchdb-docker/issues/5#issuecomment-338097313
 
 
   Hi, this is a question : How can I use already existing, locally hosted 
couchdb data files, using this docker image. While this works in real world by 
simply copying /shards and _dbs.couch into the new couch instance, it does not 
work on docker- hosted couch db. IT basically fails to load dbs. and the 
web-console verify fails , when trying to create a test db.
   sample command : 
   docker run -d -v $(pwd)/my-couch-files:/opt/couchdb/data -p 5984:5984  
--name mw-couch apache/couchdb:latest   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kavinho opened a new issue #34: run couch with existing couchdb files.

2017-10-19 Thread GitBox
kavinho opened a new issue #34: run couch with existing couchdb files.
URL: https://github.com/apache/couchdb-docker/issues/34
 
 
   Hi, this is a question : How can I use already existing, locally hosted 
couchdb data files, using this docker image. While this works in real world by 
simply copying /shards and _dbs.couch into the new couch instance, it does not 
work on docker- hosted couch db. IT basically fails to load dbs. and the 
web-console verify fails , when trying to create a test db.
   sample command :
   docker run -d -v $(pwd)/my-couch-files:/opt/couchdb/data -p 5984:5984 --name 
mw-couch apache/couchdb:latest


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] SCdF opened a new pull request #1000: Support editing _local docs

2017-10-20 Thread GitBox
SCdF opened a new pull request #1000: Support editing _local docs
URL: https://github.com/apache/couchdb-fauxton/pull/1000
 
 
   ## Overview
   
   Adds support for editing `_local` docs in Fauxton.
   
   ## Testing recommendations
   
   To test, create a _local doc and then modify the Fauxton URL to see the edit 
page:
   
   ## GitHub issue number
   
   Fixes apache/couchdb-fauxton#978
   
   ## Checklist
   
   - [ ] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] Update 
[rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
 with the correct tag once a new Fauxton release is made
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] SCdF commented on issue #1000: Support editing _local docs

2017-10-20 Thread GitBox
SCdF commented on issue #1000: Support editing _local docs
URL: https://github.com/apache/couchdb-fauxton/pull/1000#issuecomment-338216703
 
 
   NB: I couldn't work out which test to change to add a test for this. 
Direction here would be appreciated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] garrensmith commented on issue #1000: Support editing _local docs

2017-10-20 Thread GitBox
garrensmith commented on issue #1000: Support editing _local docs
URL: https://github.com/apache/couchdb-fauxton/pull/1000#issuecomment-338244745
 
 
   Hi Stefan, take a look at the nightwatch tests found under each 
test/nightwatch folder in the documents folder. There should be some examples 
there you can build off of
   
   All misspelling thanks to my iPhone.
   
   From: Stefan du Fresne 
   Sent: Friday, October 20, 2017 4:06:35 PM
   To: apache/couchdb-fauxton
   Cc: Subscribed
   Subject: Re: [apache/couchdb-fauxton] Support editing _local docs (#1000)
   
   
   NB: I couldn't work out which test to change to add a test for this. 
Direction here would be appreciated.
   
   ?
   You are receiving this because you are subscribed to this thread.
   Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Antonio-Maranhao opened a new pull request #1001: Fix table mode to show boolean values

2017-10-20 Thread GitBox
Antonio-Maranhao opened a new pull request #1001: Fix table mode to show 
boolean values
URL: https://github.com/apache/couchdb-fauxton/pull/1001
 
 
   ## Overview
   
   Fixes display of boolean values in Table mode. 
   
   ### Current behavior
   Table mode won't display boolean values of top-level fields. E.g.: `{ "_id": 
"test", "f": false, "t": true }`
   
   ### Expected behavior
   Table mode displays `true` or `false` for boolean fields. 
   
   ## Testing recommendations
   
- Create a new doc `{ "_id": "test", "f": false, "t": true }`
- In the all_docs list, switch to Table mode.
- Values for `f` and `t` should be displayed
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-20 Thread GitBox
janl commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-338282777
 
 
   > I'm interested to see what I can do.
   
   Awesome! :)
   
   > What do I need to get started?
   
   The chttpd module does all the HTTP handling in 2.0 and forward: 
https://github.com/apache/couchdb/tree/master/src/chttpd/src ? I?d give that a 
bit of a read through. Erlang basics can be picked up here: 
http://learnyousomeerlang.com/content
   
   > I am curious why this functionality was taken out of 2.1 from 1.6? 
   
   It is less that it was taken out and more that for 2.0 the code that handles 
all HTTP in CouchDB is a completely new module written from scratch to account 
for the cluster functionality that wasn't available in 1.x. Not all features 
from the old module (couch_httpd) have been ported to the new module. In 
addition, the way CouchDB 1.x is put together is not what modern idiomatic 
Erlang applications look like, and 2.x cleaned a lot of that up.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl closed issue #733: couchdb 2.0 cluster setup failing

2017-10-20 Thread GitBox
janl closed issue #733: couchdb 2.0 cluster setup failing
URL: https://github.com/apache/couchdb/issues/733
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #733: couchdb 2.0 cluster setup failing

2017-10-20 Thread GitBox
janl commented on issue #733: couchdb 2.0 cluster setup failing
URL: https://github.com/apache/couchdb/issues/733#issuecomment-338303891
 
 
   please reopen with requested info


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #666: Move _users _design/auth into Erlang

2017-10-20 Thread GitBox
janl commented on issue #666: Move _users _design/auth into Erlang
URL: https://github.com/apache/couchdb/issues/666#issuecomment-338306130
 
 
   The first steps would be to transliterate these two files into native 
Erlang. After that, we could figure out how we can hard-wire them into their 
respective databases without enabling the Erlang view server:
   
   
https://github.com/apache/couchdb/blob/master/src/couch/include/couch_js_functions.hrl
   
https://github.com/apache/couchdb/blob/master/src/couch_replicator/src/couch_replicator_js_functions.hrl
   
   This would make a great first time contribution, any one of the functions 
would already be a good help.
   
   See 
https://github.com/apache/couchdb/blob/master/test/javascript/tests/erlang_views.js
 for a few examples of how to write ddoc functions in Erlang.
   
   Please no comments about us embedding JS in Erlang in one case, and Erlang 
in JS in the other ;D


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #602: Security objects cannot be synced if nodes are in maintenance mode

2017-10-20 Thread GitBox
janl commented on issue #602: Security objects cannot be synced if nodes are in 
maintenance mode
URL: https://github.com/apache/couchdb/issues/602#issuecomment-338309872
 
 
   @kocolosk thanks for the clarification, and yeah, looks like we need to wait 
for [cassim](https://github.com/apache/couchdb-cassim) to make it into prod.
   
   I?m gonna close this issue and link one from the cassim repo, so we remember 
this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl closed issue #602: Security objects cannot be synced if nodes are in maintenance mode

2017-10-20 Thread GitBox
janl closed issue #602: Security objects cannot be synced if nodes are in 
maintenance mode
URL: https://github.com/apache/couchdb/issues/602
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #794: binary_to_term/1 unknown_error : badarg at high rate request

2017-10-20 Thread GitBox
janl commented on issue #794: binary_to_term/1 unknown_error : badarg at high 
rate request
URL: https://github.com/apache/couchdb/issues/794#issuecomment-338311884
 
 
   In addition, it would be great to hear what request(s) exactly are causing 
this.
   
   The stack trace here mentions fabric view changes, so there is some cluster 
coordination going on, under load this could be cause by a timeout or something 
tripping up the message receiver using `binary_to_term/1`, but it?s not that we 
are parsing input from an untrusted source there, so the point about 
`binary_to_term/2` is probably a red herring.
   
   Please re-open with extra info, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl closed issue #794: binary_to_term/1 unknown_error : badarg at high rate request

2017-10-20 Thread GitBox
janl closed issue #794: binary_to_term/1 unknown_error : badarg at high rate 
request
URL: https://github.com/apache/couchdb/issues/794
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl opened a new issue #904: Re-introduce cassim to the 2.0 codebase

2017-10-20 Thread GitBox
janl opened a new issue #904: Re-introduce cassim to the 2.0 codebase
URL: https://github.com/apache/couchdb/issues/904
 
 
   This [was disabled for 2.0 because of subtle 
bugs](https://github.com/apache/couchdb/pull/414).
   
   The cassim Readme includes a bunch of notes for future direction here: 
https://github.com/apache/couchdb-cassim
   
   Specifically, we need to pull CouchDB _security and _role handling from 
[couch_httpd_auth](https://github.com/apache/couchdb/blob/master/src/couch/src/couch_httpd_auth.erl)
 into 
[chttpd](https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd_auth.erl).
   
   Benefits:
   - performance improvements (30%+)
   - clearer behaviour and avoidance of bugs in degraded cluster scenarios, 
e.g. https://github.com/apache/couchdb/issues/602
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new pull request #1002: Bump version number for release

2017-10-20 Thread GitBox
wohali opened a new pull request #1002: Bump version number for release
URL: https://github.com/apache/couchdb-fauxton/pull/1002
 
 
   Ready to release 2.1.1 RCs - need this bumped and tagged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] chewbranca commented on issue #1002: Bump version number for release

2017-10-20 Thread GitBox
chewbranca commented on issue #1002: Bump version number for release
URL: https://github.com/apache/couchdb-fauxton/pull/1002#issuecomment-338321947
 
 
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Antonio-Maranhao closed pull request #1001: Fix table mode to show boolean values

2017-10-20 Thread GitBox
Antonio-Maranhao closed pull request #1001: Fix table mode to show boolean 
values
URL: https://github.com/apache/couchdb-fauxton/pull/1001
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/app/addons/documents/index-results/components/results/TableRow.js 
b/app/addons/documents/index-results/components/results/TableRow.js
index 6728996d6..b983d86c1 100644
--- a/app/addons/documents/index-results/components/results/TableRow.js
+++ b/app/addons/documents/index-results/components/results/TableRow.js
@@ -37,7 +37,8 @@ export default class TableRow extends React.Component {
 const row = this.props.data.selectedFields.map(function (k, i) {
 
   const key = 'tableview-data-cell-' + rowNumber + k + i + el[k];
-  const stringified = typeof el[k] === 'object' ? JSON.stringify(el[k], 
null, '  ') : el[k];
+  const stringified = ['object', 'boolean'].includes(typeof el[k]) ?
+JSON.stringify(el[k], null, '  ') : el[k];
 
   return (
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Antonio-Maranhao opened a new pull request #1001: Fix table mode to show boolean values

2017-10-20 Thread GitBox
Antonio-Maranhao opened a new pull request #1001: Fix table mode to show 
boolean values
URL: https://github.com/apache/couchdb-fauxton/pull/1001
 
 
   ## Overview
   
   Fixes display of boolean values in Table mode. 
   
   ### Current behavior
   Table mode won't display boolean values of top-level fields. E.g.: `{ "_id": 
"test", "f": false, "t": true }`
   
   ### Expected behavior
   Table mode displays `true` or `false` for boolean fields. 
   
   ## Testing recommendations
   
- Create a new doc `{ "_id": "test", "f": false, "t": true }`
- In the all_docs list, switch to Table mode.
- Values for `f` and `t` should be displayed
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #1002: Bump version number for release

2017-10-20 Thread GitBox
wohali closed pull request #1002: Bump version number for release
URL: https://github.com/apache/couchdb-fauxton/pull/1002
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new pull request #905: Bump fauxton and doc deps for 2.1.1 release

2017-10-20 Thread GitBox
wohali opened a new pull request #905: Bump fauxton and doc deps for 2.1.1 
release
URL: https://github.com/apache/couchdb/pull/905
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #905: Bump fauxton and doc deps for 2.1.1 release

2017-10-20 Thread GitBox
wohali commented on issue #905: Bump fauxton and doc deps for 2.1.1 release
URL: https://github.com/apache/couchdb/pull/905#issuecomment-338331780
 
 
   "Doing the right thing" and will merge this to `2.1.x` as soon as Travis is 
green.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-20 Thread GitBox
dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-338337962
 
 
   Excellent information. That insight to the module rewrite makes complete 
sense. I'll dive into this more tonight. How does this process work? Say I get 
this feature completed, what is the time frame we are looking at for a release 
with this feature?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali closed pull request #905: Bump fauxton and doc deps for 2.1.1 release

2017-10-20 Thread GitBox
wohali closed pull request #905: Bump fauxton and doc deps for 2.1.1 release
URL: https://github.com/apache/couchdb/pull/905
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new issue #906: Port remsh script to Windows

2017-10-20 Thread GitBox
wohali opened a new issue #906: Port remsh script to Windows
URL: https://github.com/apache/couchdb/issues/906
 
 
   We need a cmd.exe/powershell.exe version of the remsh bash script for 
Windows. This should be straightforward.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new pull request #907: Cleanups for 2.1.1 proper version tagging

2017-10-20 Thread GitBox
wohali opened a new pull request #907: Cleanups for 2.1.1 proper version tagging
URL: https://github.com/apache/couchdb/pull/907
 
 
   RC1 had improper version numbering, and the Makefile script fails when the 
RC number is 1. This isn't a full workaround but it gets us in place to build 
and release 2.1.1 proper.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali opened a new issue #908: Fix release build process tooling

2017-10-20 Thread GitBox
wohali opened a new issue #908: Fix release build process tooling
URL: https://github.com/apache/couchdb/issues/908
 
 
   Currently, there are 3 problems with the RC and release build process that 
I'm aware of:
   
   1. The Makefile functionality to diff a given RC against the last one is 
broken for RC1 (because there is no RC0 tag).
   1. There is no easy way to bump the version number - you have to manually 
edit both `Makefile` and `rel/reltool.config`. See: 
https://github.com/apache/couchdb/pull/907 Sure would be nice to pull this from 
an env var or tag or something.
   1. There's no equivalent of "make reltarball" that does roughly the same 
thing as "make rc" when you check out from a release tag (e.g. 2.1.0). This 
could be collapsed with "make rc" if it was assumed that all RCs have to be 
built from a proper git tag.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] triplem commented on issue #908: Fix release build process tooling

2017-10-21 Thread GitBox
triplem commented on issue #908: Fix release build process tooling
URL: https://github.com/apache/couchdb/issues/908#issuecomment-338374736
 
 
   Just leaving my w$ here.
   
   It is good practice to keep the current version in a file in the project 
(eg. version.mk), as examples see Java builds using Maven or Gradle. In Nodejs 
this is common practice as well.
   
I guess that the version.mk should be used as this single source of truth 
for the version of couchDb.
   
   This information could then be used in the Makefile to bump the version eg. 
by using a tools like https://github.com/peritus/bumpversion (python) or 
https://github.com/fsaintjacques/semver-tool (bash). Then this information 
should be used in the Makefile. No specific target for RC necessary then, just 
one to create the tarball. Some of the tools do tag the girls repository as 
well after a bump, so that the tags and releases in GitHub as well (which I 
think can be easily done in the Makefile as well). 
   
   I have looked into the releng config but have to admit, that I do not have a 
clue on how to adopt the version in there. Probably via a parse/replace?
   
   Does this help you already?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] triplem commented on issue #908: Fix release build process tooling

2017-10-21 Thread GitBox
triplem commented on issue #908: Fix release build process tooling
URL: https://github.com/apache/couchdb/issues/908#issuecomment-338374736
 
 
   Just leaving my 2$ here.
   
   It is good practice to keep the current version in a file in the project 
(eg. version.mk), as examples see Java builds using Maven or Gradle. In Nodejs 
this is common practice as well.
   
I guess that the version.mk should be used as this single source of truth 
for the version of couchDb.
   
   This information could then be used in the Makefile to bump the version eg. 
by using a tools like https://github.com/peritus/bumpversion (python) or 
https://github.com/fsaintjacques/semver-tool (bash). Then this information 
should be used in the Makefile. No specific target for RC necessary then, just 
one to create the tarball. Some of the tools do tag the girls repository as 
well after a bump, so that the tags and releases in GitHub as well (which I 
think can be easily done in the Makefile as well). 
   
   I have looked into the releng config but have to admit, that I do not have a 
clue on how to adopt the version in there. Probably via a parse/replace?
   
   Does this help you already?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] triplem commented on issue #908: Fix release build process tooling

2017-10-21 Thread GitBox
triplem commented on issue #908: Fix release build process tooling
URL: https://github.com/apache/couchdb/issues/908#issuecomment-338374736
 
 
   Just leaving my 2$ here.
   
   It is good practice to keep the current version in a file in the project 
(eg. version.mk), as examples see Java builds using Maven or Gradle. In Nodejs 
this is common practice as well.
   
I guess that the version.mk should be used as this single source of truth 
for the version of couchDb.
   
   This information could then be used in the Makefile to bump the version eg. 
by using a tools like https://github.com/peritus/bumpversion (python) or 
https://github.com/fsaintjacques/semver-tool (bash). Then this information 
should be used in the Makefile. No specific target for RC necessary then, just 
one to create the tarball. Some of the tools do tag the girls repository as 
well after a bump, so that the tags and releases in GitHub as well (which I 
think can be easily done in the Makefile as well). 
   
   I have looked into the releng config but have to admit, that I do not have a 
clue on how to adopt the version in there. Probably via a parse/replace?
   
   The hardcoring of versions in two or more (version.mk, Makefile, 
releng_config) filers should be avoided at all costs, since will lead to errors 
during a release process with too much manual intervention.
   
   Does this help you already?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #908: Fix release build process tooling

2017-10-21 Thread GitBox
wohali commented on issue #908: Fix release build process tooling
URL: https://github.com/apache/couchdb/issues/908#issuecomment-338420224
 
 
   I mostly filed this ticket for myself, but if you wanted to submit a PR and 
join the team, feel free!
   
   FYI what you suggest is what we do already; the current source of truth is 
`rel/reltool.config` and is leveraged by the Erlang build tool `rebar` to set 
the version number in the build process.
   
   In general, our process works and doesn't need a complete rework. There's 
really only 3 specific small things I'm trying to address here:
   
   1. The Makefile prints a convenience diff from the current RC to a previous 
RC. I'm not sure we need it, and was going to propose just dropping it.
   1. The Makefile has a "quick hack" hard-coded version number that it uses 
solely for the naming of the release artefact. It should be pulling that number 
from `rel/reltool.config` or from a tag/branch-name on the source repo.
   1. The `make reltarball` can do the same thing as above.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kinesias commented on issue #840: CouchDB 2.1.0 fails to start under macOS High Sierra

2017-10-22 Thread GitBox
kinesias commented on issue #840: CouchDB 2.1.0 fails to start under macOS High 
Sierra
URL: https://github.com/apache/couchdb/issues/840#issuecomment-338467817
 
 
   I installed CouchDB 2.1 on High Sierra. At first, It seemed to work, but 
from time to time I'm getting the following error, which never happened before 
on Mac OS 10.12 Sierra. CouchDB keeps restarting and restarting.
   
   `CRASH REPORT Process couch_compaction_daemon (<0.6896.0>) with 0 neighbors 
exited with reason: 
{compaction_loop_died,{{badmatch,{error,enoent}},[{couch_compaction_daemon,abs_path,1,[{file,"src/couch_compaction_daemon.erl"},{line,526}]},{couch_compaction_daemon,free_space_rec,2,[{file,"src/couch_compaction_daemon.erl"},{line,517}]},{couch_compaction_daemon,can_db_compact,2,[{file,"src/couch_compaction_daemon.erl"},{line,327}]},{couch_compaction_daemon,maybe_compact_db,3,[{file,"src/couch_compaction_daemon.erl"},{line,164}]},{couch_compaction_daemon,'-compact_loop/1-fun-0-',3,[{file,"s..."},...]},...]}}
 at gen_server:terminate/7(line:812) <= proc_lib:init_p_do_apply/3(line:247); 
initial_call: {couch_compaction_daemon,init,['Argument__1']}, ancestors: 
[couch_secondary_services,couch_sup,<0.207.0>], messages: [], links: 
[<0.6511.0>], dictionary: [], trap_exit: true, status: running, heap_size: 987, 
stack_size: 27, reductions: 2788
   [error] 2017-10-22T10:36:20.844313Z couchdb@localhost <0.6511.0>  
Supervisor couch_secondary_services had child compaction_daemon started with 
couch_compaction_daemon:start_link() at <0.6896.0> exit with reason 
{compaction_loop_died,{{badmatch,{error,enoent}},[{couch_compaction_daemon,abs_path,1,[{file,"src/couch_compaction_daemon.erl"},{line,526}]},{couch_compaction_daemon,free_space_rec,2,[{file,"src/couch_compaction_daemon.erl"},{line,517}]},{couch_compaction_daemon,can_db_compact,2,[{file,"src/couch_compaction_daemon.erl"},{line,327}]},{couch_compaction_daemon,maybe_compact_db,3,[{file,"src/couch_compaction_daemon.erl"},{line,164}]},{couch_compaction_daemon,'-compact_loop/1-fun-0-',3,[{file,"s..."},...]},...]}}
 in context child_terminated
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kinesias commented on issue #840: CouchDB 2.1.0 fails to start under macOS High Sierra

2017-10-22 Thread GitBox
kinesias commented on issue #840: CouchDB 2.1.0 fails to start under macOS High 
Sierra
URL: https://github.com/apache/couchdb/issues/840#issuecomment-338467817
 
 
   Three days ago, I installed CouchDB 2.1 on High Sierra. At first, It seemed 
to work, but from time to time I'm getting the following error, which never 
happened before on Mac OS 10.12 Sierra. CouchDB keeps restarting and restarting.
   
   `CRASH REPORT Process couch_compaction_daemon (<0.6896.0>) with 0 neighbors 
exited with reason: 
{compaction_loop_died,{{badmatch,{error,enoent}},[{couch_compaction_daemon,abs_path,1,[{file,"src/couch_compaction_daemon.erl"},{line,526}]},{couch_compaction_daemon,free_space_rec,2,[{file,"src/couch_compaction_daemon.erl"},{line,517}]},{couch_compaction_daemon,can_db_compact,2,[{file,"src/couch_compaction_daemon.erl"},{line,327}]},{couch_compaction_daemon,maybe_compact_db,3,[{file,"src/couch_compaction_daemon.erl"},{line,164}]},{couch_compaction_daemon,'-compact_loop/1-fun-0-',3,[{file,"s..."},...]},...]}}
 at gen_server:terminate/7(line:812) <= proc_lib:init_p_do_apply/3(line:247); 
initial_call: {couch_compaction_daemon,init,['Argument__1']}, ancestors: 
[couch_secondary_services,couch_sup,<0.207.0>], messages: [], links: 
[<0.6511.0>], dictionary: [], trap_exit: true, status: running, heap_size: 987, 
stack_size: 27, reductions: 2788
   [error] 2017-10-22T10:36:20.844313Z couchdb@localhost <0.6511.0>  
Supervisor couch_secondary_services had child compaction_daemon started with 
couch_compaction_daemon:start_link() at <0.6896.0> exit with reason 
{compaction_loop_died,{{badmatch,{error,enoent}},[{couch_compaction_daemon,abs_path,1,[{file,"src/couch_compaction_daemon.erl"},{line,526}]},{couch_compaction_daemon,free_space_rec,2,[{file,"src/couch_compaction_daemon.erl"},{line,517}]},{couch_compaction_daemon,can_db_compact,2,[{file,"src/couch_compaction_daemon.erl"},{line,327}]},{couch_compaction_daemon,maybe_compact_db,3,[{file,"src/couch_compaction_daemon.erl"},{line,164}]},{couch_compaction_daemon,'-compact_loop/1-fun-0-',3,[{file,"s..."},...]},...]}}
 in context child_terminated
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] kinesias commented on issue #840: CouchDB 2.1.0 fails to start under macOS High Sierra

2017-10-22 Thread GitBox
kinesias commented on issue #840: CouchDB 2.1.0 fails to start under macOS High 
Sierra
URL: https://github.com/apache/couchdb/issues/840#issuecomment-338467817
 
 
   I installed CouchDB 2.1 on High Sierra three days ago. At first, It seemed 
to work, but from time to time I'm getting the following error, which never 
happened before on Mac OS 10.12 Sierra. CouchDB keeps restarting and restarting.
   
   `CRASH REPORT Process couch_compaction_daemon (<0.6896.0>) with 0 neighbors 
exited with reason: 
{compaction_loop_died,{{badmatch,{error,enoent}},[{couch_compaction_daemon,abs_path,1,[{file,"src/couch_compaction_daemon.erl"},{line,526}]},{couch_compaction_daemon,free_space_rec,2,[{file,"src/couch_compaction_daemon.erl"},{line,517}]},{couch_compaction_daemon,can_db_compact,2,[{file,"src/couch_compaction_daemon.erl"},{line,327}]},{couch_compaction_daemon,maybe_compact_db,3,[{file,"src/couch_compaction_daemon.erl"},{line,164}]},{couch_compaction_daemon,'-compact_loop/1-fun-0-',3,[{file,"s..."},...]},...]}}
 at gen_server:terminate/7(line:812) <= proc_lib:init_p_do_apply/3(line:247); 
initial_call: {couch_compaction_daemon,init,['Argument__1']}, ancestors: 
[couch_secondary_services,couch_sup,<0.207.0>], messages: [], links: 
[<0.6511.0>], dictionary: [], trap_exit: true, status: running, heap_size: 987, 
stack_size: 27, reductions: 2788
   [error] 2017-10-22T10:36:20.844313Z couchdb@localhost <0.6511.0>  
Supervisor couch_secondary_services had child compaction_daemon started with 
couch_compaction_daemon:start_link() at <0.6896.0> exit with reason 
{compaction_loop_died,{{badmatch,{error,enoent}},[{couch_compaction_daemon,abs_path,1,[{file,"src/couch_compaction_daemon.erl"},{line,526}]},{couch_compaction_daemon,free_space_rec,2,[{file,"src/couch_compaction_daemon.erl"},{line,517}]},{couch_compaction_daemon,can_db_compact,2,[{file,"src/couch_compaction_daemon.erl"},{line,327}]},{couch_compaction_daemon,maybe_compact_db,3,[{file,"src/couch_compaction_daemon.erl"},{line,164}]},{couch_compaction_daemon,'-compact_loop/1-fun-0-',3,[{file,"s..."},...]},...]}}
 in context child_terminated
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] calonso opened a new issue #909: Compaction daemon should prioritise based on gains

2017-10-22 Thread GitBox
calonso opened a new issue #909: Compaction daemon should prioritise based on 
gains
URL: https://github.com/apache/couchdb/issues/909
 
 
   ## Expected Behavior
   
   Compaction daemon, when selecting which shard to compact, should prioritise 
based on biggest gains.
   
   ## Current Behavior
   
   Compaction daemon just picks one shard that fulfils the configured threshold
   
   ## Context
   
   Trying to have my cluster healthy I have to manually trigger compactions in 
order to keep disk space safe. I'd like compaction daemon to help me by picking 
those shards that will make the biggest impact.
   
   ## Your Environment
   
   * Version used: 2.1.0
   * Browser Name and version: Chrome
   * Operating System and version (desktop or mobile): Ubuntu Trusty
   * Link to your project: cabify.com
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on a change in pull request #907: Cleanups for 2.1.1 proper version tagging

2017-10-22 Thread GitBox
janl commented on a change in pull request #907: Cleanups for 2.1.1 proper 
version tagging
URL: https://github.com/apache/couchdb/pull/907#discussion_r146140895
 
 

 ##
 File path: Makefile
 ##
 @@ -357,11 +357,11 @@ else
@rm -rf apache-couchdb-*
@$(MAKE) dist 2>&1 > /dev/null
@rm apache-couchdb-*.tar.gz
-   @mv apache-couchdb-* apache-couchdb-2.1.0-RC$(COUCH_RC)
-   @tar czf apache-couchdb-2.1.0-RC$(COUCH_RC).tar.gz 
apache-couchdb-2.1.0-RC$(COUCH_RC)
-   @echo "Done apache-couchdb-2.1.0-RC$(COUCH_RC).tar.gz"
+   @mv apache-couchdb-* apache-couchdb-2.1.1-RC$(COUCH_RC)
 
 Review comment:
   best to use `COUCHDB_VERSION` defined in 
https://github.com/apache/couchdb/pull/907/files#diff-b67911656ef5d18c4ae36cb6741b7965R18


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on a change in pull request #907: Cleanups for 2.1.1 proper version tagging

2017-10-22 Thread GitBox
janl commented on a change in pull request #907: Cleanups for 2.1.1 proper 
version tagging
URL: https://github.com/apache/couchdb/pull/907#discussion_r146140917
 
 

 ##
 File path: rel/reltool.config
 ##
 @@ -12,7 +12,7 @@
 
 {sys, [
 {lib_dirs, ["../src"]},
-{rel, "couchdb", "2.1.0", [
+{rel, "couchdb", "2.1.1", [
 
 Review comment:
   not sure if this can be scripted. If not, we could make this the canonical 
source where we change the version number by hand instead of 
`https://github.com/apache/couchdb/blob/master/version.mk` (which I see is 
still on 2.1.0 too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #909: Compaction daemon should prioritise based on gains

2017-10-22 Thread GitBox
janl commented on issue #909: Compaction daemon should prioritise based on gains
URL: https://github.com/apache/couchdb/issues/909#issuecomment-338501774
 
 
   +1
   
   Should be not too hard a fix, the main compaction daemon loop is working off 
of _all_docs: 
https://github.com/apache/couchdb/blob/master/src/couch/src/couch_compaction_daemon.erl#L129
   
   The code to calculate the biggest-benefeacting database can be scavenged 
from here: 
https://github.com/apache/couchdb/blob/master/src/couch/src/couch_compaction_daemon.erl#L318-L323
   
   With both of these entry points, the algorithm in compact_loop should now:
   1. calculate size info for all dbs/shards into a sorted table
   2. top of the table entry gets compacted
   3. GOTO 1.
   
   Bit of handwaving about views. Two options:
   
   1. views just go into the main list of things that can be compacted and 
biggest-benefit views just go on top, like a database would.
   2. when calculating database fragmentation, include the view fragmentation 
as well, and then compact the database and its views (with or without the 
parallel option as it does now), as a batch before moving on to the next.
   
   My gut feel 1. is what makes a little more sense, but I would take 2. if the 
PR is easier and leave 1. for a later patch.
   
   @calonso wanna give this a shot?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-22 Thread GitBox
dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-338519382
 
 
   I'm developing on Windows and I've read the readme however I am finding that 
I may be missing something here. Do you have a windows specific guide anywhere?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] wohali commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-22 Thread GitBox
wohali commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-338524800
 
 
   The entire Windows build process is documented at 
https://github.com/apache/couchdb-glazier/ which should be linked from the 
developer readme document.
   
   It's a lot of work to set up that environment. Good luck. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] janl commented on issue #908: Fix release build process tooling

2017-10-23 Thread GitBox
janl commented on issue #908: Fix release build process tooling
URL: https://github.com/apache/couchdb/issues/908#issuecomment-338588375
 
 
   > ; the current source of truth is rel/reltool.config
   
   We also have version.mk, which is used by `Makefile` things that aren?t 
rebar.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy opened a new pull request #180: Document that a 413 status may be returned.

2017-10-23 Thread GitBox
flimzy opened a new pull request #180: Document that a 413 status may be 
returned.
URL: https://github.com/apache/couchdb-documentation/pull/180
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy opened a new issue #181: max_document_size docs need updating

2017-10-23 Thread GitBox
flimzy opened a new issue #181: max_document_size docs need updating
URL: https://github.com/apache/couchdb-documentation/issues/181
 
 
   #177 mentions in the 'whatsnew' doc that `max_document_size` has been 
renamed to `max_http_request_size`, but the [main 
documentation](http://docs.couchdb.org/en/2.1.0/config/couchdb.html#couchdb/max_document_size)
 still refers to the old name.
   
   I was preparing to update that in #180, so I looked at the `default.ini` as 
suggested in the whatsnew doc, and became more confused.
   
   The `default.ini` does indeed reference the 
[`max_http_request_size`](https://github.com/apache/couchdb/blob/d71ce9f8083a0c2cc5f81c353946f19589a5cba4/rel/overlay/etc/default.ini#L121)
 option, but does not mention `single_max_doc_size`, and does still mention the 
(old?) 
[`max_document_size`](https://github.com/apache/couchdb/blob/d71ce9f8083a0c2cc5f81c353946f19589a5cba4/rel/overlay/etc/default.ini#L51)
 option.
   
   I'd like to make this all consistent (before the 2.1.1 release if possible). 
 If I need to UTSL to find the canonical answer, I will, but it's my hope that 
somebody can enlighten me as to the current state of things as of now.
   
   - Is `default.ini` correct? (In which case whatsnew needs to be updated not 
to refer to `single_max_doc_size`)
   - Is `whatsnew` correct (in which case the default.ini and main docs need to 
be updated)?
   
   Is the story more complex, and full of additional nuance? :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0

2017-10-23 Thread GitBox
dwbentley commented on issue #901: HTTP access cannot be disabled Couch 2.1.0 
URL: https://github.com/apache/couchdb/issues/901#issuecomment-338597584
 
 
   Alright that is what I was reading and I was hoping there was something I
   was missing. Thanks for confirming I was on the right path anyways haha
   
   On Sun, Oct 22, 2017, 9:19 PM Joan Touzet  wrote:
   
   > The entire Windows build process is documented at
   > https://github.com/apache/couchdb-glazier/ which should be linked from
   > the developer readme document.
   >
   > It's a lot of work to set up that environment. Good luck. :)
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > , or 
mute
   > the thread
   > 

   > .
   >
   -- 
   
   -Sent from my Android-
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy commented on issue #181: max_document_size docs need updating

2017-10-23 Thread GitBox
flimzy commented on issue #181: max_document_size docs need updating
URL: 
https://github.com/apache/couchdb-documentation/issues/181#issuecomment-338597702
 
 
   By reading https://github.com/apache/couchdb-chttpd/pull/114, it looks like 
`max_document_size` was chosen over `single_max_doc_size`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] flimzy opened a new pull request #182: Update Whatsnew docs to accurately reflect config changes.

2017-10-23 Thread GitBox
flimzy opened a new pull request #182: Update Whatsnew docs to accurately 
reflect config changes.
URL: https://github.com/apache/couchdb-documentation/pull/182
 
 
   Addresses 
https://github.com/apache/couchdb-documentation/issues/181#issuecomment-338597702


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] garrensmith commented on a change in pull request #1001: Fix table mode to show boolean values

2017-10-23 Thread GitBox
garrensmith commented on a change in pull request #1001: Fix table mode to show 
boolean values
URL: https://github.com/apache/couchdb-fauxton/pull/1001#discussion_r146213138
 
 

 ##
 File path: app/addons/documents/index-results/components/results/TableRow.js
 ##
 @@ -37,7 +37,8 @@ export default class TableRow extends React.Component {
 const row = this.props.data.selectedFields.map(function (k, i) {
 
   const key = 'tableview-data-cell-' + rowNumber + k + i + el[k];
-  const stringified = typeof el[k] === 'object' ? JSON.stringify(el[k], 
null, '  ') : el[k];
 
 Review comment:
   This looks good. Can you write a test that proves this works and so we don't 
ever have a regression on this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] garrensmith commented on issue #1000: Support editing _local docs

2017-10-23 Thread GitBox
garrensmith commented on issue #1000: Support editing _local docs
URL: https://github.com/apache/couchdb-fauxton/pull/1000#issuecomment-338608972
 
 
   @SCdF You can copy this test 
https://github.com/apache/couchdb-fauxton/blob/master/app/addons/documents/tests/nightwatch/createsDocument.js#L16-L59
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   4   5   6   7   8   9   10   >