[GitHub] [couchdb] benel commented on issue #4296: unable to create new user

2022-12-08 Thread GitBox
benel commented on issue #4296: URL: https://github.com/apache/couchdb/issues/4296#issuecomment-1342832491 And did you verify your installation with ? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb] faisalabdulkadir commented on issue #4296: unable to create new user

2022-12-08 Thread GitBox
faisalabdulkadir commented on issue #4296: URL: https://github.com/apache/couchdb/issues/4296#issuecomment-1342815775 - I can't create a user with both UI and curl - Yes. I created the _users database first On Thu, Dec 8, 2022 at 3:20 PM Aurélien Bénel ***@***.***>

[GitHub] [couchdb] benel commented on issue #4296: unable to create new user

2022-12-08 Thread GitBox
benel commented on issue #4296: URL: https://github.com/apache/couchdb/issues/4296#issuecomment-1342810711 Just to help you describe the problem: - Is this with the UI or with `curl`? or both? - Did you create the `_users` database first? -- This is an automated message from the

[GitHub] [couchdb] faisalabdulkadir opened a new issue, #4296: unable to create new user

2022-12-08 Thread GitBox
faisalabdulkadir opened a new issue, #4296: URL: https://github.com/apache/couchdb/issues/4296 [NOTE]: # ( ^^ Provide a general summary of the issue in the title above. ^^ ) ## Description: Each time I try to create a new user using the fauxton UI I keep getting the error undefined.

[GitHub] [couchdb-fauxton] fryjordan opened a new pull request, #1375: disable some tests

2022-12-08 Thread GitBox
fryjordan opened a new pull request, #1375: URL: https://github.com/apache/couchdb-fauxton/pull/1375 ## Overview ## Testing recommendations ## GitHub issue number ## Related Pull Requests ## Checklist - [ ] Code is

[GitHub] [couchdb] konrad-ohms commented on issue #3517: Performance regression on CouchDB v3 while using custom reduce function

2022-12-07 Thread GitBox
konrad-ohms commented on issue #3517: URL: https://github.com/apache/couchdb/issues/3517#issuecomment-1342125074 Okay, thanks, looks like I need to go with libmozjs-78, if I want to use debian bullseye repos: ```bash $ podman run --rm -it debian:bullseye-slim

[GitHub] [couchdb] github-code-scanning[bot] commented on a diff in pull request #4291: Import nouveau

2022-12-07 Thread GitBox
github-code-scanning[bot] commented on code in PR #4291: URL: https://github.com/apache/couchdb/pull/4291#discussion_r1042739161 ## java/nouveau/src/main/java/org/apache/couchdb/nouveau/core/IndexManager.java: ## @@ -0,0 +1,470 @@ +// Copyright 2022 Robert Newson +// +//

[GitHub] [couchdb] nickva commented on pull request #4292: fix(3517): super-simplistic fix to avoid costly AST transforms when t…

2022-12-07 Thread GitBox
nickva commented on PR #4292: URL: https://github.com/apache/couchdb/pull/4292#issuecomment-1341268042 I had tried a quick test with a 500k docs view from https://gist.github.com/nickva/f4177e581a5ba275b854b9a5af875d84 and don't seem to recover the speedup yet js-78 ``` file

[GitHub] [couchdb-helm] sebastien-helbert commented on pull request #75: ingress.className added

2022-12-07 Thread GitBox
sebastien-helbert commented on PR #75: URL: https://github.com/apache/couchdb-helm/pull/75#issuecomment-1341250861 @willholley done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2022-12-07 Thread GitBox
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1341152139 API choices. Currently you can define a nouveau index almost identically to clouseau, the `index()` function behaves the same way, you just need to use "nouveau" as a top-level

[GitHub] [couchdb] rnewson commented on pull request #4291: Import nouveau

2022-12-07 Thread GitBox
rnewson commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1341144819 @big-r81 they worked in the original repo when they are at the root. good call, though. we either need to adjust them so they work here or remove them. haven't thought much about it.

[GitHub] [couchdb-fauxton] ninetteadhikari opened a new pull request, #1374: feat(navbar): Add whats new link

2022-12-07 Thread GitBox
ninetteadhikari opened a new pull request, #1374: URL: https://github.com/apache/couchdb-fauxton/pull/1374 ## Overview This PR adds the 'What's new' link to the Navbar. ## Testing recommendations See the What's new link on the Navbar at the bottom left corner

[GitHub] [couchdb-fauxton] big-r81 commented on issue #1372: add “What’s New” link in sidebar under version number:

2022-12-07 Thread GitBox
big-r81 commented on issue #1372: URL: https://github.com/apache/couchdb-fauxton/issues/1372#issuecomment-1340954147 Should this always point to the online docs, because iirc we ship local docs with each release? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [couchdb] big-r81 commented on pull request #4291: Import nouveau

2022-12-07 Thread GitBox
big-r81 commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1340924188 Are the GH workflows working/necessary, if they are not in the root directory after the merge? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb-fauxton] janl commented on issue #1372: add “What’s New” link in sidebar under version number:

2022-12-07 Thread GitBox
janl commented on issue #1372: URL: https://github.com/apache/couchdb-fauxton/issues/1372#issuecomment-1340846071 yeah good call! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [couchdb] nickva opened a new pull request, #4295: A few more smoosh test flaky fixups

2022-12-06 Thread GitBox
nickva opened a new pull request, #4295: URL: https://github.com/apache/couchdb/pull/4295 Should help with the failures in ``` smoosh_tests:21: smoosh_test_ (t_index_cleanup_happens_by_default)...[0.117 s] ok smoosh_tests:22: smoosh_test_

[GitHub] [couchdb] nickva merged pull request #4294: Fix flaky checkpointing smoosh test

2022-12-06 Thread GitBox
nickva merged PR #4294: URL: https://github.com/apache/couchdb/pull/4294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on pull request #4294: Fix flaky checkpointing smoosh test

2022-12-06 Thread GitBox
nickva commented on PR #4294: URL: https://github.com/apache/couchdb/pull/4294#issuecomment-1339915587 > Did you want to leave the remaining `?debugHere` statements in case this doesn't fix it? > > ``` > smoosh_tests:27: -smoosh_test_/0-fun-10-

[GitHub] [couchdb-fauxton] Antonio-Maranhao commented on issue #1372: add “What’s New” link in sidebar under version number:

2022-12-06 Thread GitBox
Antonio-Maranhao commented on issue #1372: URL: https://github.com/apache/couchdb-fauxton/issues/1372#issuecomment-1339907869 @janl The docs server doesn't seem to have older versions online - e.g. https://docs.couchdb.org/en/3.1.1-docs/whatsnew/3.1.html doesn't work - so the link will

[GitHub] [couchdb] nickva opened a new pull request, #4294: Fix flaky checkpointing smoosh test

2022-12-06 Thread GitBox
nickva opened a new pull request, #4294: URL: https://github.com/apache/couchdb/pull/4294 This may not be a 100% fix just doing extra asserts that file operations have succeeded and making to wait for the compactor to exit and match the exit reason exactly, to make sure we killed and it

[GitHub] [couchdb] janl commented on issue #3517: Performance regression on CouchDB v3 while using custom reduce function

2022-12-06 Thread GitBox
janl commented on issue #3517: URL: https://github.com/apache/couchdb/issues/3517#issuecomment-1339463733 feel free to try a newer spidermonkey, 60, 68, 78, 86, 91 all work: https://github.com/apache/couchdb/blob/main/src/couch/rebar.config.script#L62-L71 build CouchDB with `./configure

[GitHub] [couchdb] janl commented on issue #3517: Performance regression on CouchDB v3 while using custom reduce function

2022-12-06 Thread GitBox
janl commented on issue #3517: URL: https://github.com/apache/couchdb/issues/3517#issuecomment-1339405256 we don't have images for PRs, sorry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [couchdb-fauxton] Antonio-Maranhao merged pull request #1373: upgrade fs-extra package

2022-12-06 Thread GitBox
Antonio-Maranhao merged PR #1373: URL: https://github.com/apache/couchdb-fauxton/pull/1373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] konrad-ohms commented on issue #3517: Performance regression on CouchDB v3 while using custom reduce function

2022-12-06 Thread GitBox
konrad-ohms commented on issue #3517: URL: https://github.com/apache/couchdb/issues/3517#issuecomment-1339319235 Hey @janl, thanks for picking the issue up again. I tried to rebuild but hit a dependency problem in the docker build, I guess I might have missed overwriting certain

[GitHub] [couchdb-fauxton] fryjordan opened a new pull request, #1373: upgrade fs-extra package

2022-12-06 Thread GitBox
fryjordan opened a new pull request, #1373: URL: https://github.com/apache/couchdb-fauxton/pull/1373 ## Overview - Update `fs-extra` from `10.1.0` to `11.1.0` ## Testing recommendations - Check that add ons are loaded correctly. - `grunt get_deps` -- This is an

[GitHub] [couchdb] rnewson commented on a diff in pull request #4291: Import nouveau

2022-12-06 Thread GitBox
rnewson commented on code in PR #4291: URL: https://github.com/apache/couchdb/pull/4291#discussion_r1040895505 ## java/nouveau/pom.xml: ## @@ -0,0 +1,216 @@

[GitHub] [couchdb] janl commented on issue #3517: Performance regression on CouchDB v3 while using custom reduce function

2022-12-06 Thread GitBox
janl commented on issue #3517: URL: https://github.com/apache/couchdb/issues/3517#issuecomment-1339219475 @konrad-ohms @AltenTMAOrion — I put up a new super-simple PR that I’d love for you to try: https://github.com/apache/couchdb/pull/4292 -- This is an automated message from the Apache

[GitHub] [couchdb] janl opened a new issue, #4293: Fauxton: add “What’s New” link in sidebar under version number

2022-12-06 Thread GitBox
janl opened a new issue, #4293: URL: https://github.com/apache/couchdb/issues/4293 [couchdb-fauxton#1372](https://github.com/apache/couchdb-fauxton/issues/1372) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [couchdb] janl opened a new pull request, #4292: fix(3517): super-simplistic fix to avoid costly AST transforms when t…

2022-12-06 Thread GitBox
janl opened a new pull request, #4292: URL: https://github.com/apache/couchdb/pull/4292 …hey are not needed. ``` // low-key check if we actually have to do an AST transform // most users’ functions start with the keyword function // and if that’s the case, we

[GitHub] [couchdb] janl commented on pull request #4291: Import nouveau

2022-12-06 Thread GitBox
janl commented on PR #4291: URL: https://github.com/apache/couchdb/pull/4291#issuecomment-1339202375 @rnewson this is great, thanks a lot: for sake of easier consumption, it might be useful if you could pull out examples for what index definition and querying looks like in Search2

[GitHub] [couchdb] janl commented on a diff in pull request #4291: Import nouveau

2022-12-06 Thread GitBox
janl commented on code in PR #4291: URL: https://github.com/apache/couchdb/pull/4291#discussion_r1040869629 ## java/nouveau/pom.xml: ## @@ -0,0 +1,216 @@

[GitHub] [couchdb] janl commented on a diff in pull request #4291: Import nouveau

2022-12-06 Thread GitBox
janl commented on code in PR #4291: URL: https://github.com/apache/couchdb/pull/4291#discussion_r1040865522 ## java/nouveau/pom.xml: ## @@ -0,0 +1,216 @@

[GitHub] [couchdb-fauxton] janl opened a new issue, #1372: add “What’s New” link in sidebar under version number:

2022-12-06 Thread GitBox
janl opened a new issue, #1372: URL: https://github.com/apache/couchdb-fauxton/issues/1372 In an effort to get folks read about what is new in CouchDB, there could be a link here in the sidebar, pointing to https://docs.couchdb.org/en/3.2.2-docs/whatsnew/3.2.html with the matching

[GitHub] [couchdb-helm] willholley commented on pull request #95: add service.labels and fix ingress service reference

2022-12-05 Thread GitBox
willholley commented on PR #95: URL: https://github.com/apache/couchdb-helm/pull/95#issuecomment-1338880910 @colearendt can you describe how you envisage `NEWS.md` being managed? I need to update the repository README and GitHub templates to support the release process via GitHub actions

[GitHub] [couchdb-helm] willholley merged pull request #82: Add helm-docs

2022-12-05 Thread GitBox
willholley merged PR #82: URL: https://github.com/apache/couchdb-helm/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb-helm] willholley commented on pull request #75: ingress.className added

2022-12-05 Thread GitBox
willholley commented on PR #75: URL: https://github.com/apache/couchdb-helm/pull/75#issuecomment-1338867677 @sebastien-helbert can you rebase this on main and delete the chart tarball from the PR? The chart test / release process is now supported by GitHub actions so the manual step of

[GitHub] [couchdb-helm] krische commented on pull request #75: ingress.className added

2022-12-05 Thread GitBox
krische commented on PR #75: URL: https://github.com/apache/couchdb-helm/pull/75#issuecomment-1338285277 Will this be merging soon? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [couchdb] rnewson opened a new pull request, #4291: Import nouveau

2022-12-05 Thread GitBox
rnewson opened a new pull request, #4291: URL: https://github.com/apache/couchdb/pull/4291 This PR imports both halves of the "nouveau" project I've been working on as a possible replacement for dreyfus/clouseau, the current approach to supplementing CouchDB's indexing feature (map/reduce)

[GitHub] [couchdb] nickva merged pull request #4290: Ensure prevent_overlapping_partitions stays false in Erlang 25+

2022-12-05 Thread GitBox
nickva merged PR #4290: URL: https://github.com/apache/couchdb/pull/4290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva opened a new pull request, #4290: Ensure prevent_overlapping_partitions stays false in Erlang 25+

2022-12-05 Thread GitBox
nickva opened a new pull request, #4290: URL: https://github.com/apache/couchdb/pull/4290 It's already false in 23 and 24 but will start to be enabled in 25+. We don't rely on global for process registration any more, and have our own auto-connection module. So we don't want to be caught

[GitHub] [couchdb] big-r81 merged pull request #4289: Fix unbound variable warning

2022-12-05 Thread GitBox
big-r81 merged PR #4289: URL: https://github.com/apache/couchdb/pull/4289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] big-r81 commented on a diff in pull request #4289: Fix unbound variable warning

2022-12-05 Thread GitBox
big-r81 commented on code in PR #4289: URL: https://github.com/apache/couchdb/pull/4289#discussion_r1039717917 ## src/couch/src/couch_server.erl: ## @@ -416,10 +416,11 @@ all_databases(Fun, Acc0) -> true, fun(Filename, AccIn) ->

[GitHub] [couchdb] nickva commented on a diff in pull request #4289: Fix unbound variable warning

2022-12-05 Thread GitBox
nickva commented on code in PR #4289: URL: https://github.com/apache/couchdb/pull/4289#discussion_r1039713337 ## src/couch/src/couch_server.erl: ## @@ -416,10 +416,11 @@ all_databases(Fun, Acc0) -> true, fun(Filename, AccIn) ->

[GitHub] [couchdb] big-r81 opened a new pull request, #4289: Fix unbound variable warning

2022-12-05 Thread GitBox
big-r81 opened a new pull request, #4289: URL: https://github.com/apache/couchdb/pull/4289 ## Overview While the variable `RelativeFileName` is not really unbound in the case-statement, use a more up-to-date pattern for binding the value. -- This is an automated message from

[GitHub] [couchdb] big-r81 opened a new pull request, #4288: Spidermonkey version NIF

2022-12-05 Thread GitBox
big-r81 opened a new pull request, #4288: URL: https://github.com/apache/couchdb/pull/4288 ## Overview Created an Erlang NIF to get the Spidermonkey version from the linked library. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [couchdb] nickva merged pull request #4287: Allow = in config key names

2022-12-04 Thread GitBox
nickva merged PR #4287: URL: https://github.com/apache/couchdb/pull/4287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva closed issue #3319: Error loading config key from local.ini with scaped (equal) = char

2022-12-04 Thread GitBox
nickva closed issue #3319: Error loading config key from local.ini with scaped (equal) = char URL: https://github.com/apache/couchdb/issues/3319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [couchdb] nickva commented on pull request #4287: Allow = in config key names

2022-12-03 Thread GitBox
nickva commented on PR #4287: URL: https://github.com/apache/couchdb/pull/4287#issuecomment-1336335490 Updated and added docs for it. When adding docs a typo (`[jwt_key]` should be `[jwt_keys]`) so fixed that along the way as well. In addition manually tested that it's

[GitHub] [couchdb] nickva commented on pull request #4287: Allow = in config key names

2022-12-03 Thread GitBox
nickva commented on PR #4287: URL: https://github.com/apache/couchdb/pull/4287#issuecomment-1336334575 > Just a couple nits: First, the title of the PR "Allow = in config key values" makes it sound like we're allowing the `=` character in the _values_, but I think you mean "key names"?

[GitHub] [couchdb] nickva commented on a diff in pull request #4287: Allow = in config key names

2022-12-03 Thread GitBox
nickva commented on code in PR #4287: URL: https://github.com/apache/couchdb/pull/4287#discussion_r1038896038 ## src/config/src/config.erl: ## @@ -414,89 +415,73 @@ is_sensitive(Section, Key) -> end. parse_ini_file(IniFile) -> +IniBin = read_ini_file(IniFile), +

[GitHub] [couchdb] nickva commented on a diff in pull request #4287: Allow = in config key names

2022-12-03 Thread GitBox
nickva commented on code in PR #4287: URL: https://github.com/apache/couchdb/pull/4287#discussion_r1038896075 ## src/config/src/config.erl: ## @@ -414,89 +415,73 @@ is_sensitive(Section, Key) -> end. parse_ini_file(IniFile) -> +IniBin = read_ini_file(IniFile), +

[GitHub] [couchdb] nickva commented on a diff in pull request #4287: Allow = in config key names

2022-12-03 Thread GitBox
nickva commented on code in PR #4287: URL: https://github.com/apache/couchdb/pull/4287#discussion_r1038896038 ## src/config/src/config.erl: ## @@ -414,89 +415,73 @@ is_sensitive(Section, Key) -> end. parse_ini_file(IniFile) -> +IniBin = read_ini_file(IniFile), +

[GitHub] [couchdb] jaydoane commented on a diff in pull request #4287: Allow = in config key values

2022-12-03 Thread GitBox
jaydoane commented on code in PR #4287: URL: https://github.com/apache/couchdb/pull/4287#discussion_r1038871687 ## src/config/src/config.erl: ## @@ -414,89 +415,73 @@ is_sensitive(Section, Key) -> end. parse_ini_file(IniFile) -> +IniBin = read_ini_file(IniFile), +

[GitHub] [couchdb] jaydoane commented on pull request #4287: Allow = in config key values

2022-12-03 Thread GitBox
jaydoane commented on PR #4287: URL: https://github.com/apache/couchdb/pull/4287#issuecomment-1336273945 Just a couple nits: First, the title of the PR "Allow = in config key values" makes it sound like we're allowing the `=` character in the _values_, but I think you mean "key names"?

[GitHub] [couchdb] nickva commented on issue #3319: Error loading config key from local.ini with scaped (equal) = char

2022-12-03 Thread GitBox
nickva commented on issue #3319: URL: https://github.com/apache/couchdb/issues/3319#issuecomment-1336198290 I tried a different approach here where we allow `=` in the key with the constraint that we have to use ` = ` (have a space before and after `=`) form.

[GitHub] [couchdb] nickva opened a new pull request, #4287: Allow = in config key values

2022-12-03 Thread GitBox
nickva opened a new pull request, #4287: URL: https://github.com/apache/couchdb/pull/4287 There are allowed only for the `k = v` form and not `k=v`. The idea is to split on ` = ` first, and if that fails to produce a valid kv pair we split on `=` as before. To implement, simplify

[GitHub] [couchdb-helm] lmorandini commented on issue #33: Problem with enableSearch=True (Could not connect to the Clouseau Java service)

2022-12-03 Thread GitBox
lmorandini commented on issue #33: URL: https://github.com/apache/couchdb-helm/issues/33#issuecomment-1336110776 Same here, but with `kocolosk/couchdb-search:0.2.0` on Helm Chart `3.5.1` (CouchDB `3.2.1`). -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [couchdb] nickva commented on issue #4159: Couch DB scan inconsistency issue

2022-12-02 Thread GitBox
nickva commented on issue #4159: URL: https://github.com/apache/couchdb/issues/4159#issuecomment-1335835116 Closing since there is no activity in a few months -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [couchdb] nickva closed issue #4159: Couch DB scan inconsistency issue

2022-12-02 Thread GitBox
nickva closed issue #4159: Couch DB scan inconsistency issue URL: https://github.com/apache/couchdb/issues/4159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [couchdb] nickva merged pull request #4286: Increase ddoc_cache test timeouts

2022-12-02 Thread GitBox
nickva merged PR #4286: URL: https://github.com/apache/couchdb/pull/4286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva opened a new pull request, #4286: Increase ddoc_cache test timeouts

2022-12-02 Thread GitBox
nickva opened a new pull request, #4286: URL: https://github.com/apache/couchdb/pull/4286 To hopefully fix a flaky test I noticed: ``` module 'ddoc_cache_lru_test' ... ddoc_cache_lru_test:97: with (check_cache_refill)...*failed* ... in function meck_proc:wait/6

[GitHub] [couchdb] nickva merged pull request #4285: Add debug logs to smoosh test

2022-12-02 Thread GitBox
nickva merged PR #4285: URL: https://github.com/apache/couchdb/pull/4285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on a diff in pull request #4284: Remove all usage of global

2022-12-02 Thread GitBox
nickva commented on code in PR #4284: URL: https://github.com/apache/couchdb/pull/4284#discussion_r1038348391 ## src/couch_replicator/src/couch_replicator_scheduler_job.erl: ## @@ -406,6 +417,18 @@ terminate({shutdown, max_backoff}, State) -> ),

[GitHub] [couchdb] nickva merged pull request #4284: Remove all usage of global

2022-12-02 Thread GitBox
nickva merged PR #4284: URL: https://github.com/apache/couchdb/pull/4284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] jaydoane commented on a diff in pull request #4284: Remove all usage of global

2022-12-02 Thread GitBox
jaydoane commented on code in PR #4284: URL: https://github.com/apache/couchdb/pull/4284#discussion_r1038327083 ## src/couch_replicator/src/couch_replicator_scheduler_job.erl: ## @@ -406,6 +417,18 @@ terminate({shutdown, max_backoff}, State) -> ),

[GitHub] [couchdb] nickva commented on a diff in pull request #4285: Add debug logs to smoosh test

2022-12-02 Thread GitBox
nickva commented on code in PR #4285: URL: https://github.com/apache/couchdb/pull/4285#discussion_r1038334171 ## src/smoosh/test/smoosh_tests.erl: ## @@ -239,24 +239,33 @@ t_checkpointing_works(DbName) -> setup_db_compactor_intercept(), {ok, _} = delete_doc(DbName,

[GitHub] [couchdb] jaydoane commented on a diff in pull request #4285: Add debug logs to smoosh test

2022-12-02 Thread GitBox
jaydoane commented on code in PR #4285: URL: https://github.com/apache/couchdb/pull/4285#discussion_r1038332868 ## src/smoosh/test/smoosh_tests.erl: ## @@ -239,24 +239,33 @@ t_checkpointing_works(DbName) -> setup_db_compactor_intercept(), {ok, _} = delete_doc(DbName,

[GitHub] [couchdb] nickva commented on pull request #4285: Add debug logs to smoosh test

2022-12-02 Thread GitBox
nickva commented on PR #4285: URL: https://github.com/apache/couchdb/pull/4285#issuecomment-1335508950 The output with the debug lines should look like: ``` smoosh_tests:27: smoosh_test_ (t_checkpointing_works)...test/smoosh_tests.erl:242:<0.1658.0>: <-

[GitHub] [couchdb] nickva opened a new pull request, #4285: Add debug logs to smoosh test

2022-12-02 Thread GitBox
nickva opened a new pull request, #4285: URL: https://github.com/apache/couchdb/pull/4285 Saw this fail 2 in a the last week or so but couldn't reproduce it locally. Instead of deleting, this is an attempt to emit debug lines to see how far it goes before it times out in the CI. --

[GitHub] [couchdb] nickva commented on a diff in pull request #4284: Remove all usage of global

2022-12-01 Thread GitBox
nickva commented on code in PR #4284: URL: https://github.com/apache/couchdb/pull/4284#discussion_r1037552866 ## src/couch_replicator/src/couch_replicator_pg.erl: ## @@ -0,0 +1,86 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file

[GitHub] [couchdb] nickva commented on a diff in pull request #4284: Remove all usage of global

2022-12-01 Thread GitBox
nickva commented on code in PR #4284: URL: https://github.com/apache/couchdb/pull/4284#discussion_r1037552866 ## src/couch_replicator/src/couch_replicator_pg.erl: ## @@ -0,0 +1,86 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file

[GitHub] [couchdb] nickva commented on a diff in pull request #4284: Remove all usage of global

2022-12-01 Thread GitBox
nickva commented on code in PR #4284: URL: https://github.com/apache/couchdb/pull/4284#discussion_r1037552866 ## src/couch_replicator/src/couch_replicator_pg.erl: ## @@ -0,0 +1,86 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file

[GitHub] [couchdb] jaydoane commented on a diff in pull request #4284: Remove all usage of global

2022-12-01 Thread GitBox
jaydoane commented on code in PR #4284: URL: https://github.com/apache/couchdb/pull/4284#discussion_r1037547724 ## src/couch_replicator/src/couch_replicator_pg.erl: ## @@ -0,0 +1,86 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this

[GitHub] [couchdb] nickva opened a new pull request, #4284: Remove all usage of global

2022-12-01 Thread GitBox
nickva opened a new pull request, #4284: URL: https://github.com/apache/couchdb/pull/4284 Global has a tendency to create deadlocks [1], and when that happens replication jobs can't start on any of the nodes in the cluster. We don't really need strict consistent locking for

[GitHub] [couchdb] nickva opened a new issue, #4283: create_if_missing doesn't always take effect

2022-12-01 Thread GitBox
nickva opened a new issue, #4283: URL: https://github.com/apache/couchdb/issues/4283 In the logs we see: ``` [warning] 2022-12-01T06:27:19.402535Z couc...@couchdb-couchdb-1.couchdb-couchdb.drive-app.svc.cluster.local <0.1954.0> mem3_sync

[GitHub] [couchdb] nickva closed issue #4282: Cannot get to the COUCHDB repo on RHEL 7-8 or Rocky 8

2022-12-01 Thread GitBox
nickva closed issue #4282: Cannot get to the COUCHDB repo on RHEL 7-8 or Rocky 8 URL: https://github.com/apache/couchdb/issues/4282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [couchdb] nickva commented on issue #4282: Cannot get to the COUCHDB repo on RHEL 7-8 or Rocky 8

2022-12-01 Thread GitBox
nickva commented on issue #4282: URL: https://github.com/apache/couchdb/issues/4282#issuecomment-1334128022 apache.bintray.com is decommissioned (all of bintray is I think). see https://docs.couchdb.org/en/3.2.2-docs/install/unix.html#enabling-the-apache-couchdb-package-repository

[GitHub] [couchdb] hostingwiz opened a new issue, #4282: Cannot get to the COUCHDB repo on RHEL 7-8 or Rocky 8

2022-12-01 Thread GitBox
hostingwiz opened a new issue, #4282: URL: https://github.com/apache/couchdb/issues/4282 Hello, I cannot update COUCHDB as I cannot get to the repo and I have tried the url from many different networks. http://apache.bintray.com/couchdb-rpm/el7/x86_64/repodata/repomd.xml:

[GitHub] [couchdb] nickva closed issue #4273: Port some replicator features from fdbmain

2022-11-29 Thread GitBox
nickva closed issue #4273: Port some replicator features from fdbmain URL: https://github.com/apache/couchdb/issues/4273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] nickva merged pull request #4274: Improve validation of replicator job parameters

2022-11-29 Thread GitBox
nickva merged PR #4274: URL: https://github.com/apache/couchdb/pull/4274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on a diff in pull request #4274: Improve validation of replicator job parameters

2022-11-29 Thread GitBox
nickva commented on code in PR #4274: URL: https://github.com/apache/couchdb/pull/4274#discussion_r1035509784 ## src/couch_replicator/src/couch_replicator_parse.erl: ## @@ -0,0 +1,750 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this

[GitHub] [couchdb] jaydoane commented on a diff in pull request #4274: Improve validation of replicator job parameters

2022-11-29 Thread GitBox
jaydoane commented on code in PR #4274: URL: https://github.com/apache/couchdb/pull/4274#discussion_r1035462921 ## src/couch_replicator/src/couch_replicator_parse.erl: ## @@ -0,0 +1,750 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use

[GitHub] [couchdb] nickva commented on pull request #4274: Improve validation of replicator job parameters

2022-11-28 Thread GitBox
nickva commented on PR #4274: URL: https://github.com/apache/couchdb/pull/4274#issuecomment-1330160438 Note for the reviewer: the diff looks a bit larger than it is, but it's mostly because the parsing functions were moved to a separate parsing module - `couch_replicator_parse`. This idea

[GitHub] [couchdb] nickva merged pull request #4276: Format config files to improve readability

2022-11-28 Thread GitBox
nickva merged PR #4276: URL: https://github.com/apache/couchdb/pull/4276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on pull request #4276: Format config files to improve readability

2022-11-28 Thread GitBox
nickva commented on PR #4276: URL: https://github.com/apache/couchdb/pull/4276#issuecomment-1330039919 @big-r81 mind if I merge it? I have a PR pending which touch the .ini so didn't want to have to solve conflicts. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [couchdb] nickva merged pull request #4280: chore: configurable ICU locations

2022-11-28 Thread GitBox
nickva merged PR #4280: URL: https://github.com/apache/couchdb/pull/4280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on pull request #4280: chore: configurable ICU locations

2022-11-28 Thread GitBox
nickva commented on PR #4280: URL: https://github.com/apache/couchdb/pull/4280#issuecomment-1329577926 Merging PR. Thank you for your contribution, @jo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [couchdb] jo opened a new pull request, #4280: chore: configurable ICU locations

2022-11-28 Thread GitBox
jo opened a new pull request, #4280: URL: https://github.com/apache/couchdb/pull/4280 add `LDFLAGS` and `CFLAGS` environment variables to `IcuEnv` in rebar config to be able to configure ICU includes and object paths via environment variable without having to patch `rebar.config.script`.

[GitHub] [couchdb] nickva commented on issue #4273: Port some replicator features from fdbmain

2022-11-28 Thread GitBox
nickva commented on issue #4273: URL: https://github.com/apache/couchdb/issues/4273#issuecomment-1329387314 It's pretty wild that we allow arbitrary socket settings to be used in replication options. Even the `valid` list from

[GitHub] [couchdb] nickva commented on issue #4273: Port some replicator features from fdbmain

2022-11-28 Thread GitBox
nickva commented on issue #4273: URL: https://github.com/apache/couchdb/issues/4273#issuecomment-1329383477 Work on improving the replication parser started in https://github.com/apache/couchdb/pull/4274 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [couchdb] inthegarage opened a new issue, #4279: Linux Mint (Ubuntu 20.04 derivat) has installation issues

2022-11-28 Thread GitBox
inthegarage opened a new issue, #4279: URL: https://github.com/apache/couchdb/issues/4279 ## Description On an Ubuntu derivative (Linux Mint), there is a installation issue when using the apt-get system. The default couchdb.list entry is not correct for this environment. The actual

[GitHub] [couchdb] big-r81 opened a new pull request, #4276: Format config files to improve readability

2022-11-28 Thread GitBox
big-r81 opened a new pull request, #4276: URL: https://github.com/apache/couchdb/pull/4276 ## Overview Adjust configuration files to improve readability. The default config files have a mix of different definition of config keys. Some lines start with

[GitHub] [couchdb] big-r81 commented on issue #4265: CPU High

2022-11-27 Thread GitBox
big-r81 commented on issue #4265: URL: https://github.com/apache/couchdb/issues/4265#issuecomment-1328588728 Are there any active tasks in CouchDB while erl-CPU is high? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [couchdb] waversky commented on issue #4265: CPU High

2022-11-27 Thread GitBox
waversky commented on issue #4265: URL: https://github.com/apache/couchdb/issues/4265#issuecomment-1328406728 After Windows sleep for a weekend, activate Windows, erl.exe CPU usage reaches 50% - 70%, It may be related to the windows sleep switch -- This is an automated message from the

[GitHub] [couchdb] garrensmith closed pull request #2984: Fdb simple reduce

2022-11-25 Thread GitBox
garrensmith closed pull request #2984: Fdb simple reduce URL: https://github.com/apache/couchdb/pull/2984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [couchdb-glazier] big-r81 merged pull request #17: Create dummy logfile without BOM

2022-11-24 Thread GitBox
big-r81 merged PR #17: URL: https://github.com/apache/couchdb-glazier/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] rnewson merged pull request #4275: add warning about misapprehending the node-local interface

2022-11-24 Thread GitBox
rnewson merged PR #4275: URL: https://github.com/apache/couchdb/pull/4275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] ornotnull commented on issue #4244: _revs_limit & _purged_infos_limit are not saved

2022-11-23 Thread GitBox
ornotnull commented on issue #4244: URL: https://github.com/apache/couchdb/issues/4244#issuecomment-1324845246 restart performed after compaction is finished -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [couchdb] nickva opened a new pull request, #4274: [wip] Replace the auto-inserted replicator VDU with a BDU

2022-11-22 Thread GitBox
nickva opened a new pull request, #4274: URL: https://github.com/apache/couchdb/pull/4274 WIP, only checked that it compiles. Didn't update or add any tests yet. Switch out the VDU with a BDU (before_doc_update) check. Couch replicator already had a BDU to update the `"owner"` field

[GitHub] [couchdb] nickva commented on issue #4273: Port some replicator features from fdbmain

2022-11-22 Thread GitBox
nickva commented on issue #4273: URL: https://github.com/apache/couchdb/issues/4273#issuecomment-1323932426 It looks like most of the above commits except https://github.com/apache/couchdb/commit/b38d77fbada7cce7de288d2cdcca8839b09888f4 are already merged to `main`. Directly cherry

<    1   2   3   4   5   6   7   8   9   10   >