[GitHub] [couchdb] rnewson opened a new pull request, #4749: Nouveau ibrowse improvements

2023-09-05 Thread via GitHub
rnewson opened a new pull request, #4749: URL: https://github.com/apache/couchdb/pull/4749 ## Overview This is a performance only pull request, but a complicated one. I benchmarked nouveau against clouseau for the same database and found it was slower (2-4x slower depending on

[GitHub] [couchdb] rnewson commented on pull request #4749: Nouveau ibrowse improvements

2023-09-05 Thread via GitHub
rnewson commented on PR #4749: URL: https://github.com/apache/couchdb/pull/4749#issuecomment-1706470504 Noting that these changes bring nouveau index build times in line with clouseau index build times; they come out the same. -- This is an automated message from the Apache Git Service.

[GitHub] [couchdb-nano] YakovL opened a new pull request, #333: docs: correct db.destroy description

2023-09-05 Thread via GitHub
YakovL opened a new pull request, #333: URL: https://github.com/apache/couchdb-nano/pull/333 The current description of `db.destroy` mixes up `_rev` (referring to where revision is stored) and `rev` (the function argument). This small change is to sort things out. -- This is an

[GitHub] [couchdb] nickva commented on issue #4448: Investigate using QuickJS as a Javascript Engine

2023-09-05 Thread via GitHub
nickva commented on issue #4448: URL: https://github.com/apache/couchdb/issues/4448#issuecomment-1707183434 To avoid managing a new data state directory (config option, checking for disk space, handling read-only or other errors), it would be a lot simpler to manage the checkpoints as

[GitHub] [couchdb] fr2lancer opened a new issue, #4747: Couch db hung and system unstable after periods of times

2023-09-03 Thread via GitHub
fr2lancer opened a new issue, #4747: URL: https://github.com/apache/couchdb/issues/4747 [NOTE]: # ( ^^ Provide a general summary of the issue in the title above. ^^ ) ## Description After couchdb 3 was installed successfully, -> no modified in vm.cfg and minimal config in

[GitHub] [couchdb] fr2lancer opened a new issue, #4748: weatherreport show error when execute

2023-09-03 Thread via GitHub
fr2lancer opened a new issue, #4748: URL: https://github.com/apache/couchdb/issues/4748 [NOTE]: # ( ^^ Provide a general summary of the issue in the title above. ^^ ) ## Description Regarding to the ticket( https://github.com/apache/couchdb/issues/4747 ) I wanted to use a

[GitHub] [couchdb] fr2lancer commented on issue #4748: weatherreport show error when execute

2023-09-05 Thread via GitHub
fr2lancer commented on issue #4748: URL: https://github.com/apache/couchdb/issues/4748#issuecomment-1707443669 Hi @big-r81 Thanks for the commenting. Just a bit wonder, export PATH=$PATH:/opt/couchdb/erts-12.3.2.10/bin/ **export PATH=$PATH:/opt/couchdb/etc/ <- is that what

[GitHub] [couchdb-pkg] nickva commented on issue #112: Debian Bookworm packages please

2023-09-10 Thread via GitHub
nickva commented on issue #112: URL: https://github.com/apache/couchdb-pkg/issues/112#issuecomment-1712874146 There seems to be an included [libmozjs-78](https://packages.debian.org/bookworm/libmozjs-78-0) package so it should be doable. -- This is an automated message from the

[GitHub] [couchdb-pkg] big-r81 closed issue #108: .deb packages for s390x cpu on Ubuntu jammy and lunar

2023-09-10 Thread via GitHub
big-r81 closed issue #108: .deb packages for s390x cpu on Ubuntu jammy and lunar URL: https://github.com/apache/couchdb-pkg/issues/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [couchdb] rnewson commented on pull request #4673: Per document access control

2023-09-07 Thread via GitHub
rnewson commented on PR #4673: URL: https://github.com/apache/couchdb/pull/4673#issuecomment-1710047327 @arturog I think secondary indexes would need to be updated to support this for it to have the desired effect (restricting a user's visibility of a database to a subset). I'm sure

[GitHub] [couchdb] arturog commented on pull request #4673: Per document access control

2023-09-07 Thread via GitHub
arturog commented on PR #4673: URL: https://github.com/apache/couchdb/pull/4673#issuecomment-1709893420 I am coming back to couchdb updating an old application that *has already* implemented the above (per-document access, with linux-like permissions like owner/read/write access, even

[GitHub] [couchdb] rnewson commented on a diff in pull request #4735: feat(`mango`): rolling execution statistics

2023-09-11 Thread via GitHub
rnewson commented on code in PR #4735: URL: https://github.com/apache/couchdb/pull/4735#discussion_r1321494553 ## src/mango/src/mango_cursor_view.erl: ## @@ -337,19 +349,48 @@ choose_best_index(IndexRanges) -> {SelectedIndex, SelectedIndexRanges, _} = hd(lists:sort(Cmp,

[GitHub] [couchdb] rnewson merged pull request #4749: Nouveau ibrowse improvements

2023-09-11 Thread via GitHub
rnewson merged PR #4749: URL: https://github.com/apache/couchdb/pull/4749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] rnewson commented on pull request #4755: Add tests for X-Forwarded-For

2023-09-11 Thread via GitHub
rnewson commented on PR #4755: URL: https://github.com/apache/couchdb/pull/4755#issuecomment-1714287565 I should say, even if it does test couchdb (that is touch real chttpd and real mochiweb, not mocked versions), the problem we're addressing was not what couchdb logged anyway. it was

[GitHub] [couchdb] iilyak opened a new pull request, #4755: Add tests for X-Forwarded-For

2023-09-11 Thread via GitHub
iilyak opened a new pull request, #4755: URL: https://github.com/apache/couchdb/pull/4755 ## Overview This PR adds test cases to verify that we log the real IP address of a user when X-Forwarded-For header is present. ## Testing recommendations ``` make eunit

[GitHub] [couchdb] iilyak commented on pull request #4755: Add tests for X-Forwarded-For

2023-09-11 Thread via GitHub
iilyak commented on PR #4755: URL: https://github.com/apache/couchdb/pull/4755#issuecomment-1714289761 Closing as this is not addressing the real problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [couchdb] iilyak closed pull request #4755: Add tests for X-Forwarded-For

2023-09-11 Thread via GitHub
iilyak closed pull request #4755: Add tests for X-Forwarded-For URL: https://github.com/apache/couchdb/pull/4755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] rnewson commented on pull request #4755: Add tests for X-Forwarded-For

2023-09-11 Thread via GitHub
rnewson commented on PR #4755: URL: https://github.com/apache/couchdb/pull/4755#issuecomment-1714283996 I like the coverage but I don't think it tests _couchdb_. It asserts the behaviour of a mochiweb function, but not whether we call it and use the result to populate `peer` There

[GitHub] [couchdb] pgj opened a new pull request, #4756: fix(`mango`): align `opts.fields` with `fields` on `_explain`

2023-09-11 Thread via GitHub
pgj opened a new pull request, #4756: URL: https://github.com/apache/couchdb/pull/4756 This is a follow-up to 83e39b6d where the `all_fields` value was replaced for `[]` to preserve the JSON array type. The same has to be done for `fields` in the `opts` nesting object as well — these two

[GitHub] [couchdb] nickva commented on issue #4448: Investigate using QuickJS as a Javascript Engine

2023-09-11 Thread via GitHub
nickva commented on issue #4448: URL: https://github.com/apache/couchdb/issues/4448#issuecomment-1714673445 The callback API for each scanner module might look like: ```erlang {ok, Ctx} = start_scan(#{session_id => Uuid, start_timestamp => UnixTs}) {ok, Ctx1} = start_db(Ctx,

[GitHub] [couchdb-helm] urbaman commented on issue #130: Fresh 3 Nodes cluster do not pass Fauxton GUI replica check.

2023-09-15 Thread via GitHub
urbaman commented on issue #130: URL: https://github.com/apache/couchdb-helm/issues/130#issuecomment-1721410956 Update: Connecting to the single node's Fauxton GUI, and doing a manaul check (connect to node 1, create db, connect to node 2, check db presence), the replication seems

[GitHub] [couchdb] pgj opened a new pull request, #4764: fix(`chttpd`): comment typo

2023-09-15 Thread via GitHub
pgj opened a new pull request, #4764: URL: https://github.com/apache/couchdb/pull/4764 A follow-up commit to deddbb2 where a typo was noticed in the contents after it has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [couchdb-helm] urbaman opened a new issue, #130: Fresh 3 Nodes cluster do not pass Fauxton GUI replica check.

2023-09-15 Thread via GitHub
urbaman opened a new issue, #130: URL: https://github.com/apache/couchdb-helm/issues/130 **Describe the bug** Did a fresh setup: helm repo add couchdb https://apache.github.io/couchdb-helm helm repo update helm install couchdb couchdb/couchdb --set

[GitHub] [couchdb] pgj merged pull request #4764: fix(`chttpd`): comment typo

2023-09-15 Thread via GitHub
pgj merged PR #4764: URL: https://github.com/apache/couchdb/pull/4764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] pgj commented on pull request #4764: fix(`chttpd`): comment typo

2023-09-15 Thread via GitHub
pgj commented on PR #4764: URL: https://github.com/apache/couchdb/pull/4764#issuecomment-1721508727 Thanks @iilyak! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] pgj merged pull request #4763: fix(`mango`): plug hole in unit test coverage of view cursor functions

2023-09-15 Thread via GitHub
pgj merged PR #4763: URL: https://github.com/apache/couchdb/pull/4763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] pgj commented on pull request #4763: fix(`mango`): plug hole in unit test coverage of view cursor functions

2023-09-15 Thread via GitHub
pgj commented on PR #4763: URL: https://github.com/apache/couchdb/pull/4763#issuecomment-1721363383 Thanks @nickva! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] nickva commented on a diff in pull request #4761: Fix badrecord error when replicator is logging http usage

2023-09-14 Thread via GitHub
nickva commented on code in PR #4761: URL: https://github.com/apache/couchdb/pull/4761#discussion_r1326338963 ## src/couch_replicator/src/couch_replicator_utils.erl: ## @@ -682,4 +686,61 @@ auth_props(User, Pass) when is_list(User), is_list(Pass) -> ]}} ].

[GitHub] [couchdb] rnewson merged pull request #4759: Use HTTP rules for hostname verification

2023-09-14 Thread via GitHub
rnewson merged PR #4759: URL: https://github.com/apache/couchdb/pull/4759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] jaydoane commented on a diff in pull request #4761: Fix badrecord error when replicator is logging http usage

2023-09-14 Thread via GitHub
jaydoane commented on code in PR #4761: URL: https://github.com/apache/couchdb/pull/4761#discussion_r1326333678 ## src/couch_replicator/src/couch_replicator_utils.erl: ## @@ -682,4 +686,61 @@ auth_props(User, Pass) when is_list(User), is_list(Pass) -> ]}} ].

[GitHub] [couchdb] big-r81 opened a new pull request, #4766: [Draft] Adding smoosh:status to HTTP API

2023-09-16 Thread via GitHub
big-r81 opened a new pull request, #4766: URL: https://github.com/apache/couchdb/pull/4766 Adding the status of the CouchDB auto-compaction daemon to the HTTP API. Opening Draft-PR for comments. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [couchdb] nickva merged pull request #4765: Fix flaky mem3 reshard test

2023-09-15 Thread via GitHub
nickva merged PR #4765: URL: https://github.com/apache/couchdb/pull/4765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva opened a new pull request, #4765: Fix flaky mem3 reshard test

2023-09-15 Thread via GitHub
nickva opened a new pull request, #4765: URL: https://github.com/apache/couchdb/pull/4765 Saw this one fail multiple times already. Previously, we were counting the exact number of calls each of the mocked functions were called. However, those calls were made from separate processes

[GitHub] [couchdb] rnewson opened a new pull request, #4767: avoid badmatch in error cases

2023-09-16 Thread via GitHub
rnewson opened a new pull request, #4767: URL: https://github.com/apache/couchdb/pull/4767 ## Overview if :update returns an error we will now return this as the rexi reply, making for a better reported error. ## Testing recommendations N/A ## Related Issues or

[GitHub] [couchdb] nickva merged pull request #4744: Update mochiweb to 3.2.0

2023-08-31 Thread via GitHub
nickva merged PR #4744: URL: https://github.com/apache/couchdb/pull/4744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva opened a new pull request, #4744: Update mochiweb to 2.3.0

2023-08-31 Thread via GitHub
nickva opened a new pull request, #4744: URL: https://github.com/apache/couchdb/pull/4744 Mochiweb [2.3.0](https://github.com/mochi/mochiweb/releases/tag/v3.2.0) has a `mochiweb_request:is_closed/1` function which we can use instead of our socket check in `chttpd_util`. Since

[GitHub] [couchdb] jiahuili430 commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-08-31 Thread via GitHub
jiahuili430 commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1312345400 ## src/fabric/src/fabric_rpc.erl: ## @@ -299,6 +299,10 @@ update_docs(DbName, Docs0, Options) -> Docs2 = make_att_readers(Docs1), with_db(DbName,

[GitHub] [couchdb] big-r81 merged pull request #4743: Ban the last monster

2023-08-28 Thread via GitHub
big-r81 merged PR #4743: URL: https://github.com/apache/couchdb/pull/4743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on issue #4706: Elixir-based tests fail to run with Elixir 1.15

2023-08-28 Thread via GitHub
nickva commented on issue #4706: URL: https://github.com/apache/couchdb/issues/4706#issuecomment-1695955504 @jjrodrig one way to check dist behavior is to make a draft pr with a branch which starts with `jenkins-...` then we'd run the full CI which makes packages as the last step.

[GitHub] [couchdb] big-r81 opened a new pull request, #4743: Ban the last monster

2023-08-28 Thread via GitHub
big-r81 opened a new pull request, #4743: URL: https://github.com/apache/couchdb/pull/4743 Set an example cookie like in the cluster setup docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [couchdb] nickva commented on a diff in pull request #4662: feat(`mango`): extend `_explain` with candidate indexes and selector hints

2023-08-31 Thread via GitHub
nickva commented on code in PR #4662: URL: https://github.com/apache/couchdb/pull/4662#discussion_r1312459053 ## src/mango/src/mango_cursor.erl: ## @@ -44,27 +44,286 @@ -define(SUPERVISOR, mango_cursor_sup). -create(Db, Selector0, Opts) -> +-spec create(Db, Selector,

[GitHub] [couchdb] fr2lancer commented on issue #4733: file copy of .couch from 2.x isn't picked up by couchdb 3.3.2

2023-08-31 Thread via GitHub
fr2lancer commented on issue #4733: URL: https://github.com/apache/couchdb/issues/4733#issuecomment-1701998993 Thank you so much. I ended up copy whole files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [couchdb] big-r81 closed issue #4733: file copy of .couch from 2.x isn't picked up by couchdb 3.3.2

2023-09-01 Thread via GitHub
big-r81 closed issue #4733: file copy of .couch from 2.x isn't picked up by couchdb 3.3.2 URL: https://github.com/apache/couchdb/issues/4733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [couchdb] pgj commented on a diff in pull request #4662: feat(`mango`): extend `_explain` with candidate indexes and selector hints

2023-09-01 Thread via GitHub
pgj commented on code in PR #4662: URL: https://github.com/apache/couchdb/pull/4662#discussion_r1312863395 ## src/mango/src/mango_cursor.erl: ## @@ -44,27 +44,286 @@ -define(SUPERVISOR, mango_cursor_sup). -create(Db, Selector0, Opts) -> +-spec create(Db, Selector, Options,

[GitHub] [couchdb] pgj commented on a diff in pull request #4662: feat(`mango`): extend `_explain` with candidate indexes and selector hints

2023-09-01 Thread via GitHub
pgj commented on code in PR #4662: URL: https://github.com/apache/couchdb/pull/4662#discussion_r1312862465 ## src/docs/src/api/database/find.rst: ## @@ -1508,22 +1514,151 @@ it easier to take advantage of future improvements to query planning "title"

[GitHub] [couchdb] pgj commented on a diff in pull request #4662: feat(`mango`): extend `_explain` with candidate indexes and selector hints

2023-09-01 Thread via GitHub
pgj commented on code in PR #4662: URL: https://github.com/apache/couchdb/pull/4662#discussion_r1312867848 ## src/mango/src/mango_cursor.erl: ## @@ -44,27 +44,286 @@ -define(SUPERVISOR, mango_cursor_sup). -create(Db, Selector0, Opts) -> +-spec create(Db, Selector, Options,

[GitHub] [couchdb] streunerlein commented on issue #2635: Best practice for N-gram and set Lucene param with Clouseau

2023-09-01 Thread via GitHub
streunerlein commented on issue #2635: URL: https://github.com/apache/couchdb/issues/2635#issuecomment-1702635483 @natcohen I see your efforts here and appreciate them a lot. We are also eagerly looking out for an n-gram analyzer in Clouseau - but it seems to be very low priority.

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1313218625 ## src/chttpd/src/chttpd_httpd_handlers.erl: ## @@ -35,6 +35,7 @@ db_handler(<<"_design">>) -> fun chttpd_db:handle_design_req/2; db_handler(<<"_partition">>) -> fun

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1313200717 ## src/chttpd/test/eunit/chttpd_purge_tests.erl: ## @@ -205,287 +110,228 @@ test_accepted_purge_request(Url) -> {accepted, [

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1313236257 ## src/fabric/src/fabric_rpc.erl: ## @@ -299,6 +299,10 @@ update_docs(DbName, Docs0, Options) -> Docs2 = make_att_readers(Docs1), with_db(DbName, Options,

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1313230483 ## src/fabric/src/fabric_db_purged_infos.erl: ## @@ -0,0 +1,85 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except

[GitHub] [couchdb] nickva opened a new pull request, #4745: Increase timeout in mango_cursor tests

2023-09-01 Thread via GitHub
nickva opened a new pull request, #4745: URL: https://github.com/apache/couchdb/pull/4745 Noticed two consecutive failures there on ppc64le platform. That's usually the slowest executor so it's probalby just a timeout. Let's try bumping it from 5 sec to 10 sec. Re:

[GitHub] [couchdb] pgj merged pull request #4662: feat(`mango`): extend `_explain` with candidate indexes and selector hints

2023-09-01 Thread via GitHub
pgj merged PR #4662: URL: https://github.com/apache/couchdb/pull/4662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva opened a new pull request, #4746: Increase timeout in mango_cursor tests

2023-09-01 Thread via GitHub
nickva opened a new pull request, #4746: URL: https://github.com/apache/couchdb/pull/4746 Noticed two consecutive failures there on ppc64le platform. That's usually the slowest executor so it's probalby just a timeout. Let's try bumping it from 5 sec to 10 sec. ## Overview

[GitHub] [couchdb] nickva commented on pull request #4662: feat(`mango`): extend `_explain` with candidate indexes and selector hints

2023-09-01 Thread via GitHub
nickva commented on PR #4662: URL: https://github.com/apache/couchdb/pull/4662#issuecomment-1703174645 I noticed two failures in the full CI failure, both on ppc64le (Power) platform: ``` [2023-09-01T17:10:20.217Z] module 'mango_cursor' [2023-09-01T17:10:24.962Z]

[GitHub] [couchdb] pgj commented on pull request #4745: Increase timeout in mango_cursor tests

2023-09-01 Thread via GitHub
pgj commented on PR #4745: URL: https://github.com/apache/couchdb/pull/4745#issuecomment-1703187767 Thanks @nickva for fixing this. I agree with the approach and I will approve it if it can fix the issue. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [couchdb-fauxton] mharrigan26 opened a new pull request, #1412: Update chromedriver

2023-09-01 Thread via GitHub
mharrigan26 opened a new pull request, #1412: URL: https://github.com/apache/couchdb-fauxton/pull/1412 ## Overview Chromedriver installation was failing in the pipeline. This is because the chromedriver team migrated to a [new set of JSON

[GitHub] [couchdb] jiahuili430 commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
jiahuili430 commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1313532007 ## src/chttpd/src/chttpd_httpd_handlers.erl: ## @@ -35,6 +35,7 @@ db_handler(<<"_design">>) -> fun chttpd_db:handle_design_req/2; db_handler(<<"_partition">>) ->

[GitHub] [couchdb] jiahuili430 commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
jiahuili430 commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1313535277 ## src/chttpd/test/eunit/chttpd_purge_tests.erl: ## @@ -205,287 +110,228 @@ test_accepted_purge_request(Url) -> {accepted, [

[GitHub] [couchdb] nickva commented on pull request #4745: Increase timeout in mango_cursor tests

2023-09-01 Thread via GitHub
nickva commented on PR #4745: URL: https://github.com/apache/couchdb/pull/4745#issuecomment-1703278088 that seems to have fixed it: https://github.com/apache/couchdb/pull/4746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [couchdb] nickva merged pull request #4745: Increase timeout in mango_cursor tests

2023-09-01 Thread via GitHub
nickva merged PR #4745: URL: https://github.com/apache/couchdb/pull/4745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] jiahuili430 merged pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
jiahuili430 merged PR #4703: URL: https://github.com/apache/couchdb/pull/4703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva closed pull request #4746: Increase timeout in mango_cursor tests

2023-09-01 Thread via GitHub
nickva closed pull request #4746: Increase timeout in mango_cursor tests URL: https://github.com/apache/couchdb/pull/4746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-09-01 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1313538365 ## src/chttpd/src/chttpd_httpd_handlers.erl: ## @@ -35,6 +35,7 @@ db_handler(<<"_design">>) -> fun chttpd_db:handle_design_req/2; db_handler(<<"_partition">>) -> fun

[GitHub] [couchdb-fauxton] Antonio-Maranhao merged pull request #1409: [Bug fix] Set a default value for local database source/target for New Replications

2023-09-01 Thread via GitHub
Antonio-Maranhao merged PR #1409: URL: https://github.com/apache/couchdb-fauxton/pull/1409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb-fauxton] Antonio-Maranhao merged pull request #1410: [Bug fix] Changes feed duplicating results

2023-09-01 Thread via GitHub
Antonio-Maranhao merged PR #1410: URL: https://github.com/apache/couchdb-fauxton/pull/1410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb-fauxton] Antonio-Maranhao merged pull request #1412: Update chromedriver

2023-09-01 Thread via GitHub
Antonio-Maranhao merged PR #1412: URL: https://github.com/apache/couchdb-fauxton/pull/1412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] willholley commented on pull request #4710: feat(`mango`): strict index selection

2023-09-12 Thread via GitHub
willholley commented on PR #4710: URL: https://github.com/apache/couchdb/pull/4710#issuecomment-1715940637 > Rather than an additional request body parameter to /db/_find, perhaps we could add the index to the url path, but still end in _find? The request and response body stay in 'find'

[GitHub] [couchdb] rnewson commented on pull request #4735: feat(`mango`): rolling execution statistics

2023-09-12 Thread via GitHub
rnewson commented on PR #4735: URL: https://github.com/apache/couchdb/pull/4735#issuecomment-1715743087 To expand on that last comment, perhaps we alter how workers end? Today we do `exit(Pid, kill)` which is obviously untrappable. As an option to `fabric_util:cleanup/1` perhaps we could

[GitHub] [couchdb] rnewson commented on pull request #4710: feat(`mango`): strict index selection

2023-09-12 Thread via GitHub
rnewson commented on PR #4710: URL: https://github.com/apache/couchdb/pull/4710#issuecomment-1716142282 definitely `_find` will only work for indexes created with `_index` for the reasons you state. I think you're right that, in practice, the index-level `_find` will have to allow

[GitHub] [couchdb] pgj merged pull request #4756: fix(`mango`): align `opts.fields` with `fields` on `_explain`

2023-09-12 Thread via GitHub
pgj merged PR #4756: URL: https://github.com/apache/couchdb/pull/4756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] ricellis commented on pull request #4710: feat(`mango`): strict index selection

2023-09-12 Thread via GitHub
ricellis commented on PR #4710: URL: https://github.com/apache/couchdb/pull/4710#issuecomment-1715549181 Apologies for the delay in commenting here, I missed it initially in vacation season. >Appreciating the difficulties with augmenting existing endpoints, I think it's worth

[GitHub] [couchdb] rnewson commented on pull request #4735: feat(`mango`): rolling execution statistics

2023-09-12 Thread via GitHub
rnewson commented on PR #4735: URL: https://github.com/apache/couchdb/pull/4735#issuecomment-1715638846 That's very helpful background. You are right that it was t anticipated we'd need information back about a worker we know we no longer need to calculate the response. It would be

[GitHub] [couchdb] rnewson commented on pull request #4710: feat(`mango`): strict index selection

2023-09-12 Thread via GitHub
rnewson commented on PR #4710: URL: https://github.com/apache/couchdb/pull/4710#issuecomment-1715713111 @ricellis this is excellent feedback. I agree with your point about the several dimensions of confusion that we could introduce here, and our existing querying and indexing system is

[GitHub] [couchdb] gl-yziquel opened a new pull request, #4757: Fixing name of installation instruction file for git checkouts to README-DEV.rst.

2023-09-12 Thread via GitHub
gl-yziquel opened a new pull request, #4757: URL: https://github.com/apache/couchdb/pull/4757 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [couchdb] gl-yziquel commented on pull request #4757: Fixing name of installation instruction file for git checkouts to README-DEV.rst.

2023-09-12 Thread via GitHub
gl-yziquel commented on PR #4757: URL: https://github.com/apache/couchdb/pull/4757#issuecomment-1716616735 Small thing, really. Just improves developer experience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [couchdb] nickva merged pull request #4757: Fixing name of installation instruction file for git checkouts to README-DEV.rst.

2023-09-12 Thread via GitHub
nickva merged PR #4757: URL: https://github.com/apache/couchdb/pull/4757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] rnewson opened a new pull request, #4759: Use HTTP rules for hostname verification

2023-09-13 Thread via GitHub
rnewson opened a new pull request, #4759: URL: https://github.com/apache/couchdb/pull/4759 ## Overview By default, erlang does not recognise wildcards in Server Name Indication fields (which is bizarre but they seem committed to this error). Fortunately they also ship a

[GitHub] [couchdb] nickva merged pull request #4758: Remove sensitive headers from the mochiweb request in pdict

2023-09-13 Thread via GitHub
nickva merged PR #4758: URL: https://github.com/apache/couchdb/pull/4758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] pgj commented on a diff in pull request #4758: Remove sensitive headers from the mochiweb request in pdict

2023-09-13 Thread via GitHub
pgj commented on code in PR #4758: URL: https://github.com/apache/couchdb/pull/4758#discussion_r1325024698 ## src/chttpd/src/chttpd_util.erl: ## @@ -121,7 +121,19 @@ get_db_info(DbName) -> end. mochiweb_client_req_set(ClientReq) -> -put(?MOCHIWEB_CLIENT_REQ,

[GitHub] [couchdb] arturog commented on pull request #4673: Per document access control

2023-09-07 Thread via GitHub
arturog commented on PR #4673: URL: https://github.com/apache/couchdb/pull/4673#issuecomment-1710208649 > We currently have validate_doc_update where you can implement any kind of write control logic, but no equivalent for reads (or view queries besides the deprecated _list option). If

[GitHub] [couchdb] pgj opened a new pull request, #4751: fix(`mango`): correct behavior of `fields` on `_explain`

2023-09-07 Thread via GitHub
pgj opened a new pull request, #4751: URL: https://github.com/apache/couchdb/pull/4751 The `fields` attribute on `_explain` might have the string value `"all_fields"` when the respective query parameter (`fields`) is not set by the user. This is to express that no projection of fields

[GitHub] [couchdb] nickva commented on a diff in pull request #4751: fix(`mango`): correct behavior of `fields` on `_explain`

2023-09-07 Thread via GitHub
nickva commented on code in PR #4751: URL: https://github.com/apache/couchdb/pull/4751#discussion_r1318795597 ## src/docs/src/api/database/find.rst: ## @@ -1401,7 +1401,9 @@ it easier to take advantage of future improvements to query planning :>json object mrargs:

[GitHub] [couchdb] pgj commented on a diff in pull request #4751: fix(`mango`): correct behavior of `fields` on `_explain`

2023-09-07 Thread via GitHub
pgj commented on code in PR #4751: URL: https://github.com/apache/couchdb/pull/4751#discussion_r1318805065 ## src/docs/src/api/database/find.rst: ## @@ -1401,7 +1401,9 @@ it easier to take advantage of future improvements to query planning :>json object mrargs: Arguments

[GitHub] [couchdb] rnewson commented on pull request #4753: Revert "print peer port in http log"

2023-09-08 Thread via GitHub
rnewson commented on PR #4753: URL: https://github.com/apache/couchdb/pull/4753#issuecomment-1711835765 (this was part of the squashed "import nouveau" pull request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [couchdb] nickva commented on pull request #4753: Revert "print peer port in http log"

2023-09-08 Thread via GitHub
nickva commented on PR #4753: URL: https://github.com/apache/couchdb/pull/4753#issuecomment-1711846912 One aspect is that the previously we handled the IPv6 address format `{O1, O2, O3, O4, O5, O6, O7, O8}` and we'd be losing that. At some point in the future that might make a nice

[GitHub] [couchdb] rnewson merged pull request #4753: Revert "print peer port in http log"

2023-09-08 Thread via GitHub
rnewson merged PR #4753: URL: https://github.com/apache/couchdb/pull/4753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] rnewson commented on pull request #4753: Revert "print peer port in http log"

2023-09-08 Thread via GitHub
rnewson commented on PR #4753: URL: https://github.com/apache/couchdb/pull/4753#issuecomment-1711861709 `{ok, {Addr, _Port}} -> inet_parse:ntoa(Addr);` handles the ipv6 path, though it obviously doesn't handle x-forwarded-for for that case. -- This is an automated message from the Apache

[GitHub] [couchdb] baylisscg commented on issue #4748: weatherreport show error when execute

2023-09-07 Thread via GitHub
baylisscg commented on issue #4748: URL: https://github.com/apache/couchdb/issues/4748#issuecomment-1711085896 Looks like there needs to be a wrapper script like for remsh you can kick it off using what's in the package with ``` /opt/couchdb/erts-12.3.2.10/bin/erl +B -boot

[GitHub] [couchdb] baylisscg commented on issue #4748: weatherreport show error when execute

2023-09-07 Thread via GitHub
baylisscg commented on issue #4748: URL: https://github.com/apache/couchdb/issues/4748#issuecomment-1711068840 That doesn't work. It looks like weatherreport relies on the `no_dot_erlang.boot` binary that's part of Erlang but not included in the erts distribution Couch bundles. So

[GitHub] [couchdb] rnewson opened a new pull request, #4753: Revert "print peer port in http log"

2023-09-08 Thread via GitHub
rnewson opened a new pull request, #4753: URL: https://github.com/apache/couchdb/pull/4753 ## Overview This reverts commit 139ac9c05148b4c97c848bbe8d4d5abdf8e7fff5. I, very belatedly, realised this breaks the X-Forwarded-For feature from mochiweb. That's more important than

[GitHub] [couchdb] gigasource opened a new issue, #4754: Support webhook notification

2023-09-08 Thread via GitHub
gigasource opened a new issue, #4754: URL: https://github.com/apache/couchdb/issues/4754 Support webhook notification , I want to use couchdb with serverless lambda, but lambda can not keep the connection to listen the _change -- This is an automated message from the Apache Git

[GitHub] [couchdb-pkg] PeteLawler opened a new issue, #112: Debian Bookworm package please

2023-09-09 Thread via GitHub
PeteLawler opened a new issue, #112: URL: https://github.com/apache/couchdb-pkg/issues/112 ## Expected Behavior Install CouchDB as per instructions without error. ## Current Behavior An error is thrown as there are no Bookworm packages. ## Possible Solution Create

[GitHub] [couchdb] iilyak commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-08-30 Thread via GitHub
iilyak commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1310473014 ## src/chttpd/src/chttpd_db.erl: ## @@ -855,10 +862,12 @@ db_req(#httpd{method = 'PUT', path_parts = [_, <<"_purged_infos_limit">>]} = Req

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-08-30 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1310578052 ## src/fabric/src/fabric_rpc.erl: ## @@ -299,6 +299,10 @@ update_docs(DbName, Docs0, Options) -> Docs2 = make_att_readers(Docs1), with_db(DbName, Options,

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-08-30 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1311046408 ## src/fabric/src/fabric_rpc.erl: ## @@ -299,6 +299,10 @@ update_docs(DbName, Docs0, Options) -> Docs2 = make_att_readers(Docs1), with_db(DbName, Options,

[GitHub] [couchdb] nickva commented on a diff in pull request #4703: Add `_purged_infos` endpoint

2023-08-30 Thread via GitHub
nickva commented on code in PR #4703: URL: https://github.com/apache/couchdb/pull/4703#discussion_r1311046408 ## src/fabric/src/fabric_rpc.erl: ## @@ -299,6 +299,10 @@ update_docs(DbName, Docs0, Options) -> Docs2 = make_att_readers(Docs1), with_db(DbName, Options,

[GitHub] [couchdb] nickva closed issue #4760: replicator http usage logger crashes when canceling transient (_replicate) jobs

2023-09-14 Thread via GitHub
nickva closed issue #4760: replicator http usage logger crashes when canceling transient (_replicate) jobs URL: https://github.com/apache/couchdb/issues/4760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [couchdb] nickva merged pull request #4761: Fix badrecord error when replicator is logging http usage

2023-09-14 Thread via GitHub
nickva merged PR #4761: URL: https://github.com/apache/couchdb/pull/4761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva opened a new pull request, #4761: Fix badrecord error when replicator is logging http usage

2023-09-14 Thread via GitHub
nickva opened a new pull request, #4761: URL: https://github.com/apache/couchdb/pull/4761 Previously when transient replication jobs were canceled their `#rep` record's source and target fields would be `undefined`. That was accounted for in the http usage logger when it's enabled and

  1   2   3   4   5   6   7   8   9   10   >