[GitHub] couchdb-fauxton pull request: enable include_docs per default
Github user willholley commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/499#issuecomment-132913244 how about off by default but remembering the setting between visits to the page (could be per-database / view)? The large documents problem happens regardless of when the user uses include_docs so it sounds like a separate ticket / fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140141043 to elaborate, PouchDB is adding query parameters (revs=true, attachments=true) to the request body instead of the query string. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140140779 ah - ignore the above. PouchDB is wrong here (if we're basing this on rcouch). The CouchDB implementation works as expected through the clustered interface. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint
Github user willholley commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-139565250
in my tests, bulk_get doesn't return the list of revisions correctly:
$ curl http://localhost:15984/willtest -XPUT
{"ok":true}
$ curl http://localhost:15984/willtest -XPOST -H
'Content-Type:application/json' --data-binary '{"_id":"foo"}'
{"ok":true,"id":"foo","rev":"1-967a00dff5e02add41819138abb3284d"}
$ curl 'http://localhost:15984/willtest/foo?revs=true
{"_id":"foo","_rev":"1-967a00dff5e02add41819138abb3284d","_revisions":{"start":1,"ids":["967a00dff5e02add41819138abb3284d"]}}
$ curl http://localhost:15984/willtest -XPOST -H
'Content-Type:application/json' --data-binary
'{"_id":"foo","_rev":"1-967a00dff5e02add41819138abb3284d","generation":2}'
{"ok":true,"id":"foo","rev":"2-0cb4bbdce165620d03a15eff82d8712a"}
$ curl 'http://localhost:15984/willtest/foo?revs=true'
{"_id":"foo","_rev":"2-0cb4bbdce165620d03a15eff82d8712a","generation":2,"_revisions":{"start":2,"ids":["0cb4bbdce165620d03a15eff82d8712a","967a00dff5e02add41819138abb3284d"]}}
$ curl 'http://localhost:15984/willtest/_bulk_get' -H
'Content-Type:application/json' --data-binary
'{"docs":[{"id":"foo","rev":"2-0cb4bbdce165620d03a15eff82d8712a"}],"revs":true}'
-H 'Accept: application/json'
{"results": [{"id": "foo", "docs":
[{"ok":{"_id":"foo","_rev":"2-0cb4bbdce165620d03a15eff82d8712a","generation":2}}]}]}
In that last response, I'd expect a "_revisions" field similar to the
explicit request for /foo?revs=true.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-140180282 I have a PouchDB PR with all tests now passing against this implementation. I imagine there are some optimisations that could be done in terms of minimising individual requests to cluster nodes but as a first cut this looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: use shard suffix when generating _cha...
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/120#issuecomment-219404101 I'd like to add tests for this but not quite sure where the appropriate place is. Also, this pattern is repeated at https://github.com/apache/couchdb-global-changes/blob/203fb088ed81149108e64d18ffd9c3f5df154f97/src/global_changes_httpd.erl#L55 and https://github.com/apache/couchdb-couch/blob/b4295bfe58680c6a3d332a73ac6b061bd78b4db3/src/couch_httpd_db.erl#L123. This makes me wonder whether changing the database info object to include the unique shard prefix would be a better solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request #135: Handle empty "Access-Control-Request-Heade...
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-chttpd/pull/135 Handle empty "Access-Control-Request-Headers" header When "Access-Control-Request-Headers" is empty, return an empty "Access-Control-Allow-Headers" in the response. This is the same behaviour as when the "Access-Control-Request-Headers" header is omitted from the request entirely. Fixes COUCHDB-3090 You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-chttpd 3090-handle-empty-access-control-request-headers Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #135 commit 232bfe6d37b079096d1db4f786ff9c3c403c1fba Author: Will Holley <willhol...@gmail.com> Date: 2016-08-01T16:57:44Z Handle empty "Access-Control-Request-Headers" header When "Access-Control-Request-Headers" is empty, return an empty "Access-Control-Allow-Headers" in the response. This is the same behaviour as when the "Access-Control-Request-Headers" header is omitted from the request entirely. Fixes COUCHDB-3090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 @rnewson sure - I couldn't see an example other than `sequence number` in the CouchDB docs. Cloudant uses `sequence identifiers` in the documentation so I went with that as a first pass. I'll change it to `update sequences` or similar. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #56: update _changes API documentation for 2.0
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/56 thanks all for the feedback. I've pushed a new update which addresses the comments and adds a new section on the `_selector` filter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #55: API documentation for _find and _ind...
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/55 API documentation for _find and _index endpoints API reference documentation for the new _find and _index endpoints. Credit to this primarily goes to @KimStebel who wrote the original content at [https://github.com/cloudant-labs/slate]. This is heavily based on the Cloudant Query documentation, with references to text indices removed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-documentation find Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 6772066fcadaf3ee7bee3954934deae4092edda8 Author: Will Holley <willhol...@gmail.com> Date: 2016-09-01T16:23:21Z Add documentation for _find and _index API reference documentation for the new _find and _index endpoints. Credit to this primarily goes to @KimStebel who wrote the original content at [https://github.com/cloudant-labs/slate]. This is heavily based on the Cloudant Query documentation, with references to text indices removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #55: API documentation for _find and _index endp...
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/55 recommitted with lint fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #59: document sending multiple queries to...
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/59 document sending multiple queries to views Fixes COUCHDB-3122 You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-documentation multi-query Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit b986a3b3614d291f92439214f97dd3bdf31d4728 Author: Will Holley <willhol...@gmail.com> Date: 2016-09-07T12:19:32Z document sending multiple queries to views Fixes COUCHDB-3122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #60: document sorted parameter for view q...
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/60 document sorted parameter for view queries Refs COUCHDB-3060 You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-documentation sorted Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #55: API documentation for _find and _index endp...
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/55 the linter errors related to the files in this PR should be fixed. There were other, existing linter errors that weren't addressed here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #61: remove references to temp views
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/61 remove references to temp views possibly this is too brutal but, since they are not supported in 2.0, here's a first pass at updating the docs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-documentation remove_temp_views Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit d0c36a7d277fc3e36caff4144a0bfb3f2a1ae6e9 Author: Will Holley <willhol...@gmail.com> Date: 2016-09-07T14:54:55Z remove references to temporary views refs COUCHDB-3120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric pull request #67: clarify error when all_or_nothing attempted
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/67 clarify error when all_or_nothing attempted change the error message so that it doesn't imply that all_or_nothing is a feature that will be implemented in the future. You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-fabric all_or_nothing_error Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fabric/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit a6cd3b21518a29af491c7174aa8c22d28b0119ee Author: Will Holley <willhol...@gmail.com> Date: 2016-09-07T16:10:05Z clarify error when all_or_nothing attempted change the error message so that it doesn't imply that all_or_nothing is a feature that will be implemented in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #63: Remove row-spanning in _find documen...
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/63 Remove row-spanning in _find documentation Man pages do not support table row spanning, so don't do it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-documentation row_spanning Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit ff409d78ea302b16d9d96f71240d1752ec77cfc2 Author: Will Holley <willhol...@gmail.com> Date: 2016-09-09T14:57:53Z Remove row-spanning in _find documentation Man pages do not support table row spanning, so don't do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd issue #135: Handle empty "Access-Control-Request-Headers" hea...
Github user willholley commented on the issue: https://github.com/apache/couchdb-chttpd/pull/135 I've seen a few users run into this problem. Any chance of getting it merged now we past 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #62: remove references to all_or_nothing
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/62 remove references to all_or_nothing all_or_nothing is not supported in CouchDB 2.0, so remove it from the API docs. I was hesitant to remove the "Conflicts in batches" section and there is a code example at https://github.com/apache/couchdb-documentation/blob/master/src/replication/conflicts.rst#view-map-functions which still needs updating to not rely on `all_or_nothing`. refs COUCHDB-3120 You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-documentation all_or_nothing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #81: Document stable and update query parameters
Github user willholley commented on the issue: https://github.com/apache/couchdb-documentation/pull/81 @rnewson thanks for the swift review! Both comments addressed in the latest version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #81: Document stable and update query par...
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-documentation/pull/81 Document stable and update query parameters CouchDB-3063 adds 2 new query parameters when querying views. This commit adds API documentation for these and a note in the performance guide around when to use them. You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-documentation 3063-stable-update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit 2415092282ab9c2d5c9ed6b4893e2feaae17a9e3 Author: Will Holley <willhol...@gmail.com> Date: 2016-10-11T08:48:54Z Document stable and update query parameters CouchDB-3063 adds 2 new query parameters when querying views. This commit adds API documentation for these and a note in the performance guide around when to use them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #81: Document stable and update query par...
Github user willholley closed the pull request at: https://github.com/apache/couchdb-documentation/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric issue #81: Include conflicts parameter in doc_options
Github user willholley commented on the issue: https://github.com/apache/couchdb-fabric/pull/81 thanks for the swift review @kxepal. I've made a few changes based on your comments - the naming matches the existing conventions in the module (perhaps not ideal, but consistent). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric pull request #81: Include conflicts parameter in doc_options
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/81 Include conflicts parameter in doc_options When a keys array is passed to _all_docs, fabric translates this to individual open_doc calls. The conflicts=true query parameter is specified as a view-level option and is not, by default, parsed as an option that should be passed to open_doc. As a workaround, explicitly copy the view-level conflict parameter into the document options before open_doc is called. An alternative approach would be to address this when the query parameters are parsed, setting conflicts=true in both #mrargs and detail of fabric, I elected to make the change here instead. Fixes #COUCHDB-3264 You can merge this pull request into a Git repository by running: $ git pull https://github.com/willholley/couchdb-fabric 3264-alldocs-keys-conflicts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fabric/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 commit 22f6a3e7d58548b156a01f7321a41ae8aea739ec Author: Will Holley <willhol...@gmail.com> Date: 2017-01-03T09:54:30Z Include conflicts parameter in doc_options When a keys array is passed to _all_docs, fabric translates this to individual open_doc calls. The conflicts=true query parameter is specified as a view-level option and is not, by default, parsed as an option that should be passed to open_doc. As a workaround, explicitly copy the view-level conflict parameter into the document options before open_doc is called. An alternative approach would be to address this when the query parameters are parsed, setting conflicts=true in both #mrargs and detail of fabric, I elected to make the change here instead. Fixes #COUCHDB-3264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
