[GitHub] couchdb-fauxton issue #843: fix encoding in views

2017-02-06 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/843 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #825: 3192 - Rip and replace zeroclipboard with clipbo...

2016-12-23 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/825 good work ,+1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653925 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import Fauxt

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653979 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import Fauxt

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653495 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import Fauxt

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653242 --- Diff: app/addons/fauxton/assets/less/components.less --- @@ -44,6 +40,7 @@ } -a.clipboard-copy-element:hover

[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...

2016-12-22 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93654957 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -14,180 +14,126 @@ import app from "../../app"; import Fauxt

[GitHub] couchdb-fauxton pull request #824: Replication: hotfix url parsing for inval...

2016-12-16 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/824 Replication: hotfix url parsing for invalid urls See COUCHDB-3257: sometimes the replicator returns invalid urls which are not encoded. This makes standard conforming url parsers

[GitHub] couchdb-fauxton issue #822: Redux: update & fix

2016-12-14 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/822 green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] couchdb-fauxton pull request #822: Redux: update & fix

2016-12-14 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/822 Redux: update & fix `getReducers` is mostly covered by our other tests. no additional test coverage as we would need to build a separate build process (one wit

[GitHub] couchdb-fauxton issue #818: Add / Use Redux

2016-12-13 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/818 merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] couchdb-fauxton pull request #818: Add / Use Redux

2016-12-13 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/818 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #818: Add / Use Redux

2016-12-13 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/818 got a second thumbs up from garren via chat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton issue #818: Add / Use Redux

2016-12-12 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/818 @garrensmith added the Selenium test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton issue #821: some improvements to the new reactify setup

2016-12-12 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/821 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #820: Reactify

2016-12-08 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/820 merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] couchdb-fauxton issue #820: Reactify

2016-12-08 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/820 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request #820: Reactify

2016-12-07 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91296286 --- Diff: app/core/router.js --- @@ -48,32 +49,35 @@ export default Backbone.Router.extend({ }, addModuleRouteObject

[GitHub] couchdb-fauxton pull request #820: Reactify

2016-12-07 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91296234 --- Diff: app/core/routeObject.js --- @@ -14,325 +14,46 @@ import FauxtonAPI from "./base"; import React from "reac

[GitHub] couchdb-fauxton pull request #820: Reactify

2016-12-07 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91295992 --- Diff: app/addons/fauxton/navigation/tests/componentsSpec.react.jsx --- @@ -19,26 +19,18 @@ import React from "react"; impor

[GitHub] couchdb-fauxton pull request #820: Reactify

2016-12-07 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91296455 --- Diff: assets/index.underscore --- @@ -47,23 +47,11

[GitHub] couchdb-fauxton pull request #818: RFC: Redux

2016-12-05 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/818 RFC: Redux Here is my latest Redux work. It integrated redux into Fauxton and gets rid of the old Backbone.js Models Highlights: - Redux - Bluebird

[GitHub] couchdb-fauxton issue #817: Fix two small issues

2016-12-01 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/817 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-documentation pull request #91: clarify $db/_security section

2016-11-30 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-documentation/pull/91 clarify $db/_security section - point out that values are optional - add curl example - language fixes You can merge this pull request into a Git repository

[GitHub] couchdb-documentation issue #81: Document stable and update query parameters

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/81 thank you will, merged as fec0893 you can close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-documentation issue #84: Fixing type error

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/84 merged as c58e360 -- you can close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-documentation issue #81: Document stable and update query parameters

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/81 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] couchdb-documentation issue #84: Fixing type error

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/84 +1 thank you 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-documentation issue #85: Tiny 127 address fix

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/85 merged as 77b5d1d - thanks! please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-documentation issue #86: More command cleanup

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/86 merged as 4810d1c631728b0cf8fecedf7fa289ba9bc78304 please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-documentation issue #86: More command cleanup

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/86 LGTM, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-documentation issue #87: Fixed the transposition of the version or e...

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/87 merged as 74da74bda7b4187f105cacaa848c7daaad19a179 you can close this PR --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-documentation issue #87: Fixed the transposition of the version or e...

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/87 +1 thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing

2016-11-30 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/815 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #815: tests: add jest for testing

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/815 merged, thank you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-fauxton issue #816: Another attempt at stabilising the replication t...

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/816 merged as 57ad61ab20cd3aa9d71eea334ea27e37a0163a4f --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton issue #816: Another attempt at stabilising the replication t...

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/816 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #816: Another attempt at stabilising the replication t...

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/816 green, but travis bot not reporting: https://travis-ci.org/apache/couchdb-fauxton/builds/180102049 --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/815#discussion_r90231323 --- Diff: app/addons/replication/__tests__/helpers-tests.js --- @@ -0,0 +1,34 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/815#discussion_r90230595 --- Diff: app/addons/replication/__tests__/helpers-tests.js --- @@ -0,0 +1,34 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton issue #812: remove doc_editor template

2016-11-30 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/812 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing

2016-11-29 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/815 tests: add jest for testing Adds Jest for testing. Right now it runs in parallel to our old test setup. The idea is that we can use the faster, simpler testing for all

[GitHub] couchdb-fauxton issue #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/812 😍 heavy clean up and great refactorings. thanks so much! found some code issue, haven't run the code locally yet. seems there is a conflict, too. --- If your project

[GitHub] couchdb-fauxton pull request #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90052494 --- Diff: app/addons/config/layout.js --- @@ -0,0 +1,97 @@ +// Licensed under the Apache License, Version 2.0 (the "License"

[GitHub] couchdb-fauxton pull request #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90052964 --- Diff: app/addons/documents/routes-documents.js --- @@ -55,46 +49,39 @@ var DocumentsRouteObject = BaseRoute.extend

[GitHub] couchdb-fauxton pull request #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053583 --- Diff: app/addons/fauxton/components.js --- @@ -26,163 +26,163 @@ var Components = FauxtonAPI.addon(); * - showTray

[GitHub] couchdb-fauxton pull request #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90052264 --- Diff: app/addons/components/assets/less/layouts.less --- @@ -19,3 +19,11 @@ flex-direction: row; height: 100

[GitHub] couchdb-fauxton pull request #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053429 --- Diff: app/addons/fauxton/base.js --- @@ -32,38 +32,6 @@ Fauxton.initialize = function () { FauxtonAPI.RouteObject.on

[GitHub] couchdb-fauxton pull request #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053369 --- Diff: app/addons/documents/shared-routes.js --- @@ -88,13 +80,13 @@ var BaseRoute = FauxtonAPI.RouteObject.extend

[GitHub] couchdb-fauxton pull request #812: remove doc_editor template

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053096 --- Diff: app/addons/documents/routes-documents.js --- @@ -55,46 +49,39 @@ var DocumentsRouteObject = BaseRoute.extend

[GitHub] couchdb-fauxton issue #808: Handle trailing params when building URLs for vi...

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/808 @millayr thank you. you can close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton issue #814: add more tests to replication activity

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/814 +1 when green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-fauxton issue #813: encodeding url path for database name with speci...

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/813 you can close the PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-fauxton issue #813: encodeding url path for database name with speci...

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/813 merged as e53deb5d90fa7d6751bb753415dda5274a2b2cb5 and 1aa4ca6f34a718c294a06a1301f39fe05f157a1c thank you! --- If your project is set up for it, you can reply to this email

[GitHub] couchdb-fauxton issue #813: encodeding url path for database name with speci...

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/813 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request #813: encodeding url path for database name wit...

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/813#discussion_r89625412 --- Diff: app/addons/databases/tests/nightwatch/specialCharListLinks.js --- @@ -18,16 +18,15 @@ const testDatabases = [ 't/t-//t_f

[GitHub] couchdb-fauxton pull request #814: add more tests to replication activity

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/814#discussion_r90013925 --- Diff: app/addons/replication/tests/nightwatch/replicationactivity.js --- @@ -32,18 +32,67 @@ module.exports = { .url(baseUrl

[GitHub] couchdb-fauxton pull request #814: add more tests to replication activity

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/814#discussion_r90013882 --- Diff: app/addons/replication/tests/nightwatch/replicationactivity.js --- @@ -32,18 +32,67 @@ module.exports = { .url(baseUrl

[GitHub] couchdb-fauxton issue #808: Handle trailing params when building URLs for vi...

2016-11-21 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #810: Remove one pane

2016-11-21 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/810 +1, merge it after removing the user/pass from the script :) 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fauxton pull request #810: Remove one pane

2016-11-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/810#discussion_r88891378 --- Diff: bin/create-animal-db --- @@ -16,7 +16,7 @@ // with conflicts for the zebra doc -const url = 'http://localhost

[GitHub] couchdb-fauxton issue #809: use latest docker

2016-11-20 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/809 one test is failing: ``` ✖ nightwatch/replicationactivity ``` is it flaky? --- If your project is set up for it, you can reply to this email and have

[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.

2016-11-17 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 @bebosudo you can close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.

2016-11-17 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 and landed as 2993ccb86f9ec685a183807a54f044d42fb18592 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.

2016-11-17 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 eh typo, i was wanting to say: "i was also super excited when i sent my first PRs. for most people it is exciting and it can be unpleasant." -- edited the comment -

[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.

2016-11-17 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 @bebosudo just saw your question. some parts of the docs are still outdated or even incomplete. it was a tradeoff, we had to ship 2.0 at some point. (with a 2 year

[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.

2016-11-17 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 no worries, you are doing great! :) btw: i was also super excited when i sent my first PRs. most people are and it can be unpleasent. i'm still excited

[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.

2016-11-17 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 awesome, thank you! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton issue #802: COUCHDB-3224: Fixed view displaying for database...

2016-11-15 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 @sergey-safarov the PR looks good, it will be superseeded by https://github.com/apache/couchdb-fauxton/pull/807 which contains more fixes and changes our integration tests to default

[GitHub] couchdb-fauxton pull request #807: Couchdb 3224

2016-11-15 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/807 Couchdb 3224 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton COUCHDB-3224 Alternatively you can

[GitHub] couchdb-fauxton issue #761: New replication

2016-11-15 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 wow @garrensmith and @justin-mcdavid-ibm that is really cool stuff i am super excited --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-fauxton issue #761: New replication

2016-11-15 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 +1 after fixing the typo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-fauxton issue #761: New replication

2016-11-15 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 update: discussed with garren, the validation shoudl happen on the serverside. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-fauxton issue #761: New replication

2016-11-15 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 https://cloud.githubusercontent.com/assets/298166/20309147/28b87920-ab47-11e6-8fcc-bcd9cf9aa2dd.png;> typo: Replcator DB Activity. --- If your proj

[GitHub] couchdb-fauxton issue #761: New replication

2016-11-15 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 when i forget to add a database name to the url, it will still accept the url: remote target: ``` https://mypassw...@rockoartischocko.cloudant.com

[GitHub] couchdb-fauxton issue #806: db-list: expose elements to make them reusable

2016-11-15 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/806 merged :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-fauxton pull request #806: db-list: expose elements to make them reu...

2016-11-15 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #806: db-list: expose elements to make them reusable

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/806 no tests, as already covered and no functionality was changed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-fauxton pull request #806: db-list: expose elements to make them reu...

2016-11-11 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/806 db-list: expose elements to make them reusable You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton

[GitHub] couchdb-fauxton issue #802: COUCHDB-3224: Fixed view displaying for database...

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 hey, thank you for your contribution -- i was on vacation, i'll check next week! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-fauxton issue #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 issue 1 1) take a cloudant accoutn and database 2) put your cloudant account into the url field, e.g. "https://foo:b...@example.com/mydatabase 3) select target:

[GitHub] couchdb-fauxton pull request #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87580975 --- Diff: app/addons/auth/components.react.jsx --- @@ -302,9 +305,87 @@ var CreateAdminSidebar = React.createClass

[GitHub] couchdb-fauxton pull request #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581714 --- Diff: app/addons/replication/tests/controllerSpec.js --- @@ -0,0 +1,27 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581592 --- Diff: test/dev.js --- @@ -13,7 +13,7 @@ // This will search for files ending in .test.js and require them // so

[GitHub] couchdb-fauxton pull request #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87580932 --- Diff: app/addons/auth/actions.js --- @@ -28,88 +28,130 @@ var errorHandler = function (xhr, type, msg) { }; -export

[GitHub] couchdb-fauxton pull request #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581396 --- Diff: app/addons/replication/tests/helpersSpec.js --- @@ -0,0 +1,41 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581878 --- Diff: app/addons/replication/route.js --- @@ -10,48 +10,67 @@ // License for the specific language governing permissions

[GitHub] couchdb-fauxton pull request #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87582534 --- Diff: app/addons/replication/assets/less/replication.less --- @@ -11,187 +11,288 @@ // the License. @import

[GitHub] couchdb-fauxton issue #761: New replication

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 tests are red --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-fauxton issue #789: 3045 Replace safeURLName in code

2016-11-11 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/789 tests are red @millayr - can you see why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request #801: databases: show data_size instead of disk...

2016-11-04 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/801 databases: show data_size instead of disk_size return to old default You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] couchdb-fauxton pull request #798: break react components into individual fi...

2016-11-03 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/798#discussion_r86404825 --- Diff: app/addons/components/tests/paddedBorderedBoxSpec.react.jsx --- @@ -37,6 +37,7 @@ describe('PaddedBorderedBox', function

[GitHub] couchdb-fauxton pull request #798: break react components into individual fi...

2016-11-03 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/798#discussion_r86404908 --- Diff: app/addons/components/react-components.react.jsx --- @@ -10,1615 +10,46 @@ // License for the specific language governing

[GitHub] couchdb-fauxton issue #798: break react components into individual files

2016-11-03 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/798 wow very cool! there is a conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request #799: redux: delete unused store

2016-11-03 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton issue #800: Fix jump to dbs

2016-11-03 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/800 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request #799: redux: delete unused store

2016-11-02 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/799 redux: delete unused store i was just about to convert our first module to redux, turns out it doesn't need a store right now. so i deleted the store. http

[GitHub] couchdb-fauxton issue #796: Create React Layout

2016-11-02 Thread robertkowalski
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/796 +1 great stuff! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-fauxton pull request #796: Create React Layout

2016-11-02 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/796#discussion_r86157432 --- Diff: app/addons/activetasks/layout.js --- @@ -0,0 +1,39 @@ +// Licensed under the Apache License, Version 2.0 (the "License&q

[GitHub] couchdb-fauxton pull request #797: mango: shorten overflowing text in breadc...

2016-11-02 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/797 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

  1   2   3   4   5   6   7   8   9   10   >