[GitHub] couchdb-chttpd issue #120: use shard suffix when generating _changes ETag

2016-09-02 Thread rnewson
Github user rnewson commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/120
  
the #db record here is faked and not fully-populated (which is good, cause 
it would include disk_size and other things, which would make for a lousy etag).

I think the way forward is to fix this one and the global_changes one too. 
The instance where couch_db:get_db_info/1 is called is fine, since that's a 
real couchdb database (and thus instance_start_time does change for a 
delete/create)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #120: use shard suffix when generating _changes ETag

2016-09-02 Thread wohali
Github user wohali commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/120
  
@davisp ping, we need an Erlang code review here, Jan and Bob are kinda 
busy and I'm out of my depth. Could you kindly help? Thanks :pig_nose: :cat: 
:cow2:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---