[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user dholth commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 The "latest" documentation is okay, but the correct location of proxy_use_secret is in a different part of the documentation. Also, proxy_use_secret is not present in the web configuration

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user wohali commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 I believe we recently fixed this in our documentation (post-2.1.1): https://github.com/apache/couchdb-documentation/pull/220 ---

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user dholth commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 Thank you @dmunch ! It works for me in CouchDB 2.1.1. I added the following lines to `local.ini` to enable proxy authentication, and to check proxy before cookie. The default

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user ChiragMoradiya commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 May I know, when this will be released? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user dmunch commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 Great! Thanks for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user rnewson commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 @dmunch thank you for your contribution, I've merged this work so please close the PR. This didn't happen automatically as I squashed your two commits together and removed some trailing

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user kocolosk commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 Nice @dmunch. This remains a somewhat janky part of our codebase and I think you were smart to do this in a minimally-invasive way. 👍 --- If your project is set up for it, you can

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user dmunch commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 Agreed. Resulted from a stripped-down copy-and-pasted method. Replaced it with the assertive like you suggested. --- If your project is set up for it, you can reply to this email and have

[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.

Github user rnewson commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 just one comment, otherwise looks good to me. will merge after that case clause is looked at. I suspect we just want an assertive `{ok... = parse` there, since there's no recovery clause.