[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

2015-11-24 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/95#issuecomment-159392693 Nice! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

2015-11-18 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-chttpd/pull/95 Handle errors from before_request/after_request This refactoring fixes the handling of errors from before_request. Unify how we deal with errors among before_request and handle_request.

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

2015-11-18 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/95#discussion_r45228610 --- Diff: src/chttpd.erl --- @@ -209,21 +204,58 @@ handle_request_int(MochiReq) -> || Part <- string:tokens(Path, "/")] },

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

2015-11-18 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/95#issuecomment-157782803 Looks good for me, need to check however. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your