[GitHub] couchdb-config issue #21: Fix nasty 500 error on POST to /_config

2018-11-12 Thread jiangphcn
Github user jiangphcn commented on the issue: https://github.com/apache/couchdb-config/pull/21 @wohali thanks for your help on process. Just merged ---

[GitHub] couchdb-config issue #21: Fix nasty 500 error on POST to /_config

2018-11-12 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-config/pull/21 You're the one who gave it a +1 @jiangphcn ;) I'm not reviewing the code here, just helping you with the process! ---

[GitHub] couchdb-config issue #21: Fix nasty 500 error on POST to /_config

2018-11-12 Thread jiangphcn
Github user jiangphcn commented on the issue: https://github.com/apache/couchdb-config/pull/21 I will merge this PR if there is no additional comments. @wohali ---

[GitHub] couchdb-config issue #21: Fix nasty 500 error on POST to /_config

2018-11-12 Thread jiangphcn
Github user jiangphcn commented on the issue: https://github.com/apache/couchdb-config/pull/21 CI is happy now :-) ---

[GitHub] couchdb-config issue #21: Fix nasty 500 error on POST to /_config

2018-11-12 Thread jiangphcn
Github user jiangphcn commented on the issue: https://github.com/apache/couchdb-config/pull/21 @wohali yes, just doing this with @wenli200133 and rebased the change on #22 ---

[GitHub] couchdb-config issue #21: Fix nasty 500 error on POST to /_config

2018-11-12 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-config/pull/21 @jiangphcn you'll need to push a trivial commit to this branch to force travis to re-run the test. ---

[GitHub] couchdb-config issue #21: Fix nasty 500 error on POST to /_config

2018-11-12 Thread jiangphcn
Github user jiangphcn commented on the issue: https://github.com/apache/couchdb-config/pull/21 +1 looks good from my side. CI should be fine when https://github.com/apache/couchdb-config/pull/22 is merged. @wohali, hey Joan, would you please help take a look? ---