Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-129785406
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-129495837
thank you, this is great! merge when green! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36630749
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -0,0 +1,405 @@
+// Licensed under the Apache License, Version 2.0
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-129457967
@michellephung and @robertkowalski thanks for reviewing. All tests passing
and all fixes done. I need a +1 from both of you and then I can merge this :+1:
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-129459842
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36593285
--- Diff: app/addons/documents/views.js ---
@@ -18,14 +18,16 @@ define([
addons/databases/resources,
// Views
-
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36593287
--- Diff: app/addons/documents/views.js ---
@@ -59,13 +61,14 @@ function (app, FauxtonAPI, Components, Documents,
}));
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36593295
--- Diff: app/addons/documents/views.js ---
@@ -86,11 +89,12 @@ function (app, FauxtonAPI, Components, Documents,
// these are
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36593268
--- Diff: app/addons/documents/queryoptions/stores.js ---
@@ -0,0 +1,315 @@
+// Licensed under the Apache License, Version 2.0 (the
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36593241
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -0,0 +1,405 @@
+// Licensed under the Apache License, Version
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-128056946
wowowow everything is working when i tested it today :D :+1:
---
If your project is set up for it, you can reply to this email and have your
reply
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-128068897
For app/addons/documents/assets/less/queryOptions.less (line 93)
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#discussion_r36201754
--- Diff: app/addons/documents/views.js ---
@@ -86,11 +89,12 @@ function (app, FauxtonAPI, Components, Documents,
// these are
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/483#issuecomment-127657941
minor detail: i like newlines in the react attributes
medium detail: the cancel link doesn't do what i would expect, which would
be to close the
15 matches
Mail list logo
