[GitHub] couchdb-snappy issue #6: Add erlang 20

2017-06-23 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-snappy/pull/6 Looks great, I'll merge this now. Thank you for your contribution to Apache CouchDB! 👯 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-snappy issue #6: Add erlang 20

2017-06-23 Thread goncalotomas
Github user goncalotomas commented on the issue: https://github.com/apache/couchdb-snappy/pull/6 Can you confirm I squashed the commits correctly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-snappy issue #6: Add erlang 20

2017-06-22 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-snappy/pull/6 Ah, that'll do. Submit with `20.0-rc1` if you please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-snappy issue #6: Add erlang 20

2017-06-22 Thread goncalotomas
Github user goncalotomas commented on the issue: https://github.com/apache/couchdb-snappy/pull/6 Another option is to add `20.0-rc1` (available on Travis) and then just replace it for `20.0` when it's available. What should we do? --- If your project is set up for it, you can reply

[GitHub] couchdb-snappy issue #6: Add erlang 20

2017-06-22 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-snappy/pull/6 Ah, ok, that's not good. Remove 20 from the Travis file for now. Try a `git rebase -i HEAD~4` and squash everything but the first commit. --- If your project is set up for it, you can

[GitHub] couchdb-snappy issue #6: Add erlang 20

2017-06-22 Thread goncalotomas
Github user goncalotomas commented on the issue: https://github.com/apache/couchdb-snappy/pull/6 Sorry, I'm having a hard time squashing my branch, I don't know how to do it. I have a feeling that last Merge branch 'master' ruined it, am I right? How do I do it properly?

[GitHub] couchdb-snappy issue #6: Add erlang 20

2017-06-22 Thread wohali
Github user wohali commented on the issue: https://github.com/apache/couchdb-snappy/pull/6 Could you update the `.travis.yml` file in your branch to test 19 and 20? That will let us see that everything is good thru the GH-Travis integration. (Also, please squash your branch.) Thanks!