[GitHub] davisp commented on issue #674: Flaky compaction daemon test
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315401626 I'm gonna add a log message when the assertion fails to try and figure out what it is exactly that's causing this to fail. Hopefully that'll shed some light on who it is causing us issues. PR incoming. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp commented on issue #674: Flaky compaction daemon test
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315198304 Oops, I think we both read that wrong with GitHub chopping off and forcing the horizontal scroll. The second database compaction is the view compaction. Which we expect. Though I find it odd that the config deletion happens nearly 10ms after the swap compacted. Though we wait for that compactor pid to exit... I *think* that's the key to what's causing us issues This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp commented on issue #674: Flaky compaction daemon test
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315186525 Looks like the right diagnosis to me. My read on the is_idle test is that we're trying to assert that the compaction daemon doesn't hold a monitor on the database after its done compacting. Perhaps it'd be better to grab the monitors while its compacting and then just assert that its not got the same monitors? Though getting the monitor that Pid A has on Pid B from Pid C is racy at best. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davisp commented on issue #674: Flaky compaction daemon test
davisp commented on issue #674: Flaky compaction daemon test URL: https://github.com/apache/couchdb/issues/674#issuecomment-315147326 This is probably related to #638 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
