eiri opened a new pull request #1285: Fix mem3 tests URL: https://github.com/apache/couchdb/pull/1285 ## Overview After fix of `fake_db` function `mem3_shards` stopped silently failing and exposed race condition in `mem3_shards_changes_test_` test. What was going on, the changes listener started in the test's setup was crashing when tried to register on unstarted `couch_event` server, so the test was either fast enough to do assertions before of that or failed on a dead listener process. This fix removing dependency on mocking all modules involved and just uses standard test_util's start and stop couch. Module's start moved into the test body to avoid masking a potential failure in setup. Also the tests `mem3_sync_security_test` and `mem3_util_test` been modified to avoid setup and teardown side effects. ## Testing recommendations Minimal run `make eunit apps=mem3 suites=mem3_sync_security_test,mem3_util_test,mem3_shards` should pass, along with complete mem3 test suite test. ## Related Issues or Pull Requests Closes #1282 ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [ ] Documentation reflects the changes;
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
