[GitHub] ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-10-02 Thread GitBox
ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-426337601 @wohali I added small test, but see failed CI. What should I do with this? Seems CI fails on smth completely unrelated to rewrites.

[GitHub] ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-09-26 Thread GitBox
ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-424876593 @wohali it’s tested now, but not by CouchDB tests. There are some tests in CouchDB as well,

[GitHub] ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-09-26 Thread GitBox
ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-42489 @kxepal Thanks  > Though I forgot reasons to do erlang:get(mochiweb_request_body) Because rewrites should be fast, as fast as

[GitHub] ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-09-26 Thread GitBox
ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-42484 @wohali since no +1 so far, may be I could answer questions, if any? Since js rewrites was initially my patch refactored by @kxepal, I doubt

[GitHub] ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work

2018-09-22 Thread GitBox
ermouth commented on issue #1620: 1612 fix, js-rewritten PUTs now work URL: https://github.com/apache/couchdb/pull/1620#issuecomment-423740434 Is it now ok? This is an automated message from the Apache Git Service. To respond