[PR] New metadata service [dubbo]

2024-05-19 Thread via GitHub
namele opened a new pull request, #14210: URL: https://github.com/apache/dubbo/pull/14210 ## Purpose of the Change This PR introduces a new version of `MetadataService` (V2) based on Protobuf, which provides better compatibility with Dubbo-go. ## Brief Changelog To u

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119760367 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] check child is json or not in zookeeper.it will be continue if not. [dubbo]

2024-05-19 Thread via GitHub
AlbumenJ commented on code in PR #14166: URL: https://github.com/apache/dubbo/pull/14166#discussion_r1606304934 ## dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java: ## @@ -201,7 +203,14 @@ public void doSubscribe(fi

Re: [PR] feat: Validator supports automatic switch [dubbo]

2024-05-19 Thread via GitHub
aofall commented on code in PR #14194: URL: https://github.com/apache/dubbo/pull/14194#discussion_r1606303619 ## dubbo-plugin/dubbo-filter-validation/src/main/java/org/apache/dubbo/validation/Validation.java: ## @@ -25,7 +25,7 @@ /** * Instance of Validation interface provide

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
oxsean commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119727985 @AlbumenJ LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] [Bug] [dubbo]

2024-05-19 Thread via GitHub
AlbumenJ commented on issue #14206: URL: https://github.com/apache/dubbo/issues/14206#issuecomment-2119725570 Please submit the issue all in English:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [Bug] [dubbo]

2024-05-19 Thread via GitHub
AlbumenJ closed issue #14206: [Bug] URL: https://github.com/apache/dubbo/issues/14206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

Re: [I] No such extension org.apache.dubbo.rpc.Filter [dubbo]

2024-05-19 Thread via GitHub
AlbumenJ commented on issue #14205: URL: https://github.com/apache/dubbo/issues/14205#issuecomment-2119725034 Please submit the issue all in English:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] No such extension org.apache.dubbo.rpc.Filter [dubbo]

2024-05-19 Thread via GitHub
AlbumenJ closed issue #14205: No such extension org.apache.dubbo.rpc.Filter URL: https://github.com/apache/dubbo/issues/14205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] feat: Validator supports automatic switch [dubbo]

2024-05-19 Thread via GitHub
AlbumenJ commented on code in PR #14194: URL: https://github.com/apache/dubbo/pull/14194#discussion_r1606282886 ## dubbo-plugin/dubbo-filter-validation/src/main/java/org/apache/dubbo/validation/Validation.java: ## @@ -25,7 +25,7 @@ /** * Instance of Validation interface provi

Re: [I] [Feature] At present, the metadata pushed by the metadata center does not have an expiration date. When using Nacos as the metadata center, there is still a quantity limit. After switching to

2024-05-19 Thread via GitHub
AlbumenJ commented on issue #13926: URL: https://github.com/apache/dubbo/issues/13926#issuecomment-2119713484 > > > > 1. We can set TTL for it. But we need a mechanism to refresh it.我们可以为它设置TTL。但是我们需要一种机制来刷新它。 > > > > 2. You can upgrade it in 3.3.x您可以在 3.3.x 中升级它 > > > > > > >

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119677662 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] modify property name security judgement [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14208: URL: https://github.com/apache/dubbo/pull/14208#issuecomment-2119653167 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [I] `client.WithClientCheck()` should set `check` to false instead of true. [dubbo-go]

2024-05-19 Thread via GitHub
AlexStocks closed issue #2652: `client.WithClientCheck()` should set `check` to false instead of true. URL: https://github.com/apache/dubbo-go/issues/2652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]

2024-05-19 Thread via GitHub
AlexStocks merged PR #2680: URL: https://github.com/apache/dubbo-go/pull/2680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [I] [Bug] dubbo Provider列表变更通知consumer 消费端 出现NullPointerException bug [dubbo]

2024-05-19 Thread via GitHub
tuser4198 commented on issue #14196: URL: https://github.com/apache/dubbo/issues/14196#issuecomment-2119492346 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] [Bug] The application built using native image failed to start.I need to manually modify reflect-config. json of application.dubbo version: 3.3.0-beta.2 [dubbo]

2024-05-19 Thread via GitHub
CrazyHZM commented on issue #14147: URL: https://github.com/apache/dubbo/issues/14147#issuecomment-2119185636 @imgoby The problem cannot be reproduced using the above steps. Please provide the correct samples and steps. -- This is an automated message from the Apache Git Service.

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119181526 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2119159158 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2119155034 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] Separate the code for indicator monitoring [dubbo]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2119154946 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] dynamic Router and Cluster from registry center [dubbo-go-pixiu]

2024-05-19 Thread via GitHub
sonarcloud[bot] commented on PR #632: URL: https://github.com/apache/dubbo-go-pixiu/pull/632#issuecomment-2119131519 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] dynamic Router and Cluster from registry center [dubbo-go-pixiu]

2024-05-19 Thread via GitHub
FoghostCn opened a new pull request, #632: URL: https://github.com/apache/dubbo-go-pixiu/pull/632 **What this PR does**: dynamic Router and Cluster from registry center ref #600 **Special notes for your reviewer**: support application level and interfac