[GitHub] [dubbo] lak7 commented on issue #10850: Add deprecated method warn when called by user

2023-01-20 Thread GitBox
lak7 commented on issue #10850: URL: https://github.com/apache/dubbo/issues/10850#issuecomment-1398578287 Can you assign this issue to me? Thank you. I would appreciate any reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [dubbo-rust] yang20150702 merged pull request #102: 通过target_os使用Unix套接字连接器通信

2023-01-20 Thread GitBox
yang20150702 merged PR #102: URL: https://github.com/apache/dubbo-rust/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-rust] yang20150702 commented on pull request #102: 通过target_os使用Unix套接字连接器通信

2023-01-20 Thread GitBox
yang20150702 commented on PR #102: URL: https://github.com/apache/dubbo-rust/pull/102#issuecomment-1398437423 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [dubbo-go] bobtthp commented on a diff in pull request #2186: Support Servicemapping Listener

2023-01-20 Thread GitBox
bobtthp commented on code in PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#discussion_r1082468070 ## registry/event/service_mapping_change_listener_impl.go: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [dubbo-go] bobtthp commented on pull request #2186: Support Servicemapping Listener

2023-01-20 Thread GitBox
bobtthp commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1398320538 > Hi @bobtthp, thanks for your contribution! There are too many non-relevant commits. Please rebase the latest 3.0 branch before this pull request steps forward. got it --

[GitHub] [dubbo] zeusbee commented on a diff in pull request #11353: 【fix】remove alibaba.spring-context #11078

2023-01-20 Thread GitBox
zeusbee commented on code in PR #11353: URL: https://github.com/apache/dubbo/pull/11353#discussion_r1082356399 ## dubbo-common/src/main/java/org/apache/dubbo/common/utils/ObjectUtils.java: ## @@ -0,0 +1,24 @@ +package org.apache.dubbo.common.utils; Review Comment: OK, I'll

[GitHub] [dubbo] AlbumenJ merged pull request #11358: Support native ci check

2023-01-19 Thread GitBox
AlbumenJ merged PR #11358: URL: https://github.com/apache/dubbo/pull/11358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter

2023-01-19 Thread GitBox
AlbumenJ merged PR #11359: URL: https://github.com/apache/dubbo/pull/11359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] codecov-commenter commented on pull request #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter

2023-01-19 Thread GitBox
codecov-commenter commented on PR #11359: URL: https://github.com/apache/dubbo/pull/11359#issuecomment-1397895375 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11359?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11359: URL: https://github.com/apache/dubbo/pull/11359#issuecomment-1397893568 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397889373 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-19 Thread GitBox
AlbumenJ commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1082079313 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java: ## @@ -0,0 +1,68 @@ +/* +

[GitHub] [dubbo] codecov-commenter commented on pull request #11358: Support native ci check

2023-01-19 Thread GitBox
codecov-commenter commented on PR #11358: URL: https://github.com/apache/dubbo/pull/11358#issuecomment-1397879867 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11358?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo] AlbumenJ opened a new pull request, #11359: Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter

2023-01-19 Thread GitBox
AlbumenJ opened a new pull request, #11359: URL: https://github.com/apache/dubbo/pull/11359 ## What is the purpose of the change ```java /** * To add invoked invokers into invocation. Can be used in ClusterFilter or Filter for tracing or debugging purpose. *

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11358: Support native ci check

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11358: URL: https://github.com/apache/dubbo/pull/11358#issuecomment-1397879370 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397866970 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] codecov-commenter commented on pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
codecov-commenter commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397867259 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11352?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1397865518 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] CrazyHZM opened a new pull request, #11358: Support native ci check

2023-01-19 Thread GitBox
CrazyHZM opened a new pull request, #11358: URL: https://github.com/apache/dubbo/pull/11358 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo] CrazyHZM closed pull request #11350: Support native ci check

2023-01-19 Thread GitBox
CrazyHZM closed pull request #11350: Support native ci check URL: https://github.com/apache/dubbo/pull/11350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [dubbo] wxbty commented on a diff in pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
wxbty commented on code in PR #11352: URL: https://github.com/apache/dubbo/pull/11352#discussion_r1082048561 ## dubbo-dependencies-bom/pom.xml: ## @@ -184,7 +184,7 @@ 2.0 1.1.0 1.21 -3.2.0-beta.4-SNAPSHOT +3.2.0-beta.11-SNAPSHOT

[GitHub] [dubbo] KamToHung opened a new issue, #11357: channelHandlers has null object

2023-01-19 Thread GitBox
KamToHung opened a new issue, #11357: URL: https://github.com/apache/dubbo/issues/11357 - [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. ### Environment * Dubbo version: 3.2 *

[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-19 Thread GitBox
marcingrzejszczak commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081448498 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java: ## @@ -0,0 +1,68

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11021: Added support for Micrometer Observation API

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1397143566 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] AlbumenJ closed issue #11294: ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-19 Thread GitBox
AlbumenJ closed issue #11294: ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8 URL: https://github.com/apache/dubbo/issues/11294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [dubbo] AlbumenJ commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-19 Thread GitBox
AlbumenJ commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1397120479 Thanks for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [dubbo] AlbumenJ merged pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-19 Thread GitBox
AlbumenJ merged PR #11326: URL: https://github.com/apache/dubbo/pull/11326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] codecov-commenter commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-19 Thread GitBox
codecov-commenter commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1397111216 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11326?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1397107792 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11356: Bump protobuf-java from 3.19.6 to 3.21.12

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11356: URL: https://github.com/apache/dubbo/pull/11356#issuecomment-1397103473 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] AlbumenJ merged pull request #11356: Bump protobuf-java from 3.19.6 to 3.21.12

2023-01-19 Thread GitBox
AlbumenJ merged PR #11356: URL: https://github.com/apache/dubbo/pull/11356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-19 Thread GitBox
AlbumenJ commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081346258 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java: ## @@ -0,0 +1,68 @@ +/* +

[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11353: 【fix】remove alibaba.spring-context #11078

2023-01-19 Thread GitBox
AlbumenJ commented on code in PR #11353: URL: https://github.com/apache/dubbo/pull/11353#discussion_r1081336441 ## dubbo-common/src/main/java/org/apache/dubbo/common/utils/ObjectUtils.java: ## @@ -0,0 +1,24 @@ +package org.apache.dubbo.common.utils; + +/** + * User: aini + *

[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
AlbumenJ commented on code in PR #11352: URL: https://github.com/apache/dubbo/pull/11352#discussion_r1081334798 ## dubbo-dependencies-bom/pom.xml: ## @@ -184,7 +184,7 @@ 2.0 1.1.0 1.21 -3.2.0-beta.4-SNAPSHOT +3.2.0-beta.11-SNAPSHOT

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11334: Bump javassist from 3.28.0-GA to 3.29.2-GA

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11334: URL: https://github.com/apache/dubbo/pull/11334#issuecomment-1396980703 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11334: Bump javassist from 3.28.0-GA to 3.29.2-GA

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11334: URL: https://github.com/apache/dubbo/pull/11334#issuecomment-1396980444 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] mxsm commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-19 Thread GitBox
mxsm commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1396979806 @AlbumenJ I has fixed it and re-submit again, PTAL~ Thks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11338: Bump resteasy_version from 3.0.20.Final to 3.15.3.Final

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11338: URL: https://github.com/apache/dubbo/pull/11338#issuecomment-1396975326 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] AlbumenJ merged pull request #11351: feat: fix deploy listener exception

2023-01-19 Thread GitBox
AlbumenJ merged PR #11351: URL: https://github.com/apache/dubbo/pull/11351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] dependabot[bot] closed pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12

2023-01-19 Thread GitBox
dependabot[bot] closed pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12 URL: https://github.com/apache/dubbo/pull/11330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [dubbo] dependabot[bot] commented on pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12

2023-01-19 Thread GitBox
dependabot[bot] commented on PR #11330: URL: https://github.com/apache/dubbo/pull/11330#issuecomment-1396952658 Looks like these dependencies are updatable in another way, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [dubbo] dependabot[bot] opened a new pull request, #11356: Bump protobuf-java from 3.19.6 to 3.21.12

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #11356: URL: https://github.com/apache/dubbo/pull/11356 Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.19.6 to 3.21.12. Release notes Sourced from

[GitHub] [dubbo] AlbumenJ commented on pull request #11330: Bump protobuf-java.version from 3.19.6 to 3.21.12

2023-01-19 Thread GitBox
AlbumenJ commented on PR #11330: URL: https://github.com/apache/dubbo/pull/11330#issuecomment-1396948101 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [dubbo] AlbumenJ merged pull request #11338: Bump resteasy_version from 3.0.20.Final to 3.15.3.Final

2023-01-19 Thread GitBox
AlbumenJ merged PR #11338: URL: https://github.com/apache/dubbo/pull/11338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11340: Bump jetty-maven-plugin from 9.4.38.v20210224 to 9.4.50.v20221201

2023-01-19 Thread GitBox
AlbumenJ merged PR #11340: URL: https://github.com/apache/dubbo/pull/11340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11332: Bump jetty_version from 9.4.43.v20210629 to 9.4.50.v20221201

2023-01-19 Thread GitBox
AlbumenJ merged PR #11332: URL: https://github.com/apache/dubbo/pull/11332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11342: Bump eureka.version from 1.9.12 to 1.10.18

2023-01-19 Thread GitBox
AlbumenJ merged PR #11342: URL: https://github.com/apache/dubbo/pull/11342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11339: Bump javax.el-api from 2.2.4 to 2.2.5

2023-01-19 Thread GitBox
AlbumenJ merged PR #11339: URL: https://github.com/apache/dubbo/pull/11339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11329: Bump spring-boot-maven-plugin from 2.1.4.RELEASE to 2.7.7

2023-01-19 Thread GitBox
AlbumenJ merged PR #11329: URL: https://github.com/apache/dubbo/pull/11329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11334: Bump javassist from 3.28.0-GA to 3.29.2-GA

2023-01-19 Thread GitBox
AlbumenJ merged PR #11334: URL: https://github.com/apache/dubbo/pull/11334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11343: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.1.0

2023-01-19 Thread GitBox
AlbumenJ merged PR #11343: URL: https://github.com/apache/dubbo/pull/11343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] dependabot[bot] commented on pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0

2023-01-19 Thread GitBox
dependabot[bot] commented on PR #11341: URL: https://github.com/apache/dubbo/pull/11341#issuecomment-1396942369 OK, I won't notify you about org.apache.zookeeper:zookeeper again, unless you re-open this PR.  -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [dubbo] dependabot[bot] closed pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0

2023-01-19 Thread GitBox
dependabot[bot] closed pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0 URL: https://github.com/apache/dubbo/pull/11341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [dubbo] AlbumenJ commented on pull request #11341: Bump zookeeper from 3.4.14 to 3.8.0

2023-01-19 Thread GitBox
AlbumenJ commented on PR #11341: URL: https://github.com/apache/dubbo/pull/11341#issuecomment-1396942254 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [dubbo] AlbumenJ merged pull request #11344: Bump spring-boot-dependencies from 2.3.1.RELEASE to 2.7.7

2023-01-19 Thread GitBox
AlbumenJ merged PR #11344: URL: https://github.com/apache/dubbo/pull/11344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11348: Bump slf4j-api from 1.7.25 to 1.7.36

2023-01-19 Thread GitBox
AlbumenJ merged PR #11348: URL: https://github.com/apache/dubbo/pull/11348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11347: Bump javax.el from 3.0.1-b08 to 3.0.1-b12

2023-01-19 Thread GitBox
AlbumenJ merged PR #11347: URL: https://github.com/apache/dubbo/pull/11347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11346: Bump maven-plugin-plugin from 3.6.0 to 3.7.1

2023-01-19 Thread GitBox
AlbumenJ merged PR #11346: URL: https://github.com/apache/dubbo/pull/11346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11345: Bump curator_version from 4.2.0 to 4.3.0

2023-01-19 Thread GitBox
AlbumenJ merged PR #11345: URL: https://github.com/apache/dubbo/pull/11345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-19 Thread GitBox
marcingrzejszczak commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081221987 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java: ## @@ -0,0 +1,68

[GitHub] [dubbo] AlbumenJ commented on pull request #11338: Bump resteasy_version from 3.0.20.Final to 3.15.3.Final

2023-01-19 Thread GitBox
AlbumenJ commented on PR #11338: URL: https://github.com/apache/dubbo/pull/11338#issuecomment-1396925694 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [dubbo] AlbumenJ merged pull request #11337: Bump javax.ws.rs-api from 2.0 to 2.1.1

2023-01-19 Thread GitBox
AlbumenJ merged PR #11337: URL: https://github.com/apache/dubbo/pull/11337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11336: Bump bouncycastle-bcprov_version from 1.69 to 1.70

2023-01-19 Thread GitBox
AlbumenJ merged PR #11336: URL: https://github.com/apache/dubbo/pull/11336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11335: Bump byte-buddy from 1.12.19 to 1.12.22

2023-01-19 Thread GitBox
AlbumenJ merged PR #11335: URL: https://github.com/apache/dubbo/pull/11335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11333: Bump fluent-hc from 4.5.5 to 4.5.14

2023-01-19 Thread GitBox
AlbumenJ merged PR #11333: URL: https://github.com/apache/dubbo/pull/11333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11351: feat: fix deploy listener exception

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11351: URL: https://github.com/apache/dubbo/pull/11351#issuecomment-1396923003 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] AlbumenJ merged pull request #11331: Bump cglib-nodep from 2.2 to 2.2.2

2023-01-19 Thread GitBox
AlbumenJ merged PR #11331: URL: https://github.com/apache/dubbo/pull/11331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-19 Thread GitBox
marcingrzejszczak commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081084317 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java: ## @@ -0,0 +1,68

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1396844150 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] songxiaosheng commented on issue #11354: Observability: about the design of the collector's domain

2023-01-19 Thread GitBox
songxiaosheng commented on issue #11354: URL: https://github.com/apache/dubbo/issues/11354#issuecomment-1396829098 默认的收集器已经比较重了,目前几乎做了所有类型的数据收集,需要一个组合的收集器来处理不同类型的数据收集,组合的数据收集器负责产生的具体的收集器,转发指标数据到消费者收集器等功能不去做具体逻辑处理 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [dubbo] songxiaosheng commented on issue #11355: Observability: about the design of the collector's domain

2023-01-19 Thread GitBox
songxiaosheng commented on issue #11355: URL: https://github.com/apache/dubbo/issues/11355#issuecomment-1396784766 重复 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [dubbo] songxiaosheng closed issue #11355: Observability: about the design of the collector's domain

2023-01-19 Thread GitBox
songxiaosheng closed issue #11355: Observability: about the design of the collector's domain URL: https://github.com/apache/dubbo/issues/11355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [dubbo] songxiaosheng opened a new issue, #11355: Observability: about the design of the collector's domain

2023-01-19 Thread GitBox
songxiaosheng opened a new issue, #11355: URL: https://github.com/apache/dubbo/issues/11355 - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. ## Describe the proposal En:

[GitHub] [dubbo] marcingrzejszczak commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-19 Thread GitBox
marcingrzejszczak commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1081084317 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java: ## @@ -0,0 +1,68

[GitHub] [dubbo] jojocodeX commented on pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
jojocodeX commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1396763658 > ## What is the purpose of the change > When I was writing registry metric implement, I will use some codes of metrics-api, and found that some codes might be optimized. > >

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11352: metrics code optimization

2023-01-19 Thread GitBox
sonarcloud[bot] commented on PR #11352: URL: https://github.com/apache/dubbo/pull/11352#issuecomment-1396763455 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] songxiaosheng opened a new issue, #11354: Observability: about the design of the collector's domain

2023-01-19 Thread GitBox
songxiaosheng opened a new issue, #11354: URL: https://github.com/apache/dubbo/issues/11354 - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. ## Describe the proposal En:

[GitHub] [dubbo] EnjoyWall commented on issue #4309: use consul with group and version

2023-01-19 Thread GitBox
EnjoyWall commented on issue #4309: URL: https://github.com/apache/dubbo/issues/4309#issuecomment-1396717688 The code is still the same as this page shows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [dubbo-rust] robberphex opened a new pull request, #103: implement service discovery

2023-01-19 Thread GitBox
robberphex opened a new pull request, #103: URL: https://github.com/apache/dubbo-rust/pull/103 You may call `client.with_directory(Box::new(StaticDirectory::new()))` to call a static host. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [dubbo] zeusbee opened a new pull request, #11353: 【fix】remove alibaba.spring-context #11078

2023-01-19 Thread GitBox
zeusbee opened a new pull request, #11353: URL: https://github.com/apache/dubbo/pull/11353 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo] wxbty opened a new pull request, #11352: metrics code optimization

2023-01-19 Thread GitBox
wxbty opened a new pull request, #11352: URL: https://github.com/apache/dubbo/pull/11352 ## What is the purpose of the change When I was writing registry metric implement, I will use some codes of metrics-api, and found that some codes might be optimized. ## Brief changelog

[GitHub] [dubbo-rust] robberphex closed pull request #101: add robberphex as collaborator

2023-01-18 Thread GitBox
robberphex closed pull request #101: add robberphex as collaborator URL: https://github.com/apache/dubbo-rust/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11350: Support native ci check

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #11350: URL: https://github.com/apache/dubbo/pull/11350#issuecomment-139655 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-18 Thread GitBox
CrazyHZM commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1080846615 ## dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/filter/observation/AbstractDefaultDubboObservationConvention.java: ## @@ -0,0 +1,68 @@ +/* +

[GitHub] [dubbo] aamingaa opened a new pull request, #11351: feat: fix deploy listener exception

2023-01-18 Thread GitBox
aamingaa opened a new pull request, #11351: URL: https://github.com/apache/dubbo/pull/11351 fix deploy listener exception. issue url: https://github.com/apache/dubbo/issues/11027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [dubbo] CrazyHZM opened a new pull request, #11350: Support native ci check

2023-01-18 Thread GitBox
CrazyHZM opened a new pull request, #11350: URL: https://github.com/apache/dubbo/pull/11350 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo-samples] AlbumenJ merged pull request #674: Bump spring-framework-bom from 4.3.16.RELEASE to 4.3.29.RELEASE in /99-integration/dubbo-samples-prefer-serialization-test-31x

2023-01-18 Thread GitBox
AlbumenJ merged PR #674: URL: https://github.com/apache/dubbo-samples/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] chickenlj merged pull request #11349: metrics key duplication

2023-01-18 Thread GitBox
chickenlj merged PR #11349: URL: https://github.com/apache/dubbo/pull/11349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-rust] chickenlj commented on issue #99: [Proposal] integratable with other projects

2023-01-18 Thread GitBox
chickenlj commented on issue #99: URL: https://github.com/apache/dubbo-rust/issues/99#issuecomment-1396497158 I think this proposal is very similar to https://github.com/apache/dubbo-rust/issues/100 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [dubbo-rust] chickenlj commented on issue #100: [Proposal] Let Dubbo Rust could call other RPC services.

2023-01-18 Thread GitBox
chickenlj commented on issue #100: URL: https://github.com/apache/dubbo-rust/issues/100#issuecomment-1396495674 `gRPC, Thrift, REST, static files? You name it. We serve them all.` The goal is kinda like the feature of this framework [Armeria](https://armeria.dev/) -- This is an

[GitHub] [dubbo-rust] robberphex opened a new issue, #100: [Proposal] Let Dubbo Rust could call other RPC service.

2023-01-18 Thread GitBox
robberphex opened a new issue, #100: URL: https://github.com/apache/dubbo-rust/issues/100 At real business logics, there are always different RPC service to call. For example, 1, to call Dubbo/hessian service to get user info, 2, to call Rest/http (third-party) service to get user

[GitHub] [dubbo-rust] robberphex opened a new issue, #99: [Proposal] integratable with other project

2023-01-18 Thread GitBox
robberphex opened a new issue, #99: URL: https://github.com/apache/dubbo-rust/issues/99 Dubbo Rust will parse more than one protocol of Dubbo RPC, * Triple/gRPC protocol parsing ✅ * Hessian protocol parsing * Thrift protocol parsing * etc. Dubbo Rust could release protocol

[GitHub] [dubbo-rust] robberphex opened a new issue, #98: [Proposal] add c binding

2023-01-18 Thread GitBox
robberphex opened a new issue, #98: URL: https://github.com/apache/dubbo-rust/issues/98 Dubbo have different language binding for different scenario: * Dubbo Java for Java ecosystem. * Dubbo Go for Go ecosystem. * Dubbo Js for frontend scenario. * Dubbo Python for AI/ML

[GitHub] [dubbo] codecov-commenter commented on pull request #11349: metrics key duplication

2023-01-18 Thread GitBox
codecov-commenter commented on PR #11349: URL: https://github.com/apache/dubbo/pull/11349#issuecomment-1396395769 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11349?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11349: metrics key duplication

2023-01-18 Thread GitBox
sonarcloud[bot] commented on PR #11349: URL: https://github.com/apache/dubbo/pull/11349#issuecomment-1396393677 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] mxsm commented on pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-18 Thread GitBox
mxsm commented on PR #11326: URL: https://github.com/apache/dubbo/pull/11326#issuecomment-1396378948 @AlbumenJ PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [dubbo] mxsm commented on a diff in pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-18 Thread GitBox
mxsm commented on code in PR #11326: URL: https://github.com/apache/dubbo/pull/11326#discussion_r1080758607 ## dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConcurrentHashMapUtils.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [dubbo] aamingaa commented on issue #10968: File name too long

2023-01-18 Thread GitBox
aamingaa commented on issue #10968: URL: https://github.com/apache/dubbo/issues/10968#issuecomment-1396375818 assign me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [dubbo] mxsm commented on a diff in pull request #11326: [ISSUE #11294] Optimize ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-18 Thread GitBox
mxsm commented on code in PR #11326: URL: https://github.com/apache/dubbo/pull/11326#discussion_r1080758607 ## dubbo-common/src/main/java/org/apache/dubbo/common/utils/ConcurrentHashMapUtils.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [dubbo] jojocodeX opened a new pull request, #11349: metrics key duplication

2023-01-18 Thread GitBox
jojocodeX opened a new pull request, #11349: URL: https://github.com/apache/dubbo/pull/11349 metrics key duplication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   3   4   5   6   7   8   9   10   >