[GitHub] [dubbo-go] justxuewei commented on pull request #2186: Support Servicemapping Listener

2023-01-17 Thread GitBox
justxuewei commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1385100857 Hi @bobtthp, thanks for your contribution! Please rebase the latest 3.0 branch before this pull request steps forward. -- This is an automated message from the Apache Git Service.

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-17 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1071941307 ## dubbo-metrics/dubbo-metrics-api/src/main/resources/META-INF/dubbo/internal/org.apache.dubbo.rpc.cluster.filter.ClusterFilter: ## @@ -0,0 +1,2 @@

[GitHub] [dubbo] conghuhu commented on a diff in pull request #11021: Added support for Micrometer Observation API

2023-01-17 Thread GitBox
conghuhu commented on code in PR #11021: URL: https://github.com/apache/dubbo/pull/11021#discussion_r1071927912 ## dubbo-metrics/dubbo-metrics-api/src/test/java/org/apache/dubbo/metrics/filter/observation/ObservationSenderFilterTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to

[GitHub] [dubbo] marcingrzejszczak commented on pull request #11021: Added support for Micrometer Observation API

2023-01-17 Thread GitBox
marcingrzejszczak commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1385038819 Yup, I will, thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [dubbo-go] ZLBer commented on issue #2178: 不支持 version+group 调用

2023-01-17 Thread GitBox
ZLBer commented on issue #2178: URL: https://github.com/apache/dubbo-go/issues/2178#issuecomment-1385034237 @CodingAdai hi,我这边跑了dubbo-go-samples里的一个例子,发现是可以用group+version进行调用的,具体地址在:https://github.com/apache/dubbo-go-samples/tree/master/rpc/dubbo java服务端的配置:

[GitHub] [dubbo] Johnson-Jia commented on issue #11310: Dubbo3.1.2经常找不到服务的提供者

2023-01-17 Thread GitBox
Johnson-Jia commented on issue #11310: URL: https://github.com/apache/dubbo/issues/11310#issuecomment-1385025919 使用k8s 容器,内部启动docker服务, 生产者重启后ip变成新的了, 但是消费者还是使用旧的生产者ip连接,造成找不到生产者。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [dubbo] AlbumenJ merged pull request #11309: Add xdsroute observe logic

2023-01-16 Thread GitBox
AlbumenJ merged PR #11309: URL: https://github.com/apache/dubbo/pull/11309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-samples] AlbumenJ merged pull request #668: Add nacos registry test

2023-01-16 Thread GitBox
AlbumenJ merged PR #668: URL: https://github.com/apache/dubbo-samples/pull/668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] aamingaa commented on issue #11111: 有Dubbo3 mesh的调试文档吗,官网只有简单的部署文档,具体bebug调试的文档没有,自己尝试没有成功

2023-01-16 Thread GitBox
aamingaa commented on issue #1: URL: https://github.com/apache/dubbo/issues/1#issuecomment-1384901698 https://cn.dubbo.apache.org/zh/docs3-v2/java-sdk/reference-manual/mesh/mesh/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [dubbo] AlbumenJ commented on issue #11293: How can i inject a bean to my own Validator implementation?

2023-01-16 Thread GitBox
AlbumenJ commented on issue #11293: URL: https://github.com/apache/dubbo/issues/11293#issuecomment-1384897431 Is your application run with dubbo-config-spring or dubbo-spring-boot-starter? If so, Dubbo will try to inject field from spring context.

[GitHub] [dubbo] AlbumenJ commented on issue #11289: 过期的Invoker 连接 持续在 时间轮线程中执行重连任务,抛出大量异常

2023-01-16 Thread GitBox
AlbumenJ commented on issue #11289: URL: https://github.com/apache/dubbo/issues/11289#issuecomment-1384893532 > 不好意思,看到你处理了 channel.close() 虽然 在时间轮中,ReconnectTimerTask 还会执行, 因为 还会Reput。 但 channel.isClose() 后 不会在执行 doTask了。 从注册中心摘掉的连接不应该还在 ReconnectTimerTask 的,你可以看下升级 Dubbo 版本后还有没有

[GitHub] [dubbo-samples] AlbumenJ merged pull request #700: Feature/split rpccontext

2023-01-16 Thread GitBox
AlbumenJ merged PR #700: URL: https://github.com/apache/dubbo-samples/pull/700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ commented on issue #11311: support register custom metadata

2023-01-16 Thread GitBox
AlbumenJ commented on issue #11311: URL: https://github.com/apache/dubbo/issues/11311#issuecomment-1384890727 ```java default void postProcessReferConfig(ReferenceConfig referenceConfig) { referenceConfig.getParameters().put("key", "val"); } ``` -- This is an

[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #538: 修改 istio 编译镜像

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #538: URL: https://github.com/apache/dubbo-go-pixiu/pull/538#issuecomment-1384890027 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] AlbumenJ commented on issue #11311: support register custom metadata

2023-01-16 Thread GitBox
AlbumenJ commented on issue #11311: URL: https://github.com/apache/dubbo/issues/11311#issuecomment-1384889899 org.apache.dubbo.config.ConfigPostProcessor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [dubbo] AlbumenJ commented on issue #11311: support register custom metadata

2023-01-16 Thread GitBox
AlbumenJ commented on issue #11311: URL: https://github.com/apache/dubbo/issues/11311#issuecomment-1384889691 You can add metadata by impl ConfigPostProcessor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [dubbo] AlbumenJ commented on issue #10111: Critical bug: Consistency loadbalance cause the CPU usage is 100%.

2023-01-16 Thread GitBox
AlbumenJ commented on issue #10111: URL: https://github.com/apache/dubbo/issues/10111#issuecomment-1384888599 > 我这里使用的是version 2.7.18,遇到一致性hash负载占用cpu高的问题,请问这个问题在2.7.x有修复吗 dump看线程都是在执行org.apache.dubbo.rpc.cluster.loadbalance.ConsistentHashLoadBalance.ConsistentHashSelector#selectForKey

[GitHub] [dubbo-samples] AlbumenJ merged pull request #709: Bump fastjson from 1.2.83_noneautotype to 1.2.83 in /4-governance/dubbo-samples-metrics-prometheus

2023-01-16 Thread GitBox
AlbumenJ merged PR #709: URL: https://github.com/apache/dubbo-samples/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-go-samples] AlexStocks closed pull request #488: Build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0

2023-01-16 Thread GitBox
AlexStocks closed pull request #488: Build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0 URL: https://github.com/apache/dubbo-go-samples/pull/488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [dubbo-go-samples] dependabot[bot] commented on pull request #488: Build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #488: URL: https://github.com/apache/dubbo-go-samples/pull/488#issuecomment-1384850731 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [dubbo] conghuhu commented on issue #11234: Observability Tasks: Built in link tracking page(内置链路追踪页面)

2023-01-16 Thread GitBox
conghuhu commented on issue #11234: URL: https://github.com/apache/dubbo/issues/11234#issuecomment-1384838365 assign to me, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [dubbo] chickenlj merged pull request #11315: metrics

2023-01-16 Thread GitBox
chickenlj merged PR #11315: URL: https://github.com/apache/dubbo/pull/11315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] songxiaosheng opened a new issue, #11318: Observability communication 2022-1-17

2023-01-16 Thread GitBox
songxiaosheng opened a new issue, #11318: URL: https://github.com/apache/dubbo/issues/11318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [dubbo] songxiaosheng commented on a diff in pull request #11317: Thread pool metric

2023-01-16 Thread GitBox
songxiaosheng commented on code in PR #11317: URL: https://github.com/apache/dubbo/pull/11317#discussion_r1071730255 ## dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/MetricThreadPool.java: ## @@ -0,0 +1,25 @@ +package org.apache.dubbo.common.threadpool; Review

[GitHub] [dubbo] codecov-commenter commented on pull request #11309: Add xdsroute observe logic

2023-01-16 Thread GitBox
codecov-commenter commented on PR #11309: URL: https://github.com/apache/dubbo/pull/11309#issuecomment-1384815145 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11309?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2186: Support Servicemapping Listener

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1384814913 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] codecov-commenter commented on pull request #11315: metrics

2023-01-16 Thread GitBox
codecov-commenter commented on PR #11315: URL: https://github.com/apache/dubbo/pull/11315#issuecomment-1384814147 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/11315?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11309: Add xdsroute observe logic

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11309: URL: https://github.com/apache/dubbo/pull/11309#issuecomment-1384813957 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11309: Add xdsroute observe logic

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11309: URL: https://github.com/apache/dubbo/pull/11309#issuecomment-1384813700 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11315: metrics

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11315: URL: https://github.com/apache/dubbo/pull/11315#issuecomment-1384811603 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] Webster-Yang opened a new pull request, #11317: Thread pool metric

2023-01-16 Thread GitBox
Webster-Yang opened a new pull request, #11317: URL: https://github.com/apache/dubbo/pull/11317 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11316: Enhance class forname in triple

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11316: URL: https://github.com/apache/dubbo/pull/11316#issuecomment-1384798630 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] EarthChen closed pull request #11303: [3.2] Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
EarthChen closed pull request #11303: [3.2] Serialization and deserialization use classes in the wrapper URL: https://github.com/apache/dubbo/pull/11303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [dubbo-go] codecov-commenter commented on pull request #2186: Support Servicemapping Listener

2023-01-16 Thread GitBox
codecov-commenter commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1384786745 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/2186?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [dubbo] AlbumenJ merged pull request #11316: Enhance class forname in triple

2023-01-16 Thread GitBox
AlbumenJ merged PR #11316: URL: https://github.com/apache/dubbo/pull/11316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11312: change class loader

2023-01-16 Thread GitBox
AlbumenJ merged PR #11312: URL: https://github.com/apache/dubbo/pull/11312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ opened a new pull request, #11316: Enhance class forname in triple

2023-01-16 Thread GitBox
AlbumenJ opened a new pull request, #11316: URL: https://github.com/apache/dubbo/pull/11316 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo] CrazyHZM commented on pull request #11021: Added support for Micrometer Observation API

2023-01-16 Thread GitBox
CrazyHZM commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1384781003 ping @marcingrzejszczak Pleas check and process the above review content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [dubbo] AlbumenJ merged pull request #11302: Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
AlbumenJ merged PR #11302: URL: https://github.com/apache/dubbo/pull/11302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11313: Refactor nacos to update

2023-01-16 Thread GitBox
AlbumenJ merged PR #11313: URL: https://github.com/apache/dubbo/pull/11313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2186: Support Servicemapping Listener

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1384779795 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] mxsm commented on issue #11294: ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-16 Thread GitBox
mxsm commented on issue #11294: URL: https://github.com/apache/dubbo/issues/11294#issuecomment-1384775229 @CrazyHZM I will submit a PR to fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2186: Support Servicemapping Listener

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1384774969 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] CrazyHZM commented on issue #11294: ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8

2023-01-16 Thread GitBox
CrazyHZM commented on issue #11294: URL: https://github.com/apache/dubbo/issues/11294#issuecomment-1384774588 Thanks for raising this question, it does have this performance problem in JDK8, the original link: https://bugs.openjdk.org/browse/JDK-8161372 , would you like to optimize it?

[GitHub] [dubbo-samples] AlbumenJ merged pull request #698: add rest test case with token

2023-01-16 Thread GitBox
AlbumenJ merged PR #698: URL: https://github.com/apache/dubbo-samples/pull/698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2186: Support Servicemapping Listener

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2186: URL: https://github.com/apache/dubbo-go/pull/2186#issuecomment-1384771203 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo-go] bobtthp opened a new pull request, #2186: Support Servicemapping Listener

2023-01-16 Thread GitBox
bobtthp opened a new pull request, #2186: URL: https://github.com/apache/dubbo-go/pull/2186 support application level service discovery issue: https://github.com/apache/dubbo-go/issues/2167 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #538: 修改 istio 编译镜像

2023-01-16 Thread GitBox
codecov-commenter commented on PR #538: URL: https://github.com/apache/dubbo-go-pixiu/pull/538#issuecomment-1384764815 #

[GitHub] [dubbo] jojocodeX opened a new pull request, #11315: metrics

2023-01-16 Thread GitBox
jojocodeX opened a new pull request, #11315: URL: https://github.com/apache/dubbo/pull/11315 Added metrics for failed request total -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [dubbo-go-pixiu] sonarcloud[bot] commented on pull request #538: 修改 istio 编译镜像

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #538: URL: https://github.com/apache/dubbo-go-pixiu/pull/538#issuecomment-1384758308 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo-go-pixiu] bobtthp opened a new pull request, #538: 修改 istio 编译镜像

2023-01-16 Thread GitBox
bobtthp opened a new pull request, #538: URL: https://github.com/apache/dubbo-go-pixiu/pull/538 修改编译镜像指定版本:docker.io/golang:1.18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [dubbo-go-samples] dependabot[bot] opened a new pull request, #488: Build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #488: URL: https://github.com/apache/dubbo-go-samples/pull/488 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.51.0 to 1.52.0. Release notes Sourced from

[GitHub] [dubbo-rust] yang20150702 opened a new pull request, #97: Rft: Update Invoker Trait

2023-01-16 Thread GitBox
yang20150702 opened a new pull request, #97: URL: https://github.com/apache/dubbo-rust/pull/97 #96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-rust] yang20150702 opened a new issue, #96: Rft: Update Invoker Trait

2023-01-16 Thread GitBox
yang20150702 opened a new issue, #96: URL: https://github.com/apache/dubbo-rust/issues/96 I add new api for Invoker trait. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11313: Refactor nacos to update

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11313: URL: https://github.com/apache/dubbo/pull/11313#issuecomment-1384071274 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo-samples] dependabot[bot] opened a new pull request, #709: Bump fastjson from 1.2.83_noneautotype to 1.2.83 in /4-governance/dubbo-samples-metrics-prometheus

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #709: URL: https://github.com/apache/dubbo-samples/pull/709 Bumps [fastjson](https://github.com/alibaba/fastjson) from 1.2.83_noneautotype to 1.2.83. Release notes Sourced from https://github.com/alibaba/fastjson/releases;>fastjson's

[GitHub] [dubbo-samples] AlbumenJ merged pull request #705: :sparkles: Add Prometheus Metrics Sample

2023-01-16 Thread GitBox
AlbumenJ merged PR #705: URL: https://github.com/apache/dubbo-samples/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ merged pull request #11314: Fix instance revision check

2023-01-16 Thread GitBox
AlbumenJ merged PR #11314: URL: https://github.com/apache/dubbo/pull/11314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] AlbumenJ opened a new pull request, #11314: Fix instance revision check

2023-01-16 Thread GitBox
AlbumenJ opened a new pull request, #11314: URL: https://github.com/apache/dubbo/pull/11314 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo] AlbumenJ opened a new pull request, #11313: Refactor nacos to update

2023-01-16 Thread GitBox
AlbumenJ opened a new pull request, #11313: URL: https://github.com/apache/dubbo/pull/11313 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo-go] dependabot[bot] commented on pull request #2183: build(deps): bump github.com/nacos-group/nacos-sdk-go from 1.1.3 to 1.1.4

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #2183: URL: https://github.com/apache/dubbo-go/pull/2183#issuecomment-1383987583 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [dubbo-go] AlexStocks closed pull request #2183: build(deps): bump github.com/nacos-group/nacos-sdk-go from 1.1.3 to 1.1.4

2023-01-16 Thread GitBox
AlexStocks closed pull request #2183: build(deps): bump github.com/nacos-group/nacos-sdk-go from 1.1.3 to 1.1.4 URL: https://github.com/apache/dubbo-go/pull/2183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [dubbo-go] dependabot[bot] commented on pull request #2184: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #2184: URL: https://github.com/apache/dubbo-go/pull/2184#issuecomment-1383987458 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [dubbo-go] AlexStocks closed pull request #2184: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0

2023-01-16 Thread GitBox
AlexStocks closed pull request #2184: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0 URL: https://github.com/apache/dubbo-go/pull/2184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [dubbo-go] AlexStocks merged pull request #2185: build(deps): bump github.com/hashicorp/vault/sdk from 0.6.2 to 0.7.0

2023-01-16 Thread GitBox
AlexStocks merged PR #2185: URL: https://github.com/apache/dubbo-go/pull/2185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] aamingaa commented on a diff in pull request #11309: Add xdsroute observe logic

2023-01-16 Thread GitBox
aamingaa commented on code in PR #11309: URL: https://github.com/apache/dubbo/pull/11309#discussion_r1071180118 ## dubbo-xds/src/main/java/org/apache/dubbo/registry/xds/util/PilotExchanger.java: ## @@ -108,9 +114,21 @@ private void createRouteObserve() { } public

[GitHub] [dubbo] aamingaa commented on a diff in pull request #11309: Add xdsroute observe logic

2023-01-16 Thread GitBox
aamingaa commented on code in PR #11309: URL: https://github.com/apache/dubbo/pull/11309#discussion_r1071177823 ## dubbo-xds/src/main/java/org/apache/dubbo/rpc/cluster/router/xds/XdsRouter.java: ## @@ -28,19 +28,9 @@ import

[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2185: build(deps): bump github.com/hashicorp/vault/sdk from 0.6.2 to 0.7.0

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2185: URL: https://github.com/apache/dubbo-go/pull/2185#issuecomment-1383949049 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2184: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2184: URL: https://github.com/apache/dubbo-go/pull/2184#issuecomment-1383948910 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo-go] dependabot[bot] opened a new pull request, #2185: build(deps): bump github.com/hashicorp/vault/sdk from 0.6.2 to 0.7.0

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #2185: URL: https://github.com/apache/dubbo-go/pull/2185 Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.2 to 0.7.0. Changelog Sourced from

[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2183: build(deps): bump github.com/nacos-group/nacos-sdk-go from 1.1.3 to 1.1.4

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #2183: URL: https://github.com/apache/dubbo-go/pull/2183#issuecomment-1383948116 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo-go] dependabot[bot] opened a new pull request, #2184: build(deps): bump google.golang.org/grpc from 1.51.0 to 1.52.0

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #2184: URL: https://github.com/apache/dubbo-go/pull/2184 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.51.0 to 1.52.0. Release notes Sourced from https://github.com/grpc/grpc-go/releases;>google.golang.org/grpc's

[GitHub] [dubbo-go] dependabot[bot] opened a new pull request, #2183: build(deps): bump github.com/nacos-group/nacos-sdk-go from 1.1.3 to 1.1.4

2023-01-16 Thread GitBox
dependabot[bot] opened a new pull request, #2183: URL: https://github.com/apache/dubbo-go/pull/2183 Bumps [github.com/nacos-group/nacos-sdk-go](https://github.com/nacos-group/nacos-sdk-go) from 1.1.3 to 1.1.4. Release notes Sourced from

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11303: [3.2] Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11303: URL: https://github.com/apache/dubbo/pull/11303#issuecomment-1383918428 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11302: Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11302: URL: https://github.com/apache/dubbo/pull/11302#issuecomment-1383915409 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11303: [3.2] Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11303: URL: https://github.com/apache/dubbo/pull/11303#issuecomment-1383859176 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11303: [3.2] Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11303: URL: https://github.com/apache/dubbo/pull/11303#issuecomment-1383854827 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11302: Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11302: URL: https://github.com/apache/dubbo/pull/11302#issuecomment-1383855215 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11302: Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11302: URL: https://github.com/apache/dubbo/pull/11302#issuecomment-1383853277 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11312: change class loader

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11312: URL: https://github.com/apache/dubbo/pull/11312#issuecomment-1383848121 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11303: [3.2] Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11303: URL: https://github.com/apache/dubbo/pull/11303#issuecomment-1383834405 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11302: Serialization and deserialization use classes in the wrapper

2023-01-16 Thread GitBox
sonarcloud[bot] commented on PR #11302: URL: https://github.com/apache/dubbo/pull/11302#issuecomment-1383824250 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] edhn3000 commented on issue #10111: Critical bug: Consistency loadbalance cause the CPU usage is 100%.

2023-01-16 Thread GitBox
edhn3000 commented on issue #10111: URL: https://github.com/apache/dubbo/issues/10111#issuecomment-1383825354 我这里使用的是version 2.7.18,遇到一致性hash负载占用cpu高的问题,请问这个问题在2.7.x有修复吗 dump看线程都是在执行org.apache.dubbo.rpc.cluster.loadbalance.ConsistentHashLoadBalance.ConsistentHashSelector#selectForKey

[GitHub] [dubbo-go] LvBay commented on issue #2165: 服务端返回isXxxx字段的问题

2023-01-16 Thread GitBox
LvBay commented on issue #2165: URL: https://github.com/apache/dubbo-go/issues/2165#issuecomment-1383808181 > > @CodingAdai 你好,线上有一批接口都是isSuccess()命名的,通知业务方改造成本有些大。是否可以通过修改dubbo-go的consumer侧代码,兼容掉这个问题 > > @LvBay 需要兼容的话,可以再加一个getIsSuccess()的getter方法,这样可以返回success和isSuccess两个字段。

[GitHub] [dubbo] EarthChen opened a new pull request, #11312: change class loader

2023-01-16 Thread GitBox
EarthChen opened a new pull request, #11312: URL: https://github.com/apache/dubbo/pull/11312 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

[GitHub] [dubbo] yisirman commented on issue #11310: Dubbo3.1.2经常找不到服务的提供者

2023-01-16 Thread GitBox
yisirman commented on issue #11310: URL: https://github.com/apache/dubbo/issues/11310#issuecomment-1383791601 ` { "@timestamp": "2023-01-16 10:06:59.026", "APP_NAME": "x", "traceId": "6f8cd262ee4b46105a7025393c285f4d", "spanId": "2e8149dcf85758c2",

[GitHub] [dubbo] edhn3000 commented on issue #10111: Critical bug: Consistency loadbalance cause the CPU usage is 100%.

2023-01-16 Thread GitBox
edhn3000 commented on issue #10111: URL: https://github.com/apache/dubbo/issues/10111#issuecomment-1383781097 问一下这个问题在2.7.x中修复了吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [dubbo-go] CodingAdai commented on issue #2178: 不支持 version+group 调用

2023-01-16 Thread GitBox
CodingAdai commented on issue #2178: URL: https://github.com/apache/dubbo-go/issues/2178#issuecomment-1383778109 补充下这个问题: 代码demo:https://github.com/CodingAdai/java-go-dubbo.git (Go consumer call Java provider on triple) 加version之后,Java提供者收到请求后,会返回service not found,grpc status

[GitHub] [dubbo] sunmmi commented on issue #11301: Dubbo 3.1.0 用k8s做注册中心,一直watch超时

2023-01-15 Thread GitBox
sunmmi commented on issue #11301: URL: https://github.com/apache/dubbo/issues/11301#issuecomment-1383617086 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [dubbo] sunmmi closed issue #11301: Dubbo 3.1.0 用k8s做注册中心,一直watch超时

2023-01-15 Thread GitBox
sunmmi closed issue #11301: Dubbo 3.1.0 用k8s做注册中心,一直watch超时 URL: https://github.com/apache/dubbo/issues/11301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [dubbo] AlbumenJ commented on issue #11310: Dubbo3.1.2经常找不到服务的提供者

2023-01-15 Thread GitBox
AlbumenJ commented on issue #11310: URL: https://github.com/apache/dubbo/issues/11310#issuecomment-1383612544 > > > 有时候A服务调用C服务时报错没有服务提供者 > > > > > > 在出现这个问题之前进行什么变更吗,比如C服务发布重启 > > 有的 就是C服务发布重启 偶尔会出现A服务调用C服务找不到提供者 但是这个问题必须要等C服务下一次再次重启才能解决 A 的 Dubbo 日志有都输出吗,可以贴下相关的日志吗

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11302: Serialization and deserialization use classes in the wrapper

2023-01-15 Thread GitBox
sonarcloud[bot] commented on PR #11302: URL: https://github.com/apache/dubbo/pull/11302#issuecomment-1383563761 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo-go] AlexStocks merged pull request #2182: Fix: Replace assignment behavior with copy operation to avoid OOM pro…

2023-01-15 Thread GitBox
AlexStocks merged PR #2182: URL: https://github.com/apache/dubbo-go/pull/2182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo] yisirman commented on issue #11310: Dubbo3.1.2经常找不到服务的提供者

2023-01-15 Thread GitBox
yisirman commented on issue #11310: URL: https://github.com/apache/dubbo/issues/11310#issuecomment-1383551502 > > 有时候A服务调用C服务时报错没有服务提供者 > > 在出现这个问题之前进行什么变更吗,比如C服务发布重启 有的 就是C服务发布重启 偶尔会出现A服务调用C服务找不到提供者 但是这个问题必须要等C服务下一次再次重启才能解决 -- This is an automated message from the Apache

[GitHub] [dubbo] AlbumenJ merged pull request #11295: Add dubbo prefix(dubbo.provider) to dubbo's provider.

2023-01-15 Thread GitBox
AlbumenJ merged PR #11295: URL: https://github.com/apache/dubbo/pull/11295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dubbo-go] LvBay commented on issue #2165: 服务端返回isXxxx字段的问题

2023-01-15 Thread GitBox
LvBay commented on issue #2165: URL: https://github.com/apache/dubbo-go/issues/2165#issuecomment-1383525769 @CodingAdai 你好,线上有一批接口都是isSuccess()命名的,通知业务方改造成本有些大。是否可以通过修改dubbo-go的consumer侧代码,兼容掉这个问题 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11303: [3.2] Serialization and deserialization use classes in the wrapper

2023-01-15 Thread GitBox
sonarcloud[bot] commented on PR #11303: URL: https://github.com/apache/dubbo/pull/11303#issuecomment-1383480509 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo] sonarcloud[bot] commented on pull request #11302: Serialization and deserialization use classes in the wrapper

2023-01-15 Thread GitBox
sonarcloud[bot] commented on PR #11302: URL: https://github.com/apache/dubbo/pull/11302#issuecomment-1383470229 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [dubbo-go] CodingAdai commented on issue #2165: 服务端返回isXxxx字段的问题

2023-01-15 Thread GitBox
CodingAdai commented on issue #2165: URL: https://github.com/apache/dubbo-go/issues/2165#issuecomment-1383449600 > 场景:服务端是java实现的dubbo服务;调用方是dubbo-go泛化调用。服务端返回的结构体是{"isSuccess":true},但是dubbo-go收到的却是{"success":true} > > 请问如何接收到原始的isSuccess字段呢 @LvBay

[GitHub] [dubbo] schneiderlin opened a new issue, #11311: support register custom metadata

2023-01-15 Thread GitBox
schneiderlin opened a new issue, #11311: URL: https://github.com/apache/dubbo/issues/11311 the same issue as #3343, the problem is not solved, and I'd like to reopen it. my use case is that I need to AB test some providers. each provider would add custom data like "tag: A/B" in the

<    1   2   3   4   5   6   7   8   9   10   >